- 27 Jan, 2017 2 commits
-
-
ishell authored
Basically, with --deopt-every-n-times flag all bets are off since the functions can be optimized and deoptimized at any time. BUG=v8:5890 Review-Url: https://codereview.chromium.org/2655263004 Cr-Commit-Position: refs/heads/master@{#42735}
-
ishell authored
The mentioned asserts did not work properly with interpreted and turbofanned functions. To fix this issue %GetOptimizationStatus() now returns a set of flags instead of a single value. This CL also adds more helper functions to mjsunit, like isNeverOptimize(), isAlwaysOptimize(), isOptimized(fun), etc. BUG=v8:5890 Review-Url: https://codereview.chromium.org/2654733004 Cr-Original-Commit-Position: refs/heads/master@{#42703} Committed: https://chromium.googlesource.com/v8/v8/+/d1ddec785725a184fe6d01bd0813262e3ba24966 Review-Url: https://codereview.chromium.org/2654733004 Cr-Commit-Position: refs/heads/master@{#42731}
-
- 26 Jan, 2017 2 commits
-
-
machenbach authored
Revert of [tests] Make assertOptimized()/assertUnoptimized() great again. (patchset #6 id:130042 of https://codereview.chromium.org/2654733004/ ) Reason for revert: Mac gc stress failures: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/11195 There's also this flake, but maybe unrelated: https://build.chromium.org/p/client.v8/builders/V8%20Win64/builds/15422 Original issue's description: > [tests] Make assertOptimized()/assertUnoptimized() great again. > > The mentioned asserts did not work properly with interpreted and turbofanned functions. > > To fix this issue %GetOptimizationStatus() now returns a set of flags instead of a single value. > > This CL also adds more helper functions to mjsunit, like isNeverOptimize(), isAlwaysOptimize(), > isOptimized(fun), etc. > > BUG=v8:5890 > > Review-Url: https://codereview.chromium.org/2654733004 > Cr-Commit-Position: refs/heads/master@{#42703} > Committed: https://chromium.googlesource.com/v8/v8/+/d1ddec785725a184fe6d01bd0813262e3ba24966 TBR=mstarzinger@chromium.org,ishell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5890 Review-Url: https://codereview.chromium.org/2655223003 Cr-Commit-Position: refs/heads/master@{#42704}
-
ishell authored
The mentioned asserts did not work properly with interpreted and turbofanned functions. To fix this issue %GetOptimizationStatus() now returns a set of flags instead of a single value. This CL also adds more helper functions to mjsunit, like isNeverOptimize(), isAlwaysOptimize(), isOptimized(fun), etc. BUG=v8:5890 Review-Url: https://codereview.chromium.org/2654733004 Cr-Commit-Position: refs/heads/master@{#42703}
-
- 28 Nov, 2016 1 commit
-
-
ahaas authored
Up until now assertThrows allows to check the type field of an exception, which is, however, a custom field introduced in a single regression test. With the change assertThrows allows to check the message field of an exception, which is set for standard V8 exceptions by default. I use the new assertThrows to refactor test/mjsunit/wasm/divrem-trap.js R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2525313003 Cr-Commit-Position: refs/heads/master@{#41302}
-
- 10 Nov, 2016 1 commit
-
-
jkummerow authored
This is mostly a performance experiment. If it provides no speedup, it can be reverted to keep IC miss events in timeline plots. Otherwise, the RuntimeCallStats system is the replacement tool for investigating performance issues related to IC misses. This effectively reverts 1f8adc15 / r21736. Review-Url: https://codereview.chromium.org/2480343002 Cr-Commit-Position: refs/heads/master@{#40893}
-
- 20 Oct, 2016 1 commit
-
-
neis authored
R=adamk@chromium.org, marja@chromium.org BUG= Review-Url: https://chromiumcodereview.appspot.com/2436073002 Cr-Commit-Position: refs/heads/master@{#40482}
-
- 17 Oct, 2016 1 commit
-
-
marja authored
1) assertInstanceOf(o, Foo, Bar) used to produce this error message: Failure: expected <o> is not an instance of <Foo> but of < Bar>> found <undefined> Fixed: Failure: <o> is not an instance of <Foo> but of <Bar> 2) assertDoesNotThrow("throw 1") used to produce this error message: Failure: expected <threw an exception: > found <1> Fixed: Failure: threw an exception: 1 3) assertDoesNotThrow("...", SomeError) was not doing what you'd think it does, so removed the last parameter. BUG= Review-Url: https://codereview.chromium.org/2424743003 Cr-Commit-Position: refs/heads/master@{#40347}
-
- 15 Oct, 2016 1 commit
-
-
marja authored
Revert of mjsunit: Fix the error message produced by assertInstanceof. (patchset #1 id:1 of https://codereview.chromium.org/2413153004/ ) Reason for revert: This is probably not working for falsey values. I cannot JavaScript :P Original issue's description: > mjsunit: Fix the error message produced by assertInstanceof. > > Used to be: > > Failure: expected <foo> is not an instance of <Bar> but of < Baz>> found <undefined> > > Should be: > > Failure: <foo> is not an instance of <Bar> but of <Baz> > > BUG= > > Committed: https://crrev.com/2a480eff395756f36eb0ae2fc0a573454b394268 > Cr-Commit-Position: refs/heads/master@{#40319} TBR=verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2421033003 Cr-Commit-Position: refs/heads/master@{#40331}
-
- 14 Oct, 2016 1 commit
-
-
marja authored
Used to be: Failure: expected <foo> is not an instance of <Bar> but of < Baz>> found <undefined> Should be: Failure: <foo> is not an instance of <Bar> but of <Baz> BUG= Review-Url: https://codereview.chromium.org/2413153004 Cr-Commit-Position: refs/heads/master@{#40319}
-
- 12 Oct, 2016 1 commit
-
-
clemensh authored
For the asm.js to WASM pipeline, the current stack traces only show low-level WASM information. This CL maps this back to asm.js source positions. It does so by attaching the asm.js source Script to the compiled WASM module, and emitting a delta-encoded table which maps from WASM byte offsets to positions within that Script. As asm.js code does not throw exceptions, we only store a mapping for call instructions. The new AsmJsWasmStackFrame implementation inherits from WasmStackFrame, but contains the logic to provide the source script and the position inside of it. What is still missing is the JSFunction object returned by CallSite.getFunction(). We currently return null. R=jgruber@chromium.org, titzer@chromium.org BUG=v8:4203 Review-Url: https://codereview.chromium.org/2404253002 Cr-Commit-Position: refs/heads/master@{#40205}
-
- 21 Apr, 2016 1 commit
-
-
clemensh authored
This extends the wasm test case which only checks the "simple" string-variant of the stack trace. It checks the return values of the getFunctionName, getLineNumber, getFileName and toString methods. R=machenbach@chromium.org, jfb@chromium.org, titzer@chromium.org Review URL: https://codereview.chromium.org/1875153002 Cr-Commit-Position: refs/heads/master@{#35687}
-
- 20 Apr, 2016 2 commits
-
-
machenbach authored
Revert of [wasm] Also test structured stack trace (patchset #4 id:60001 of https://codereview.chromium.org/1875153002/ ) Reason for revert: Breaks: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20custom%20snapshot%20-%20debug/builds/6322 Original issue's description: > [wasm] Also test structured stack trace > > This extends the wasm test case which only checks the "simple" > string-variant of the stack trace. > It checks the return values of the getFunctionName, getLineNumber, > getFileName and toString methods. > > R=ahaas@chromium.org, jfb@chromium.org, titzer@chromium.org > BUG= TBR=ahaas@chromium.org,jfb@chromium.org,titzer@chromium.org,clemensh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1903293002 Cr-Commit-Position: refs/heads/master@{#35670}
-
clemensh authored
This extends the wasm test case which only checks the "simple" string-variant of the stack trace. It checks the return values of the getFunctionName, getLineNumber, getFileName and toString methods. R=ahaas@chromium.org, jfb@chromium.org, titzer@chromium.org BUG= Review URL: https://codereview.chromium.org/1875153002 Cr-Commit-Position: refs/heads/master@{#35666}
-
- 07 Jan, 2016 1 commit
-
-
neis authored
Some tests passed a string as second argument to assertThrows, expecting it to be matched against the exception. However, assertThrows simply ignored these. (Some other tests actually seem to use that argument as a comment ...) This CL - changes assertThrows to fail if the second argument is not a function, - adds assertThrowsEquals which compares the exception to a given value using assertEquals - fixes some bogus tests that got exposed by this. R=jarin@chromium.org BUG= Review URL: https://codereview.chromium.org/1544793002 Cr-Commit-Position: refs/heads/master@{#33159}
-
- 19 Nov, 2015 1 commit
-
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1448933002 Cr-Commit-Position: refs/heads/master@{#32120}
-
- 27 Oct, 2015 1 commit
-
-
neis authored
R=jochen BUG= Review URL: https://codereview.chromium.org/1424793004 Cr-Commit-Position: refs/heads/master@{#31595}
-
- 09 Oct, 2015 1 commit
-
-
jochen authored
Makes debugging failures a bit easier BUG=none R=ulan@chromium.org LOG=n Review URL: https://codereview.chromium.org/1398703007 Cr-Commit-Position: refs/heads/master@{#31195}
-
- 17 Feb, 2015 1 commit
-
-
rossberg authored
This broke with the TSAN fix. R=marja@chromium.org BUG= Review URL: https://codereview.chromium.org/933863002 Cr-Commit-Position: refs/heads/master@{#26687}
-
- 14 Nov, 2014 1 commit
-
-
Ben L. Titzer authored
R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/724133004 Cr-Commit-Position: refs/heads/master@{#25353}
-
- 25 Jun, 2014 1 commit
-
-
yangguo@chromium.org authored
This was broken some time ago by a refactor. R=ulan@chromium.org Review URL: https://codereview.chromium.org/349423003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21995 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Jun, 2014 1 commit
-
-
mstarzinger@chromium.org authored
BUG=None LOG=n R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/309173003 Patch from Erik Arvidsson <arv@chromium.org>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21748 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 May, 2014 2 commits
-
-
yangguo@chromium.org authored
R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/300003007 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21522 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
R=jochen@chromium.org Review URL: https://codereview.chromium.org/301673002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21518 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Nov, 2013 1 commit
-
-
yangguo@chromium.org authored
The changes are (excluding presubmit.py) mechanical. I added the following lines after the check and iterated the presubmit script until all errors went away: f = open(name, "w"); if contents.endswith('\n\n'): f.write(contents[0:-1]) else: f.write(contents + '\n') R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/82803005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18017 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 20 Nov, 2013 1 commit
-
-
yangguo@chromium.org authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/66703005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17933 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Aug, 2013 1 commit
-
-
yangguo@chromium.org authored
Also introduced macros for flag aliases for temporary backwards compatibility. R=hpayer@chromium.org BUG= Review URL: https://codereview.chromium.org/23014007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16280 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Jul, 2013 1 commit
-
-
yangguo@chromium.org authored
R=mvstanton@chromium.org BUG= Review URL: https://codereview.chromium.org/19807002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15793 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 28 Jun, 2012 1 commit
-
-
rossberg@chromium.org authored
- Add copy constructors. - Add subarray methods. - Make instanceof and constructor property work. - Rename PixelArray to Uint8ClampedArray. Also fix broken definition of assertInstanceof in MJSUnit test harness. R=mstarzinger@chromium.org BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10558005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11949 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 Apr, 2012 1 commit
-
-
rossberg@chromium.org authored
I also discovered that our treatment of const declarations is inconsistent when inside a global eval under 'with' (i.e., when created by DeclareContextSlots). That is, var x; eval("const x = 9") and var x; eval("with({}) const x = 9") differ (the former assigns 9, the latter throws). This appears to be an oversight from earlier changes to our const semantics (the latter shouldn't throw either). Fixing this is a separate issue, though (and one that doesn't seem quite worthwhile). R=mstarzinger@chromium.org BUG=v8:1991,80591 TEST= Review URL: https://chromiumcodereview.appspot.com/10067010 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11333 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 08 Mar, 2012 1 commit
-
-
mstarzinger@chromium.org authored
R=rossberg@chromium.org TEST=mjsunit/object-is,mjsunit/number-is Review URL: https://chromiumcodereview.appspot.com/9630009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10965 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 28 Oct, 2011 1 commit
-
-
mstarzinger@chromium.org authored
Using isNaN() here is bogus because it performs an implicit toNumber() conversion, hence something like assertSame(undefined, {}) would not throw an exception. These are not the NaNs you are looking for. R=rossberg@chromium.org TEST=mjsunit Review URL: http://codereview.chromium.org/8400056 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9831 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 15 Apr, 2011 1 commit
-
-
lrn@chromium.org authored
Encapsulate the helper functions in mjsunit.js. Now only exposes the exception class and the assertXXX functions. Make assertEquals use === instead of ==. This prevents a lot of possiblefalse positives in tests, and avoids having to do assertTrue(expected === actual) when you need it. Fixed some tests that were either buggy or assuming == test. Review URL: http://codereview.chromium.org/6869007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7628 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Apr, 2011 1 commit
-
-
lrn@chromium.org authored
TEST=mjsunit/math-floor Review URL: http://codereview.chromium.org/6835021 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7613 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 25 Mar, 2011 1 commit
-
-
lrn@chromium.org authored
Make MJSUnit able to distinguish 0 and -0. Review URL: http://codereview.chromium.org/6688062 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7368 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Feb, 2011 1 commit
-
-
antonm@chromium.org authored
That better follows ECMA-262 (see 13.2 Creating Function Objects) and allows to ignore nasty JS accessors for 'constructor' property. BUG=v8:1172 TEST=test/mjsunit/regress/regress-1172.js Review URL: http://codereview.chromium.org/6531037 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@6849 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 May, 2010 1 commit
-
-
vitalyr@chromium.org authored
Review URL: http://codereview.chromium.org/2094005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4654 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 01 Feb, 2010 1 commit
-
-
lrn@chromium.org authored
Review URL: http://codereview.chromium.org/549207 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3752 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 05 Nov, 2009 1 commit
-
-
kmillikin@chromium.org authored
regular expressions to be consistent with typeof in other contexts. Typeof regular expressions should now be 'function' in all contexts. In the JS natives, IS_FUNCTION, IS_OBJECT, and IS_REGEXP return the same answers as before. Review URL: http://codereview.chromium.org/360053 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3231 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 Aug, 2009 1 commit
-
-
mikhail.naganov@gmail.com authored
http://code.google.com/p/v8/issues/detail?id=420 Review URL: http://codereview.chromium.org/171038 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2695 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-