- 23 Apr, 2015 1 commit
-
-
arv authored
ES6 specifies the function name property (it was not part of ES5) and it specifies the name of Function.prototype to the empty string ("" and not "Empty"). This makes us match Firefox, Safari and IE developer preview. BUG=v8:4033 LOG=N R=adamk@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1080393004 Cr-Commit-Position: refs/heads/master@{#28021}
-
- 04 Mar, 2015 1 commit
-
-
arv authored
Function name property is now standardized in ES6. It was a Mozilla proprietary extension before. With ES6, the property was made configurable, so that it can be used instead of another proprietary property, displayName. This is a revert of revert https://chromium.googlesource.com/v8/v8.git/+/c791d8411225aa95518c880defd9a5b1ea243afc. Last time this broke a Chrome browser test which has since been updated: https://chromium.googlesource.com/chromium/src/+/5f75a3be4c9334aba627d6c5eb884adf965e1d78 BUG=v8:3333 LOG=N R=mstarzinger@chromium.org,verwaest@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/977003004 Cr-Commit-Position: refs/heads/master@{#26996}
-
- 02 Mar, 2015 1 commit
-
-
arv authored
Revert of ES6: Make function name configurable (patchset #10 id:220001 of https://codereview.chromium.org/960343002/) Reason for revert: Breaks Chrome browser test that checks Object.name [16509:16509:0228/030150:INFO:CONSOLE(43)] "Uncaught Error: Clobbered Object.name getter", source: http://www.chromium.org:33611/assertions.js (43) http://build.chromium.org/p/client.v8/builders/Linux%20Tests%20%28dbg%29%281%29/builds/2328/steps/browser_tests/logs/stdio Original issue's description: > ES6: Make function name configurable > > This is partially based on r21609 but that CL was incomplete. > > Function name is still non writable so one has to use defineProperty > to change the actual value. > > BUG=v8:3333 > LOG=N > R=adamk, mstarzinger@chromium.org > > Committed: https://crrev.com/f7790f7670c8d859455a98fcb90ff1b66af1eca7 > Cr-Commit-Position: refs/heads/master@{#26924} TBR=adamk@chromium.org,mstarzinger@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3333 Review URL: https://codereview.chromium.org/969683002 Cr-Commit-Position: refs/heads/master@{#26933}
-
- 27 Feb, 2015 1 commit
-
-
arv authored
This is partially based on r21609 but that CL was incomplete. Function name is still non writable so one has to use defineProperty to change the actual value. BUG=v8:3333 LOG=N R=adamk, mstarzinger@chromium.org Review URL: https://codereview.chromium.org/960343002 Cr-Commit-Position: refs/heads/master@{#26924}
-