- 02 Dec, 2019 7 commits
-
-
Ng Zhi An authored
Bug: v8:9886 Change-Id: I321e93d02971c6ba568d9d7c52d464ffc2754665 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1929837 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#65277}
-
Ng Zhi An authored
Adding a regression test for https://crrev.com/c/1930606. This test was generated using --dump-wasm-module, which created a 6KB module, and then running binaryen's wasm-reduce on it until it churned this out, and removing an extra kExprUnreachable. Bug: chromium:1027410 Change-Id: I14ba6ebe52f45e3b3ba943088807e110eebe0339 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1933592Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#65276}
-
Ng Zhi An authored
Bug: v8:9886 Change-Id: Idd44fb99be54c56385db55895dba58b35c1b660e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1928150Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#65275}
-
Ng Zhi An authored
This change includes splitting the existing SSE_INSTRUCTION_LIST into two: 1. sse instructions with two-operand AVX 2. sse instructions with three-operand AVX Also a drive by fix for disasm of pblendw, the printing of imm8 doesn't not require AND-ing with 3, since all 8 bits are significant. Bug: v8:9561 Change-Id: I56c93a24bb9905ae6422698c793b27f3b9e66d8f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1933593Reviewed-by:
-
Simon Zünd authored
Design doc: bit.ly/v8-repl-mode This CL allows the usage of 'await' without wrapping code in an async function when using REPL mode in global evaluate. REPL mode evaluate is changed to *always* return a Promise. The resolve value of the promise is the completion value of the REPL script. The implementation is based on two existing mechanisms: - Similar to async functions, the content of a REPL script is enclosed in a synthetic 'try' block. Any thrown error is used to reject the Promise of the REPL script. - The content of the synthetic 'try' block is also re-written the same way a normal script is. This is, artificial assignments to a ".result" variable are inserted to simulate a completion value. The difference for REPL scripts is, that ".result" is used to resolve the Promise of the REPL script. - ".result" is not returned directly but wrapped in an object literal: "{ .repl_result: .result}". This is done to prevent resolved promises from being chained and resolved prematurely: > Promse.resolve(42); should evaluate to a promise, not 42. Bug: chromium:1021921 Change-Id: I00a5aafd9126ca7c97d09cd8787a3aec2821a67f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1900464Reviewed-by:Yang Guo <yangguo@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#65273}
-
Bartek Nowierski authored
Bug: chromium:1018156 Change-Id: I2133bd8fc4ae4d9ce3c16c50887beb677d979e18 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1924000 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#65272}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/bcfcc04..0317de9 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I21e8f3bf8a9c0cfdd3c0db2bd49386eede39870e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1944233Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#65271}
-
- 01 Dec, 2019 2 commits
-
-
Jakob Kummerow authored
No-Try: true Change-Id: I9c4d6f02451872dacf6e5e172ec32afde5f80281 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943165 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#65270}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/15fd848..00a14de Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/bf0fe87..5395345 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/e3d2982..ae5343c TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I22c818999d745103e09d7438839e03ca80ab7e08 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1944232Reviewed-by:
-
- 30 Nov, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2fc048c..15fd848 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b97d4ce..bcfcc04 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/7c62ed6..5ae4817 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/076c461..bf0fe87 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/05979d8..e3d2982 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I9ff4c73b501e7b99b0ef5e2f491d090333e6a342 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1944231Reviewed-by:
-
- 29 Nov, 2019 16 commits
-
-
Hannes Payer authored
Change-Id: I60fdb6af5382e0ccd6bff16f89aad804c13cd900 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943147Reviewed-by:
-
Sigurd Schneider authored
This CL introduces a CHECK in v8_compile that compilation succeedes. Previously, a failed compilation would lead to undefined behavior or a crash in CompileRun, because it would call Script::Run on a nullptr. This CL introduced v8_try_compile that returns a MaybeLocal and supports test-cases that want to ensure that a compilation fails. Bug: chromium:1014415 Change-Id: I559190da6049f325e8650e4a29c6e387d8ff7af5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943154 Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This fixes the accessor functions (getters and setters) for WebAssembly accessor properties to not have 'prototype' properties and not be marked as constructors. R=ahaas@chromium.org TEST=mjsunit/wasm/js-api BUG=chromium:1027945 Change-Id: I0288f511fee1f99997031b41354ecf7b8629b783 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943157 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#65265}
-
Liviu Rau authored
No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ib485ec835d73f9da0c5379c80865ad6702293e6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943148 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Reported at comment #18 of the linked bug. Bug: chromium:1027461 Change-Id: I64fb4c4edd4df07ddf86c508dfecec7f509efc9f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940262Reviewed-by:
-
Jakob Kummerow authored
Replacing a constant BigInt with a constant int64 is only valid when the use site has truncating semantics. (For non-constant values, the representation changer did correctly check for this.) Bug: chromium:1028593 Change-Id: Ib58b16ece6f21ba30153fd6cfa0560cc2d78d6a2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940263Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#65262}
-
Mythri A authored
This cl: https://chromium-review.googlesource.com/c/v8/v8/+/1924439 has renamed the optimize passed happening on the backgroudn to OptimizeBackground instead of OptimizeConcurrent or RecompileConcurrent. Concurrent optimization has main thread phases so using OptimizeConcurrent for background computations only was a bit confusing. Bug: chromium:1029456 Change-Id: Idd0a0ff82597bb18c2d8896c7288f268e59acc05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943156 Commit-Queue: Mythri Alle <mythria@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Auto-Submit: Mythri Alle <mythria@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#65261}
-
Georg Neis authored
If the inputs are Unsigned32OrMinusZeroOrNaN and we want to compile for an Unsigned32 result, we still need to deopt if the RHS is zero (because that must produce NaN). Bug: chromium:1028862 Change-Id: Ib5b7cd10f8c4ec9a76b75a2b408729f1ca86ea3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943150Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#65260}
-
Toon Verwaest authored
This reverts commit 5253d7bf. Reason for revert: Elements don't properly invalidate the cache. Original change's description: > [runtime] Cache prototype chain enumerable keys in PrototypeInfo > > This CL adds a prototype_chain_enum_cache to cache the enumeration of a > prototype and its entire chain on the PrototypeInfo. It can improve for-in > performance via simply merging the receiver enumeration with this cache. > > It improves the score of JetStream2-tagcloud-SP case by ~9% on IA Chromebook. > > Contributed by tao.pan@intel.com > > Change-Id: Ib40bfe41e772672337155584672f06fa1ba1e70d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1870844 > Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65224} TBR=verwaest@chromium.org,shiyu.zhang@intel.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ic5d476bc8b334241b2accb8344749fcf7dcf5e09 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943153Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#65259}
-
Sigurd Schneider authored
This is a reland of 4ed9d48f CompileRun leads to undefined behavior if the compile fails; CompileRunChecked can be used to assert that the compile must succeed. I've removed the attempt to compile and rely on a simpler check in the tests now. Original change's description: > [exceptions] Don't re-request interrupt in InvokeWithTryCatch > > This CL changes InvokeWithTryCatch to not re-request the terminate > execution interrupt, but instead schedule the termination exception. > This ensures that leaving the outermost TryCatch scope will clear > the exception, and no interrupt remains. > > Previously, the interrupt request could remain and prevent further > JavaScript execution even after the TryCatch scope was left. > > Change-Id: I1e603dc822bbcb0def4cf0a898d59cf8d4b9d039 > Bug: chromium:1014415 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871910 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65255} Tbr: yangguo@chromium.org, verwaest@chromium.org Bug: chromium:1014415 Change-Id: I29444c4b7ea5a158865f54d4608f374914f7b133 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943151Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#65258}
-
Michael Achenbach authored
R=neis@chromium.org No-Try: true Change-Id: I91ebaceb036381f8183b0703ccfed58e1cbbeeb3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943152Reviewed-by:
-
Leszek Swirski authored
This reverts commit 4ed9d48f. Reason for revert: UBSan failure https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20UBSan/9084 Original change's description: > [exceptions] Don't re-request interrupt in InvokeWithTryCatch > > This CL changes InvokeWithTryCatch to not re-request the terminate > execution interrupt, but instead schedule the termination exception. > This ensures that leaving the outermost TryCatch scope will clear > the exception, and no interrupt remains. > > Previously, the interrupt request could remain and prevent further > JavaScript execution even after the TryCatch scope was left. > > Change-Id: I1e603dc822bbcb0def4cf0a898d59cf8d4b9d039 > Bug: chromium:1014415 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871910 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65255} TBR=yangguo@chromium.org,sigurds@chromium.org,verwaest@chromium.org Change-Id: Iedefe5320d8bdc442a87e03698a20daf6a0ebf4f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1014415 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943149Reviewed-by:
-
Sigurd Schneider authored
This CL changes InvokeWithTryCatch to not re-request the terminate execution interrupt, but instead schedule the termination exception. This ensures that leaving the outermost TryCatch scope will clear the exception, and no interrupt remains. Previously, the interrupt request could remain and prevent further JavaScript execution even after the TryCatch scope was left. Change-Id: I1e603dc822bbcb0def4cf0a898d59cf8d4b9d039 Bug: chromium:1014415 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871910 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/eeb227e..2fc048c Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/fa0def7..b97d4ce Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/f31cb80..7c62ed6 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I0fb2bb08bc55ecc83695a5f7aa5bcb7676fb550b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1942916Reviewed-by:
-
jiepan authored
The lane indices of S8x16Shuffle will be printed as null-terminated character array in Operator1's PrintParameter implementation.This patch add S8x16ShuffleParameter class, override operater<<, print indices as integer array. before fix: Shuffle[\b\t\n^K\f\r^N^O] after fix: Shuffle[8,9,10,11,12,13,14,15,0,0,0,0,0,0,0,0] Change-Id: I421e639f5229d3a5e348868be33f2d8bbfcfd2d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1922735 Commit-Queue: Jie Pan <jie.pan@intel.com> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Shu-yu Guo authored
Correctly passing the receiver depends on the Call AST node's type. Calling a parenthesized optional chain expression is parsed as a Call of an OptionalChain of a Property. Currently the computation of the type does not take optional chains of property loads into consideration, so calls of parenthesized optional chain expressions always get passed an undefined receiver. Bug: v8:10024 Change-Id: I904b0eeca2df30160def674fb32adf821403aef9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1938571Reviewed-by:
-
- 28 Nov, 2019 14 commits
-
-
Dan Elphick authored
If source positions are not required when a background compilation task starts, but then something like profiling is started before the task finalizes, then logging of the compilation task will crash due to a missing source position table. This ensures source positions are collected if source positions are required during finalization. R=rmcilroy@chromium.org Bug: chromium:1022749 Change-Id: Ie83c3d88131a1c1f434274ea9ee52895c6753b49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1942611 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#65251}
-
Santiago Aboy Solanes authored
git cl upload failed since I needed to do a git cl format. Missed that and uploaded https://chromium-review.googlesource.com/c/v8/v8/+/1940153 without the rename. Bug: v8:7703 Change-Id: I26090433af86968357eaeecf3e906a9e824647a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940260 Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Hannes Payer authored
Change-Id: I5d98dac3cde530f2bac5ef1239bc0e8805a01f99 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1942609 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Due to the ordering of the nodes to be changed, we might change the ChangeTaggedToCompressed's input before the ChangeTaggedToCompressed node itself changes. Then, we need to check for this possibility too. Bug: v8:7703 Change-Id: I2b453211dc264b509f2ea7c0cf891be50f404009 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1942607 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Anna Henningsen authored
Ensure that all fields of `SyntheticModule` are set before creating the exports hash table for it, because the latter may trigger garbage collection, leading to crashes. This has been causing failures in the Node.js CI over the last weeks, after making the creating of synthetic modules part of Node’s startup sequence. (I am generally not very familiar with this part of the V8 code and there might be a better way, or possibly a way to add a reliable regression test, that I am not aware of.) Refs: https://github.com/nodejs/node/issues/30498 Refs: https://github.com/nodejs/node/issues/30648 Change-Id: I32da4b7bd888c6ec1421f34f5bd52e7bad154c1e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1939752 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Ports are getting easier now. This one was fairly straightforward. Bug: v8:9972 Change-Id: I69c0566060523e505e30980cb1d3d9633da976b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940257 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Andreas Haas authored
The bulk-memory tests changed with recent proposal changes: OOB accesses of size 0 cause traps now. R=thibaudm@chromium.org CC=emcziegler@chromium.org Change-Id: Id3f74373839434a61d3bf346a12146aa77894a8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940159Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#65245}
-
Jakob Gruber authored
These node/edge kinds don't fit into the heap object type system; add wrapper classes for them instead. The wrapper class must be explicitly created, but is implicitly convertible to Node*. Bug: v8:9972 Change-Id: Ic6c253a95bb5705fb946ee3f35508ea70c9f0070 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940255 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Jakob Gruber authored
... for convenient TNode access (e.g.: PhiAt, LoadField, LoadElement). Bug: v8:9972 Change-Id: Ie6f5f204079cf7c84279d1cb015055816f301916 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940254 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Clemens Backes authored
Fix a TODO from Ben to change the macro argument order to match the actual order in wasm code. After this fix, we can remove the individual {WASM_CALL_INDIRECT[0-5]} macros and implement them via a common variadic macro. Also, rename {WASM_CALL_INDIRECT_TABLE0} to {WASM_CALL_INDIRECT_TABLE}. The name was confusing, because this macro explictly allows to set a table index different from 0. Thus, just drop the "0" in the name. The individual test changes were done via a vim macro, to avoid manual errors. R=mstarzinger@chromium.org Bug: v8:10021 Change-Id: I9f0f31511c5c6e20a0b07524bf75fe9cf1598eba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940265Reviewed-by: -
Jakob Gruber authored
This is an initial (and partial) step towards full typing in graph assembler. It removes all uses of SloppyTNode, starts to introduce types in the GraphAssembler base class, and makes lambda function types (for if- and for-builders) more specific. Plenty of TODOs remain; e.g. checked casts and complete typing of GraphAssembler are left to follow-up work. Bug: v8:9972 Change-Id: I780adf83b53ad76beda4726960d95ab6df13e2ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940476 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Georg Neis authored
A call to this intrinsic will produce true in the interpreter and false in optimized code. This is useful for writing tests. Change-Id: I64d06ed062027e723eca82d6f879202244f21fdf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1939750 Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
Milad Farazmand authored
CodeStubAssembler::ComputeSeededHash is passing key as Int32 to ComputeSeededIntegerHash, but ComputeSeededIntegerHash only accepts Uint32 value. This could cause problems on s390 and ppc because GCC expects any value less than 8 bytes sign/zero-extending to 64-bits by the caller, therefore, the static cast from uint32->uint64 will be treated as no-op (expecting zero-ext instead), which leads to unexpected behaviors. Change-Id: Icd1eecaea1415e36c0c13eef513ff69cc418f247 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940209Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#65239}
-
Michael Starzinger authored
The last use of the predicate in question was to switch builtins that implement WebAssembly runtime stubs to use hard aborts instead of normal aborts like other builtins. This is no longer needed since the builtins in question are embedded and no longer copied into WebAssembly modules. This also allows to move the {WASM_RUNTIME_STUB_LIST} macro out of the builtins-defintions.h file and into the wasm-code-manager.h file. R=clemensb@chromium.org BUG=v8:10021 Change-Id: Ib42d3731fc92df378cfce39d39e7fbdbbf722937 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940266 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
