- 12 May, 2022 16 commits
-
-
Igor Sheludko authored
This reverts commit 411a0157. Reason for revert: crbug.com/1324829 (Canary crashes) Original change's description: > Reland "[rwx][mac] Enable fast W^X on Apple Silicon (M1)" > > This is a reland of commit e8cac377 > Broken jitless mode is fixed in a separate CL. > > Original change's description: > > [rwx][mac] Enable fast W^X on Apple Silicon (M1) > > > > Bug: v8:12797 > > Change-Id: I53bb803dd77db5bdd42b1a1b4b568e63857adf31 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3598861 > > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > > Commit-Queue: Igor Sheludko <ishell@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#80396} > > Bug: v8:12797 > Change-Id: I5436ceced5d4673f3b80d9cacdb3d6e84012c6e7 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3635720 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80450} Bug: v8:12797 Change-Id: If776ccb6ce9f41a84b94409ec5cae91c0915f129 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3644620 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80496}
-
Francis McCabe authored
This reverts commit 8278cb50. Reason for revert: breaking https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20CFI/10778/overview Original change's description: > [inspector] Re-enable Debugger#restartFrame > > Doc: https://bit.ly/revive-restart-frame > > This CL "undeprecates" Debugger#restartFrame and adds a new optional > "mode" parameter for back-wards compatibility. Moreover, the return > values are all deprecated. They were never actually used in the > DevTools frontend and the same information is available from the > Debugger#paused event that fires once execution stops at the > beginning of the restarted function. > > The CL also re-baselines all the restart-frame inspector tests that > now run successfully. > > R=bmeurer@chromium.org, kimanh@chromium.org > > Bug: chromium:1303521 > Change-Id: I34bddeb1f2f4ff3dee58dd82e779c111495566f3 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3616505 > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Kim-Anh Tran <kimanh@chromium.org> > Commit-Queue: Simon Zünd <szuend@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80491} Bug: chromium:1303521 Change-Id: Ibc33328c31a4b6ea736d07ce5e5ee109039eec8b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3645767 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#80495}
-
Jakob Kummerow authored
The IsValidSectionCode function shouldn't include internally-used numeric identifiers of well-known optional sections. Fixed: v8:12867 Change-Id: I9d894ee57157455e92a17ddcde94f32f05fb038d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3644612 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#80494}
-
Jakob Kummerow authored
This reverts commit c3ac338b. Reason for revert: Breaks stepping with `n` Original change's description: > [tools] Add a simple gdb frame unwinder > > Add a simple unwinder for gdb which, on x64, walks frame pointers > whenever there is no source information available. Ideally we would only > do this for V8 PCs but this appears hard to do in an Unwinder without > messing with gdb's internal assumptions. > > Change-Id: Iba1e62a3768340ee912e81d691237c1920a8ae91 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3608628 > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80204} Change-Id: I0264cf34cfe8fe2331bacf202dedbb4706535936 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3644855 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Omer Katz authored
This CL separates logic for promoting all of new space during fast promotion out of the heap and into a new dedicated PromoteYoungGenerationGC class. It currently assumes SemiSpaceNewSpace and will need to be extended with support for PagedNewSpace. Bug: v8:12612 Change-Id: I0e65c034b444634a31b3c00df0a4b558612f023f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3644610Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80492}
-
Simon Zünd authored
Doc: https://bit.ly/revive-restart-frame This CL "undeprecates" Debugger#restartFrame and adds a new optional "mode" parameter for back-wards compatibility. Moreover, the return values are all deprecated. They were never actually used in the DevTools frontend and the same information is available from the Debugger#paused event that fires once execution stops at the beginning of the restarted function. The CL also re-baselines all the restart-frame inspector tests that now run successfully. R=bmeurer@chromium.org, kimanh@chromium.org Bug: chromium:1303521 Change-Id: I34bddeb1f2f4ff3dee58dd82e779c111495566f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3616505Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Kim-Anh Tran <kimanh@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#80491}
-
Jakob Kummerow authored
Hexadecimal/octal/binary BigInt property names should be converted to decimal, i.e. the following object literals should all be equivalent: var o = {0xF: 1}, p = {0xFn: 1}, q = {15: 1}, r = {15n: 1}. Test case by yangwenming@bytedance.com, uploaded at https://chromium-review.googlesource.com/c/v8/v8/+/3634937 Fixed: v8:10600 Change-Id: Ie1d8a16e95697cd31cbc0784843779c921ce91fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3642302Reviewed-by:Toon Verwaest <verwaest@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#80490}
-
Junliang Yan authored
Change-Id: I62f4d7fae09ab529756d106e77bb9bd8b3b239a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3644850 Commit-Queue: Junliang Yan <junyan@redhat.com> Reviewed-by:
Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#80489}
-
V8 Autoroll authored
Change-Id: If91de8dd11bdd2207bf88cad376c626964bfd162 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3644848Reviewed-by:
Lutz Vahl <vahl@chromium.org> Commit-Queue: Lutz Vahl <vahl@chromium.org> Cr-Commit-Position: refs/heads/main@{#80488}
-
Igor Sheludko authored
Bug: chromium:1310062 Change-Id: Iba231f98ef88df07b24b1c2bc9026a5b8ca18e15 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3644228Reviewed-by:
-
Andreas Haas authored
R=thibaudm@chromium.org Bug: v8:12864 Change-Id: Ic8f031eafaeab6e17fa070a8447cd093ebb9adf5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3643656Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#80486}
-
Michael Lippautz authored
This is a reland of commit 25e32252 Original change's description: > Reland "[heap] Refactor atomic marking phase" > > This is a reland of commit a3f66927 > > The reland addresses a few CHECKs that were too agressive and also > properly adjusts Oilpan's marking configurations depending on V8's > flags. > > Original change's description: > > [heap] Refactor atomic marking phase > > > > The atomic marking phase was organized in many distinct smaller > > phases. In particular, before http://crrev.com/c/3584115 the marking > > phase split into two large separate phases. > > > > This CL reorganizes marking into two phases that perform regular V8 > > heap marking, Oilpan, and ephemerons: > > - A parallel phase that likely drains all marking worklists; > > - A single-threaded final phase to catch any left overs; > > > > This avoids artificial splitting in phases and also avoids repeated > > starting and joining of jobs. > > > > Change-Id: I5cccfc5777837d9ece10d8f4925781bf2d07d9da > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3602507 > > Reviewed-by: Omer Katz <omerkatz@chromium.org> > > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#80265} > > Change-Id: I26648da361b92d787c173aa9d390100ce8958728 > Bug: chromium:1320896 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3616519 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Omer Katz <omerkatz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80301} Bug: chromium:1320896 Change-Id: I7ebb3bde9f0d3497f46c728bfbc380c1bd4bc021 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3641167Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80485}
-
Igor Sheludko authored
This CL introduces SideEffectDetectorScope which requires explicit allowlisting of cases when side effects are allowed after calling interceptor callbacks. Side effects are not allowed when the callback does not intercept the request. The side effects detector is not enabled yet, it will be enabled in a follow-up CL. Bug: chromium:1310062 Change-Id: I805764920ed016cb37390aef7bb02cbdf5f72846 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3641172Reviewed-by:
-
Liu Yu authored
Port commit fe443a4e Bug: v8:12284 Change-Id: I242c4161ecff09fd7bcfeda27560a6c881c87d09 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3641034 Auto-Submit: Yu Liu <liuyu@loongson.cn> Commit-Queue: Yu Liu <liuyu@loongson.cn> Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/main@{#80483}
-
Omer Katz authored
NewSpace is renamed to SemiSpaceNewSpace and NewSpaceBase is renamed to NewSpace (the new PagedSpace new space implementation will be named PagedNewSpace). Most usecases are updated to use the base class rather than the concrete semi space based implementation. To that end, the base class is extended with additional virtual methods (for delegating to the concrete class). This CL follows these guidelines: (*) If at a method callsite we should know the exact new space implementation we use, we cast to the concrete class. This is the case for example for callsites in scavenger.*. (*) If a method is called from outside the heap implementation or should be present regardless of the concrete implementation, that method is made virtual. (*) Other cases are usually methods that are specific to a concrete implementation but the concrete implementation is not known at the callsite and there's no clear way to nicely abstract the method. In such cases we cast to the concrete SemiSpaceNewSpace implementation for now and we will revisit these cases once PagedNewSpace exists. Bug: v8:12612 Change-Id: I7b85626774ce0d785b0257bf8d32b9f50eeaf292 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3625975 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/bc4639c..aecbdbf fix some typos (#1393) (cui fliter) https://chromium.googlesource.com/external/github.com/google/benchmark/+/aecbdbf R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: Ib44a175614b0e3f2394c901b96e8d0b7fbaaa33c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3641659 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80481}
-
- 11 May, 2022 21 commits
-
-
Deepti Gandluri authored
Change-Id: I0efdbb9cdfef6c206201adf4d75a0c542979d2f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3640267Reviewed-by:
-
Milad Fa authored
Port fe443a4e Original Commit Message: Prototype the instruction on the interpreter, and Arm64. Details of instruction lowerings on all relevant architectures can be found at: https://github.com/WebAssembly/relaxed-simd/issues/40 R=gdeepti@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I5da65cb5f59db811d9d796918b8f5c8892e053fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3642299Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by:
Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#80479}
-
Rob Paveza authored
Bug: chromium:1322555 Change-Id: I2416150c19cd1b9dc062edd42806c1b10eead969 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3625836 Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Clemens Backes authored
BS for "backing store", obviously. R=ahaas@chromium.org Bug: v8:12425 Change-Id: I310ba8e34e8ca2c7b7bdeec5f1bc184330fbaf28 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3641175Reviewed-by:
-
Marja Hölttä authored
Change-Id: Iafca9e5ddf85bc528d4043863ec71ae1ce7020d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3641168Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#80476}
-
Deepti Gandluri authored
Prototype the instruction on the interpreter, and Arm64. Details of instruction lowerings on all relevant architectures can be found at: https://github.com/WebAssembly/relaxed-simd/issues/40 Bug: v8:12284 Change-Id: Id4cb3889d94cf0bb7169ea068efe5ca68cfcbad9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3636365 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
-
Marja Hölttä authored
Side product: enable null as __proto__. Bug: v8:11525,v8:12820 Change-Id: I2b9508d0f3563d9000ddede24e7684aab18c2b5e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3637791Reviewed-by:
-
Camillo Bruni authored
- Make sure the viewport size of the svg is adjusted properly when scaling - Fix an off-by-one when calculating Chunk groups Bug: v8:10644 Change-Id: I56e857a8aa1a67e408bcfb08ed126e6bfdb0ce1b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3641177 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Patrick Thier <pthier@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#80473}
-
Seth Brenith authored
Once the root SharedFunctionInfo for any Script gets its bytecode flushed, the Isolate's compilation cache currently evicts that entry, to reduce memory usage. However, the associated Script is likely still alive, since scripts often declare functions which outlive the initial evaluation of the script. If an identical script is loaded later, a duplicate Script is created for it, which can waste memory. In this change, I propose that the compilation cache keys can refer weakly to the Script. When the root SharedFunctionInfo gets old, instead of deleting the cache entry entirely, we can just drop the strong reference to the SharedFunctionInfo. A subsequent lookup in the cache will retrieve the Script instead of the root SharedFunctionInfo, indicating an opportunity to save some memory by reusing the existing Script. Eventually, all callers to CompilationCache::LookupScript should reuse the Script if possible. This change implements only the easy case of reusing the Script for synchronous parsing. Follow-up changes will be required for the TODO comments left by this change. Bug: v8:12808 Change-Id: Ia8b0389441a682de9a43e73329049fd2e7835d3d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3597106Reviewed-by:
-
Jakob Kummerow authored
This adds a non-standard, unsafe instruction for performance experiments: ref.cast_nop_static behaves like ref.cast_static as far as static types are concerned, but emits no code. Bug: v8:7748 Change-Id: Ic5797a941146a06d7c6ff249d8e29919145d8ea1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3639206Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#80471}
-
Igor Sheludko authored
The issue is that a thread_local variable used in RwxMemoryWriteScope can't be directly accessed from another component, so the workaround is to avoid inlining accesses the variable into other components. Bug: v8:12797, chromium:1324333 Change-Id: I0f83358ac0c663c92ef7b3dff54a068472d61aed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3641169 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Pierre Langlois authored
CIPD provides both amd64 and arm64 binaries for GN, download the correct one. This way we get the correct GN when checking out V8 on an AArch64 linux host. Change-Id: I39c2d7a0062eb330bccac9bc71068bc02bf6958b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3637798 Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#80469}
-
Michael Achenbach authored
This filters the flags --maglev and --no-use-map-space when passed to foozzie. Most open bugs are known or spurious, but all take up the limited hashes for correctness bugs, which prevents finding other bugs. Filtering on the source-side will make those reports appear as fixed. Bug: chromium:1324097, chromium:1317880 Change-Id: Ibf1b04bdfdd2395c3bda5787b4843c6bb5ca8f8e No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3641171Reviewed-by:
-
Camillo Bruni authored
Bug: chromium:1319267 Change-Id: I7956b804246ee2c1fa170bf2eb8f3588b7488b42 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3620285Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#80467}
-
Nico Hartmann authored
Bug: v8:12619 Change-Id: Idcad21d03081e6f012656d36d99ce465158f84eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3634958Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#80466}
-
Patrick Thier authored
This reverts commit b086aa70. Reason for revert: Significant negative performance impact on Android. Original change's description: > [csa] Load hash in TryToName with Acquire semantics > > Add support to atomically load (untagged) values from objects to CSA. > > Bug: v8:12007 > Change-Id: If0c4f20f20e021ace3b1e3a874c0405574d313e1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3627513 > Commit-Queue: Patrick Thier <pthier@chromium.org> > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80444} Bug: v8:12007 Change-Id: Iee97d83725beb0671fd585a2955cf208975315e8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3641164Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80465}
-
Marja Hölttä authored
Bug: v8:11525 Change-Id: I59fdb446d2b704ef386a8695ee3ddd1b1cdd1dac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3635724Reviewed-by:
-
Samuel Groß authored
They are causing failures in the Linux ChromiumOS MSan bot. Bug: chromium:1324301 Change-Id: I7a7bcd111a9f0e0e652d38e107027c51e51bd4bc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3639205Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Samuel Groß <saelo@chromium.org> Reviewed-by:
-
Simon Zünd authored
Doc: https://bit.ly/revive-restart-frame This CL implements support for the Debugger's "restart frame" functionality in the deoptimizer. When the debugger wants to restart a frame, we throw a termination exception. If the restarted frame is an optimized frame or was inlined into an optimized frame, the deoptimizer has to materialize all the frames up to (and including) the frame we want to restart. This is similar to materializing all the frames up until the frame with a catch handler. The main difference is that we do not jump into the middle of the top-most materialized frame, but instead use the RestartFrameTrampolone to immediatly exit, and then re-invoke the top-most materialized frame. R=jarin@chromium.org, tebbi@chromium.org Bug: chromium:1303521 Change-Id: I74ee412bc67f027be81fe56e529b5e5161e97153 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3616504Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/8d86026..bc4639c Add installation and build instructions for Python bindings (#1392) (Nicholas Junge) https://chromium.googlesource.com/external/github.com/google/benchmark/+/bc4639c R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I1ab826ee75b642f04c753dd43e5fe01e9821cc2d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3640524 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80461}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/256e629..1c34f36 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/ac1834f..ecff200 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/406c287..d1ddc12 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/1bc3cd2..31bfd51 Rolling v8/third_party/fuchsia-sdk/sdk: version:8.20220509.2.1..version:8.20220510.2.1 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/cd2b9e3..9da9510 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ide529df4fdc042606e784122148ad1593893b8f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3640523 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80460}
-
- 10 May, 2022 3 commits
-
-
Michael Lippautz authored
Upon destroying a v8::TracedReference while concurrent marking is running, we merely reset the object pointer but do not get rid of the global handle. We were also restting the parameter which would read the internal state for a DCHECK. Remove this clearing as the parameter field is not used for v8::TracedReference. Bug: chromium:1324074 Change-Id: Ic21bad78deba0925e12c3fc1215b087d0ef5dd7a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3637796Reviewed-by:
-
Peter Kasting authored
This prevents "ambiguous call" warnings when compiling in C++20 mode. Bug: chromium:1284275 Change-Id: I52f782aaddfad1920e4b2df5e916b2c292cc7cff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3630346 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/main@{#80458}
-
Tobias Tebbi authored
UnsafePointerAdd is unnecessary as long as a proper bitcast is used before the addition. The bitcast is already in the effect chain and prevents the addition from floating before a GC operation. Change-Id: Ieadb8a51d2d24eaa1132a62c77c674954f7e2644 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3616727Reviewed-by:
-
