- 24 Apr, 2017 27 commits
-
-
brucedawson authored
VC++ 2017's STL doesn't suppress warnings as aggressively as prior versions did. This causes warnings on code which mixes signed and unsigned types. In this case a deque of unsigned integers was being queried to see how many signed integers it contains. This could be fixed by passing in unsigned 0, 1, and 2 to std::count but changing the deque from unsigned to int is simpler. R=adamk@chromium.org BUG=chromium:683729 Review-Url: https://codereview.chromium.org/2834293002 Cr-Commit-Position: refs/heads/master@{#44814}
-
binji authored
This makes it easier to set the value for embedders where it is difficult to plumb through to the Isolate constructor. BUG=chromium:711809 R=jochen@chromium.org Review-Url: https://codereview.chromium.org/2829223002 Cr-Commit-Position: refs/heads/master@{#44813}
-
bbudge authored
- Adds new F32x4AddHoriz, I32x4AddHoriz, etc. to WASM opcodes. - Implements them for ARM. LOG=N BUG=v8:6020 Review-Url: https://codereview.chromium.org/2804883008 Cr-Commit-Position: refs/heads/master@{#44812}
-
neis authored
R=adamk@chromium.org BUG=v8:1569 Review-Url: https://codereview.chromium.org/2833773002 Cr-Commit-Position: refs/heads/master@{#44811}
-
bbudge authored
- All ARM hardware has 32 single precision float registers; save all s-registers regardless of the number of d-registers (16 or 32). LOG=N BUG=v8:6077 Review-Url: https://codereview.chromium.org/2821273004 Cr-Commit-Position: refs/heads/master@{#44810}
-
Franziska Hinkelmann authored
Bug: Change-Id: I116591b80af41e8d210445ba4c2bc3b25577b15d Reviewed-on: https://chromium-review.googlesource.com/480619Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#44809}
-
jkummerow authored
In general, deleting a property from a fast-properties object requires transitioning the object to dictionary mode. However, when the most-recently-added property is deleted, we can simply roll back the last map transition that the object went through. This is a performance experiment: it should make things faster, but if it turns out to have more negative than positive impact, we will have to revert it. TBR=bmeurer@chromium.org (just adding a comment) Previously reviewed at https://codereview.chromium.org/2830093002 Previously landed as 98acfb36 / r44799 Review-Url: https://codereview.chromium.org/2840583002 Cr-Commit-Position: refs/heads/master@{#44808}
-
mlippautz authored
- Dispatch evacuation of a page to its concrete evacuator. - Create MC base class to accommodate shared state. BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2828323004 Cr-Commit-Position: refs/heads/master@{#44807}
-
machenbach authored
Revert of [builtins] DeleteProperty: Handle last-added fast properties (patchset #2 id:20001 of https://codereview.chromium.org/2830093002/ ) Reason for revert: Breaks: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/12920 and https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/10281 Original issue's description: > [builtins] DeleteProperty: Handle last-added fast properties > > In general, deleting a property from a fast-properties object > requires transitioning the object to dictionary mode. However, > when the most-recently-added property is deleted, we can simply > roll back the last map transition that the object went through. > > This is a performance experiment: it should make things faster, > but if it turns out to have more negative than positive impact, > we will have to revert it. > > TBR=bmeurer@chromium.org (just adding a comment) > > Review-Url: https://codereview.chromium.org/2830093002 > Cr-Commit-Position: refs/heads/master@{#44799} > Committed: https://chromium.googlesource.com/v8/v8/+/98acfb36e1acf2ab52ab6b6439eb6356c83dcda6 TBR=ishell@chromium.org,jkummerow@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2843473002 Cr-Commit-Position: refs/heads/master@{#44806}
-
Franziska Hinkelmann authored
This reverts commit e8f1fc24. Reason for revert: Node.js doesn't build with this patch anymore. out/Release/obj/gen/debug-support.cc:428:55: error: expected initializer before ‘<’ token int v8dbg_class_Script__preparsed_scope_data__PodArray<uint32_t> = Script::kPreParsedScopeDataOffset; Original change's description: > [parser] Skipping inner funcs: use PodArray for the data. > > The data produced by the preparser scope analysis might be large. > > ByteArrays are already allowed in the large object space. > > This fixes mjsunit/asm/poppler/poppler.js with the flag on. > > BUG=v8:5516 > > Change-Id: I951836244776c57efdd2a491c5c78493dc8cca63 > Reviewed-on: https://chromium-review.googlesource.com/484459 > Commit-Queue: Marja Hölttä <marja@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#44795} TBR=marja@chromium.org,mstarzinger@chromium.org,ulan@chromium.org,vogelheim@chromium.org,hpayer@chromium.org,v8-reviews@googlegroups.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5516 Change-Id: I3012d27b6b65b37d3afc5f3b0921e044bdcc118e Reviewed-on: https://chromium-review.googlesource.com/485759Reviewed-by: Franziska Hinkelmann <franzih@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#44805}
-
Daniel Ehrenberg authored
This patch cleans up the Intl code by switching to using declared accessors, rather than embedder fields, for holding references to ICU objects. Additionally: - Rename classes to be more similar to how other classes are named - Make some unreachable paths into check-fails, rather than throwing JS exceptions - Move some macros from objects-inl.h into object-macros.h, to allow the implementation here to not touch objects.h - Some setup logic is moved from runtime-i18n.cc to i18n.cc. This patch leaves type tags as they are; a future patch should move from a special Intl type tagging system to object types as other system objects use. Future patches should also move more logic to i18n.cc BUG=v8:5402,v8:5751,v8:6057 CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: Ia9cbb25cf8f52662e3deb15e64179d792c10842c Reviewed-on: https://chromium-review.googlesource.com/479651 Commit-Queue: Daniel Ehrenberg <littledan@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#44804}
-
Franziska Hinkelmann authored
I have no idea how the empty folder got in there in the first place ¯\_(ツ)_/¯. Bug: Change-Id: I0fd94d1dec76f2444b24f772c1691924f872ec55 Reviewed-on: https://chromium-review.googlesource.com/485621Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#44803}
-
yangguo authored
Also move the responsibility of marking builtins as initialized to the deserializer. R=jkummerow@chromium.org Review-Url: https://codereview.chromium.org/2840493002 Cr-Commit-Position: refs/heads/master@{#44802}
-
Daniel Ehrenberg authored
- Split out code for Intl objects into src/objects/ - Rename i18n to intl (except for the name of the build flag) - Use build system more broadly to turn on/off Intl code - Delete a little bit of dead code Bug: v8:5751 Change-Id: I41bf2825a5cb0df20824922b17c24cae637984da Reviewed-on: https://chromium-review.googlesource.com/481284Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Daniel Ehrenberg <littledan@chromium.org> Cr-Commit-Position: refs/heads/master@{#44801}
-
Michael Starzinger authored
This makes sure that typed array constructors (e.g. Int8Array, ...) used within an asm.js module are considered uses of stdlib values, and hence are checked during module instantiation. R=clemensh@chromium.org TEST=mjsunit/regress/regress-6280 BUG=v8:6280,chromium:714537 Change-Id: Ic5d689f5319c4dac4e9df3dca4a8cf5a4edd890b Reviewed-on: https://chromium-review.googlesource.com/485521 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#44800}
-
jkummerow authored
In general, deleting a property from a fast-properties object requires transitioning the object to dictionary mode. However, when the most-recently-added property is deleted, we can simply roll back the last map transition that the object went through. This is a performance experiment: it should make things faster, but if it turns out to have more negative than positive impact, we will have to revert it. TBR=bmeurer@chromium.org (just adding a comment) Review-Url: https://codereview.chromium.org/2830093002 Cr-Commit-Position: refs/heads/master@{#44799}
-
Clemens Hammacher authored
Local refactoring to replace if cascade by switch. For readability and performance. R=ahaas@chromium.org Change-Id: I064d51c7c8232fefcde223b086eb7b9caf44f94c Reviewed-on: https://chromium-review.googlesource.com/485480 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#44798}
-
yangguo authored
for now, it's just the methods - log - warn - debug - info - error - time - timeEnd R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2840543002 Cr-Commit-Position: refs/heads/master@{#44797}
-
yangguo authored
R=jgruber@chromium.org BUG=v8:5821 Review-Url: https://codereview.chromium.org/2841513002 Cr-Commit-Position: refs/heads/master@{#44796}
-
Marja Hölttä authored
The data produced by the preparser scope analysis might be large. ByteArrays are already allowed in the large object space. This fixes mjsunit/asm/poppler/poppler.js with the flag on. BUG=v8:5516 Change-Id: I951836244776c57efdd2a491c5c78493dc8cca63 Reviewed-on: https://chromium-review.googlesource.com/484459 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#44795}
-
Clemens Hammacher authored
Add missing kEnd opcode after each body. Also, avoid the macro. This fix is needed for follow-up changes to the control transfer computation. R=ahaas@chromium.org BUG=v8:5822 Change-Id: If2b4dbea831ec40939a2045701f3d13479331773 Reviewed-on: https://chromium-review.googlesource.com/485481Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#44794}
-
mvstanton authored
BUG= Review-Url: https://codereview.chromium.org/2775503006 Cr-Commit-Position: refs/heads/master@{#44793}
-
ahaas authored
This is the arm64 implementation fo the CL https://codereview.chromium.org/2763593002 Original message: [wasm][arm] Add an additional stack check for functions with big frames. Stack overflow checks are typically implemented as part of the TurboFan graph of a function. This means that the stack check code is executed after frame construction. When a frame is too big, though, there may not be enough space on the stack anymore to throw the stack overflow exception after frame construction. With this CL we do an additional stack check before frame construction for functions with big frames. As discussed offline with mstarzinger, I do this change currently only for WebAssembly. This CL contains only the changes for arm. I will do the other platforms in separate CLs. R=mstarzinger@chromium.org, rodolph.perfetta@gmail.com, v8-arm-ports@googlegroups.com Review-Url: https://codereview.chromium.org/2785723002 Cr-Commit-Position: refs/heads/master@{#44792}
-
dusan.simicic authored
For now skip some WASM SIMD tests that fail when MIPS SIMD extension is not available. Turn on these tests again when simd scalar lowering mechanism supports all WASM SIMD operations. BUG= Review-Url: https://codereview.chromium.org/2829963003 Cr-Commit-Position: refs/heads/master@{#44791}
-
jgruber authored
Consistently support calls to host-C-linkage functions with up to 9 arguments from the simulator, and check that these limits aren't exceeded accidentally. BUG=v8:6281 Review-Url: https://codereview.chromium.org/2825393003 Cr-Commit-Position: refs/heads/master@{#44790}
-
Franziska Hinkelmann authored
This file is never updated, I think we don't use it - or we are using a Chromium revision from 2013 as baseline. Bug: Change-Id: I82496d04cfa7c19e8c44ce9d9d2fa914e0c0d706 Reviewed-on: https://chromium-review.googlesource.com/485600Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#44789}
-
bmeurer authored
We already have an optimization to constant-fold access to an object's prototype via the special __proto__ accessor (specified in appendix B). We can use the same optimization to also constant-fold accesses to an object's prototype via the official Object.getPrototypeOf function. Also add the optimization for Reflect.getPrototypeOf, which is equivalent for object inputs. This is commonly used by Babel to implement various new language features, for example subclassing and certain property lookups. R=yangguo@chromium.org BUG=v8:6292 Review-Url: https://codereview.chromium.org/2841463002 Cr-Commit-Position: refs/heads/master@{#44788}
-
- 23 Apr, 2017 1 commit
-
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e3e598a..4636d31 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Change-Id: Ibd4494496354a6ee1c7aa348d06c081507f39e69 Reviewed-on: https://chromium-review.googlesource.com/485140Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#44787}
-
- 22 Apr, 2017 1 commit
-
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ff3857b..e3e598a Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/34ee837..4d43438 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Change-Id: Ibba7b3dafaba3cc1f416e960595305e657e0c82f Reviewed-on: https://chromium-review.googlesource.com/484939Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#44786}
-
- 21 Apr, 2017 11 commits
-
-
kozyatinskiy authored
.. replace all of them with prepared global object template. + bonus: wrap inspector related methods with inspector namespace. BUG=none R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2832723004 Cr-Commit-Position: refs/heads/master@{#44785}
-
bbudge authored
These can be synthesized from existing operations and scheduled for better performance than if we have to generate blocks of instructions that take many cycles to complete. - Remove F32x4RecipRefine, F32x4RecipSqrtRefine. Clients are better off synthesizing these from splats, multiplies and adds. - Remove F32x4Div, F32x4Sqrt, F32x4MinNum, F32x4MaxNum. Clients are better off synthesizing these or using the reciprocal approximations, possibly with a refinement step. LOG=N BUG=v8:6020 Review-Url: https://codereview.chromium.org/2827143002 Cr-Commit-Position: refs/heads/master@{#44784}
-
jkummerow authored
Review-Url: https://codereview.chromium.org/2827263004 Cr-Commit-Position: refs/heads/master@{#44783}
-
Igor Sheludko authored
BUG=chromium:713365 Change-Id: I5d9d5b5e00a637923a1a3e0dc7f81fa4075c4e82 Reviewed-on: https://chromium-review.googlesource.com/484300Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#44782}
-
Michael Lippautz authored
Bug: Change-Id: I532e8894df288c81a71b08ca85742f2847f57191 Reviewed-on: https://chromium-review.googlesource.com/484339 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#44781}
-
Igor Sheludko authored
Ensure source map is not stable if elements kind transitions are expected. BUG=chromium:700733 Change-Id: Ie937e7064127250b1100109986c3e9b411fae1d6 Reviewed-on: https://chromium-review.googlesource.com/483442Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#44780}
-
jgruber authored
If we avoid throwing a stack overflow exception from Irregexp code during direct calls, there is no need to construct exit frames before the Irregexp call anymore. As that was the last remaining blocker, we can now implement the entire stub in CSA. BUG=v8:5339 Review-Url: https://codereview.chromium.org/2752143003 Cr-Original-Original-Commit-Position: refs/heads/master@{#44770} Committed: https://chromium.googlesource.com/v8/v8/+/74f2497eae068f85da26904d8c451376c77957bf Review-Url: https://codereview.chromium.org/2752143003 Cr-Original-Commit-Position: refs/heads/master@{#44775} Committed: https://chromium.googlesource.com/v8/v8/+/9c0832eb1aceba625a2443a31d51bcaf550c575a Review-Url: https://codereview.chromium.org/2752143003 Cr-Commit-Position: refs/heads/master@{#44779}
-
yangguo authored
R=franzih@chromium.org Review-Url: https://codereview.chromium.org/2834053002 Cr-Commit-Position: refs/heads/master@{#44778}
-
jkummerow authored
NOTRY=true Review-Url: https://codereview.chromium.org/2834853002 Cr-Commit-Position: refs/heads/master@{#44777}
-
jgruber authored
Revert of [regexp] Remove remainder of native RegExpExecStub (patchset #10 id:180001 of https://codereview.chromium.org/2752143003/ ) Reason for revert: More failures on ports: https://build.chromium.org/p/client.v8.ports/builders/V8%20Android%20Arm64%20-%20builder/builds/9123/steps/compile/logs/stdio https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder/builds/8966/steps/compile/logs/stdio Original issue's description: > [regexp] Remove remainder of native RegExpExecStub > > If we avoid throwing a stack overflow exception from Irregexp code during > direct calls, there is no need to construct exit frames before the Irregexp > call anymore. As that was the last remaining blocker, we can now implement the > entire stub in CSA. > > BUG=v8:5339 > > Review-Url: https://codereview.chromium.org/2752143003 > Cr-Original-Commit-Position: refs/heads/master@{#44770} > Committed: https://chromium.googlesource.com/v8/v8/+/74f2497eae068f85da26904d8c451376c77957bf > Review-Url: https://codereview.chromium.org/2752143003 > Cr-Commit-Position: refs/heads/master@{#44775} > Committed: https://chromium.googlesource.com/v8/v8/+/9c0832eb1aceba625a2443a31d51bcaf550c575a TBR=ishell@chromium.org,mstarzinger@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5339 Review-Url: https://codereview.chromium.org/2832193002 Cr-Commit-Position: refs/heads/master@{#44776}
-
jgruber authored
If we avoid throwing a stack overflow exception from Irregexp code during direct calls, there is no need to construct exit frames before the Irregexp call anymore. As that was the last remaining blocker, we can now implement the entire stub in CSA. BUG=v8:5339 Review-Url: https://codereview.chromium.org/2752143003 Cr-Original-Commit-Position: refs/heads/master@{#44770} Committed: https://chromium.googlesource.com/v8/v8/+/74f2497eae068f85da26904d8c451376c77957bf Review-Url: https://codereview.chromium.org/2752143003 Cr-Commit-Position: refs/heads/master@{#44775}
-