- 27 Apr, 2018 1 commit
-
-
Georg Neis authored
R=sigurds@chromium.org Bug: v8:7570 Change-Id: I3f077940117467be98fbb3c2a30684af8eaaf801 Reviewed-on: https://chromium-review.googlesource.com/1032432 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#52837}
-
- 26 Oct, 2016 1 commit
-
-
neis authored
Native setters (see AccessorInfo in accessors.h) didn't have the ability to return a result value. As a consequence of this, for instance, Reflect.set on the length property of arrays had the wrong behavior: var y = []; Object.defineProperty(y, 0, {value: 42, configurable: false}) Reflect.set(y, 'length', 0) The Reflect.set call used to return true. Now it returns false as required by the spec. BUG=v8:5401 Review-Url: https://codereview.chromium.org/2397603003 Cr-Commit-Position: refs/heads/master@{#40579}
-
- 25 May, 2016 1 commit
-
-
cbruni authored
Reland of [keys] Simplify KeyAccumulator (patchset #1 id:1 of https://codereview.chromium.org/2010593002/ ) Reason for revert: relanding, fixed handle dereferencing Original issue's description: > Revert of [keys] Simplify KeyAccumulator (patchset #15 id:280001 of https://codereview.chromium.org/1995263002/ ) > > Reason for revert: > https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/6248 > > Original issue's description: > > [keys] Simplify KeyAccumulator > > > > - Use KeyAccumulator::GetKeys directly instead of JSReceiver::GetKeys > > - Revert KeyAccumulator to single OrderedHashSet implementation. > > - Convert the OrderedHashSet in-place to a FixedArray > > - IndexedInterceptor indices are no longer combined and sorted with the object indices > > > > BUG= > > > > Committed: https://crrev.com/d3324df017046bcde247a5aef6d1b59bfae5908f > > Cr-Commit-Position: refs/heads/master@{#36485} > > TBR=jkummerow@chromium.org,verwaest@chromium.org,cbruni@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/893524b53d43df63bca6cb9b7244d21771fadb0b > Cr-Commit-Position: refs/heads/master@{#36486} TBR=jkummerow@chromium.org,verwaest@chromium.org,machenbach@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2014523002 Cr-Commit-Position: refs/heads/master@{#36502}
-
- 24 May, 2016 2 commits
-
-
machenbach authored
Revert of [keys] Simplify KeyAccumulator (patchset #15 id:280001 of https://codereview.chromium.org/1995263002/ ) Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/6248 Original issue's description: > [keys] Simplify KeyAccumulator > > - Use KeyAccumulator::GetKeys directly instead of JSReceiver::GetKeys > - Revert KeyAccumulator to single OrderedHashSet implementation. > - Convert the OrderedHashSet in-place to a FixedArray > - IndexedInterceptor indices are no longer combined and sorted with the object indices > > BUG= > > Committed: https://crrev.com/d3324df017046bcde247a5aef6d1b59bfae5908f > Cr-Commit-Position: refs/heads/master@{#36485} TBR=jkummerow@chromium.org,verwaest@chromium.org,cbruni@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2010593002 Cr-Commit-Position: refs/heads/master@{#36486}
-
cbruni authored
- Use KeyAccumulator::GetKeys directly instead of JSReceiver::GetKeys - Revert KeyAccumulator to single OrderedHashSet implementation. - Convert the OrderedHashSet in-place to a FixedArray - IndexedInterceptor indices are no longer combined and sorted with the object indices BUG= Review-Url: https://codereview.chromium.org/1995263002 Cr-Commit-Position: refs/heads/master@{#36485}
-
- 21 Mar, 2016 1 commit
-
-
adamk authored
Both of them shipped in Chrome 49 without incident. Also move relevant tests from harmony/ to es6/. Review URL: https://codereview.chromium.org/1815773002 Cr-Commit-Position: refs/heads/master@{#34964}
-
- 22 Feb, 2016 1 commit
-
-
littledan authored
The Proxy enumerate trap and Reflect.enumerate are removed from the ES2016 draft specification. This patch removes the Reflect.enumerate function, and a follow-on patch will be responsible for the Proxy trap changes. R=adamk LOG=Y BUG=v8:4768 Review URL: https://codereview.chromium.org/1721453002 Cr-Commit-Position: refs/heads/master@{#34196}
-
- 07 Jan, 2016 1 commit
-
-
neis authored
Some tests passed a string as second argument to assertThrows, expecting it to be matched against the exception. However, assertThrows simply ignored these. (Some other tests actually seem to use that argument as a comment ...) This CL - changes assertThrows to fail if the second argument is not a function, - adds assertThrowsEquals which compares the exception to a given value using assertEquals - fixes some bogus tests that got exposed by this. R=jarin@chromium.org BUG= Review URL: https://codereview.chromium.org/1544793002 Cr-Commit-Position: refs/heads/master@{#33159}
-
- 04 Dec, 2015 1 commit
-
-
neis authored
R=rossberg BUG= Review URL: https://codereview.chromium.org/1498983003 Cr-Commit-Position: refs/heads/master@{#32615}
-
- 18 Nov, 2015 1 commit
-
-
neis authored
Proxies are not properly supported yet. This is a reland of 1405243006. TBR=rossberg@chromium.org Review URL: https://codereview.chromium.org/1460563002 Cr-Commit-Position: refs/heads/master@{#32065}
-
- 10 Nov, 2015 1 commit
-
-
neis authored
Reason for revert: failed tests on a Windows build. TBR=rossberg,cbruni,neis NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1426943007 Cr-Commit-Position: refs/heads/master@{#31907}
-
- 09 Nov, 2015 1 commit
-
-
neis authored
Proxies are not properly supported yet. R=cbruni, rossberg BUG= Review URL: https://codereview.chromium.org/1405243006 Cr-Commit-Position: refs/heads/master@{#31906}
-
- 03 Nov, 2015 2 commits
-
-
neis authored
If the property is a data property on the holder (or does not exist) and is a readonly data property in the receiver, then we must fail. R=rossberg, verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/1424233005 Cr-Commit-Position: refs/heads/master@{#31751}
-
neis authored
When the property is an accessor property in the receiver but not on the holder (ES6 "target"), we must fail. R=rossberg, verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/1427113002 Cr-Commit-Position: refs/heads/master@{#31733}
-
- 30 Oct, 2015 2 commits
-
-
neis authored
Proxies are not properly supported yet. R=rossberg BUG=v8:3931 LOG=n Review URL: https://codereview.chromium.org/1415883007 Cr-Commit-Position: refs/heads/master@{#31685}
-
neis authored
Proxies are not properly supported yet. R=rossberg, jkummerow@chromium.org BUG= Review URL: https://codereview.chromium.org/1408163005 Cr-Commit-Position: refs/heads/master@{#31674}
-
- 29 Oct, 2015 1 commit
-
-
neis authored
Proxies are not properly supported yet. R=rossberg,jkummerow@chromium.org BUG=v8:3931 LOG=n Review URL: https://codereview.chromium.org/1421033002 Cr-Commit-Position: refs/heads/master@{#31661}
-
- 22 Oct, 2015 1 commit
-
-
neis authored
Proxies are not properly supported yet. R=rossberg BUG=v8:3931 LOG=n Review URL: https://codereview.chromium.org/1417243002 Cr-Commit-Position: refs/heads/master@{#31465}
-
- 21 Oct, 2015 2 commits
-
-
neis authored
Proxies are not properly supported yet. R=rossberg BUG=v8:3931 LOG=n Review URL: https://codereview.chromium.org/1416433003 Cr-Commit-Position: refs/heads/master@{#31447}
-
neis authored
Ignore proxies for now. R=rossberg BUG=v8:3931 LOG=n Review URL: https://codereview.chromium.org/1397853005 Cr-Commit-Position: refs/heads/master@{#31431}
-
- 15 Oct, 2015 1 commit
-
-
neis authored
R=rossberg BUG=v8:3931 LOG=n Review URL: https://codereview.chromium.org/1397443013 Cr-Commit-Position: refs/heads/master@{#31299}
-
- 08 Oct, 2015 1 commit
-
-
neis authored
Also add some more tests. R=rossberg BUG= Review URL: https://codereview.chromium.org/1392203002 Cr-Commit-Position: refs/heads/master@{#31181}
-
- 07 Oct, 2015 1 commit
-
-
neis authored
- Reflect.deleteProperty - Reflect.get - Reflect.has - Reflect.isExtensible Reflect.get doesn't support the receiver argument yet, and some of the others don't support proxies yet. R=rossberg BUG=v8:3931 LOG=n Review URL: https://codereview.chromium.org/1379313002 Cr-Commit-Position: refs/heads/master@{#31146}
-