- 08 Jul, 2022 21 commits
-
-
Leszek Swirski authored
Add a concept of "register snapshots" which snapshot the end-state of the register allocation for a node (i.e. the state of the register allocation when the node's code completes). These can be requested by nodes, so that they know which registers need to be kept alive by the node, and which of those are tagged. Nodes can then use this information to temporarily spill registers across a deferred call, without requiring the register allocator to spill them unconditionally on the non-deferred path. The maglev safepoint table has support for these additional spilled registers. Bug: v8:7700 Change-Id: Id0052b5da86dd263f9019b1433fe5994a472a5b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3751203 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#81614}
-
Manos Koukoutos authored
Mostly src/codegen, src/compiler, src/interpreter, src/libplatform. Drive-by: Remove some unreachable code. Bug: v8:13006 Change-Id: I1a9467f7e42531c545f660d35416c388e8ef9d3c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3749193 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Leszek Swirski authored
It is currently incorrect and causing issues, put it behind a flag so that we can fix these issues while working on the rest of maglev in parallel. Bug: v8:7700 Change-Id: Idab7056db1236366410c30c06473016842aee5ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3748659 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#81612}
-
Leszek Swirski authored
Merging register values can encounter constants, which are loadable but don't have spill slots. Add support for these (in practice this is the same behaviour, we're just fixing a DCHECK). Bug: v8:7700 Change-Id: I9ab8ba1fc3a3a64fe16668bb317ad02f878f5849 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3749579 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Maya Lekova authored
Bug: chromium:1342020 Change-Id: Ie8e68d06509cb64088c3e88140f5ab0c6494c915 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3747865Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Auto-Submit: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#81610}
-
Maksim Sadym authored
1. Added method `debug::GetBigIntStringValue`. 2. Used the method in BigInt BiDi serialization. Bug: v8:13043 Change-Id: I6047d2ea7657e8bb891f5099971deed49bd3e31b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3749185 Auto-Submit: Maksim Sadym <sadym@chromium.org> Commit-Queue: Maksim Sadym <sadym@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/main@{#81609}
-
Jakob Kummerow authored
Duplicate subsections in the name section are disallowed by the spec. Since the whole name section is optional, we shouldn't fail validation because of it, but we'll ignore duplicate subsections. Drive-by cleanup: reduce code duplication by reusing DecodeNameMap from DecodeIndirectNameMap. Fixed: chromium:1342338 Change-Id: Icae14c27a0255c6107517354f07ec8eb78d2a7b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3751211 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#81608}
-
Andy Wingo authored
We represent WTF-8 views as ByteArray instances. Bug: v8:12868 Change-Id: I642ee2ef3d6fd7ea0f383073b282549c31233c7b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3750931 Commit-Queue: Andy Wingo <wingo@igalia.com> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#81607}
-
Leszek Swirski authored
Bug: v8:7700 Change-Id: I78d22fe079313312274a1ee9ac285d5dc4e9c38f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3751208Reviewed-by:
-
Thibaud Michaud authored
The stack-switching variant of the wasm-to-js wrapper was only generated for js functions with matching arity. Also suspend for js functions with mismatching arity and unknown callables. R=ahaas@chromium.org Bug: v8:12191 Change-Id: Iab3e2d85210c86a814ae1defab9cd57bf74d80d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3749578Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#81605}
-
Leszek Swirski authored
Having interrupt budget updates be part of register allocation caused various difficulties around gap moves for temporaries vs. gap moves for phis. This patch splits them off into a separate node which is separately allocated, and adds invariant checks that phi-updating nodes don't do any other tricky register allocation. Bug: v8:7700 Change-Id: I5a454fe4c5a5adff08d5a327ee34fbb43cda97ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3751196Reviewed-by:
-
Clemens Backes authored
This is a reland of commit 1ed7d0b8. The (hopefully) last issue in chromium is fixed in https://crrev.com/c/3745533. Original change's description: > [flags] Enable freezing of flags > > This enables the --freeze-flags-after-init flag globally. Note that > tests, fuzzers, Node and other still explicitly disable the flag. The > chrome renderer process and default d8 execution will have it enabled > though. > > R=cbruni@chromium.org > > Bug: v8:12887 > Change-Id: I9a15ef64227e5e6e04779d8d671a2c50d99c9097 > Cq-Include-Trybots: luci.v8.try:v8_linux_blink_rel > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3695264 > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/main@{#81214} Bug: v8:12887 Change-Id: I6445c04abc55242d6e2f204d45ec9ce22c6ece34 Cq-Include-Trybots: luci.v8.try:v8_linux_blink_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3707284Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#81603}
-
Clemens Backes authored
Limit the allowed module size in the streaming decoder to 256kiB to avoid OOMs on systems that are very memory constained (32-bit ASan builds). Drive-by: Skip linting wasm fuzzer input files, as those are binary files. R=ahaas@chromium.org Bug: chromium:1334577, chromium:1337558 Change-Id: Ie5599088fd25c0bc7c8f9f1a953d31fe61a21844 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3700073Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Matthias Liedtke authored
in unit tests: - function-body-decoder-unittest.cc - module-decoder-unittest.cc Bug: v8:7748 Change-Id: I1f782bb7292ecd1206a921daccde23b1d314d325 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3751198Reviewed-by: -
Andy Wingo authored
Bug: v8:12868 Change-Id: I4229cefc4dfdb29214712aeef18841092cdf9e87 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3748653 Commit-Queue: Andy Wingo <wingo@igalia.com> Reviewed-by:
-
Marja Hölttä authored
In this part: sort Bug: v8:11111 Change-Id: Idd1e7552b4cdda0cdec610189391dbb729c94cdf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3742703Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#81599}
-
Marja Hölttä authored
Bug: v8:11111,chromium:1339648 Change-Id: I3b472f74f37a4e1514ce20635b16970e95a36e15 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3735162Reviewed-by:
-
Andy Wingo authored
Bug: v8:12868 Change-Id: Ide772c6e480783931942f6c02eb3e57dd3adf508 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3751201 Commit-Queue: Andy Wingo <wingo@igalia.com> Reviewed-by:
-
Marja Hölttä authored
In this part: shift, unshift, reverse Bug: v8:11111 Change-Id: I13c156dc401b6a90b3bcccd9261b7240d8dc7498 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3740720Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ea8947a..85604a1 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Idd514783b20c79ebd5db5a1f8a411580c1e21013 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3751763 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81595}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/6f2de7b..d7cbf23 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/78c53d1..bb07d9e Rolling v8/third_party/fuchsia-sdk/sdk: version:8.20220706.2.1..version:8.20220707.3.1 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I939a41ce43ce12a41da87970bc550c0ee03797ba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3751761 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81594}
-
- 07 Jul, 2022 19 commits
-
-
Michael Lippautz authored
Parallel marking is running at the beginning of the atomic pause, so the extraction of these objects must happen atomically. Bug: v8:13045 Change-Id: I90d489597847e76ade7185cd7120816eddcdc9fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3749204Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#81593}
-
Toon Verwaest authored
Now that we have block-lists this isn't strictly necessary anymore. As a side-effect, AllocateRegister for results now can't use registers used as inputs anymore either. We could explicitly use FreeSomeRegister without blocklist in that case, but this CL doesn't do that yet. Bug: v8:7700 Change-Id: If4aef1face138e528dc4f8da674326805e4af67c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3749194 Auto-Submit: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#81592}
-
Jakob Kummerow authored
Either the whole module or a single function: $ out/x64.release/wami my_module.wasm --single-wat 42 $ out/x64.release/wami my_module.wasm --full-wat Change-Id: Ifa1088a78bb6f86427074806b05226c4bf583b9a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3747677 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Merging typed slots in the marking barrier may require allocating a new typed slots set. We need a CodePageHeaderModificationScope since that slot set is actually written into the code page. Bug: chromium:1336850, v8:12797 Change-Id: If3f7d2bb179c2554ea2888c5ad92f098bd29b1c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3751210Reviewed-by:
-
Michael Achenbach authored
Bug: v8:13005 Change-Id: I25f44231d936d7b3688898e6941d3877f31fafd3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3751205 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Michael Achenbach authored
No-Try: true Bug: v8:13005 Change-Id: I940d78696885f94afee8b6222b439227b22a3ea5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3751209 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/main@{#81588}
-
Michael Achenbach authored
The test mjsunit/wasm/shared-memory-worker-gc is too slow on the gcov bot. No-Try: true Bug: v8:13005 Change-Id: Idac2a6df836c981195d61f9c2737c06d548edb28 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3751204 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Milad Fa authored
Port 1f16e67b Original Commit Message: Mostly src/codegen, src/compiler, src/snapshot, src/utils. R=manoskouk@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I8d3c2296aa82332e854ba6c3c8f99346d9561168 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3749827 Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by:
Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#81586}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/7280499..ac8a6d3 cleanup comments (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/ac8a6d3 fix sanitizer builds by using clang 13 (#1426) (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/8205547 fix dependabot numpy version warning (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/0a95a42 fix cmake warning for libcxx setup (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/a8bc318 Expose default help printer function (#1425) (Yuri Khan) https://chromium.googlesource.com/external/github.com/google/benchmark/+/4136c4a Fix DoNotOptimize() GCC compile error with some types (#1340) (#1424) (Alexander Popov) https://chromium.googlesource.com/external/github.com/google/benchmark/+/dfdda57 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I3e08e9e4f0374c836b9fb96d80feff125664589f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3750518 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#81585}
-
Jakob Kummerow authored
DevTools needs this. Bug: v8:12917 Change-Id: Id63f290ebc9eff4ab87e88b97d81ae4d5ac3283a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3747676Reviewed-by:
-
Darius M authored
Bug: v8:12783 Change-Id: I5495aac4213b0f9783b5e239b2d90047d25552d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3721497 Commit-Queue: Darius Mercadier <dmercadier@chromium.org> Reviewed-by:
-
Andy Wingo authored
See https://github.com/WebAssembly/stringref/issues/24. Bug: v8:12868 Change-Id: Ib3854625aa18ae0e59f8d62d04e7132ca7381f60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3749179 Commit-Queue: Andy Wingo <wingo@igalia.com> Reviewed-by:
-
Ben Noordhuis authored
std::is_same is the wrong predicate to use because `unsigned long` need not be equivalent to either `unsigned int` or `unsigned long long`. Fixes: https://github.com/nodejs/node-v8/issues/229 Bug: v8:12982 Change-Id: Iafff3c6a33f841490fa66d48649d24f720c869f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3749192 Auto-Submit: Ben Noordhuis <info@bnoordhuis.nl> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-by:
Darius Mercadier <dmercadier@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Refactor register saving (both general and double registers) as using a PushAll helper taking a RegList. Change-Id: I0ccdec091f60988cbdb6893eb9cdda11efd8e1eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3749176 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Samuel Groß authored
This field points to the start of an ArrayBuffer backing store, which is guaranteed to be located inside the sandbox if it is enabled. As such, this simply turns the field into a sandboxed pointer field. Bug: chromium:1342548 Change-Id: I5a76e23cfc83b2a04cd461def1cd04337ccf5cf7 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3749190Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#81579}
-
Samuel Groß authored
Page allocation in a partially-reserved sandbox is generally best-effort once the reserved part is fully allocated, which happens in this test. As such, there is no guarantee that this test succeeds, and it does seem to fail in practice on some bots with memory sanitizers enabled. The same logic is essentially tested by the VirtualAddressSpaceTest.TestEmulatedSubspace test so simply deleting this test should be fine. Bug: v8:13040 Change-Id: I1469bd9d2e330a6e834bb565ce4e7f5985be28a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3749180Reviewed-by:
-
Clemens Backes authored
Instead of just failing with a CHECK failure, do print the actual cycle. Before: # Check failed: iteration++ < 1000. After: # Cycle in flag implications: --assert-types -> --no-concurrent-recompilation --stress-concurrent-inlining -> --concurrent-recompilation R=tebbi@chromium.org Bug: chromium:1336577 Change-Id: I9707fbe19fbc3c27b54cf2ef7626a5f8825e8c60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3707275 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Toon Verwaest authored
To implement this, this cl introduces explicit check smi/heapobject nodes that we use for the value (and also separate from CheckMaps now). This will allow us to remove duplicate checks later. The performance of StoreField itself isn't vastly better due to fixed register requirements though. Bug: v8:7700 Change-Id: I98caa290c88be64f41154fd232bde98fb46ce497 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3747870 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Mostly src/codegen, src/compiler, src/snapshot, src/utils. Bug: v8:13006 Change-Id: I2fb31acc749a7376e6f2a7424ed2e67ff479d971 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3749178 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
