- 01 Mar, 2019 3 commits
-
-
Matt Gardner authored
The original was reverted for breaking webkit layout tests: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064/30270 It also caused the following clusterfuzz failures: chromium:935832 This was a correctness bug due to not properly handling the case of arrays with prototypes other than Array.prototype. Accesses that were TheHole were not being handled property, both in bounds holes in holey arrays and out of bounds on either holey or packed arrays. Handling was incorrect both in access-assembler and in Turbofan. chromium:935932 This bug was that there was no handling for Has checks on the global object. Turbofan was emitting code for a store (the 'else' condition on 'access_mode == AccessMode::kLoad'). It hit a DCHECK in debug builds but in release could show up in different places. This is the bug that caused the webkit layout test failure that led to the revert. Both bugs are fixed by in CL, and tests are added for those cases. Bug: v8:8733, chromium:935932, chromium:935832 Change-Id: Iba0dfcfce6e15d2c0815a7670ece67bc13ba1925 Reviewed-on: https://chromium-review.googlesource.com/c/1493132Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Matt Gardner <magardn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#59958}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/325e95d..04fc46b Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/827da84..9950df1 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/fe34723..a6d41e2 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/960f195..8c67416 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/a287525..257c91c TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I19df61991d87ab439d3dd2c88368081dc5632be3 Reviewed-on: https://chromium-review.googlesource.com/c/1495899Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#59957}
-
Johannes Henkel authored
... to b13e24ccee66d7e0590ce1266db9c906e3648561 to support UTF16 strings with binary protocol (v8). Original review here: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1493312 Change-Id: I401c5d52d233805dc681bb23b40df99f2ea14992 Reviewed-on: https://chromium-review.googlesource.com/c/1493291 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#59956}
-
- 28 Feb, 2019 29 commits
-
-
Tom Tan authored
Assembler::AbortedCodeGeneration() is defined in assembler-arm64.h, but it calls into Constant::Clear() which is defined in assembler-arm64.cc. This introduces dependency to v8_base component when including assembler-arm64.h which is not always possible like for V8 unittests target. To fix this, we could define both in the same file, like Assembler::IsConstPoolEmpty() calls Constant::Clear() and both are defined in assembler-arm64.h, so it works fine. Bug: chromium:893460 Change-Id: I895cf0147950fca20142ea5ed18bcd020c1ab866 Reviewed-on: https://chromium-review.googlesource.com/c/1493293Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#59955}
-
Maciej Goszczycki authored
This provides a single point where read-only space sharing will be controlled. Eventually ReadOnlyDeserializer will take ReadOnlyHeap instead of Isolate, first steps include https://chromium-review.googlesource.com/c/v8/v8/+/1483054 Bug: v8:7464 Change-Id: I213819aeca6fca335235025c9195edf474230eda Reviewed-on: https://chromium-review.googlesource.com/c/1489087 Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Change-Id: I4d774452e4537ba507bab87ac0a197d17a2f2862 Reviewed-on: https://chromium-review.googlesource.com/c/1494759Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#59953}
-
Dan Elphick authored
This changes DebugObjectCache to be a vector of Handles rather than tagged pointers, meaning it's not GC-safe. This will allow PrintStack to allocate memory if required (if for instance source positions must be regenerated). Bug: v8:8834, v8:8510 Change-Id: Ieec9a827af9abbcb9b5b237d79984eedf0cdcc57 Reviewed-on: https://chromium-review.googlesource.com/c/1494755Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#59952}
-
Leszek Swirski authored
Rather than manually tracking basic blocks in the bytecode array builder, use the existing dead code elimination to generate an implicit return iff the block ending the bytecode is not dead by the time all statements have been visited. Change-Id: I9520486a523ec4e01bc203e9a847eb1f57b130b6 Reviewed-on: https://chromium-review.googlesource.com/c/1494756Reviewed-by:
-
Clemens Hammacher authored
1) Rename {size()} to {total_size()} because {size() != end() - start()}. 2) Avoid undefined behaviour when creating segments, i.e. construct them via a constructor. 3) Minor drive-by cleanups. R=mstarzinger@chromium.org Bug: v8:8834 Change-Id: I3de47b2a775cf277e2f01ba5482afbd400acd06c Reviewed-on: https://chromium-review.googlesource.com/c/1493926 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#59950}
-
Clemens Hammacher authored
Avoid atomicops, use std::atomic instead. R=ishell@chromium.org Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel Bug: v8:8834, v8:8926 Change-Id: I07bc7bbe079fc4a138feb4d8fda91eb57046846d Reviewed-on: https://chromium-review.googlesource.com/c/1491609Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#59949}
-
Leszek Swirski authored
This is a reland of 35269f77 Switches on an expression that unconditionally throws would have all their case statements dead, causing a DCHECK error in the SwitchBuilder. This fixes up the DCHECK to allow dead labels. Original change's description: > [ignition] Skip binding dead labels > > BytecodeLabels for forward jumps may create a dead basic block if their > corresponding jump was elided (due to it dead code elimination). We can > avoid generating such dead basic blocks by skipping the label bind when > no corresponding jump has been observed. This works because all jumps > except JumpLoop are forward jumps, so we only have to special case one > Bind for loop headers to bind unconditionally. > > Since Binds are now conditional on a jump existing, we can no longer rely > on using Bind to get the current offset (e.g. at the beginning of a try > block). Instead, we now expose the current offset in the bytecode array > writer. Conveniently, this means that we can be a bit smarter about basic > blocks around these statements. > > As a drive-by, remove the unused Bind(target,label) function. > > Bug: chromium:934166 > Change-Id: I532aa452fb083560d07b90da99caca0b1d082aa3 > Reviewed-on: https://chromium-review.googlesource.com/c/1488763 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59942} TBR=rmcilroy@chromium.org Bug: chromium:934166 Change-Id: If6eab4162106717ce64a2dc477000c6a76354cb4 Reviewed-on: https://chromium-review.googlesource.com/c/1494535Reviewed-by:
-
Sigurd Schneider authored
This reverts commit 35269f77. Reason for revert: Fuzzer unhappy: https://ci.chromium.org/p/v8/builders/ci/V8%20Fuzzer/29792 Original change's description: > [ignition] Skip binding dead labels > > BytecodeLabels for forward jumps may create a dead basic block if their > corresponding jump was elided (due to it dead code elimination). We can > avoid generating such dead basic blocks by skipping the label bind when > no corresponding jump has been observed. This works because all jumps > except JumpLoop are forward jumps, so we only have to special case one > Bind for loop headers to bind unconditionally. > > Since Binds are now conditional on a jump existing, we can no longer rely > on using Bind to get the current offset (e.g. at the beginning of a try > block). Instead, we now expose the current offset in the bytecode array > writer. Conveniently, this means that we can be a bit smarter about basic > blocks around these statements. > > As a drive-by, remove the unused Bind(target,label) function. > > Bug: chromium:934166 > Change-Id: I532aa452fb083560d07b90da99caca0b1d082aa3 > Reviewed-on: https://chromium-review.googlesource.com/c/1488763 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59942} TBR=rmcilroy@chromium.org,leszeks@chromium.org Change-Id: I8118e54e0afa5e08b0a0a874c952f8a01f1c3242 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:934166 Reviewed-on: https://chromium-review.googlesource.com/c/1494534Reviewed-by:
-
Clemens Hammacher authored
We sometimes store function indexes and number of functions as {size_t} and sometimes as {int}. Unify a few places to be {int}. R=ahaas@chromium.org Change-Id: I1d204cbd9388245f97f291a469b32743457ab2c0 Reviewed-on: https://chromium-review.googlesource.com/c/1491607Reviewed-by:Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#59946}
-
Maciej Goszczycki authored
Bug: v8:8562 Change-Id: I1ad6d2febc9327e2ef93f0409f6fddf1cebb4834 Reviewed-on: https://chromium-review.googlesource.com/c/1494012Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Cr-Commit-Position: refs/heads/master@{#59945}
-
Mike Stanton authored
Since the performance implications of the patch "[Torque] Reduce code size by combining FixedArray/FixedDoubleArray paths" are negligible, I'll extend the pattern to all the array builtins, providing a savings of about 20% per builtin. Bug: v8:7672 Change-Id: Ib9aace4da38369842154065f5b4bcfb3ce2355d7 Reviewed-on: https://chromium-review.googlesource.com/c/1488768 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#59944}
-
Sigurd Schneider authored
Some array builtins used branch hints for loop bounds checks, causing all code after the inlined builtin to become deferred code. This is detrimental for performance. This CL removes the hints, which improves code scheduling a lot, on the micro benchmark from the linked bug by 3x. Bug: v8:8922 Change-Id: I64faaf763a385c80d80b8be5a4fb8e75dd731693 Reviewed-on: https://chromium-review.googlesource.com/c/1494011Reviewed-by:
-
Leszek Swirski authored
BytecodeLabels for forward jumps may create a dead basic block if their corresponding jump was elided (due to it dead code elimination). We can avoid generating such dead basic blocks by skipping the label bind when no corresponding jump has been observed. This works because all jumps except JumpLoop are forward jumps, so we only have to special case one Bind for loop headers to bind unconditionally. Since Binds are now conditional on a jump existing, we can no longer rely on using Bind to get the current offset (e.g. at the beginning of a try block). Instead, we now expose the current offset in the bytecode array writer. Conveniently, this means that we can be a bit smarter about basic blocks around these statements. As a drive-by, remove the unused Bind(target,label) function. Bug: chromium:934166 Change-Id: I532aa452fb083560d07b90da99caca0b1d082aa3 Reviewed-on: https://chromium-review.googlesource.com/c/1488763 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL introduces a new contextual 'LanguageSererData'. Its purpose is to hold all the eagerly calculated data needed to answer language server requests. The first thing collected are the definitoins of some IdentifierExpresisons and macro/builtin call-sites. Collecting this data is not necessary for normal compilation, so it is disabled by default and can be enabled via a Torque compiler option. Since the holder class is a contextual for which no scope exists during normal compilation, accidental collection of unnecessary language server data *should* be prevented. R=tebbi@chromium.org Bug: v8:7793 Change-Id: Iffcebad4c420a0a51b1ed3c37a37c3475c6ab2e8 Reviewed-on: https://chromium-review.googlesource.com/c/1491594Reviewed-by:
-
Sigurd Schneider authored
after previous change, which moved icons to .png format and to subdirectory img/. Bug: v8:7327 Notry: true Change-Id: Iebbbe175cc65ed1f2e505084344a2b55864732e7 Reviewed-on: https://chromium-review.googlesource.com/c/1494009 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#59940}
-
Sigurd Schneider authored
Change-Id: I19abd54f3c7825a99cbebd370092259cf8c21945 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1494007Reviewed-by:
-
Michael Achenbach authored
This lets foozzie call d8 with sanity output before doing the actual correctness comparisons. This will make clusterfuzz dedupe cases on the difference found in the sanity checks. Also adding missing OWNERS file. NOTRY=true Bug: chromium:933076 Change-Id: I4229183726064cc0ad76da8fe432e1dbb601a7ba Reviewed-on: https://chromium-review.googlesource.com/c/1491221 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59938}
-
Clemens Hammacher authored
This is a reland of b2f8280e, fixing asan and msan invocations to use {Segment::capacity()} instead of {Segment::size()}. Original change's description: > [zone] Teach ASan about the zone segment pool > > This adds proper poisoning/unpoisoning to segments put into the segment > pool of an accounting allocator, and also marks a segment uninitialized > when returning it from the pool. This gives ASan a better chance at > catching use-after-free and others. > > Drive-by: Fix type check in ASAN_POISON_MEMORY_REGION > > R=mstarzinger@chromium.org > > Change-Id: Iadbdd7c0a0c80da8e7b9bb8f3399209715436073 > Reviewed-on: https://chromium-review.googlesource.com/c/1489086 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59932} Change-Id: I3150a7f96fefd94bd96af2fdc24c302a4a5d0ea3 Reviewed-on: https://chromium-review.googlesource.com/c/1493866Reviewed-by:
-
Benjamin authored
The SourceRangeAstVisitor has custom logic for blocks ending with a statement that has a continuation range. In these cases, the trailing continuation is removed which makes the reported coverage ranges a bit nicer. throw Error('foo') consists of an ExpressionStatement, with a Throw expression stored within the statement. The source range itself is stored with the Throw, not the statement. We now properly extract the correct AST node for trailing throw statements. R=jgruber@chromium.org, neis@chromium.org, yangguo@chromium.org Bug: v8:8691 Change-Id: Ibcbab79fbe54719a8993045040349c863b139011 Reviewed-on: https://chromium-review.googlesource.com/c/1480632 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#59936}
-
Clemens Hammacher authored
Remove another use of atomicops. R=mstarzinger@chromium.org Bug: v8:8834 Change-Id: Ide1aa87f4bb4cdc4346fe7b1bf78b8118592c7ae Reviewed-on: https://chromium-review.googlesource.com/c/1491603 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This reverts commit b2f8280e. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/25509 Original change's description: > [zone] Teach ASan about the zone segment pool > > This adds proper poisoning/unpoisoning to segments put into the segment > pool of an accounting allocator, and also marks a segment uninitialized > when returning it from the pool. This gives ASan a better chance at > catching use-after-free and others. > > Drive-by: Fix type check in ASAN_POISON_MEMORY_REGION > > R=mstarzinger@chromium.org > > Change-Id: Iadbdd7c0a0c80da8e7b9bb8f3399209715436073 > Reviewed-on: https://chromium-review.googlesource.com/c/1489086 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59932} TBR=mstarzinger@chromium.org,clemensh@chromium.org Change-Id: Iacf322d04822382ea8e1f5abe1d5e72758adc399 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1493055Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59934}
-
tzik authored
This introduces v8::MicrotaskQueue backed by v8::internal::MicrotaskQueue. The embedder will get an option to use non-default MicrotaskQueue by creating the instance by v8::MicrotaskQueue::New(). The instance can be attached to a Context by passing it to Context::New(). Bug: v8:8124 Change-Id: Iee0711785d5748860eb94e30a8d83199a743ffaa Reviewed-on: https://chromium-review.googlesource.com/c/1414950 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#59933}
-
Clemens Hammacher authored
This adds proper poisoning/unpoisoning to segments put into the segment pool of an accounting allocator, and also marks a segment uninitialized when returning it from the pool. This gives ASan a better chance at catching use-after-free and others. Drive-by: Fix type check in ASAN_POISON_MEMORY_REGION R=mstarzinger@chromium.org Change-Id: Iadbdd7c0a0c80da8e7b9bb8f3399209715436073 Reviewed-on: https://chromium-review.googlesource.com/c/1489086 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This makes the output a lot smaller and thus makes it easier to see the relevant part of the command. R=machenbach@chromium.org Change-Id: I62ac7218be4a02f0270a2d88a2f69b6ced45a041 Reviewed-on: https://chromium-review.googlesource.com/c/1491597 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7cd7119..325e95d Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/f610057..827da84 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/be28670..fe34723 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/987f14b..a287525 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I1f645eb9c6d13cefaca46ad5f93f2712fd4a2728 Reviewed-on: https://chromium-review.googlesource.com/c/1493047Reviewed-by:
-
Jakob Kummerow authored
One of the early (no-op) returns forgot to check whether the number of existing digits equals the number of required digits. Bug: chromium:936506 Change-Id: Ic9a5b927306de3cd6b26662785ac11d866e12026 Reviewed-on: https://chromium-review.googlesource.com/c/1493133Reviewed-by:
-
Frank Tang authored
Mentioned by ICU guru during design review. Bug in theory, but cannot find a locale has 'b' and 'B' in the 12 date/time style canned pattern. Bug: v8:8877 Change-Id: I126fdf979e8ea5b97773c8fd974359a7e52f18e9 Reviewed-on: https://chromium-review.googlesource.com/c/1480922Reviewed-by:
Frank Tang <ftang@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#59928}
-
Frank Tang authored
https://chromium.googlesource.com/v8/v8/+/ee3f62fb0dd872841c589a6e61d9c6a97d169939 1. On Android, Skips mjsunit tests depending on setting LC_ALL env var. 2. With the cherrypick from ICU, locale "C" will no longer be canonicalized into "en-US-POSIX" since that is not part of a registered canonicalization. So on OS which there are no LANG, LC_CTYPE or LC_MESSAGE env vars, we need to also map that fallback locale "C" to "en-US". Bug: v8:8242, v8:8260, v8:8903 Change-Id: I63e5db10e0a7453394787421f4d55418f286f67d Reviewed-on: https://chromium-review.googlesource.com/c/1479030Reviewed-by:
-
- 27 Feb, 2019 8 commits
-
-
Alexei Filippov authored
Change-Id: I1863f9d93ed36956f0c66540df4f44ecd809b5e8 Reviewed-on: https://chromium-review.googlesource.com/c/1492516Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#59926}
-
Francis McCabe authored
Implement the ReturnCall functionality for the interpreter. Note that some tests have had to be deferred to the implementation of ReturnCall for TurboFan. This a reland of https://chromium-review.googlesource.com/c/v8/v8/+/1467343 Bug: v8:7431 Change-Id: Iac9392a6a81995e30009dac74035e4d728ac3dbb Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/1484905 Commit-Queue: Francis McCabe <fgm@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Georg Neis authored
This merges the check if a protector is intact with the recording of the dependency on it, at least in many cases. Also introduce convenience functions to avoid the heap broker clutter. Change-Id: I35508c4685a2f0df77819bf81075dd14a30e7e4f Reviewed-on: https://chromium-review.googlesource.com/c/1487491 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#59924}
-
Georg Neis authored
This was an oversight in my previous CL. Bug: chromium:936077, v8:7790 Change-Id: Ic1034c1754d10c72df8f61d1e2c34333e1565e3e Reviewed-on: https://chromium-review.googlesource.com/c/1491222Reviewed-by:
-
Junliang Yan authored
Port f70bb59b Original Commit Message: Includes various fixes and cleanups here and there. R=ishell@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, miladfar@ca.ibm.com LOG=N Bug: v8:7703, v8:8852 Change-Id: I1e25c6da6677aab64dabc052aee555f534386df7 Reviewed-on: https://chromium-review.googlesource.com/c/1491698Reviewed-by:
-
Irina Yatsenko authored
Creates Torque classes for JSProxy, JSAccessorPropertyDescriptor, JSCollection, JSProxyRevocableResult, JSValue Change-Id: I01eec27b158b4beb778cb5efce44f241c09ef0f7 Reviewed-on: https://chromium-review.googlesource.com/c/1489184 Commit-Queue: Irina Yatsenko <irinayat@microsoft.com> Reviewed-by:
-
Sathya Gunasekaran authored
This will allow the devtools UI to display private fields on the scope panel. Instead of extending GetInternalProperties, we expose a separate GetPrivateFields method on the debug interface. This allows us to do better type checking, for example, we can directly cast to a v8::Private as this can only contain private fields. This also allows us to have better constraints on the input type -- v8::Object, as opposed to a v8::Value. The KeyAccumulator is extended to collect private names for the PRIVATE_NAMES_ONLY PropertyFilter. Bug: v8:8773 Change-Id: Id47c551186c59dae9a06721074ef78144f25892f Reviewed-on: https://chromium-review.googlesource.com/c/1475664 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Daniel Ehrenberg <littledan@chromium.org> Cr-Commit-Position: refs/heads/master@{#59920}
-
Sven Sauleau authored
WebAssembly's specification tests use a timeout annotation. This change allows the shared testrunner to use it to calculate the testcase timeout. Currently, the allowed timeout values are: long. Other values will emit a warning. Change-Id: Id7f453f5fd49854c8f53ff86ef2ec58aa0ae8748 Reviewed-on: https://chromium-review.googlesource.com/c/1480376Reviewed-by:
-
