- 14 Nov, 2016 24 commits
-
-
caitp authored
Adds a protector cell to prevent inlining (which will likely lead to deopt loops) when a JSArrayIterator's array transitions from a fast JSArray to a slow JSArray (such as, when the array is touched during iteration in a way which triggers a map transition). Also adds TODO comments relating to the spec update proposed by Dan at https://github.com/tc39/ecma262/pull/724 BUG=v8:5388 R=bmeurer@chromium.org, mstarzinger@chromium.org TBR=hpayer@chromium.org, ulan@chromium.org Review-Url: https://codereview.chromium.org/2484003002 Cr-Commit-Position: refs/heads/master@{#40970}
-
cbruni authored
BUG= Review-Url: https://codereview.chromium.org/2431133003 Cr-Commit-Position: refs/heads/master@{#40969}
-
jgruber authored
BUG=v8:5619,chromium:664490 Review-Url: https://codereview.chromium.org/2503463002 Cr-Commit-Position: refs/heads/master@{#40968}
-
leszeks authored
Using indices rather than pointers to probe the hashmap lets us unconditionally mask the index to ensure it wraps around, rather than branching on the pointer value. This produces slightly more optimal code. Review-Url: https://codereview.chromium.org/2488423003 Cr-Commit-Position: refs/heads/master@{#40967}
-
neis authored
R=jgruber@chromium.org BUG= Review-Url: https://codereview.chromium.org/2493533003 Cr-Commit-Position: refs/heads/master@{#40966}
-
rmcilroy authored
This removes the POSSIBLY_EVAL_CALL call type, and instead uses OTHER_CALL or WITH_CALL to decide whether to do the special LOOKUP_SLOT_CALL runtime call to find the callee and possibly update the receiver with the with-object. This means that eval calls out of 'with' blocks can now just do a normal LdaLookupGlobalSlot operation, which can check the context chain for eval extentions and fast-path the lookup if none exist. BUG=661556 Review-Url: https://codereview.chromium.org/2487483004 Cr-Commit-Position: refs/heads/master@{#40965}
-
neis authored
Revert of [ast] Simplify FetchFreeVariables. (patchset #1 id:1 of https://codereview.chromium.org/2491373004/ ) Reason for revert: It's probably needed after all but we're lacking tests. Original issue's description: > [ast] Simplify FetchFreeVariables. > > This CL removes the ParseInfo argument from FetchFreeVariables, since it seems > to have become unnecessary. > > R=verwaest@chromium.org > BUG= TBR=verwaest@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Review-Url: https://codereview.chromium.org/2495293002 Cr-Commit-Position: refs/heads/master@{#40964}
-
mstarzinger authored
This fixes the bogus {Word32Equal} comparison in the ToString builtin implementing Object.prototype.toString to be a pointer-size {WordEqual} comparison instead. Comparing just the lower half-word is insufficient on 64-bit architectures. R=jgruber@chromium.org TEST=mjsunit/regress/regress-crbug-664506 BUG=chromium:664506 Review-Url: https://codereview.chromium.org/2496043003 Cr-Commit-Position: refs/heads/master@{#40963}
-
verwaest authored
This replaces LOOKUP_SLOT_CALL with WITH_CALL, and relies on regular lookup-slot handling in variable load to support other lookup slots (variables resolved in the context of sloppy eval). This allows optimizations for such variable loads to kick in for calls as well. We only need special handling for function calls in the context of with, since it changes the receiver of the call from undefined/global to the with-object. This currently doesn't yet make it work for the direct eval call itself, since the POSSIBLY_EVAL_CALL flag is also used to deal with direct eval later. BUG= Review-Url: https://codereview.chromium.org/2480253006 Cr-Commit-Position: refs/heads/master@{#40962}
-
jarin authored
Revert of [turbofan] Fix deoptimization of boolean bit constants. (patchset #1 id:1 of https://codereview.chromium.org/2495243002/ ) Reason for revert: Seems to break GC stress. Original issue's description: > [turbofan] Fix deoptimization of boolean bit constants. > > BUG=chromium:664490 TBR=bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:664490 Review-Url: https://codereview.chromium.org/2502613002 Cr-Commit-Position: refs/heads/master@{#40961}
-
bmeurer authored
When constant-folding S[K], make sure to return a String, and not the character code as Number. BUG=chromium:664942 R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2503433002 Cr-Commit-Position: refs/heads/master@{#40960}
-
bmeurer authored
Revert of MIPS: Optimize load/store with large offset (patchset #1 id:1 of https://codereview.chromium.org/2486283003/ ) Reason for revert: Breaks CQ trybots now, i.e. https://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel/builds/24703/steps/compile%20with%20ninja/logs/stdio Original issue's description: > MIPS: Optimize load/store with large offset > > Currently, we are using the following sequence for load/store with large offset (offset > 16b): > > lui at, 0x1234 > ori at, at, 0x5678 > add at, s0, at > lw a0, 0(at) > > This sequence can be optimized in the following way: > > lui at, 0x1234 > add at, s0, at > lw a0, 0x5678(at) > > BUG= TBR=ivica.bogosavljevic@imgtec.com,miran.karic@imgtec.com,v8-mips-ports@googlegroups.com,dusan.simicic@imgtec.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2500863003 Cr-Commit-Position: refs/heads/master@{#40959}
-
ulan authored
BUG=v8:5614 Review-Url: https://codereview.chromium.org/2493193002 Cr-Commit-Position: refs/heads/master@{#40958}
-
jarin authored
This helps if the polymorhpic case has other maps with fast accesses. In box2d (with high number of iterations and warm-up), we spend about 2.7% of running time in StoreIC; after this change it is only 0.2%. Review-Url: https://codereview.chromium.org/2494673002 Cr-Commit-Position: refs/heads/master@{#40957}
-
yangguo authored
We are removing use of the debugger context. When the debugger triggers compilation, we may not have a context from which to create a JSArray. R=ishell@chromium.org BUG=chromium:664577 Review-Url: https://codereview.chromium.org/2479123002 Cr-Commit-Position: refs/heads/master@{#40956}
-
Miran.Karic authored
In component build, unittests did not link with icu libraries, which caused errors. By adding icu libraries to dependencies unittests links correctly. BUG= TEST=unittests/* Review-Url: https://codereview.chromium.org/2479863002 Cr-Commit-Position: refs/heads/master@{#40955}
-
yangguo authored
R=mstarzinger@chromium.org Review-Url: https://codereview.chromium.org/2497213002 Cr-Commit-Position: refs/heads/master@{#40954}
-
dusan.simicic authored
Currently, we are using the following sequence for load/store with large offset (offset > 16b): lui at, 0x1234 ori at, at, 0x5678 add at, s0, at lw a0, 0(at) This sequence can be optimized in the following way: lui at, 0x1234 add at, s0, at lw a0, 0x5678(at) BUG= Review-Url: https://codereview.chromium.org/2486283003 Cr-Commit-Position: refs/heads/master@{#40953}
-
ahaas authored
R=mlippautz@chromium.org Review-Url: https://codereview.chromium.org/2498633002 Cr-Commit-Position: refs/heads/master@{#40952}
-
jarin authored
BUG=chromium:664490 Review-Url: https://codereview.chromium.org/2495243002 Cr-Commit-Position: refs/heads/master@{#40951}
-
verwaest authored
BUG=chromium:664411 Review-Url: https://codereview.chromium.org/2498963002 Cr-Commit-Position: refs/heads/master@{#40950}
-
yangguo authored
Changes include: - Adding V8_EXPORT macro for SnapshotCreator - Removing outdated DCHECKs. - Allow nullptr as external reference. This required a... - Refactoring of hashmaps used by the serializer. - Remove external references for counters. These are not used anywhere for isolates that are being serialized. - Put template infos into the partial snapshot cache. - Remove unnecessary presubmit check for external references. mksnapshot crashes if external references are missing. R=jochen@chromium.org, vogelheim@chromium.org BUG=chromium:617892 Review-Url: https://codereview.chromium.org/2490783004 Cr-Commit-Position: refs/heads/master@{#40949}
-
bjaideep authored
TestBit sets cr0 therefore need to pass that to the branch instruction. This got exposed with testcase added in CL https://codereview.chromium.org/2497573003/ R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2495853003 Cr-Commit-Position: refs/heads/master@{#40948}
-
bjaideep authored
Port 1915762c Original commit message: These JavaScript operators were special hacks to ensure that we always operate on Smis for the magic for-in index variable, but this never really worked in the OSR case, because the OsrValue for the index variable didn't have the proper information (that we have for the JSForInPrepare in the non-OSR case). Now that we have loop induction variable analysis and binary operation hints, we can just use JSLessThan and JSAdd instead with appropriate Smi hints, which handle the OSR case by inserting Smi checks (that are always true). Thanks to OSR deconstruction and loop peeling these Smi checks will be hoisted so they don't hurt the OSR case too much. Drive-by-change: Rename the ForInDone bytecode to ForInContinue, since we have to lower it to JSLessThan to get the loop induction variable goodness. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2502503002 Cr-Commit-Position: refs/heads/master@{#40947}
-
- 13 Nov, 2016 2 commits
-
-
ishell authored
BUG=v8:5561 Review-Url: https://codereview.chromium.org/2488673004 Cr-Commit-Position: refs/heads/master@{#40946}
-
jbroman authored
Several weeks have now passed since it was deprecated; Chromium does not call it. BUG=chromium:148757 Review-Url: https://codereview.chromium.org/2478863002 Cr-Commit-Position: refs/heads/master@{#40945}
-
- 12 Nov, 2016 2 commits
-
-
jochen authored
That way we don't have to update the perf tests whenever the exact configuration changes. R=mvstanton@chromium.org,hablich@chromium.org,danno@chromium.org BUG= Review-Url: https://codereview.chromium.org/2420053002 Cr-Commit-Position: refs/heads/master@{#40944}
-
jbroman authored
BUG=chromium:148757 Review-Url: https://codereview.chromium.org/2492943002 Cr-Commit-Position: refs/heads/master@{#40943}
-
- 11 Nov, 2016 12 commits
-
-
jwolfe authored
BUG=v8:5051 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2484223004 Cr-Commit-Position: refs/heads/master@{#40942}
-
gsathya authored
- Creates a new promise-utils.{h, cc} which refactors out the logic to create resolving functions. This is shared between the runtime functions and builtins. - Changes PromiseResolveThenableJobInfo to store the context since we no longer create the resolving functions in JS. - Changes EnqueuPromiseResolveThenableJob to take in the promise and not the callbacks. BUG=v8:5343 Review-Url: https://codereview.chromium.org/2487053002 Cr-Commit-Position: refs/heads/master@{#40941}
-
ynovikov authored
Review-Url: https://codereview.chromium.org/2491373003 Cr-Commit-Position: refs/heads/master@{#40940}
-
bbudge authored
- Adds VmovExtended, VswpExtended methods to MacroAssembler. These methods use only VFP registers to perform s-register moves. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2497483002 Cr-Commit-Position: refs/heads/master@{#40939}
-
yangguo authored
Review-Url: https://codereview.chromium.org/2494993002 Cr-Commit-Position: refs/heads/master@{#40938}
-
leszeks authored
Previous: https://codereview.chromium.org/2491773006 BUG=v8:5512 Review-Url: https://codereview.chromium.org/2498643002 Cr-Commit-Position: refs/heads/master@{#40937}
-
yangguo authored
GetSharedFunctionInfo will compile inner functions if we get the compile-eager hint, even if the shared function info already exists, and the function already has been compiled. This breaks suspended generator objects. R=mstarzinger@chromium.org, neis@chromium.org BUG=v8:5575 Review-Url: https://codereview.chromium.org/2494043002 Cr-Commit-Position: refs/heads/master@{#40936}
-
mlippautz authored
BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2493803002 Cr-Commit-Position: refs/heads/master@{#40935}
-
yangguo authored
R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2492713005 Cr-Commit-Position: refs/heads/master@{#40934}
-
neis authored
This CL removes the ParseInfo argument from FetchFreeVariables, since it seems to have become unnecessary. R=verwaest@chromium.org BUG= Review-Url: https://codereview.chromium.org/2491373004 Cr-Commit-Position: refs/heads/master@{#40933}
-
verwaest authored
Methods in the runtime that enumerate over properties should never deal with private symbols. Most commonly such methods only loop over enumerable properties. This fix avoids accidentally handling private symbols in methods that only deal with enumerable properties. Methods that need to look at non-enumerable properties as well still have to manually filter private symbols (e.g., the KeyAccumulator). BUG=chromium:664411 Review-Url: https://codereview.chromium.org/2499593002 Cr-Commit-Position: refs/heads/master@{#40932}
-
ulan authored
BUG=v8:5614 Review-Url: https://codereview.chromium.org/2496913002 Cr-Commit-Position: refs/heads/master@{#40931}
-