- 16 Aug, 2017 4 commits
-
-
Georg Neis authored
Allowing GetModuleNamespace on a not-yet-evaluated module does not make a lot of sense because accessing the namespace object before evaluation can lead to surprising behavior. R=adamk@chromium.org Bug: v8:1569 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I3e3feb344f6399bf92b3dabc97c571a61b38bd41 Reviewed-on: https://chromium-review.googlesource.com/613268Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#47365}
-
Yang Guo authored
This removes: - CodeBreakIterator for FCG code. - RelocModes for debug breaks. - Code generator for debug break slots. - GC support for debug break slots. - Code flag to indicate code with debug break slots. - Builtin type DBG. - Mechanisms to replace FCG code in the debugger and LiveEdit. - Runtime entry to the debugger from debug break slots. R=bmeurer@chromium.org, rmcilroy@chromium.org, ulan@chromium.org Bug: v8:6409 Change-Id: I5662c8800e3ef1b1584ad107bfe0aae26c9d8abb Reviewed-on: https://chromium-review.googlesource.com/613263Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#47364}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2fe6f54..179cd37 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/ceb0504..f90f6a5 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/2ebc30b..b153f21 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/98218d1..08cb956 TBR=machenbach@chromium.org,hablich@chromium.org Change-Id: Ia5af304723428636c982e1c1e675f63e7c467dbb Reviewed-on: https://chromium-review.googlesource.com/616447Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#47363}
-
Jaideep Bajwa authored
On 64bit BE, build fails with error "error: left shift count >= width of type" casting the variable to uintptr_t which will set the size correctly. R=predrag.rudic@imgtec.com, jkummerow@chromium.org, ivica.bogosavljevic@imgtec.com, hablich@chromium.org LOG=N Bug: Change-Id: I8e466bd2c17b9976171ffd88725dce548153108e Reviewed-on: https://chromium-review.googlesource.com/616010Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jaideep Bajwa <bjaideep@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#47362}
-
- 15 Aug, 2017 8 commits
-
-
Tom Anderson authored
BUG=v8:6565 R=machenbach@chromium.org Change-Id: I2bd9b65fd7f991899e365354e262e62e78d1e852 Reviewed-on: https://chromium-review.googlesource.com/568679Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#47361}
-
Jaideep Bajwa authored
Port 4b397e6c Original Commit Message: The way we access wasm addresses or sizes is the same, on a platform. We have 2 size parameters - memory and table - and 2 addresses - globals and memory. The CL also renames for generality the address setting API. R=mtrofin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ic6c398e0eeb6c9344aca3f92223d8b99a9e518ef Reviewed-on: https://chromium-review.googlesource.com/615012Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Jaideep Bajwa <bjaideep@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#47360}
-
Martyn Capewell authored
Small improvements to code generated on arm and arm64. Bug: v8:6644 Change-Id: Id3d9be87f6a071e949985a1b6b62a43d9195a104 Reviewed-on: https://chromium-review.googlesource.com/615300Reviewed-by:
-
Alexandre Talon authored
Simple typo fixed. Bug: Change-Id: I958e384490db02008765408bc825345d350586b2 Reviewed-on: https://chromium-review.googlesource.com/614340Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Alexandre Talon <alexandret@google.com> Cr-Commit-Position: refs/heads/master@{#47358}
-
Martyn Capewell authored
No longer needed. Bug: v8:6409 Change-Id: Iea0afcb7ced24d10223db5e01f66813e97fc4134 Reviewed-on: https://chromium-review.googlesource.com/613761 Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Reviewed-by:
-
Predrag Rudic authored
This CL doesn't add static initializer Fix d4c157ee commit On big endian platforms wrong byte is initialized for "parameter_count" field of the union. Bug: Change-Id: I1c4b1d7f5fb3bd29077fdaa158560c380fba1875 Reviewed-on: https://chromium-review.googlesource.com/613266Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/876f9d1..2fe6f54 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/f4bcb07..ceb0504 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/5db5135..2ebc30b TBR=machenbach@chromium.org,hablich@chromium.org Change-Id: I728e0948c9af65fab07a79b6c415dde5f08e6681 Reviewed-on: https://chromium-review.googlesource.com/615140Reviewed-by:
-
Alexey Kozyatinskiy authored
This one allows us to support custom promises implementation. With awaitPromise flag Runtime.evaluate awaits Promise.resolve(<expression result>). This also allows to await for any non-Promise value, similar to await expression, which is more convenient for most protocol users. R=dgozman@chromium.org Bug: chromium:755104 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iee798b33b6fb7de7d393372e164c0481d1bbf7eb Reviewed-on: https://chromium-review.googlesource.com/614308 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#47354}
-
- 14 Aug, 2017 26 commits
-
-
Deepti Gandluri authored
Tests were monolithic, with large loops, and slow on ARM64. Refactor to small tests so they can be sharded better, reduce page size to 1 to keep the loops small. BUG=v8:6532 Change-Id: I712551564d4a70fc12acdf114922feb614aeb271 Reviewed-on: https://chromium-review.googlesource.com/611614Reviewed-by:
Ben Smith <binji@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#47353}
-
Sathya Gunasekaran authored
In the case of a function constructor or eval, we create a new script object which doesn't have a script name. In this case, we traverse upwards on the list of SFI's through script->eval_from_shared() to get the outermost script that was not an eval script and get the script name from that script. Bug: chromium:746909, v8:6683, v8:5785 Change-Id: I430459f632a0e3b18fc3111a5cf1c00cedb9f520 Reviewed-on: https://chromium-review.googlesource.com/606701 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#47352}
-
Ali Ijaz Sheikh authored
Bug: Change-Id: I5698f846e72e4f86b392a0c745a9f4793c7f4f25 Reviewed-on: https://chromium-review.googlesource.com/608584Reviewed-by:
-
Mircea Trofin authored
The way we access wasm addresses or sizes is the same, on a platform. We have 2 size parameters - memory and table - and 2 addresses - globals and memory. The CL also renames for generality the address setting API. Bug: Change-Id: Ib66c3aff6a0ab4313391528cd2692749bb389559 Reviewed-on: https://chromium-review.googlesource.com/612597 Commit-Queue: Brad Nelson <bradnelson@chromium.org> Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#47350}
-
Adam Klein authored
Change-Id: I612b7500556eb9763d6668716b1b7331e31f3079 Reviewed-on: https://chromium-review.googlesource.com/614399Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#47349}
-
Sampson Gao authored
R=bjaideep@ca.ibm.com, jyan@ca.ibm.com, joransiu@ca.ibm.com Bug: Change-Id: I80bbb38800c9c43e95045f5db5b63894a5a0711a Reviewed-on: https://chromium-review.googlesource.com/614113Reviewed-by:
Jaideep Bajwa <bjaideep@ca.ibm.com> Commit-Queue: Jaideep Bajwa <bjaideep@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#47348}
-
Mostyn Bramley-Moore authored
* Avoid "using namespace" statements, which trigger clang's -Wheader-hygiene warnings in jumbo builds. * Undefine created macros at the end of source files. BUG=chromium:746958 Change-Id: I5d25432c314437f607b0e1be22765a6764267ba6 Reviewed-on: https://chromium-review.googlesource.com/610962Reviewed-by:
-
Karl Schimpf authored
Fixes the implementation of wasm exceptions to use a WasmRuntimeError object, and set the exception tag value as a property of the object. This guarantees that an uncaught wasm exception is treated like all other runtime errors. Bug: v8:6577 Change-Id: I0ab0130444e745178e86c23b3bc9fc9f385c8d05 Reviewed-on: https://chromium-review.googlesource.com/611124Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Eric Holk <eholk@chromium.org> Commit-Queue: Karl Schimpf <kschimpf@chromium.org> Cr-Commit-Position: refs/heads/master@{#47346}
-
Franziska Hinkelmann authored
Add benchmark for TypedArray.prototype.set from a regular array. Bug: v8:6704 Change-Id: I350960dec530c06e7cad62eec1f977d8fda97347 Reviewed-on: https://chromium-review.googlesource.com/613163Reviewed-by:
-
Jaideep Bajwa authored
Port c820b89b Original Commit Message: Removes the new.target slot from the interpreter's fixed frame. Instead adds a field to BytecodeArray to get the bytecode's incoming new.target or generator object register. The InterpreterEntryTrampoline then sets this register with the incoming new.target (or generator object) when the function is called. This register can be directly the new.target or generator object variable if they are LOCAL location, otherwise it is a temporary register which is then moved to the variable's location during the function prologue. This fixes a hack in the deoptimizer where we would set the new.target fixed slot to undefined in order to avoid extending it's lifetime through the optimized code - now it's just a standard register and can be optimized away as normal. R=rmcilroy@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ifb93179153016ad989c6ae3675554e70c426e2fa Reviewed-on: https://chromium-review.googlesource.com/612746Reviewed-by:
-
Franziska Hinkelmann authored
Add a benchmark for TypedArray.prototype.set when setting from another TypedArray with a different type. Bug: v8:6704 Change-Id: Iad5585fe7d3a28b5b1a1b1f85ec81be659959239 Reviewed-on: https://chromium-review.googlesource.com/613267 Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Reviewed-by:
-
Franziska Hinkelmann authored
Add benchmark for TypedArray.prototype.set when setting from another TypedArray with the same type. Bug: v8:6704 Change-Id: Ibde60b17aa32fb9c8237b2ab766d2b2913e256d7 Reviewed-on: https://chromium-review.googlesource.com/613264Reviewed-by:
-
Georg Neis authored
R=jarin@chromium.org Bug: Change-Id: I97c2d73ea4ac83802421be85da327e214939d5a1 Reviewed-on: https://chromium-review.googlesource.com/610006Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#47341}
-
Yang Guo authored
R=petermarshall@chromium.org Bug: v8:6687 Change-Id: Ic447a6cd5cb8a7a251b4820fc82f1f1d033be355 Reviewed-on: https://chromium-review.googlesource.com/612067Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#47340}
-
Martyn Capewell authored
Delete StringCharCodeAtGenerator, as it's no longer used. Bug: Change-Id: I05294fac69671c0652742d120de9ea17e9031518 Reviewed-on: https://chromium-review.googlesource.com/613164Reviewed-by:
-
Michael Achenbach authored
The V8 mac asan bots correspond to "Mac ASAN Release" and "Mac ASAN Debug" from chromium.lkgr waterfall. Depends on infra side: https://chromium-review.googlesource.com/c/613162 TBR=yangguo@chromium.org NOTRY=true Bug: chromium:726584 Change-Id: Ic71e3577485131b260801eef9e801ab19ed093c1 Reviewed-on: https://chromium-review.googlesource.com/613480Reviewed-by:
-
Ross McIlroy authored
Splits CompileUnoptimizedCode into a non-main thread GenerateUnoptimizedCode and a main thread FinalizeUnoptimizedCode phase. Adds Disallow<HeapAccess> scopes in CompileUnoptimizedCode to ensure no access to the heap during this phase. Also cleans up a few heap accesses in CompilationInfo's constructor to avoid violating the disallowed heap access. Currently we reallow heap access during asm.js compilation as a temporary measure until the script streamer uses an off-heap script buffer. BUG=v8:5203 TBR=titzer@chromium.org Change-Id: I7f6140f19938a10a85f1cd89501812dd59dbf6d4 Reviewed-on: https://chromium-review.googlesource.com/605949 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#47337}
-
Ulan Degenbaev authored
This follows up 4af9cfcc by separating incremental marking state from the full MC marking state. Runtime and tests now use only the incremental marking state. The full MC marking state used by MC during atomic pause. This separation decouples atomicity of markbit accesses during incremental marking and during full MC. Bug: chromium:694255 TBR: mlippautz@chromium.org Change-Id: Ia409ab06515cd0d1403a272a016633295c0d6692 Reviewed-on: https://chromium-review.googlesource.com/612350 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Michael Achenbach authored
Depends on infra change: https://chromium-review.googlesource.com/c/612079 This emulates the same GN configurations as from the builders "UBSan Release" and "UBSan vptr Release" on the chromium.lkgr waterfall. NOTRY=true TBR=yangguo@chromium.org Bug: chromium:726584 Change-Id: I248765f7f8353351da2a4d5b897b06cbc04ba007 Reviewed-on: https://chromium-review.googlesource.com/612982Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
The function shouldn't try to start black allocation if it is already started. Bug: chromium:694255 TBR: mlippautz@chromium.org Change-Id: I77b5346f6ac2ec5947ca4351a8abe33865729fda Reviewed-on: https://chromium-review.googlesource.com/612385Reviewed-by:
-
Ulan Degenbaev authored
Bug: chromium:694255 TBR: mlippautz@chromium.org Change-Id: I207fd28c2e19637f45da3735284c8ca223b33481 Reviewed-on: https://chromium-review.googlesource.com/610562Reviewed-by:
-
Michael Achenbach authored
This reverts commit 01cae9ef. Reason for revert: Seeing several flaky crashes on windows associated to this change: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20debug/builds/18407 https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20debug/builds/18408 Original change's description: > [Memory] Improve OOM callback tests. > > - Changes OOM tests to keep allocating more and more, starting from a > large amount, until we exhaust address space and get a failure. > > Bug: v8:6635 > Change-Id: I007927c5f639ed395d90198272c93b6ee0e58249 > Reviewed-on: https://chromium-review.googlesource.com/609264 > Commit-Queue: Bill Budge <bbudge@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#47328} TBR=bbudge@chromium.org,mlippautz@chromium.org Change-Id: Ibe49f99040e1a3c595ed836d1d40dbd0c7247d1c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6635 Reviewed-on: https://chromium-review.googlesource.com/612288Reviewed-by:
-
Michael Achenbach authored
This reverts commit 0d14ad57. Reason for revert: Seems to add a static initializer: https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/19779 Original change's description: > [builtins] Fix union initialization > > Fix d4c157ee commit > > On big endian platforms wrong byte is being read when accessing > "parameter_count" field of union, in function > failing on MIPS big endian platforms. > > Builtins: :GetStackParameterCount. It is the reason of several tests > Bug: > Change-Id: Ia21aba80a89215022ee218d27552b5b4ea18a0db > Reviewed-on: https://chromium-review.googlesource.com/603808 > Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@imgtec.com> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#47330} TBR=jkummerow@chromium.org,jarin@chromium.org,jgruber@chromium.org,predrag.rudic@imgtec.com,ivica.bogosavljevic@imgtec.com Change-Id: I596bb1a04c72c8f5cb4f7b4a8e9161bd5889683d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/612287Reviewed-by:
-
Predrag Rudic authored
Fix d4c157ee commit On big endian platforms wrong byte is being read when accessing "parameter_count" field of union, in function failing on MIPS big endian platforms. Builtins: :GetStackParameterCount. It is the reason of several tests Bug: Change-Id: Ia21aba80a89215022ee218d27552b5b4ea18a0db Reviewed-on: https://chromium-review.googlesource.com/603808 Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@imgtec.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#47330}
-
v8-autoroll authored
Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/a1420b8..5bad4f2 TBR=machenbach@chromium.org,hablich@chromium.org Change-Id: I7cf78bd76d7a5126194bfcb5538803de8e6ea601 Reviewed-on: https://chromium-review.googlesource.com/612852Reviewed-by:
-
Bill Budge authored
- Changes OOM tests to keep allocating more and more, starting from a large amount, until we exhaust address space and get a failure. Bug: v8:6635 Change-Id: I007927c5f639ed395d90198272c93b6ee0e58249 Reviewed-on: https://chromium-review.googlesource.com/609264 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#47328}
-
- 13 Aug, 2017 1 commit
-
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b810910..876f9d1 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/3be402c..a1420b8 TBR=machenbach@chromium.org,hablich@chromium.org Change-Id: I798d723b736faa1eff4cd50f34e7af9bc3f36a26 Reviewed-on: https://chromium-review.googlesource.com/612842Reviewed-by:
-
- 12 Aug, 2017 1 commit
-
-
Marja Hölttä authored
- See bug for the reduced test case. - Not adding a regression test here: I don't want to assert that PreParser doesn't detect the redeclaration error, OTOH I don't want to make it detect the error either (in order to not couple detecting the error with FLAG_experimental_preparser_analysis). BUG=chromium:753896, v8:5516 Change-Id: I0f1beffe30e5cb48d6dbec35181980864e6df153 Reviewed-on: https://chromium-review.googlesource.com/608976Reviewed-by:
-
