- 30 Apr, 2019 25 commits
-
-
Ross McIlroy authored
BUG=v8:8801 Change-Id: I20e1b343f33293a5de3a8953650a26852126533a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588466 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#61127}
-
Mythri A authored
TraceIC always expects a valid feedback vector to check for state transitions. With lazy feedback allocations, it is possible that we don't have feedback vectors. This cl fixes TraceIC to also work when there is no feedback vector. Bug: v8:8394 Change-Id: If7e40a9f16de7415e04a812440ccc0cfcf1cbc07 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1584322Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#61126}
-
Ulan Degenbaev authored
This simplifies the marking write barrier for elements to mark the values instead of revisiting the array. Bug: chromium:918485 Change-Id: Id5da0d5b9ff8385a256fe14f4bf7171f9f6343e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588459 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#61125}
-
Frederik Gossen authored
Remove unused function {UseLazyStubs}. Lazy compile stubs are now set on a per function basis. This made the function {UseLazyStubs} redundant. Change-Id: I8e715d6a9774c39841219c04c42364fc2e964569 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588473 Commit-Queue: Frederik Gossen <frgossen@google.com> Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61124}
-
Milad Farazmand authored
Port ed319e84 Original Commit Message: Failure addressed by not exposing the new test to the jitless environment. (jgruber@ on TBR). New enum RelocInfo::COMPRESSED_EMBEDDED_OBJECT created to support compressed pointers in generated code. Enum name EMBEDDED_OBJECT changed to FULL_EMBEDDED_OBJECT. RelocInfo::[set_]target_object() abstract away the difference between FULL_EMBEDDED_OBJECT and COMPRESSED_EMBEDDED_OBJECT. Compressed embedded objects can only be created at this time on x64 with pointer compression turned on. Arm64 constant pools don't support compressed objects at this time. R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I8bdb5391fd2b2565d2fcaf6c806fcdbe1a1f27b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1589862Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#61123}
-
Mythri A authored
With bytecode flushing and lazy feedback allocation, we need to call %PrepareForOptimization before we call %OptimizeFunctionOnNextCall Bug: v8:8801, v8:8394 Change-Id: I81918f174b2f97cbaa8b8ef2e459080c2581f535 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588415 Commit-Queue: Mythri Alle <mythria@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#61122}
-
Jakob Gruber authored
Relative code targets are emitted as pc-relative jumps. The relocation delta must be subtracted (not added) from the branch offset. Before GC: |-------- branch offset --->| [host code object] [target code object] After GC: |- delta ->| |- new offset -->| [host code object] [target code object] See also the similar fix for mips in https://crrev.com/c/1581239. Bug: v8:6666 Change-Id: Ie0867d98906d4a8daa7e335884f7a4d814333872 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581260Reviewed-by:Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#61121}
-
Yu Yin authored
Fix several small compile problems which causes by https://crrev.com/c/1585737. Change-Id: I78a07d597db9d81d4a99aac08e257f380be8f7e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1589202Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Yu Yin <xwafish@gmail.com> Cr-Commit-Position: refs/heads/master@{#61120}
-
Michael Starzinger authored
Change-Id: Ifbf1b49d7caad9b050945b07065ee5ecb9d9f9e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588470Reviewed-by:
-
Sigurd Schneider authored
This reverts commit 9284ad57. Reason for revert: breaks blink tests: https://ci.chromium.org/p/v8/builders/ci/V8-Blink%20Win/16839 Original change's description: > [turbofan] Avoid raw InferReceiverMaps in JSCallReducer > > Instead provide an abstraction that makes it hard to forget > dealing with unreliable maps. > > This also fixes a deopt loop in Function.prototype.bind and > one in Array.prototype.reduce. > > Bug: v8:9137 > Change-Id: If6a51182c8693a62e9fb6d302cec19b4d48e25cb > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578501 > Commit-Queue: Georg Neis <neis@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61106} TBR=jarin@chromium.org,neis@chromium.org Change-Id: I97e0f47fb82eda76656905a3f7cc494babd92be6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9137 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588433Reviewed-by:
-
Sigurd Schneider authored
We enable this feature to collect performance data; revert at will. Bug: v8:9088 Change-Id: I57cd79707fe56ec5a2d6d5ee65b7ce24bda57773 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1585726 Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#61117}
-
Frederik Gossen authored
Treat lazy functions the same no matter whether they are lazy due to compilation hints or flags ({--wasm-lazy-compilation}, {--asm-wasm-lazy-compilation}). Test coverage is given by regression tests 956771 and 956771b. Bug: v8:9003 Change-Id: I123f83636f055fb142cd71f6cde88480f3c141bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1585846 Commit-Queue: Frederik Gossen <frgossen@google.com> Reviewed-by: -
Jaroslav Sevcik authored
This just adds the same case we already added in https://chromium-review.googlesource.com/c/v8/v8/+/1478192 for conversions to tagged representation. Bug: chromium:957559 Change-Id: I62a388ba47bd72d65fa07d0141362d7f1383c96e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588428Reviewed-by:
-
Frederik Gossen authored
Fix recognition of lazy functions when {--wasm-lazy-compilation} is used. Bug: chromium:956771 Change-Id: I3f9bb25ccf3920a6c3d266876faace8841dcdc61 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1585843Reviewed-by: -
Sigurd Schneider authored
Bug: chromium:951322 Change-Id: Ibbc656c4a22adffc7d7df305541d4264a3b199ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1583760 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Andreas Haas authored
This CL refactors WasmTableObject::Grow to make it usable for the table.grow instruction of WebAssembly. The refactored version of WasmTableObject::Grow does additionally: * Check if growing is possible * Grow the FixedArray backing store of the table and initialize the new fields. * Calculate the return value of WasmTableObject::Grow. R=jkummerow@chromium.org Bug: v8:7581 Change-Id: Ic6c867b96c30bd987ea281d5b3515a04bc5a3900 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588136 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#61112}
-
Yang Guo authored
This reverts commit e632f8f4. Reason for revert: Seems to cause some timeouts to trigger failures: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/26129 Original change's description: > [test] Remove longer timeout on bots > > CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_linux_gc_stress_dbg > CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_linux_gcc_rel > CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_linux64_msan_rel > CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_linux64_tsan_rel > CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_linux_arm64_dbg > CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_mac64_asan_rel > CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_win64_dbg > CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_android_arm64_n5x_rel_ng > CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_linux64_cfi_rel_ng > CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_linux64_ubsan_rel_ng > CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_linux_arm_lite_rel_ng > CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_linux_noi18n_rel_ng > CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_mac64_dbg_ng > > Bug: v8:9145 > Change-Id: I6efee8579d9d9e0aad0431f6b87c152141d4ec7f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581261 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61107} TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I5e23aebc41e6ab15baa57093f7f056cdabd58f21 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9145 Cq-Include-Trybots: luci.v8.try:v8_linux_gc_stress_dbg, luci.v8.try:v8_linux_gcc_rel, luci.v8.try:v8_linux64_msan_rel, luci.v8.try:v8_linux64_tsan_rel, luci.v8.try:v8_linux_arm64_dbg, luci.v8.try:v8_mac64_asan_rel, luci.v8.try:v8_win64_dbg, luci.v8.try:v8_android_arm64_n5x_rel_ng, luci.v8.try:v8_linux64_cfi_rel_ng, luci.v8.try:v8_linux64_ubsan_rel_ng, luci.v8.try:v8_linux_arm_lite_rel_ng, luci.v8.try:v8_linux_noi18n_rel_ng, luci.v8.try:v8_mac64_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588425Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#61111}
-
Peng Fei authored
Change-Id: Ie44615daa6e0bef13a969cfb4fa62654ce31f448 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581239 Commit-Queue: peng fei <pfgenyun@gmail.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#61110}
-
Clemens Hammacher authored
Instead, use std::sort and std::stable_sort at the 3 (!) call sites directly. This also removes the weird comparer adaptors from Vector, which are only used in ZoneList. R=jkummerow@chromium.org Bug: v8:9183 Change-Id: I4d0377976fb0a965cb68a21d4307df9ba09fd55d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1587394Reviewed-by:
-
Mike Stanton authored
New RelocInfo test needs to adapt to the new pattern. Change-Id: I09e531d099541511f94b929de647a3e3510f748f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588465Reviewed-by:
-
Michael Achenbach authored
CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_linux_gc_stress_dbg CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_linux_gcc_rel CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_linux64_msan_rel CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_linux64_tsan_rel CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_linux_arm64_dbg CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_mac64_asan_rel CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_win64_dbg CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_android_arm64_n5x_rel_ng CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_linux64_cfi_rel_ng CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_linux64_ubsan_rel_ng CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_linux_arm_lite_rel_ng CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_linux_noi18n_rel_ng CQ_INCLUDE_TRYBOTS=luci.v8.try:v8_mac64_dbg_ng Bug: v8:9145 Change-Id: I6efee8579d9d9e0aad0431f6b87c152141d4ec7f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581261 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#61107}
-
Georg Neis authored
Instead provide an abstraction that makes it hard to forget dealing with unreliable maps. This also fixes a deopt loop in Function.prototype.bind and one in Array.prototype.reduce. Bug: v8:9137 Change-Id: If6a51182c8693a62e9fb6d302cec19b4d48e25cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578501 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Frederik Gossen authored
Ignore the error type in {assertThrows} only if it was not passed as an argument. If users do not care about the error type they can user the generic type {Error}. Before this change, an undefined error type would simply be ignored. A simple typo could therefore disable the error type assertion without being recognized. Change-Id: I9becfd0bf14dcaa511854e65ff94f94481cc79b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1585855 Commit-Queue: Frederik Gossen <frgossen@google.com> Reviewed-by:Mathias Bynens <mathias@chromium.org> Reviewed-by:
-
Mike Stanton authored
Failure addressed by not exposing the new test to the jitless environment. (jgruber@ on TBR). New enum RelocInfo::COMPRESSED_EMBEDDED_OBJECT created to support compressed pointers in generated code. Enum name EMBEDDED_OBJECT changed to FULL_EMBEDDED_OBJECT. RelocInfo::[set_]target_object() abstract away the difference between FULL_EMBEDDED_OBJECT and COMPRESSED_EMBEDDED_OBJECT. Compressed embedded objects can only be created at this time on x64 with pointer compression turned on. Arm64 constant pools don't support compressed objects at this time. NOPRESUBMIT=true Bug: v8:7703 TBR: jgruber@chromium.org Change-Id: Ifff53b041bab09b4b8c3e16085e5df4aa2b99f4f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588461Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c185a34..4087d63 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/d235eb2..5b26b37 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/6837707..e49aed3 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/396602c..210f1dc TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I7844de2802808ecbcc98c5ca80ebe8b0613b4395 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588730Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#61103}
-
- 29 Apr, 2019 15 commits
-
-
Milad Farazmand authored
Port 4b0f9c85 Original Commit Message: Our {Vector} template provides both {start} and {begin} methods. They return exactly the same value. Since the {begin} method is needed for iteration, and is also what standard containers provide, this CL switches all uses of the {start} method to use {begin} instead. Patchset 1 was auto-generated by using this clang AST matcher: callExpr( callee( cxxMethodDecl( hasName("start"), ofClass(hasName("v8::internal::Vector"))) ), argumentCountIs(0)) Patchset 2 was created by running clang-format. Patchset 3 then removes the now unused {Vector::start} method. R=clemensh@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I119532691af31a3db1107c47de8b6f0c84697b5c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588226Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#61102}
-
Jakob Kummerow authored
Similar issue as crbug.com/933103, so the fix follows the same pattern too. No regression test, because it will OOM anyway. Bug: chromium:957015 Change-Id: Ic5b67d84aa1c44609e6c96485974af9ecab2ed0e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1585854 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#61101}
-
Benedikt Meurer authored
This adds a new %_CopyDataProperties intrinsic, that reuses most of the existing machinery that we already have in place for Object.assign() and computed property names in object literals. This speeds up the general case for object spread (where the spread is not the first item in an object literal) and brings it on par with Object.assign() at least - in most cases it's significantly faster than Object.assign(). In the test case [1] referenced from the bug, the performance goes from objectSpreadLast: 3624 ms. objectAssignLast: 1938 ms. to objectSpreadLast: 646 ms. objectAssignLast: 1944 ms. which corresponds to a **5-6x performance boost**, making object spread faster than Object.assign() in general. Drive-by-fix: This refactors the Object.assign() fast-path in a way that it can be reused appropriately for object spread, and adds another new builtin SetDataProperties, which does the core of the Object.assign() work. We can teach TurboFan to inline Object.assign() based on the new SetDataProperties builtin at some later point to further optimize Object.assign(). [1]: https://gist.github.com/bmeurer/0dae4a6b0e23f43d5a22d7c91476b6c0 Bug: v8:9167 Change-Id: I57bea7a8781c4a1e8ff3d394873c3cd4c5d73834 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1587376Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#61100}
-
Suraj Sharma authored
Converted JSGlobalObject, JSIteratorResult, JSLocale, JSDateTimeFormat, JSListFormat, JSNumberFormat, JSPluralRules, JSRelativeTimeFormat, JSSegmenter, JSAsyncFromSyncIterator to torque. Bug: v8:8952 Change-Id: Id912197054727815b481b2c683b93473bfcbd0c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1574491Reviewed-by:
-
Maciej Goszczycki authored
It was once widely used throughout v8 but now there is no need for it anymore. Bug: v8:9183 Change-Id: Id766987d468383cf459414eb5edfdee71b83a60b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1585839 Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Reviewed-by:
-
Michael Lippautz authored
Change-Id: I55e8e42b88c8df1f75ff05f22b39d69e9dc586ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588457 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#61097}
-
Maciej Goszczycki authored
Switch all uses of NewCode and TryNewCode to CodeBuilder and remove these methods. NewCode and TryNewCode use a large number of default parameters, which makes it difficult to use and add any new ones. Large chunks of code were also duplicated across TryNewCode and NewCode. The previous CL (https://chromium-review.googlesource.com/c/v8/v8/+/1585736) added a new CodeBuilder class which allows much simpler building of Code objects. Bug: v8:9183 Change-Id: I9f6884f35a3284cbd40746376f0f27e36f9051b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1585737 Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Reviewed-by:
-
Sergiy Belozorov authored
This is needed to allow deriving timeout and near_timeout runnables on the recipe side and drop corresponding fields in the output. We also remove some unused code that was removed in previous refactoring CLs. R=tmrts@chromium.org No-Try: true No-Tree-Checks: true Bug: chromium:841700 Change-Id: Ib7cec9baceff994fb9b32be09ba4a4079ebff2c8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588417 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... to a separate file. Bug: v8:9183 Change-Id: I87f98ed0fec84eb32403c3447bec7be50a79261d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588095Reviewed-by:
-
Igor Sheludko authored
... where the other set of similar macros live. Bug: v8:9183 Change-Id: I114237a90c45205417b6d3fb0d939542c5c4fc76 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588096Reviewed-by:
-
Clemens Hammacher authored
The {Vector} class does not use it any more. External uses should be converted to {size_t} instead of {int}. This CL removes the function from vector.h and updates all users to either use {size_t}, or cast to {int} explicitly. In tests, no further checks are needed if the string is a constant. R=mstarzinger@chromium.org Bug: v8:9183 Change-Id: I60f99302504c74d8a7c79b147ca01d8ba61b6879 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1587393Reviewed-by: -
Igor Sheludko authored
1) HAS_[STRONG|WEAK]_HEAP_OBJECT_TAG macros are to be used for checking raw representations of tagged values (Address or Tagged_t) 2) HasWeakHeapObjectTag(Object) function is for overzealous checking of Object tags Bug: v8:9183 Tbr: jgruber@chromium.org Change-Id: Iaa456dbcb21f43a8df0d9ca706c0fc3b2ede075d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588455 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
See https://cs.chromium.org/chromium/src/v8/src/code-stub-assembler.h?l=244 for the implementation. Change-Id: I848e86aa69aaa9ceef9fff8b62ad947b0f67b781 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588235 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This makes the gc-stress bots set the '--stress-wasm-code-gc' flag. Note that this also implicitly enables wasm code gc on these bots. R=mstarzinger@chromium.org, machenbach@chromium.org Cq-Include-Trybots: luci.v8.try:v8_linux_gc_stress_dbg Cq-Include-Trybots: luci.v8.try:v8_mac64_gc_stress_dbg Bug: v8:8217 Change-Id: Idc4fb996f50632d5621200e138f3ddc572ed9b05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1585721 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#61089}
-
Georg Neis authored
Also const-ify and refactor a few things in BytecodeAnalysis. Change-Id: Ibd261bb67d8c035b1f818e9114d09db08737000d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1587384 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
