- 09 Sep, 2016 4 commits
-
-
bmeurer authored
For call sites where the target is not a known constant, but potentially a list of known constants (i.e. a Phi with all HeapConstant inputs), we still record the call site as a potential candidate for inlining. In case the heuristic picks that candidate for inlining, we expand the call site to a dispatched call site and invoke the actual inlining logic for all the nested call sites. Like Crankshaft, we currently allow up to 4 targets for polymorphic inlining, although we might want to refine that later. This approach is different from what Crankshaft does in that we don't duplicate the evaluation of the parameters per polymorphic case. Instead we first perform the load of the target (which usually dispatches based on the receiver map), then we evaluate all the parameters, and then we dispatch again based on the known targets. This might generate better or worse code compared to what Crankshaft does, and for the cases where we generate worse code (i.e. because we have only trivial parameters or no parameters at all), we might want to investigate optimizing away the double dispatch in the future. R=mvstanton@chromium.org BUG=v8:5267,v8:5365 Review-Url: https://codereview.chromium.org/2325943002 Cr-Commit-Position: refs/heads/master@{#39302}
-
machenbach authored
This is a work-around as v8_enable_i18n_support=false does currently not imply icu_use_data_file_flag=false. The swarming isolator then tries to find the data file also in builds without ICU. Making the implication is non-trivial as icu_use_data_file_flag lives in ICU and v8_enable_i18n_support lives in V8. BUG=chromium:474921 NOTRY=true TBR=petermarshall@chromium.org, vogelheim@chromium.org, jochen@chromium.org Review-Url: https://codereview.chromium.org/2321563007 Cr-Commit-Position: refs/heads/master@{#39301}
-
marja authored
BUG= Review-Url: https://codereview.chromium.org/2311903003 Cr-Commit-Position: refs/heads/master@{#39300}
-
zhengxing.li authored
port 9a31162d(r39283) original commit message: Adds support to collect allocation site feedback for Array function calls to the call bytecode handler. BUG= Review-Url: https://codereview.chromium.org/2319123004 Cr-Commit-Position: refs/heads/master@{#39299}
-
- 08 Sep, 2016 36 commits
-
-
bjaideep authored
Port 9a31162d Original commit message: Adds support to collect allocation site feedback for Array function calls to the call bytecode handler. R=mythria@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4280, v8:4780 LOG=N Review-Url: https://codereview.chromium.org/2319913004 Cr-Commit-Position: refs/heads/master@{#39298}
-
bgeron authored
BUG= Review-Url: https://codereview.chromium.org/2293483002 Cr-Commit-Position: refs/heads/master@{#39297}
-
jbroman authored
Without this cast, the integer type isn't promoted before being shifted, and so for types larger than sizeof(int) there is data loss. This will become an issue once the host begins using this helper to send 64-bit integers. BUG=chromium:148757 Review-Url: https://codereview.chromium.org/2326653002 Cr-Commit-Position: refs/heads/master@{#39296}
-
lpy authored
This patch adds runtime call stats tracing for GC correctly, makes --runtime-call-stats and tracing mutually exclusive with tracing taking precedence if both modes are on, and uses only one runtime call stats in counter. BUG=v8:5089 Review-Url: https://codereview.chromium.org/2313193002 Cr-Commit-Position: refs/heads/master@{#39295}
-
adamk authored
Before this change, the spread desugaring would naively call `%AppendElement($R, the_hole)` and in some cases $R would have a non-holey elements kind, putting the array into the bad state of exposing holes to author code. This patch avoids calling %AppendElement with a hole, instead simply incrementing $R.length when it sees a hole in the literal (this is safe because $R is known to be an Array). The existing logic for elements transitions takes care of giving the array a holey ElementsKind. BUG=chromium:644215 Review-Url: https://codereview.chromium.org/2321533003 Cr-Commit-Position: refs/heads/master@{#39294}
-
cbruni authored
This CL fixes %DebugPrint for FAST_HOLEY_DOUBLE_ELEMENTS and now properly distinguishes TheHole and NaN values. BUG= Review-Url: https://codereview.chromium.org/2294913004 Cr-Commit-Position: refs/heads/master@{#39293}
-
cbruni authored
Revert of [runtime] temporarily transform IsContext check from DHECK to CHECK (patchset #2 id:20001 of https://codereview.chromium.org/2164633002/ ) Reason for revert: There have been no more occurrences of this on dev / beta so we can convert the CHECK back to DCHECK. Original issue's description: > [runtime] temporarily transform IsContext check from DCHECK to CHECK > > We are enabling this trial on canary to see if we can flush out some missing > context restores. > > BUG= > > Committed: https://crrev.com/ec94ad400dc257af396efa3b1899bc3168347d82 > Cr-Commit-Position: refs/heads/master@{#37875} TBR=jkummerow@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Review-Url: https://codereview.chromium.org/2303543003 Cr-Commit-Position: refs/heads/master@{#39292}
-
caitp authored
BUG=v8:5363 R=adamk@chromium.org, littledan@chromium.org, cbruni@chromium.org Review-Url: https://codereview.chromium.org/2328523002 Cr-Commit-Position: refs/heads/master@{#39291}
-
epertoso authored
The previous DCHECK (removed in issue 2316033002) was checking that the new interval strictly overlapped with the first interval. BUG= Review-Url: https://codereview.chromium.org/2321113002 Cr-Commit-Position: refs/heads/master@{#39290}
-
ishell authored
Drive-by-fix: the old code never triggered write barrier. Review-Url: https://codereview.chromium.org/2321993002 Cr-Commit-Position: refs/heads/master@{#39289}
-
aseemgarg authored
BUG=v8:4124 TEST:test-run-wasm-simd R=titzer@chromium.org,bradnelson@chromium.org,gdeepti@chromium.org Review-Url: https://codereview.chromium.org/2300753005 Cr-Commit-Position: refs/heads/master@{#39288}
-
ofrobots authored
Revert of Use -fno-delete-null-pointer-checks with gcc builds (patchset #2 id:20001 of https://codereview.chromium.org/2310513002/ ) Reason for revert: Fails on MIPS: https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder/builds/3653 Original issue's description: > Use -fno-delete-null-pointer-checks with gcc builds > > R=bmeurer@chromium.org, jochen@chromium.org, machenbach@chromium.org > BUG=v8:3782 > > Committed: https://crrev.com/dbefc8ee2e9ee6e41b83f3d09c788c34bc923b43 > Cr-Commit-Position: refs/heads/master@{#39286} TBR=jochen@chromium.org,bmeurer@chromium.org,machenbach@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3782 Review-Url: https://codereview.chromium.org/2328563002 Cr-Commit-Position: refs/heads/master@{#39287}
-
ofrobots authored
R=bmeurer@chromium.org, jochen@chromium.org, machenbach@chromium.org BUG=v8:3782 Review-Url: https://codereview.chromium.org/2310513002 Cr-Commit-Position: refs/heads/master@{#39286}
-
machenbach authored
Fell through the cracks in a recent CL. Should have switched with the CI bot, which is on GN already. BUG=chromium:474921 NOTRY=true Review-Url: https://codereview.chromium.org/2328533002 Cr-Commit-Position: refs/heads/master@{#39285}
-
mlippautz authored
BUG= R=ulan@chromium.org Review-Url: https://codereview.chromium.org/2328503002 Cr-Commit-Position: refs/heads/master@{#39284}
-
mythria authored
Adds support to collect allocation site feedback for Array function calls to the call bytecode handler. BUG=v8:4280, v8:4780 LOG=N Review-Url: https://codereview.chromium.org/2307903002 Cr-Commit-Position: refs/heads/master@{#39283}
-
ahaas authored
I could not reproduce the bug in either a unittest nor a cctest. That's why I created an mjsunit test now. BUG=chromium:644682 R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2319213003 Cr-Commit-Position: refs/heads/master@{#39282}
-
machenbach authored
BUG=chromium:644643 NOTRY=true Review-Url: https://codereview.chromium.org/2319583002 Cr-Commit-Position: refs/heads/master@{#39281}
-
ishell authored
Review-Url: https://codereview.chromium.org/2321543003 Cr-Commit-Position: refs/heads/master@{#39280}
-
franzih authored
The existing PropertyQueryCallback intercepts getOwnPropertyDescriptor, but it returns only value and attributes, not the accessors. This PropertyDescriptorCallback returns a descriptor similar to Ecma-262 6.2.4. You can either set a PropertyQueryCallback or a PropertyDescriptorCallback, but not both. When you set a callback for DefineProperty(), you can set a PropertyDescriptorCallback but not a PropertyQueryCallback. BUG=v8:5359 Review-Url: https://codereview.chromium.org/2311873002 Cr-Commit-Position: refs/heads/master@{#39279}
-
ulan authored
BUG= Review-Url: https://codereview.chromium.org/2324623004 Cr-Commit-Position: refs/heads/master@{#39278}
-
mstarzinger authored
This fixes the materialization of JSFunction objects to not rely on a context being available. The context has been cleared because it might be de-materiallized itself. R=bmeurer@chromium.org TEST=mjsunit/compiler/escape-analysis-materialize BUG=chromium:644245 Review-Url: https://codereview.chromium.org/2320983002 Cr-Commit-Position: refs/heads/master@{#39277}
-
ishell authored
Review-Url: https://codereview.chromium.org/2319243002 Cr-Commit-Position: refs/heads/master@{#39276}
-
rodolph.perfetta authored
The test was using some callee saved registers but tests don't save those. BUG=v8:5354 Review-Url: https://codereview.chromium.org/2322923002 Cr-Commit-Position: refs/heads/master@{#39275}
-
mstarzinger authored
This fixes the materialization of JSArray objects to not rely on a context being available. The context has been cleared because it might be de-materiallized itself. R=bmeurer@chromium.org BUG=chromium:644245 Review-Url: https://codereview.chromium.org/2323713002 Cr-Commit-Position: refs/heads/master@{#39274}
-
mlippautz authored
BUG=chromium:636331 R=ulan@chromium.org Review-Url: https://codereview.chromium.org/2319683002 Cr-Commit-Position: refs/heads/master@{#39273}
-
nikolaos authored
This patch moves the following parsing methods to ParserBase: - ParseScopedStatement - ParseVariableStatement - ParseDebuggerStatement - ParseV8Intrinsic It also cleans up the implementation-specific use counter mechanism. R=adamk@chromium.org, marja@chromium.org BUG= LOG=N Review-Url: https://codereview.chromium.org/2318263002 Cr-Commit-Position: refs/heads/master@{#39272}
-
ishell authored
Review-Url: https://codereview.chromium.org/2319173002 Cr-Commit-Position: refs/heads/master@{#39271}
-
mstarzinger authored
This adds support to the deoptimizer to materialize ContextExtension objects that have been de-materialized by escape analysis. This is follow-up to the inline allocation of such objects during the create lowering phase (i.e. JSCreateWithContext and JSCreateCatchContext). R=bmeurer@chromium.org TEST=mjsunit/regress/regress-crbug-644245 BUG=chromium:644245 Review-Url: https://codereview.chromium.org/2317353003 Cr-Commit-Position: refs/heads/master@{#39270}
-
machenbach authored
Also roll build and android_tools, which contains a bump of the ndk to r12b. BUG=chromium:629806 Review-Url: https://codereview.chromium.org/2320843003 Cr-Commit-Position: refs/heads/master@{#39269}
-
ishell authored
Delete unused CSA::AllocateUninitializedFixedArray() which also does not respect ParameterMode concept. Review-Url: https://codereview.chromium.org/2321643002 Cr-Commit-Position: refs/heads/master@{#39268}
-
mstarzinger authored
This clears the context register by setting it to Smi(0) before calling the Runtime::kNotifyDeoptimized helper. The deoptimizer must be able to materialize all heap objects without any context available. The context itself might be dematerialized. With this change we make sure that invariant is maintained even without escape analysis kicking in. We also satisfy the check that the context register is either Smi(0) or a valid context. It might have been the special {arguments_marker} in this particular case. R=bmeurer@chromium.org BUG=chromium:644245 Review-Url: https://codereview.chromium.org/2320673002 Cr-Commit-Position: refs/heads/master@{#39267}
-
bmeurer authored
When lowering Array.prototype.push/.pop to the fast inlined version, we first need to ensure that all prototypes (including the Object.prototype) are stable. R=mvstanton@chromium.org BUG=chromium:644689 Review-Url: https://codereview.chromium.org/2319533005 Cr-Commit-Position: refs/heads/master@{#39266}
-
marija.antic authored
BUG= Review-Url: https://codereview.chromium.org/2304133002 Cr-Commit-Position: refs/heads/master@{#39265}
-
martyn.capewell authored
Reason for revert: Breaks g++ build. Original issue's description: > [turbofan] ARM: Implement vswp and use in gap resolver > > Use vswp to switch double-precision registers in the gap resolver, with fall > back temp register-based code if NEON is not available. > > BUG= > > Committed: https://crrev.com/2837c2e65a2ee5b9fc610f30ce1215f52323ecbd > Cr-Commit-Position: refs/heads/master@{#39209} BUG= Review-Url: https://codereview.chromium.org/2314043002 Cr-Commit-Position: refs/heads/master@{#39264}
-
landell authored
BUG= Review-Url: https://codereview.chromium.org/2292973002 Cr-Commit-Position: refs/heads/master@{#39263}
-