1. 03 Aug, 2022 1 commit
    • Andreas Haas's avatar
      [wasm] Delay error messages for lazy compilation · fe53fbfc
      Andreas Haas authored
      With streaming compilation we delay the generation of errors until after
      all bytes are received, so that potentially better error messages get
      generated. With this CL we also delay the generation of errors in the
      combination of lazy compilation and streaming compilation.
      
      In particular, this CL does the following:
      * It avoids the creation of a `DecodeFail` task in
      `FinishAsyncCompileJobWithError`, which would create an error immediately before a potential name section arrived.
      * It calls `CompilationStateImpl::SetError()` so that an error is
      created once the stream finishes.
      * It removes the return value of `ProcessFunctionBody` so that wire
      bytes continue to be received even after a validation error.
      * It adds an early exit to `ProcessFunctionBody` if
      `CompilationStateImpl::failed()` is true, so that we don't continue
      validation after the first detected error.
      
      R=clemensb@chromium.org
      
      Bug: v8:12852
      Change-Id: Ie8c6be243a257ef62cbb29fea6b8e0c205060680
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3802691Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
      Commit-Queue: Andreas Haas <ahaas@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#82181}
      fe53fbfc
  2. 01 Jun, 2021 1 commit
  3. 03 May, 2019 1 commit
  4. 30 Apr, 2019 1 commit