- 03 Aug, 2022 1 commit
-
-
Andreas Haas authored
With streaming compilation we delay the generation of errors until after all bytes are received, so that potentially better error messages get generated. With this CL we also delay the generation of errors in the combination of lazy compilation and streaming compilation. In particular, this CL does the following: * It avoids the creation of a `DecodeFail` task in `FinishAsyncCompileJobWithError`, which would create an error immediately before a potential name section arrived. * It calls `CompilationStateImpl::SetError()` so that an error is created once the stream finishes. * It removes the return value of `ProcessFunctionBody` so that wire bytes continue to be received even after a validation error. * It adds an early exit to `ProcessFunctionBody` if `CompilationStateImpl::failed()` is true, so that we don't continue validation after the first detected error. R=clemensb@chromium.org Bug: v8:12852 Change-Id: Ie8c6be243a257ef62cbb29fea6b8e0c205060680 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3802691Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#82181}
-
- 01 Jun, 2021 1 commit
-
-
Camillo Bruni authored
- Add d8.file.read() and d8.file.execute() helpers - Change tools and tests to use new d8.file helper - Unify error throwing in v8::Shell::ReadFile Change-Id: I5ef4cb27f217508a367106f01e872a4059d5e399 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928505 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#74883}
-
- 03 May, 2019 1 commit
-
-
Frederik Gossen authored
Fix function name in error messages thrown by the streaming API. The API functions {WebAssembly.compileStreaming} and {WebAssembly.instantiateStreaming} are now mentioned where needed. Bug: v8:9184 Change-Id: I70b27efe1c027d119fa7b5b9be27988a92304682 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588468Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Frederik Gossen <frgossen@google.com> Cr-Commit-Position: refs/heads/master@{#61202}
-
- 30 Apr, 2019 1 commit
-
-
Frederik Gossen authored
Fix recognition of lazy functions when {--wasm-lazy-compilation} is used. Bug: chromium:956771 Change-Id: I3f9bb25ccf3920a6c3d266876faace8841dcdc61 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1585843Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Frederik Gossen <frgossen@google.com> Cr-Commit-Position: refs/heads/master@{#61114}
-