- 15 Feb, 2016 3 commits
-
-
zhengxing.li authored
port 2166bd8c (r33797) original commit message: BUG= Review URL: https://codereview.chromium.org/1697953002 Cr-Commit-Position: refs/heads/master@{#33969}
-
v8-autoroll authored
Rolling v8/build/gyp to 2f9ffdc96135eaa102ee90584e7c6e5e5c45915c TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1701613002 Cr-Commit-Position: refs/heads/master@{#33968}
-
zhengxing.li authored
port 187b3f28 (r33796) original commit message: BUG= Review URL: https://codereview.chromium.org/1700583002 Cr-Commit-Position: refs/heads/master@{#33967}
-
- 14 Feb, 2016 2 commits
-
-
titzer authored
R=jarin@chromium.org BUG= Review URL: https://codereview.chromium.org/1691373002 Cr-Commit-Position: refs/heads/master@{#33966}
-
bmeurer authored
When we specialize to the native context, we can replace loads of the NATIVE_CONTEXT_INDEX in any known context with the appropriate native context for that context. This allows us to constant-fold and further optimize things like %reflect_construct, which are inserted by the parser. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1697513003 Cr-Commit-Position: refs/heads/master@{#33965}
-
- 13 Feb, 2016 1 commit
-
-
bradnelson authored
Older versions of Emscripten appear to emit Asm.js containing: HEAP8[x] with x in int As opposed to the spec legal construct: HEAP8[x>>0] with x in int As older programs and even benchmarks such as Embenchen include these constructs, support them for compatibility. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=test-asm-validator,mjsunit/asm-wasm R=aseemgarg@chromium.org,titzer@chromium.org LOG=N Review URL: https://codereview.chromium.org/1692713006 Cr-Commit-Position: refs/heads/master@{#33964}
-
- 12 Feb, 2016 34 commits
-
-
mbrandy authored
Port 09d84535 Original commit message: The FastNewStrictArgumentsStub is very similar to the recently added FastNewRestParameterStub, it's actually almost a copy of it, except that it doesn't have the fast case we have for the empty rest parameter. This patch improves strict arguments in TurboFan and fullcodegen by up to 10x compared to the previous version. Also introduce proper JSSloppyArgumentsObject and JSStrictArgumentsObject for the in-object properties instead of having them as constants in the Heap class. Drive-by-fix: Use this stub and the FastNewRestParameterStub in the interpreter to avoid the runtime call overhead for strict arguments and rest parameter creation. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1696743002 Cr-Commit-Position: refs/heads/master@{#33963}
-
mbrandy authored
Port a2935d63 Original commmit message: Saves and restores the dispatch pointer during calls to enable the debugger to switch the dispatch table used by a function during it's execution. Also moves the accumulator and context nodes to be Variables so that they will be properly merged across branches. R=rmcilroy@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4280,v8:4690 LOG=N Review URL: https://codereview.chromium.org/1688373002 Cr-Commit-Position: refs/heads/master@{#33962}
-
adamk authored
This is hopefully the last in a series of cleanup patches around destructuring assignment. It simplifies the ParseAssignmentExpression API, making the callers call CheckDestructuringElement() where appropriate. CheckDestructuringElement has been further simplified to only emit the errors that the parser depends on it emitting. I've also beefed up the test coverage in test-parsing.cc to handling all the destructuring flags being on, which caught an oddity in how we disallow initializers in spreads in patterns (we need to treat RewritableAssignmentExpressions as Assignments for the purpose of error checking). Finally, I added a few helper methods to ParserBase to handle a few classes of expressions (assignments and literals-as-patterns). Review URL: https://codereview.chromium.org/1696603002 Cr-Commit-Position: refs/heads/master@{#33961}
-
kozyatinskiy authored
This behavior was changed in https://codereview.chromium.org/1402913002. It's pretty usefull to have ability to disable debugger statement for our users. BUG=chromium:583515 LOG=N R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1690173002 Cr-Commit-Position: refs/heads/master@{#33960}
-
mattloring authored
This change expands allocation sampling to include old, map, code, and large object spaces. This involved refactoring much of the observation logic out of NewSpace into Space and overriding as needed in sub-classes. Additionally, the sampling heap profiler now maintains a pair of heap observers. One observer is used for observing new space and resetting the inline allocation limit to be periodically notified of allocations. The other observes allocation across the other spaces where there is no additional work required to observe allocations. Tests have been updated to ensure that allocations are observed correctly for Paged and LargeObject spaces. R=ofrobots@google.com, hpayer@chromium.org, ulan@chromium.org BUG= Review URL: https://codereview.chromium.org/1625753002 Cr-Commit-Position: refs/heads/master@{#33959}
-
titzer authored
R=bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1690343002 Cr-Commit-Position: refs/heads/master@{#33958}
-
titzer authored
R=mtrofin@chromium.org BUG= Review URL: https://codereview.chromium.org/1690863006 Cr-Commit-Position: refs/heads/master@{#33957}
-
bradnelson authored
Since wasm has no direct notion of foreign globals, pass the ffi object on to the AsmWasmBuilder so that foreign globals can be extracted at module instantiation time. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=mjsunit/asm-wasm R=titzer@chromium.org,aseemgarg@chromium.org LOG=N Review URL: https://codereview.chromium.org/1677373002 Cr-Commit-Position: refs/heads/master@{#33956}
-
titzer authored
R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1698473003 Cr-Commit-Position: refs/heads/master@{#33955}
-
titzer authored
R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1692223002 Cr-Commit-Position: refs/heads/master@{#33954}
-
alph authored
Recent flake happened bacause all the samples landed into native code. The patch makes sure we collect enough JS samples. BUG=v8:4751 LOG=N Review URL: https://codereview.chromium.org/1695663002 Cr-Commit-Position: refs/heads/master@{#33953}
-
oth authored
Adds JumpIfNotHoleConstant and JumpIfNotHoleConstantWide bytecodes and removes JumpIfHole bytecode. In situations with large numbers of constants, the generator would fail because an 8-bit constant could not be reserved for JumpIfHole/JumpIfNotHole and so a 16-bit constant would be reserved. Then when patching the bytecode the patcher would discover there was no wide constant variant of the emitted jump. BUG=v8:4280,v8:4680 LOG=N Review URL: https://codereview.chromium.org/1697473002 Cr-Commit-Position: refs/heads/master@{#33952}
-
mbrandy authored
Port e519e6fa Original commit message: 1) Update profiling counters in Full codegen. 2) Call Runtime::kTraceTailCall when tracing is on test/mjsunit/es6/tail-call-simple.js is disabled for now, because Turbofan does not fully support TCO yet. R=ishell@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4698 LOG=N Review URL: https://codereview.chromium.org/1690953003 Cr-Commit-Position: refs/heads/master@{#33951}
-
machenbach authored
Authorize people with try-job access to do dry runs. Change to faster blink trybot in 20% experiment. NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1692943002 Cr-Commit-Position: refs/heads/master@{#33950}
-
verwaest authored
This avoids having to read the context and call through from the inlined path in the JSReceiver case. BUG= Review URL: https://codereview.chromium.org/1698463002 Cr-Commit-Position: refs/heads/master@{#33949}
-
bmeurer authored
There are only two uses of %_ObjectEquals left, which should actually use strict equality instead, so there's no need to keep this special logic at all. R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1692193002 Cr-Commit-Position: refs/heads/master@{#33948}
-
machenbach authored
Revert of [turbofan] Ship turbofan try-catch. (patchset #1 id:1 of https://codereview.chromium.org/1694743003/ ) Reason for revert: [Sheriff] Might break layout tests unintended. Original issue's description: > [turbofan] Ship turbofan try-catch. > > Committed: https://crrev.com/5bb459ba4daa34e5ed2fca0dd146aa18f9b6b036 > Cr-Commit-Position: refs/heads/master@{#33938} TBR=mstarzinger@chromium.org,bmeurer@chromium.org,jarin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1688403003 Cr-Commit-Position: refs/heads/master@{#33947}
-
machenbach authored
This returns a proper test result (failure) when files are missing for setting up the command. Review URL: https://codereview.chromium.org/1696713002 Cr-Commit-Position: refs/heads/master@{#33946}
-
verwaest authored
Speeds up Object.keys by another ~10-20% :) Review URL: https://codereview.chromium.org/1697533002 Cr-Commit-Position: refs/heads/master@{#33945}
-
machenbach authored
BUG=v8:4754 LOG=n NOTRY=true TBR=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/1693823002 Cr-Commit-Position: refs/heads/master@{#33944}
-
bmeurer authored
This removes support for the %Arguments and %ArgumentsLength runtime entries and their intrinsic counterparts. If you need variable arguments in any builtin, either use (strict) arguments object or rest parameters, which are both compositional across inlining (in TurboFan), and not that much slower compared to the %_Arguments hackery. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1688163004 Cr-Commit-Position: refs/heads/master@{#33943}
-
jarin authored
Review URL: https://codereview.chromium.org/1669303002 Cr-Commit-Position: refs/heads/master@{#33942}
-
jarin authored
Review URL: https://codereview.chromium.org/1689573008 Cr-Commit-Position: refs/heads/master@{#33941}
-
ulan authored
BUG= Review URL: https://codereview.chromium.org/1693813002 Cr-Commit-Position: refs/heads/master@{#33940}
-
bmeurer authored
This is the very last use of %_Arguments and %_ArgumentsLength, and also the main blocker for not inlining builtins. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1681403006 Cr-Commit-Position: refs/heads/master@{#33939}
-
jarin authored
Review URL: https://codereview.chromium.org/1694743003 Cr-Commit-Position: refs/heads/master@{#33938}
-
mstarzinger authored
The tests in question have been disabled because throwing into lazy deoptimized code was borked. After recent fixes landed these tests should now pass again. R=jarin@chromium.org TEST=cctest/test-run-deopt/DeoptExceptionHandler BUG=v8:4195 LOG=n Review URL: https://codereview.chromium.org/1692873002 Cr-Commit-Position: refs/heads/master@{#33937}
-
jarin authored
The idea here is to perform the handler lookup in the deoptimizer, and then take the information from the handler table to build the catch handler frame in the deoptimizer. Specifically, we use the pc offset, context location and stack height (in full-code) to tweak the output frame. Sadly, this still requires nasty voodoo for the liveness analyzer so that it keeps variables alive if they are used in the catch handler. Review URL: https://codereview.chromium.org/1416543006 Cr-Commit-Position: refs/heads/master@{#33936}
-
bmeurer authored
There's only one last user of %_Arguments and %_ArgumentsLength left, the rest was updated to either strict mode arguments object or to not use arguments at all. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1692003003 Cr-Commit-Position: refs/heads/master@{#33935}
-
epertoso authored
This was causing code like: REX.W cmpq r9,r8 setzl r8l movzxbl r8,r8 REX.W cmpq r8,0x0 jz 185 (note the cmpq instead of cmpl above) on x64 instead of: REX.W cmpq r9,r8 jnz 149 http://crrev.com/1677503002 is now obsolete and has been reverted. Review URL: https://codereview.chromium.org/1685183003 Cr-Commit-Position: refs/heads/master@{#33934}
-
mstarzinger authored
Reland of [interpreter] Correctly thread through catch prediction. (patchset #1 id:1 of https://codereview.chromium.org/1695613002/ ) Reason for revert: No fix needed, original CL was perfectly fine! Original issue's description: > Revert of [interpreter] Correctly thread through catch prediction. (patchset #1 id:1 of https://codereview.chromium.org/1690973002/ ) > > Reason for revert: > Depends on the reverted https://codereview.chromium.org/1691723002 > > Original issue's description: > > [interpreter] Correctly thread through catch prediction. > > > > This change correctly sets the {CatchPrediction} field in exception > > handler tables for bytecode and optimized code. It also adds tests > > independent of promise handling for this prediction, to ensure all our > > backends are in sync on their prediction. > > > > R=rmcilroy@chromium.org,yangguo@chromium.org > > TEST=mjsunit/compiler/debug-catch-prediction > > BUG=v8:4674 > > LOG=n > > > > Committed: https://crrev.com/ba55f5594cb0b4a1a1e9b35d87fe54afe2d93f3b > > Cr-Commit-Position: refs/heads/master@{#33906} > > TBR=rmcilroy@chromium.org,yangguo@chromium.org,mstarzinger@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4674 > > Committed: https://crrev.com/c5229b311968fd638a6cd537c341b1055eb7be97 > Cr-Commit-Position: refs/heads/master@{#33922} TBR=rmcilroy@chromium.org,yangguo@chromium.org,adamk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4674 Review URL: https://codereview.chromium.org/1689113004 Cr-Commit-Position: refs/heads/master@{#33933}
-
rmcilroy authored
Remove some Ignition skips in mjsunit and cctest, and replace a few others with fails now that the there is more debugger support. BUG=v8:4680 LOG=N Review URL: https://codereview.chromium.org/1689993002 Cr-Commit-Position: refs/heads/master@{#33932}
-
mstarzinger authored
Reland of [interpreter] Make d8's TryCatch block be verbose. (patchset #1 id:1 of https://codereview.chromium.org/1694523003/ ) Reason for revert: No fix needed, original CL was perfectly fine! Original issue's description: > Revert of [interpreter] Make d8's TryCatch block be verbose. (patchset #3 id:40001 of https://codereview.chromium.org/1691723002/ ) > > Reason for revert: > [Sheriff] Speculative revert. Breaks > https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/3944 > > Somehow https://chromium.googlesource.com/v8/v8/+/3a2fbc3a4ed2802b52659df2209b930200d63b29 seems to hide it again and then https://chromium.googlesource.com/v8/v8/+/699e1081a658ff62df6df1efe7db2b250111dedd lets it show up again. > > Reproduced locally. > > Original issue's description: > > [interpreter] Make d8's TryCatch block be verbose. > > > > This changes "d8" to no longer report exceptions as being "caught" when > > it comes to the catch prediction mechanism in our debugger. This treats > > scripts as being truly top-level when it comes to exception handling and > > will allow us to properly test the catch prediction mechanism using just > > mjsunit tests alone. > > > > R=yangguo@chromium.org > > BUG=v8:4674 > > LOG=n > > > > Committed: https://crrev.com/fb1de271a6bc2c89a1682db8c151cf5fcda86c45 > > Cr-Commit-Position: refs/heads/master@{#33898} > > TBR=yangguo@chromium.org,mstarzinger@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4674 > > Committed: https://crrev.com/f9eef1f33d2e5cde8cb948424e7ebf509090aa59 > Cr-Commit-Position: refs/heads/master@{#33921} TBR=yangguo@chromium.org,machenbach@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4674 Review URL: https://codereview.chromium.org/1692133002 Cr-Commit-Position: refs/heads/master@{#33931}
-
rmcilroy authored
BUG=v8:4680 LOG=N Review URL: https://codereview.chromium.org/1692693004 Cr-Commit-Position: refs/heads/master@{#33930}
-