- 17 Feb, 2021 24 commits
-
-
Seth Brenith authored
This is a reland of cf93071c Original change's description: > [interpreter] Short Star bytecode > > Design doc: > https://docs.google.com/document/d/1g_NExMT78II_KnIYNa9MvyPYIj23qAiFUEsyemY5KRk/edit > > This change adds 16 new interpreter opcodes, kStar0 through kStar15, so > that we can use a single byte to represent the common operation of > storing to a low-numbered register. This generally reduces the quantity > of bytecode generated on web sites by 8-9%. > > In order to not degrade speed, a couple of other changes are required: > > The existing lookahead logic to check for Star after certain other > bytecode handlers is updated to check for these new short Star codes > instead. Furthermore, that lookahead logic is updated to contain its own > copy of the dispatch jump rather than merging control flow with the > lookahead-failed case, to improve branch prediction. > > A bunch of constants use bytecode size in bytes as a proxy for the size > or complexity of a function, and are adjusted downward proportionally to > the decrease in generated bytecode size. > > Other small drive-by fix: update generate-bytecode-expectations to emit > \n instead of \r\n on Windows. > > Change-Id: I6307c2b0f5794a3a1088bb0fb94f6e1615441ed5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2641180 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#72773} Change-Id: I1afb670c25694498b3989de615858f984a8c7f6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2698057 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#72821}
-
Michael Lippautz authored
Previously, ephemerons without a base_object_payload have been filtered. base_object_payload is currently used to differentiate between GarbageCollected and just traceable objects, so we need to pass on the empty descriptor. Bug: chromium:1056170 Change-Id: I9cba53295779ec74dce2822b7bf83f477bc3241f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2700039Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#72820}
-
Leszek Swirski authored
Move the CompileWithBaseline interface to the Compiler class, as CompileBaseline, which will do the additional work of pre-compiling to bytecode, ensuring there is a feedback vector, and setting the code on the function closure. As a drive-by, fix v8_enable_trace_unoptimized to have a blank default value, so that v8_enable_trace_ignition/v8_enable_trace_baseline_exec can set it. Bug: v8:11420, v8:11429 Change-Id: If715161de71f7d9300f3fdcbb50cc678b1fcdfdf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2697352Reviewed-by:
-
Almothana Athamneh authored
Bug: v8:11344 Change-Id: I407e6a9afa0c813f9a41b5e7f0e6ff72f768ffea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2699264Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/master@{#72818}
-
Thibaud Michaud authored
R=ahaas@chromium.org Bug: v8:8091 Change-Id: Ie3450c2a55d2fd272efc6c69632cf52a9aede597 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2699259 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#72817}
-
Milad Fa authored
Port af3c5307 Original Commit Message: This threads through a JumpMode kJump/kReturn to JumpCodeObject so we can use a return instruction to jump instead by first pushing the jump target and then using a return instruction. R=verwaest@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I354329238d00503a234556f25adccd920d26d320 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2700036Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#72816}
-
Leszek Swirski authored
This prevents conflicts with e.g. --always-opt Fixed: v8:11462 Change-Id: Ib98378a1bf620f5706bf3eef06f997bd994b1e2c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2700035 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#72815}
-
Leszek Swirski authored
Fixed: chromium:1178841 Change-Id: Ic91f5930476695bfc1767eac9140b8120935c9e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2700171 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
In case there's no exact match for the breakable location in SetBreakpoint(), don't try to find the syntactically closest break location, but rather find the first possible break location in bytecode order. In particular when trying to set a breakpoint in a line with for-of or an array destruction, there's no point in going for the syntactically closest to the beginning of the line, but rather go for the semantically first, as the intiution for setting a breakpoint on a line is that the debugger stops before it executes anything on said line. In the example ``` var [^a, ^b] = ^func(); ``` there are three possible break locations, and the correct one is the last one as the call to func will happen first at runtime. For generators that's currently broken because of the implicit initial yield, and same with modules (see crbug.com/901819), so we keep the previous behavior of finding the closest breakable location, and will fix that independently in a follow up CL. Bug: chromium:901819 Fixed: chromium:782461 Also-By: yangguo@chromium.org Change-Id: Ie724c5cb08e5f4edd90a450d99e001dff06bbe7a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2696586 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#72813}
-
Clemens Backes authored
Pinned registers were not considered correctly when taking a volatile register. This CL refactors handling of the pinned registers list by combining the candidates list and the pinned list early. This avoid additional parameters on some functions and might save some redundant masking. As a side effect, it also fixes the DCHECK error on arm. R=ahaas@chromium.org Bug: chromium:1179025 Change-Id: Ib9193b209c5741ea97fd1d0dffeeb9e824639439 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2699254Reviewed-by:
-
Clemens Backes authored
We made two runtime calls: The first one allocated the exception object containing a FixedArray of exception values, the second call did the actual throw. Inbetween the code was filling the values array. This CL refactors this to only allocate the FixedArray initially, fill it, and then allocate the actual exception and throw it both from the second runtime function. This avoids a WasmGetOwnProperty call to find the values array. R=thibaudm@chromium.org Bug: v8:11453 Change-Id: I091aaa5c7bfb2b5579fc92c953adf582e6cc175a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2697359 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#72811}
-
Thibaud Michaud authored
'catch_all' and 'else' use distinct opcodes now. R=clemensb@chromium.org Bug: v8:8091 Change-Id: If07e46b9ea23068953db1765d10c7e3746d21d99 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2699258 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#72810}
-
Santiago Aboy Solanes authored
During the string reverts a while back https://chromium-review.googlesource.com/c/v8/v8/+/2633547 I reverted some tests that were testing the code that was *not* reverted i.e. the internalization of external strings. Bug: v8:7790 Change-Id: I84964791cce712d753fd409cc3c641d9fbbb6550 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2699262Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#72809}
-
Leszek Swirski authored
Add baseline builtins for CreateAsyncFromSyncIterator and GetImportMetaObject, and call those instead of the runtime functions. Drive-by remove some TODOs in baseline-compiler.cc which are either no longer planned or don't need to be done any time soon. Bug: v8:11420, v8:11429 Change-Id: I15b4fe1f04316492045250b2c65ab6016f29b313 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2699261 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#72808}
-
Paolo Severini authored
The csuite.py script does not work correctly on Windows. It runs correctly in baseline mode, but there are two problems when running in compare mode: 1. In compare mode the output of benchmark.py is piped to the compare-baseline.py script, but Windows only execute python files if python.exe is the default program to open '.py' files, and this is not the case, by default, when python is installed as part of the depot_tools. Fix: explicitly add the 'python' command before compare-baseline.py. 2. By default CSuite prints the results to stdout using escapes codes that add color highlights. But this does not work on Windows when compare-baseline.py is launched with a pipe: python test/benchmarks/csuite/benchmark.py <...> | python test/benchmarks/csuite/compare-baseline.py <baseline_results> Fix: Do not use a pipe. Write the benchmark numbers for the compare-run into a separate file, and pass the path to this file to compare-baseline.py Change-Id: Ic22d5bd4b47901f0ba0f35bc2496441346d21c6a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2656855Reviewed-by:Michael Stanton <mvstanton@chromium.org> Commit-Queue: Paolo Severini <paolosev@microsoft.com> Cr-Commit-Position: refs/heads/master@{#72807}
-
pthier authored
The expected exception in this regression test is thrown due to a limitation in the IrRegExp engine. The experimental engine is unaffected and won't throw. Bug: v8:11363 Change-Id: If37d86f5d4494b40c47ecc5e5bc4f86fda30389c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2699251 Auto-Submit: Patrick Thier <pthier@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#72806}
-
Victor Gomes authored
Change-Id: Icdd2d4a178415d240a82378ffa575e6e6b79dca1 Bug: v8:11429 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2697353Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
-
Toon Verwaest authored
This threads through a JumpMode kJump/kReturn to JumpCodeObject so we can use a return instruction to jump instead by first pushing the jump target and then using a return instruction. Bug: v8:11429 Change-Id: I8658ed9c5bade28bd6efc76e26fd92bad22b3c68 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2697196 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Georg Neis authored
This reverts commit e27b7b60, which was a workaround. The original problem is not reproducible anymore. Bug: v8:9717 Change-Id: I11e165d7ec9643ec805ab8c075b720b58e7769bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2699249 Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#72803}
-
Leszek Swirski authored
Bug: v8:11429, v8:11461 Change-Id: Iffe9ac09eea008b45a6b9734a3c78ac8ba508222 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2699253 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Georg Neis authored
Bug: v8:9717 Change-Id: I2338e11ec8263b18e60eb5206431738a8532c977 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2699248 Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
Victor Gomes authored
Change-Id: I9eb86c5ca40734ec61864bce7d0f757fcd4b7d93 Bug: v8:11429 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2697205Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/bc28354..a42736b Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/228b1c1..fe293b0 Rolling v8/third_party/aemu-linux-x64: AFb5I0J9LTvrxaixyFmiKgTuOLLQ3YJ_FAEwRZq1basC..9VxcXi3GhpRxrjwHQwa801vcevGa1Pew2lw1KkUkgmgC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/35976bf..832539c Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/7386a1e..0391863 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/dbe0d80..823dc87 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idc687f5ee60652f381dca0c9d0f7c8293ea6a73a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2699354Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#72799}
-
Milad Fa authored
Bug: v8:11416 Change-Id: I0c993ee564358f5c5f8880cbae1bce9ff2128087 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2698308 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by:
-
- 16 Feb, 2021 16 commits
-
-
Ng Zhi An authored
Bug: v8:11415,v8:11348,v8:11416,v8:11347 Change-Id: I0c945ecf10264fdaf90dab7b854cb2392976a8ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2693988 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#72797}
-
Milad Fa authored
Bug: v8:11415 Change-Id: I0101d88d19e5cad20d5f0fa6926cf0ebd9d000e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2698091 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#72796}
-
Ng Zhi An authored
Bug: v8:11265 Change-Id: I133c050a4d4c479c2d5adb1b95ef758d2875e773 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2692731Reviewed-by:
-
Nicolas Dubus authored
samples being discarded - Passed in as CpuProfilingOptions parameter, client is responsible for determining if function is still safe to execute. Includes unit tests - Client (blink) side CR: https://chromium-review.googlesource.com/c/chromium/src/+/2649617, - Client (blink) side CR requires this to be pushed prior to it being pushed Change-Id: I3ef4640186115d4e14c1b73f902c889c776e310f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2652206 Commit-Queue: Nicolas Dubus <nicodubus@fb.com> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#72794}
-
Ng Zhi An authored
Bug: v8:11416 Change-Id: I094e91b1e5b382e5eced24d198e1f6bbc1b4ae0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2686311 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#72793}
-
Junliang Yan authored
Change-Id: I9241573c3644918028e2b302da2988cca0973cb8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2698089Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#72792}
-
Junliang Yan authored
Port adf035fb Original Commit Message: This CL avoids redundant loads of the instance from the frame by caching it in a register if possible. This register will be the first one to be cleared once we run out of registers (hence it's called a "volatile register"). On local tests, this seems to reduce most redundant loads within a function, and it also reduces the load for the stack check in the function prologue. After the stack check, we need to discard the cached instance though, since the potential runtime call for the stack check might clobber it. This will be addressed in a follow-up CL by re-loading the cached instance after the stack check. This is expected to remove another good chunk of instance loads, because the instance would initially be available in a register when starting the function code. R=clemensb@chromium.org, midawson@redhat.com, mfarazma@redhat.com BUG= LOG=N Change-Id: I3756ce98d4dfefb44c946a4948f1a6dbe0ce44dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2698291Reviewed-by:
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:8091 Change-Id: I2933342da65ef75cfe36f81f8828411fd78d45e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2696659 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Bug: v8:11415 Change-Id: I8ad0aab2c1ac89ec66779b44542833c3a4eb96fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2693323Reviewed-by:
-
Milad Fa authored
As of https://crrev.com/c/2629465, Simd tests cannot pass on architectures without Simd support. Tests will need to be re-enabled once Simd support is fully implemented on PPC. Change-Id: I963639f1afa0c0ca7be3ca4b2fc06e874235b903 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2693056Reviewed-by:
Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Bug: v8:11416 Change-Id: I9fe70ae588147a3e04c719f14d86fb80ed9b6caa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2686310 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Milad Fa authored
Change-Id: I66c3dc4a92f814b7ee1771136a5ab794bae9cd98 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2697649Reviewed-by:
-
Thibaud Michaud authored
Implicitly rethrow the exception when we reach the end of a try..unwind..end. Also make it a validation error to rethrow an exception caught by an unwind block. R=clemensb@chromium.org Bug: v8:8091 Change-Id: Ia149d2e81b1fbfa9209047b35ff0c9fedc1b8895 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2696662 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Clemens Backes authored
The WasmThrow and WasmRethrow runtime functions have the same signature, but we should still use the correct description in case the signature changes (which is planned for a follow-up CL). R=thibaudm@chromium.org Bug: v8:11453 Change-Id: Iaec9c353d30fa7673ceb8994e3029c4adfc01311 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2697348Reviewed-by:
-
Milad Fa authored
Change-Id: Iebd2bcbe8587fe079b8f058f9546294d020e23d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2697389Reviewed-by:
-
Benedikt Meurer authored
The Debug::SetBreakPointForScript() method essentially figures out the SharedFunctionInfo and then duplicates the logic from SetBreakpoint(). Bug: chromium:1162229 Change-Id: Iae98ab5d182739d44e0277b799509723d950f381 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2697351 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
