- 10 Mar, 2016 6 commits
-
-
zhengxing.li authored
port c29a4560(r34610) original commit message: In case when F was called with incompatible number of arguments (and therefore the arguments adator frame was created), F inlines a tail call of G which then deopts the deoptimizer should also remove the arguments adaptor frame for F. This CL adds required machinery to the deoptimizer. BUG= Review URL: https://codereview.chromium.org/1785593002 Cr-Commit-Position: refs/heads/master@{#34651}
-
zhengxing.li authored
port 679d9503(r34608) original commit message: According to https://www.w3.org/TR/html5/obsolete.html#dom-document-all, comparisons of document.all to other values such as strings or objects, are unaffected. In fact document.all only gets special treatment in comparisons with null or undefined according to HTML. Especially setting the undetectable doesn't make two distinct JSReceivers equal. BUG= Review URL: https://codereview.chromium.org/1784763002 Cr-Commit-Position: refs/heads/master@{#34650}
-
v8-autoroll authored
Rolling v8/tools/clang to fc7b250f6ca03bcbcd2cd1a3e4102cb639a2814a TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1784643005 Cr-Commit-Position: refs/heads/master@{#34649}
-
zhengxing.li authored
port 9dcd0857 (r34571) original commit message: Before this CL, various code stubs used different techniques for marking their frames to enable stack-crawling and other access to data in the frame. All of them were based on a abuse of the "standard" frame representation, e.g. storing the a context pointer immediately below the frame's fp, and a function pointer after that. Although functional, this approach tends to make stubs and builtins do an awkward, unnecessary dance to appear like standard frames, even if they have nothing to do with JavaScript execution. This CL attempts to improve this by: * Ensuring that there are only two fundamentally different types of frames, a "standard" frame and a "typed" frame. Standard frames, as before, contain both a context and function pointer. Typed frames contain only a minimum of a smi marker in the position immediately below the fp where the context is in standard frames. * Only interpreted, full codegen, and optimized Crankshaft and TurboFan JavaScript frames use the "standard" format. All other frames use the type frame format with an explicit marker. * Typed frames can contain one or more values below the type marker. There is new magic macro machinery in frames.h that simplifies defining the offsets of these fields in typed frames. * A new flag in the CallDescriptor enables specifying whether a frame is a standard frame or a typed frame. Secondary register location spilling is now only enabled for standard frames. * A zillion places in the code have been updated to deal with the fact that most code stubs and internal frames use the typed frame format. This includes changes in the deoptimizer, debugger, and liveedit. * StandardFrameConstants::kMarkerOffset is deprecated, (CommonFrameConstants::kContextOrFrameTypeOffset and StandardFrameConstants::kFrameOffset are now used in its stead). BUG= Review URL: https://codereview.chromium.org/1774353002 Cr-Commit-Position: refs/heads/master@{#34648}
-
littledan authored
BUG=v8:4348 R=adamk LOG=Y Review URL: https://codereview.chromium.org/1783643002 Cr-Commit-Position: refs/heads/master@{#34647}
-
littledan authored
This flag bans illegal (and likely useless) constructs like for (;;) function f() {} R=adamk BUG=v8:4824 LOG=Y Review URL: https://codereview.chromium.org/1781653005 Cr-Commit-Position: refs/heads/master@{#34646}
-
- 09 Mar, 2016 34 commits
-
-
mbrandy authored
Port 679d9503 Original commit message: According to https://www.w3.org/TR/html5/obsolete.html#dom-document-all, comparisons of document.all to other values such as strings or objects, are unaffected. In fact document.all only gets special treatment in comparisons with null or undefined according to HTML. Especially setting the undetectable doesn't make two distinct JSReceivers equal. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1785503002 Cr-Commit-Position: refs/heads/master@{#34645}
-
mbrandy authored
Port c29a4560 Original commit message: In case when F was called with incompatible number of arguments (and therefore the arguments adator frame was created), F inlines a tail call of G which then deopts the deoptimizer should also remove the arguments adaptor frame for F. This CL adds required machinery to the deoptimizer. R=ishell@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4698 LOG=N Review URL: https://codereview.chromium.org/1775393004 Cr-Commit-Position: refs/heads/master@{#34644}
-
mbrandy authored
Port 9dcd0857 Original commit message: Before this CL, various code stubs used different techniques for marking their frames to enable stack-crawling and other access to data in the frame. All of them were based on a abuse of the "standard" frame representation, e.g. storing the a context pointer immediately below the frame's fp, and a function pointer after that. Although functional, this approach tends to make stubs and builtins do an awkward, unnecessary dance to appear like standard frames, even if they have nothing to do with JavaScript execution. This CL attempts to improve this by: * Ensuring that there are only two fundamentally different types of frames, a "standard" frame and a "typed" frame. Standard frames, as before, contain both a context and function pointer. Typed frames contain only a minimum of a smi marker in the position immediately below the fp where the context is in standard frames. * Only interpreted, full codegen, and optimized Crankshaft and TurboFan JavaScript frames use the "standard" format. All other frames use the type frame format with an explicit marker. * Typed frames can contain one or more values below the type marker. There is new magic macro machinery in frames.h that simplifies defining the offsets of these fields in typed frames. * A new flag in the CallDescriptor enables specifying whether a frame is a standard frame or a typed frame. Secondary register location spilling is now only enabled for standard frames. * A zillion places in the code have been updated to deal with the fact that most code stubs and internal frames use the typed frame format. This includes changes in the deoptimizer, debugger, and liveedit. * StandardFrameConstants::kMarkerOffset is deprecated, (CommonFrameConstants::kContextOrFrameTypeOffset and StandardFrameConstants::kFrameOffset are now used in its stead). R=danno@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1778713002 Cr-Commit-Position: refs/heads/master@{#34643}
-
mbrandy authored
R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1779803004 Cr-Commit-Position: refs/heads/master@{#34642}
-
titzer authored
R=binji@chromium.org BUG= Review URL: https://codereview.chromium.org/1783593002 Cr-Commit-Position: refs/heads/master@{#34641}
-
adamk authored
BUG=v8:4247 LOG=y Review URL: https://codereview.chromium.org/1781573003 Cr-Commit-Position: refs/heads/master@{#34640}
-
binji authored
BUG= R=titzer@chromium.org Review URL: https://codereview.chromium.org/1776923005 Cr-Commit-Position: refs/heads/master@{#34639}
-
yangguo authored
As described in unicode database file PropertyValueAliases.txt R=littledan@chromium.org BUG=v8:4743 LOG=N Review URL: https://codereview.chromium.org/1776953002 Cr-Commit-Position: refs/heads/master@{#34638}
-
binji authored
R=titzer@chromium.org Review URL: https://codereview.chromium.org/1781523002 Cr-Commit-Position: refs/heads/master@{#34637}
-
littledan authored
When an Array subclass is used as the receiver for concat, or with certain usages of @@species, the output that's constructed is of a different type with new slow path logic. This slow path still made references to elements, so it's important that bounds checking for a too-long result still be done. This patch repairs that bounds checking. R=cbruni LOG=Y BUG=chromium:592340 Review URL: https://codereview.chromium.org/1782443002 Cr-Commit-Position: refs/heads/master@{#34636}
-
titzer authored
R=binji@chromium.org BUG= Review URL: https://codereview.chromium.org/1775123003 Cr-Commit-Position: refs/heads/master@{#34635}
-
hlopko authored
BUG=chromium:468240 LOG=no Review URL: https://codereview.chromium.org/1773273002 Cr-Commit-Position: refs/heads/master@{#34634}
-
jkummerow authored
Reading the registers' values back from the FrameDescription should use the same offset computation as storing them into it. The offsets must also match what the deoptimizer expects, which is rx at offset rx.code() * kDoubleSize, even if some registers are not saved (leaving gaps). BUG=v8:4800 LOG=n R=danno@chromium.org Review URL: https://codereview.chromium.org/1769833006 Cr-Commit-Position: refs/heads/master@{#34633}
-
alan.li authored
Port 9d0cf920 Bug Descriptions: 1. We are missing drotr32 instruction 2. Ror Macro should also handle values less than zero or bigger than 31, as WASM instruction kExprI32Rol will generate shifting operands beyond [0 .. 31] range. 3. Same as Dror. 4. drotrv instruction in simulator is incorrect. BUG= TEST=cctest/test-run-wasm/Run_WasmInt32Binops,cctest/test-run-wasm/Run_WasmInt64Binops Review URL: https://codereview.chromium.org/1776623002 Cr-Commit-Position: refs/heads/master@{#34632}
-
ssanfilippo authored
BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1772403002 Cr-Commit-Position: refs/heads/master@{#34631}
-
ahaas authored
I implemented I64ShrU and I64ShrS the same as I64Shl in https://codereview.chromium.org/1756863002 R=titzer@chromium.org Review URL: https://codereview.chromium.org/1768233002 Cr-Commit-Position: refs/heads/master@{#34630}
-
ahaas authored
R=titzer@chromium.org Review URL: https://codereview.chromium.org/1776613002 Cr-Commit-Position: refs/heads/master@{#34629}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1776803003 Cr-Commit-Position: refs/heads/master@{#34628}
-
vogelheim authored
- Eliminate stubs with a variable number of arguments. (That only worked due to their very limited use. These stubs' interface descriptors were basically lying about their number of args, which will fail when used generically.) - Fix all CallApi*Stubs' interface descriptors to no longer lie about their arguments. - Unify CallApi*Stub, for * in Function, Accessor, FunctionWithFixedArgs. (Since these are now all doing the same thing.) - Rename the unified stub (and interface descriptors) to *ApiCallback*, since that's really what they're doing. - Refuse inlining an API callback if its number of parameters exceeds the supported number of args. BUG= Committed: https://crrev.com/d238b953a474272c0e3ea22ef6a9b63fa9729340 Cr-Commit-Position: refs/heads/master@{#34614} Review URL: https://codereview.chromium.org/1748123003 Cr-Commit-Position: refs/heads/master@{#34627}
-
yangguo authored
The CharacterRange constructor checks the input for validity. However, CharacterRange::Singleton also uses the constructor and may have kEndMarker as input, causing the check to fail. The solution is to move the check to CharacterRange::Range and consistently use it across the code base. R=jkummerow@chromium.org BUG=chromium:593282 LOG=N Review URL: https://codereview.chromium.org/1776013003 Cr-Commit-Position: refs/heads/master@{#34626}
-
jkummerow authored
We have to do a Smi check on the frame marker, not just compare against a single frame type. BUG=chromium:593332 LOG=n TBR=danno@chromium.org Review URL: https://codereview.chromium.org/1777913002 Cr-Commit-Position: refs/heads/master@{#34625}
-
vogelheim authored
Revert of Rework CallApi*Stubs. (patchset #5 id:100001 of https://codereview.chromium.org/1748123003/ ) Reason for revert: Breaks Chromium. Original issue's description: > Rework CallApi*Stubs. > > - Eliminate stubs with a variable number of arguments. > (That only worked due to their very limited use. These > stubs' interface descriptors were basically lying > about their number of args, which will fail when used > generically.) > - Fix all CallApi*Stubs' interface descriptors to no > longer lie about their arguments. > - Unify CallApi*Stub, for * in Function, Accessor, > FunctionWithFixedArgs. > (Since these are now all doing the same thing.) > - Rename the unified stub (and interface descriptors) to > *ApiCallback*, since that's really what they're doing. > - Refuse inlining an API callback if its number of > parameters exceeds the supported number of args. > > BUG= > > Committed: https://crrev.com/d238b953a474272c0e3ea22ef6a9b63fa9729340 > Cr-Commit-Position: refs/heads/master@{#34614} TBR=danno@chromium.org,jkummerow@chromium.org,mstarzinger@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1775933005 Cr-Commit-Position: refs/heads/master@{#34624}
-
mbrandy authored
Avoid hard-coding fp offset to marker in StandardFrame::IterateCompiledFrame. R=danno@chromium.org, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1775193002 Cr-Commit-Position: refs/heads/master@{#34623}
-
ishell authored
Parallelize test/mjsunit/es6/tail-call-megatest.js in order to avoid timeouts on slow architectures. Review URL: https://codereview.chromium.org/1778663004 Cr-Commit-Position: refs/heads/master@{#34622}
-
titzer authored
R=ahaas@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1775353003 Cr-Commit-Position: refs/heads/master@{#34621}
-
jochen authored
I used a new category "v8.runtime" and all events are disabled by default, so there shouldn't be any perf impact. BUG=none R=fmeawad@chromium.org,cbruni@chromium.org Review URL: https://codereview.chromium.org/1770353002 Cr-Commit-Position: refs/heads/master@{#34620}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1780663002 Cr-Commit-Position: refs/heads/master@{#34619}
-
Ilija.Pavlovic authored
Implementation new test cases for conversion instructions Cvt_s_uw, Cvt_s_ul, Cvt_d_ul and truncate instructions Trunc_uw_s, Trunc_ul_s, Trunc_ul_d, Trunc_l_d, Trunc_l_ud, Trunc_w_d. TEST=cctest/test-macro-assembler-mips/cvt_s_w_Trunc_uw_s, others cctest/test-macro-assembler-mips64/Cvt_s_uw_Trunc_uw_s, others BUG= Review URL: https://codereview.chromium.org/1747863002 Cr-Commit-Position: refs/heads/master@{#34618}
-
titzer authored
R=verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/1778863002 Cr-Commit-Position: refs/heads/master@{#34617}
-
verwaest authored
If left or right is guaranteed at compile-time to be an undetectable object, use HIsUndetectableAndBranch on the other side. BUG= Review URL: https://codereview.chromium.org/1775163005 Cr-Commit-Position: refs/heads/master@{#34616}
-
jarin authored
BUG=chromium:592341 LOG=n Review URL: https://codereview.chromium.org/1776013002 Cr-Commit-Position: refs/heads/master@{#34615}
-
vogelheim authored
- Eliminate stubs with a variable number of arguments. (That only worked due to their very limited use. These stubs' interface descriptors were basically lying about their number of args, which will fail when used generically.) - Fix all CallApi*Stubs' interface descriptors to no longer lie about their arguments. - Unify CallApi*Stub, for * in Function, Accessor, FunctionWithFixedArgs. (Since these are now all doing the same thing.) - Rename the unified stub (and interface descriptors) to *ApiCallback*, since that's really what they're doing. - Refuse inlining an API callback if its number of parameters exceeds the supported number of args. BUG= Review URL: https://codereview.chromium.org/1748123003 Cr-Commit-Position: refs/heads/master@{#34614}
-
ishell authored
TBR=bmeurer@chromium.org BUG=v8:4698 LOG=N Review URL: https://codereview.chromium.org/1773173005 Cr-Commit-Position: refs/heads/master@{#34613}
-
hpayer authored
This CL allows the sweeper to free up all memory >= free list item size (3 words). This may reduce memory consumption (especially in map space), but may be worse for allocation order as soon as we start using the tiny category. This CL is just a first step in the right direction. A follow up CL will add customizable free list categories for each old space. BUG=chromium:587026 LOG=n Review URL: https://codereview.chromium.org/1774953003 Cr-Commit-Position: refs/heads/master@{#34612}
-