- 03 May, 2018 40 commits
-
-
Junliang Yan authored
This is a reland of dfdc3135 Original change's description: > PPC/s390: [interpreter] correctly advance over debug scaling prefixes. > > Port 7a07d74b > > R=yangguo@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com > BUG= > LOG=N > > Change-Id: I99553fde819cbdc8a12df5b82d9d7230ba4ef8b3 > Reviewed-on: https://chromium-review.googlesource.com/1042355 > Commit-Queue: Junliang Yan <jyan@ca.ibm.com> > Reviewed-by: Joran Siu <joransiu@ca.ibm.com> > Cr-Commit-Position: refs/heads/master@{#52970} Change-Id: I012e79ef5fbff37a8ded8c8cf5d4aaf324cd6ccb Reviewed-on: https://chromium-review.googlesource.com/1043026Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#52972}
-
Junliang Yan authored
This reverts commit dfdc3135. Reason for revert: <INSERT REASONING HERE> Original change's description: > PPC/s390: [interpreter] correctly advance over debug scaling prefixes. > > Port 7a07d74b > > R=yangguo@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com > BUG= > LOG=N > > Change-Id: I99553fde819cbdc8a12df5b82d9d7230ba4ef8b3 > Reviewed-on: https://chromium-review.googlesource.com/1042355 > Commit-Queue: Junliang Yan <jyan@ca.ibm.com> > Reviewed-by: Joran Siu <joransiu@ca.ibm.com> > Cr-Commit-Position: refs/heads/master@{#52970} TBR=yangguo@chromium.org,michael_dawson@ca.ibm.com,jyan@ca.ibm.com,joransiu@ca.ibm.com Change-Id: I04fadaa81a6dd124811c002ab4ffa61e3785b717 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1043025Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#52971}
-
Junliang Yan authored
Port 7a07d74b R=yangguo@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I99553fde819cbdc8a12df5b82d9d7230ba4ef8b3 Reviewed-on: https://chromium-review.googlesource.com/1042355 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
-
Junliang Yan authored
Port ab9e0124 Original Commit Message: Original CL: https://crrev.com/c/1018468 During code generation, we generate self-references (i.e. references to the Code object currently being generated) as references to a temporary handle. When the final Code object has been allocated, the handle's location is fixed up and RelocInfo iteration fixes up all references embedded in the generated code. This adds support for this mechanism to the builtins constants table builder. CodeObject() is now a new handle pointing to a dedicated self-reference marker in order to distinguish between self-references and references to undefined. In Factory::NewCode, we patch up the constants table. R=jgruber@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Iba0f4435125b9d6c3fda7fc3e9836494b6eb6f45 Reviewed-on: https://chromium-review.googlesource.com/1042216Reviewed-by:
-
Junliang Yan authored
Port a9db2c74 R=marja@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:5402,v8:7570 LOG=N Change-Id: Ife3c7463066eb747c27c1479c76106b51e568f92 Reviewed-on: https://chromium-review.googlesource.com/1042451Reviewed-by:
-
Camillo Bruni authored
This is a preparatory CL to find a potential regression on x86. Bug: chromium:835558 Change-Id: I3859b59d1497d4b7447ad38ee352cf4bbdeb4502 Reviewed-on: https://chromium-review.googlesource.com/1027842 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#52967}
-
Michael Achenbach authored
TBR=santa Change-Id: I3841ddfd3de67dfe7f18d4f0d36c68d8b83da651 Reviewed-on: https://chromium-review.googlesource.com/1042574Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52966}
-
Bill Budge authored
- Separates measuring from wasm::SerializeNativeModule so caller can allocate or reserve the buffer memory. Call site thus avoid one unnecessary copy. Bug: chromium:719007 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I50412c0c0279114dcdc1aead810ad39e7c4e2a6e Reviewed-on: https://chromium-review.googlesource.com/1039183 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#52965}
-
Vincent Belliard authored
Bug: v8:6600 Change-Id: I1d8447349f73985653d3124c2b76d8756b0bf30a Reviewed-on: https://chromium-review.googlesource.com/1040673 Commit-Queue: Vincent Belliard <vincent.belliard@arm.com> Reviewed-by:
-
Vincent Belliard authored
Define and use TurboAssembler::AssertUnreachable Bug: v8:6600 Change-Id: I6901896ea4fd7e0fe24dd76a1afbb409a24a2994 Reviewed-on: https://chromium-review.googlesource.com/1040766 Commit-Queue: Vincent Belliard <vincent.belliard@arm.com> Reviewed-by:
-
Vincent Belliard authored
Bug: v8:6600 Change-Id: I9e4b4770286cb08e83dd5dbf9b5ae5cfd7d4d411 Reviewed-on: https://chromium-review.googlesource.com/1040649 Commit-Queue: Vincent Belliard <vincent.belliard@arm.com> Reviewed-by:
-
Vincent Belliard authored
Bug: v8:6600 Change-Id: If52fd4600c178354cb0631d062be71d19cc10a89 Reviewed-on: https://chromium-review.googlesource.com/1040669 Commit-Queue: Vincent Belliard <vincent.belliard@arm.com> Reviewed-by:
-
jgruber authored
Temporarily skip this test until it can be fixed. TBR=machenbach@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7718 Change-Id: I04b6c47b72ed041b2b22669187b8afbcc0c05ff6 Reviewed-on: https://chromium-review.googlesource.com/1042398 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#52960}
-
Vincent Belliard authored
Bug: v8:6600 Change-Id: Ia494d7fefee2dc6ae6f31ea73e35c0921953c2c0 Reviewed-on: https://chromium-review.googlesource.com/1040666 Commit-Queue: Vincent Belliard <vincent.belliard@arm.com> Reviewed-by:
-
Camillo Bruni authored
This should reduce the probability of running out of stack space while logging a fatal error message. Additionally this CL distinguishes the error OOM error message when there is no isolate available on the background thread. Bug: chromium:839166 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I17e929f322dda20127fbf86a6154af5460e53490 Reviewed-on: https://chromium-review.googlesource.com/1041964Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#52958}
-
Hannes Payer authored
Bug: chromium:829771 Change-Id: I9e71e6cbba347dd6951e5415332e5178df9b5122 Reviewed-on: https://chromium-review.googlesource.com/1041685 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
{kCopiedStub} is not used any more since https://crrev.com/c/1012024. R=mstarzinger@chromium.org Change-Id: Idb0049f7d0bb0215cef902daba49591596f93668 Reviewed-on: https://chromium-review.googlesource.com/1042225Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#52956}
-
Benoît Lizé authored
As with other code size stats, this doesn't distinguish between live and dead objects, and doesn't scan the young generation. Also make ExternalString::is_short() const. Bug: chromium:837659 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I72815edb719ba61d9727e226ff1da0fc4af22a24 Reviewed-on: https://chromium-review.googlesource.com/1032994 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#52955}
-
Bill Budge authored
Change-Id: I6bc23527f63e86ecde228c85d499c55278ff555e Reviewed-on: https://chromium-review.googlesource.com/1041949 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
-
Ben L. Titzer authored
R=clemensh@chromium.org CC=ahaas@chromium.org Change-Id: Ibcbc5e43e7095d9783f49ad2c3f27338100c4fdf Reviewed-on: https://chromium-review.googlesource.com/1039489 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
-
Toon Verwaest authored
There are likely cleanups that can be done after this CL: - context-related functions in the interpreter and compiler take ScopeInfo as well as ScopeType and slot-count as input. The latter 2 should be directly derived from the former. We should be able to drop FunctionContextParameters. - ContextExtension is probably not needed anymore, since we now always have the correct scope_info directly in the SCOPE_INFO_INDEX slot. Bug: v8:7066 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie1f6134c686a9f2183e54730d9cdd598a9e5ab67 Reviewed-on: https://chromium-review.googlesource.com/785151 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Marja Hölttä authored
BUG=v8:7490 Change-Id: I10f5339f3d7e634934d59d744334a045276fbed6 Reviewed-on: https://chromium-review.googlesource.com/1041906Reviewed-by:
-
Michael Achenbach authored
This reverts commit c32f6614. Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/20563 Original change's description: > [logging] Remove unused code > > This removes unused mutex, headers from log.(h|cc). > > Change-Id: Ie4dc69a7efa9494b21ff6e2b19828bd740e3a47c > Reviewed-on: https://chromium-review.googlesource.com/1041967 > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52946} TBR=jarin@chromium.org,cbruni@chromium.org Change-Id: I48b63c7fc6a10e118b735f708db37d353ba6c0f7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1041969Reviewed-by:
-
Michael Achenbach authored
This reverts commit a0c57368. Reason for revert: Speculative revert due to failures with custom snapshot: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/19061 Local bisect also points to this change: http://shortn/_IhVxU2FKLu Original change's description: > [wasm] Maintain link from Instance to Module. > > This moves the link from a {WasmInstanceObject} to its corresponding > {WasmModuleObject} into the right place and also makes it strong. This > ensures that an instance always keeps the underlying module alive and > hence removes the situation of an "orphaned instance". > > R=clemensh@chromium.org > > Change-Id: Id59f6a49740af8ef0248679c3d2c696bb9776944 > Reviewed-on: https://chromium-review.googlesource.com/1041691 > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52942} TBR=mstarzinger@chromium.org,clemensh@chromium.org Change-Id: I1830e6ce14314f06f918a0c428182bfd68354ad9 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1041968Reviewed-by:
-
Hannes Payer authored
Bug: chromium:999634 Change-Id: Ia7a0dd6ddc2477a7656a26548e9a247470d9143f Reviewed-on: https://chromium-review.googlesource.com/1041688 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Daniel Clifford authored
This is a preparatory step for implementing generics. Along the way, clean up and encapsulate a bunch of code, including: * Fully encapsulate Scope by adding the new class ScopeChain that provide an abstraction for creating and activating scopes. * Untangle Modules and Scopes. * Unify scope activation so that it is always associated with an AST node and triggered by a RAII helper class. * Unify (somewhat) how builtins and macros are created, fixing a few inconsistencies with when and how parameters and their types are declared. * Create a new Declarations class that brokers between the visitor classes and the ScopeChain. This moves handling of declaration-related errors out of the visitors but also makes it possible to do so without polluting Scope and ScopeChain with details about resolving SourcePositions in error cases. Change-Id: I180017d4cf39ccf5ef1d20b84f53284c252f8d87 Reviewed-on: https://chromium-review.googlesource.com/1038504 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#52947}
-
Jaroslav Sevcik authored
This removes unused mutex, headers from log.(h|cc). Change-Id: Ie4dc69a7efa9494b21ff6e2b19828bd740e3a47c Reviewed-on: https://chromium-review.googlesource.com/1041967Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#52946}
-
Michael Achenbach authored
TBR=santa NOTREECHECKS=true Change-Id: Ia141585c57407b98140ca49cb75f0bc966da8c8c Reviewed-on: https://chromium-review.googlesource.com/1041966 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This reverts commit 40f1aaf3. Reason for revert: https://luci-milo.appspot.com/buildbot/client.v8/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/21000 Original change's description: > [heap] Mark RO_SPACE as read-only after deserialization > > Adds MarkAsReadOnly and MarkAsReadWrite to ReadOnlySpace. The latter > is only usable with ReadOnlySpace::WritableScope to avoid the space > being left writable). MarkAsReadOnly updates the high water mark and > makes several previously mutating methods into no-ops. > > Moves some writes to immutable objects out of the bootstrapper to > setup-heap-internal so they don't write to a read-only page. > > Also avoid writing hashes to strings that already have the value set as > that invariably means writing to the "0" and "1" constant strings in > RO_SPACE. > > Before serialization, it makes RO_SPACE writable again so that any > padding can be cleared before writing it. > > Bug: v8:7464 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: I22edc20dba7dde8943991a8fcaf87244af4490a3 > Reviewed-on: https://chromium-review.googlesource.com/1014128 > Commit-Queue: Dan Elphick <delphick@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52943} TBR=yangguo@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,delphick@chromium.org Change-Id: Id4770c0fdb21cd9eea2f62a019f44a6bdea8f0a7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7464 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1041948Reviewed-by:
-
Dan Elphick authored
Adds MarkAsReadOnly and MarkAsReadWrite to ReadOnlySpace. The latter is only usable with ReadOnlySpace::WritableScope to avoid the space being left writable). MarkAsReadOnly updates the high water mark and makes several previously mutating methods into no-ops. Moves some writes to immutable objects out of the bootstrapper to setup-heap-internal so they don't write to a read-only page. Also avoid writing hashes to strings that already have the value set as that invariably means writing to the "0" and "1" constant strings in RO_SPACE. Before serialization, it makes RO_SPACE writable again so that any padding can be cleared before writing it. Bug: v8:7464 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I22edc20dba7dde8943991a8fcaf87244af4490a3 Reviewed-on: https://chromium-review.googlesource.com/1014128 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This moves the link from a {WasmInstanceObject} to its corresponding {WasmModuleObject} into the right place and also makes it strong. This ensures that an instance always keeps the underlying module alive and hence removes the situation of an "orphaned instance". R=clemensh@chromium.org Change-Id: Id59f6a49740af8ef0248679c3d2c696bb9776944 Reviewed-on: https://chromium-review.googlesource.com/1041691Reviewed-by: -
Marja Hölttä authored
Restores some sensemaking properties, such as making src/machine-type.h (lower level header) independent of src/zone/zone.h (higher level header). BUG=v8:7490 Change-Id: Ibc6e5c7a75e4aaf917d086cf70267abc7ee9a9b0 Reviewed-on: https://chromium-review.googlesource.com/1039586Reviewed-by:
-
Ben L. Titzer authored
R=mstarzinger@chromium.org Change-Id: I57ff09601a9e84cc5b53ff06a446b7dfc3c026b2 Reviewed-on: https://chromium-review.googlesource.com/1032742Reviewed-by:
-
Clemens Hammacher authored
Now that wasm-linkage.h is split off, we can easily implement {MoveToReturnRegister} in platform independent code. R=titzer@chromium.org Bug: v8:6600 Change-Id: I072a0ee48d58ed29e0df489016f838915c3f2cb2 Reviewed-on: https://chromium-review.googlesource.com/1041690 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#52939}
-
Michael Achenbach authored
NOTRY=true Bug: chromium:830557 Change-Id: Iccd9a6e586d388c55382dd0fbb51d2b62922b8c5 Reviewed-on: https://chromium-review.googlesource.com/1041689 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#52938}
-
Simon Zünd authored
This CL changes how TypedArray.p.sort is implemented in Torque, mainly to address the binary memory size of the builtin. With this CL the memory comes down from 53611 to 4215 (as reported by --print-builtin-size on a x64.release build). With the following performance impact on the relevant benchmarks: Benchmark Original (JS) Torque (initial) This CL IntTypes 83.9 263.7 202.3 BigIntTypes 32.1 54.6 47.2 FloatTypes 99.3 138.7 109.3 This is achieved by pushing the Load/Store dispatch based on the elements kind into separate builtins that are executed for each load/store. This results in only one version of the sorting algorithm instead of one version per elements kind. R=jgruber@chromium.org Bug: chromium:837282 Change-Id: I7fe2da3cbfd01531d070128126a0d56d3dd6bdcc Reviewed-on: https://chromium-review.googlesource.com/1033744 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
-
Dan Elphick authored
Removes unused parameter from CommitBlock and CommitMemory functions. Change-Id: I4b79c1802060f1f70e06fd39532758fcdae2bead Reviewed-on: https://chromium-review.googlesource.com/1039830Reviewed-by:
-
jgruber authored
With the exception of the InterpreterEntryTrampoline, all builtins are now isolate-independent and can be embedded into the binary. This CL updates the corresponding list and also contains a few smallish tweaks to support having these builtins off the heap: * wasm: copy the off-heap builtin, not its trampoline. * Code::contains: support off-heap builtins. * JSFunction::is_compiled: compare builtin index instead of identity (this is relevant during mksnapshot when we transition from the on-heap builtin to its off-heap representation + the trampoline). * Remove old DCHECKs. * A few tweaks in macro-assembler ports that have snuck in recently. Bug: v8:6666 Change-Id: Iabf5b47ade3826a4da35b6b75a4e61614f0158b0 Reviewed-on: https://chromium-review.googlesource.com/1032777 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Michaël Zasso authored
Add an include of stdlib.h for the abort function. Compilation fails on FreeBSD without it. See Node.js issue: https://github.com/nodejs/node-v8/issues/56 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I67ac21fdc9bc1072d5aaf4f7180dcf4000a938c9 Reviewed-on: https://chromium-review.googlesource.com/1039705Reviewed-by:
-
Yang Guo authored
R=leszeks@chromium.org, ulan@chromium.org Bug: chromium:835973 Change-Id: I35600e1da60bb6cd3b87cd1573791355e310aa9c Reviewed-on: https://chromium-review.googlesource.com/1032430 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#52933}
-
