1. 09 Sep, 2020 5 commits
  2. 08 Sep, 2020 32 commits
  3. 07 Sep, 2020 3 commits
    • Andreas Haas's avatar
      [wasm][liftoff] Emit safepoints for externref values on the stack · 10348e8e
      Andreas Haas authored
      With this CL we emit safepoint maps for externref values on the Liftoff
      value stack. With that there is support for externref parameters and
      locals in Liftoff, as well as for intermediate values of type
      externref.
      
      R=thibaudm@chromium.org
      
      Bug: v8:7581
      Change-Id: I2df0a8d00b2da33fe06ff474b039cca4c7be726d
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2387571
      Commit-Queue: Andreas Haas <ahaas@chromium.org>
      Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#69725}
      10348e8e
    • Thibaud Michaud's avatar
      [wasm] Scan stack in foreground code GC · 40ce9f70
      Thibaud Michaud authored
      When a WasmGCForegroundTask starts during runMessageLoopOnPause, the
      stack may contain Wasm code. In this case we need to scan the stack to
      report live code.
      
      This is already caught by some tests when RemoveBreakpoint is
      implemented correctly, which will be done in a separate CL, so no
      regression test is added here.
      
      R=clemensb@chromium.org
      
      Bug: v8:10337
      Change-Id: I308145b9c2cf69f0100853be47ec9e30ce79a876
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2379510Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
      Commit-Queue: Thibaud Michaud <thibaudm@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#69724}
      40ce9f70
    • Clemens Backes's avatar
      [wasm] Fix check for committing over the global limit · 1a3cc643
      Clemens Backes authored
      If we generate more code than allowed by the --wasm-max-code-space flag,
      the {WasmCodeManager::Commit} method will fail (via fatal error). The
      DCHECK that was placed before that call checked for a related condition
      though, and failed before the {Commit} method could fail.
      By moving it after the call, we fix this issue.
      
      Adding a test case for this seems to be involved, since that test would
      crash the whole process (because of the fatal error). So it would have
      to be a unittest such that we can use ASSERT_DEATH_IF_SUPPORTED. In
      unittests though we don't yet have the infrastructure to create a
      NativeModule (needed for the WasmCodeAllocator). Alternatively we could
      add special testing methods (and a constructor) to the
      WasmCodeAllocator, but I do not consider this worth the effort for this
      little fix.
      
      R=thibaudm@chromium.org
      
      Bug: chromium:1124646
      Change-Id: Ief09dfbd0a5b0b040fe9cf8a34e458d1d01dfacc
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2390754
      Auto-Submit: Clemens Backes <clemensb@chromium.org>
      Commit-Queue: Thibaud Michaud <thibaudm@chromium.org>
      Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#69723}
      1a3cc643