- 09 Apr, 2018 22 commits
-
-
Deepti Gandluri authored
Bug: v8:6532 Change-Id: I3840df75b745790aaa7e9dec7188adccc70627ce Reviewed-on: https://chromium-review.googlesource.com/998838Reviewed-by:
Ben Smith <binji@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Martyn Capewell <martyn.capewell@arm.com> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#52484}
-
Clemens Hammacher authored
This fixes a deadlock related to throttling: It can happen that all background tasks detect that they should not produce more work because of throttling (!CanAcceptWork()). Reducing the number of running background tasks is done in a later step (OnBackgroundTaskStopped). If the finisher task finishes all outstanding units between these two calls, it will not schedule another background compilation task, but all background compilation tasks will quit, hence compilation will never finish. Fixing this should allow us to reenable the 'wasm-finish-compilation' test: https://crrev.com/c/999632 R=ahaas@chromium.org Bug: chromium:824681 Change-Id: I967e4d6b2917d369dd49bb80ce4bef552d10b371 Reviewed-on: https://chromium-review.googlesource.com/1002174 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#52483}
-
Clemens Hammacher authored
Throttling of background compilation tasks is enabled in all paths anyway (async compilation, parallel compilation). Hence remove the bool to control that. R=ahaas@chromium.org Change-Id: Id5d4de38d22e1eb63c8864f41c219f4dd28429e0 Reviewed-on: https://chromium-review.googlesource.com/1002814 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
CompilationState had three different mutexes, plus two atomic fields. Not holding the right mutexes at the right time has already led to failures. Hence, only use a single mutex to protect all shared state of the CompilationState. R=ahaas@chromium.org Bug: chromium:824681 Change-Id: I2c414f3ddb75e82944621590493fadcbbdfb781c Reviewed-on: https://chromium-review.googlesource.com/1000783Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: Ib399e6beb1f643ed58d46a19fcaa0e9bf44ba2ea Reviewed-on: https://chromium-review.googlesource.com/998161Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#52480}
-
Sigurd Schneider authored
This CL ensures that the frame pointer register is set to the innermost frame for builtin continuations. To make this work, this CL contains a temporary fix for NotifyDeoptimized, which needs to skip these frames in order to obtain a valid JavaScript context. Bug: v8:7584, v8:7639 Change-Id: I8ea318e5441950fdf45d909e1f3ee649daf38dca Reviewed-on: https://chromium-review.googlesource.com/1001899Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#52479}
-
Sigurd Schneider authored
This CL adds a forced GC point in Deoptimizer::MaterializeHeapObjects, which will catch problems with deoptimized frames early and improve reproducibility. Bug: v8:7584 Change-Id: Idfad584e821b777542cf8fce673a9080c64d5d7b Reviewed-on: https://chromium-review.googlesource.com/1002655Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I51e4210334a50ebb9ed7172c112083d6c3d784d9 Reviewed-on: https://chromium-review.googlesource.com/1000776Reviewed-by:
-
Sigurd Schneider authored
For BuiltinContinuationFrames we stored the frame-height as a plain value, which did not cause problems because height (in bytes) always looks like a Smi to the GC. This CL introduces proper Smi encoding. Bug: v8:7584 Change-Id: I5e3c41c2e576926bbb2bad7dbe0f277cc017b495 Reviewed-on: https://chromium-review.googlesource.com/1000782Reviewed-by:
-
Clemens Hammacher authored
std::unique_ptr should never be passed by rvalue reference. This is also not allowed by our style guide. Instead, just pass it by value. R=ahaas@chromium.org Bug: v8:7570 Change-Id: I525d3b4fd88e6ea47b22a517714a713dbb711ef8 Reviewed-on: https://chromium-review.googlesource.com/999419Reviewed-by:
-
Clemens Hammacher authored
R=ahaas@chromium.org Bug: v8:7570 Change-Id: Ib21d96e2b91cac118c79f2969c9fb0d9c80701fe Reviewed-on: https://chromium-review.googlesource.com/1002175Reviewed-by:
-
jgruber authored
Builtins::IsOffHeapSafe is unused now that embedded builtins are shipped in the snapshot. A longer explanation: there used to be a difference between IsOffHeapSafe and IsIsolateIndependent back at an earlier stage when we still copied off-heap-safe builtins off the heap on isolate startup. At that point, off-heap builtins didn't need to be isolate-independent, e.g. they could still contain embedded external references. Now that embedded builtins are shipped in the snapshot, this distinction is no longer needed. Bug: v8:6666 Change-Id: I0be6120b94b01480262f472f0904ea9037941e2a Reviewed-on: https://chromium-review.googlesource.com/1002652Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#52473}
-
Michael Achenbach authored
NOTRY=true NOTREECHECKS=true TBR=sergiyb@chromium.org Bug: v8:7339 Change-Id: Ie408680f3185f58cd023dcfdb14565e49c28ad0c Reviewed-on: https://chromium-review.googlesource.com/1002559Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52472}
-
Kim-Anh Tran authored
The prologue checks if optimized code exists, and if not, continues execution of the current function. Otherwise, it jumps to the address specified in the native module's code_table. Also-by: clemensh@chromium.org Change-Id: If3e76de02115f44ab7758590a949c3f0965a11ca Reviewed-on: https://chromium-review.googlesource.com/985837 Commit-Queue: Kim-Anh Tran <kimanh@google.com> Reviewed-by:
-
Peter Marshall authored
We hardcoded this accidentally in the original CL for the turbofan case, instead we need to call JSConstructStubGeneric() which will return the correct construct stub based on the harmony_restrict_constructor_return flag. Bug: chromium:829899 Change-Id: I6776a5daebd57d8881d926ad68595141312a877d Reviewed-on: https://chromium-review.googlesource.com/1001893Reviewed-by:
-
Simon Zünd authored
Also removes the JS constructor. R=jgruber@chromium.org Bug: v8:7624 Change-Id: I33493ab2fafb35f95fb1822d46d3f249568c0a56 Reviewed-on: https://chromium-review.googlesource.com/999534 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#52469}
-
Andreas Haas authored
R=titzer@chromium.org Bug: v8:7581 Change-Id: Ib100a45ad51ec6b6a0400cfe97fe918089c04ead Reviewed-on: https://chromium-review.googlesource.com/998095 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#52468}
-
Vlad Tsyrklevich authored
Replace direct calls to generated code with calls using GeneratedCode to match the rest of v8. BUG=v8:7164 Change-Id: I5d90bcb6e90d99e105be18886d4844b83f611b95 Reviewed-on: https://chromium-review.googlesource.com/1000416Reviewed-by:
-
jgruber authored
Remaining tests also lead to OOM, skip all of them on tsan stress modes. Bug: v8:7626 Change-Id: Ie2c128b9a718c7c34c974e628ba60e5549ea04fc Reviewed-on: https://chromium-review.googlesource.com/1002552 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
Currently a WeakMap key edge shows up as '<id> / WeakMap'. This patch changes it to '<id> / key <KeyName> in WeakMap'. Bug: chromium:827713 Change-Id: I0306bacdc331ab69739be88cf29d16a21187625f Reviewed-on: https://chromium-review.googlesource.com/992035Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#52465}
-
Michael Achenbach authored
Bug: chromium:653569 Change-Id: I2fa288d3281c75d3e5d483fb94d29efe454c633b Reviewed-on: https://chromium-review.googlesource.com/1000773Reviewed-by:
-
Hannes Payer authored
Bug: chromium:829771 Change-Id: Ia3b6221cdc54c5102760665076f1cb2541d16fb4 Reviewed-on: https://chromium-review.googlesource.com/999634Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
- 08 Apr, 2018 1 commit
-
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/30e8660..6ae4520 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5361d68..1e3e74d TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I5055341de21a09bc3dd221b52b8d655221b0c654 Reviewed-on: https://chromium-review.googlesource.com/1001652Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#52462}
-
- 07 Apr, 2018 1 commit
-
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d1cd744..30e8660 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/aaeb23e..5361d68 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/cd83d95..d7c36b0 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I2f99649c97e5e83616822d442c60bcbd1ca9e9b9 Reviewed-on: https://chromium-review.googlesource.com/1000489Reviewed-by:
-
- 06 Apr, 2018 16 commits
-
-
Daniel Clifford authored
Currently these new functions are unused and untested, but will be used once Torque is checked in. They are split off into this separate CL to ease rollback of Torque if required. Change-Id: If2b96f342011592ae7cd88a4f6d9a4f2acc3643e Reviewed-on: https://chromium-review.googlesource.com/998171 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#52460}
-
Eric Holk authored
Bug: v8:5277 Change-Id: I47ad0b7dbd9471e350b7aa1b6dd5ad122b97021a Reviewed-on: https://chromium-review.googlesource.com/990239Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#52459}
-
Myles Borins authored
A DCHECK in TimeTicks::HighResolutionNow was replaced with a warning to stop systems from crashing. This warning broke parts of the Node.js test-suite on certain systems. The warning has been replaced with a comment documenting this situation and a TODO to ensure we don't lose track of this code path. Bug: v8:7617 Bug: chromium:809016 Change-Id: I5e3af8c31817291d264af861514f34e3e1af9af2 Reviewed-on: https://chromium-review.googlesource.com/997153Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Myles Borins <mborins@google.com> Cr-Commit-Position: refs/heads/master@{#52458}
-
Clemens Hammacher authored
Replace all uses with V8_WARN_UNUSED_RESULT. WARN_UNUSED_RESULT was defined in src/base/compiler-specific.h, which includes include/v8config.h, which already defined V8_WARN_UNUSED_RESULT. R=mstarzinger@chromium.org Bug: v8:7570 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I662072294605036ca5aa0c8fdaa0218ac5d95f23 Reviewed-on: https://chromium-review.googlesource.com/998893Reviewed-by:
-
Michael Achenbach authored
NOTRY=true TBR=hablich@chromium.org Bug: v8:7632 Change-Id: I42e6b3f3585c8a98750ac39de06934174f2a2fa4 Reviewed-on: https://chromium-review.googlesource.com/999417Reviewed-by:
-
Daniel Clifford authored
Change-Id: If2a207d97b16bd74c2fd75e2ad9be1ecc921f492 Reviewed-on: https://chromium-review.googlesource.com/998169Reviewed-by:
-
Leszek Swirski authored
Merge the outer_scope_info and feedback_metadata fields on SharedFunctionInfo. outer_scope_info is only used during parsing, and feedback_metadata is only available after compilation, so the two never exist at the same time. Thus, they can share a field slot. The exception is un-compiling and re-compiling a function, where we need the outer_scope_info again. Fortunately, the outer_scope_info can be re-calculated from the SFI's scope_info. Bug: v8:7606 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I6b97fefe859e89df75ad870da4a0bfa4b869772a Reviewed-on: https://chromium-review.googlesource.com/992432Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#52454}
-
jgruber authored
Bug: v8:7626 Change-Id: Ifd6908941b7bc62357c3577bea4a097c45903129 Reviewed-on: https://chromium-review.googlesource.com/998167Reviewed-by:
-
Alexey Kozyatinskiy authored
This is a reland of 0340874b Original change's description: > [debug] add runtime side effect check for StaCurrentContextSlot > > R=yangguo@chromium.org > > Bug: v8:7588 > Change-Id: If78f6dd460c7423923800a98d44520c1bf71663c > Reviewed-on: https://chromium-review.googlesource.com/996236 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52398} Bug: v8:7588 Change-Id: Ife6b039ea3291103a54ae04c3007fe4610371c3f Reviewed-on: https://chromium-review.googlesource.com/998801Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#52452}
-
Clemens Hammacher authored
The maximum number of background tasks to spawn can be computed right in the constructor of the CompilationState, and is constant afterwards. Additionally, we ensure to never start more background tasks than the number of available compilation units. R=ahaas@chromium.org Change-Id: I430e9a28a0bd15166ed05d120782f182d10c3e44 Reviewed-on: https://chromium-review.googlesource.com/997652 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Ben L. Titzer authored
R=mstarzinger@chromium.org Bug: v8:7424 Change-Id: I5a854d334957c285eebe850024c25d1cdcf71f7f Reviewed-on: https://chromium-review.googlesource.com/995772 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
-
Junliang Yan authored
Port b158bfdc Original Commit Message: This is a reland of 63ecddc8 Original change's description: > [runtime] Remove the construct_stub field of the SFI > > Don't dispatch based on the construct_stub field anymore. Rather than > read it out and jump to the construct stub, we can switch on the > builtin_id. > > Builtins will always have builtin_id as a Smi, so this signals we need > to jump to JSBuiltinsConstructStub. The only exception is for uncompiled > functions, which will have kCompileLazy as the builtin_id, but need to > jump to the generic stub instead. > > API function calls will have a FunctionTemplateInfo in the SFI > function_data field, and need to go to the builtins stub as well. > > The final case is everything else, which should go to the generic stub. > > Bug: v8:7503 > Change-Id: I14790a5f9784dc0d940bf10a05f5310026e1d482 > Reviewed-on: https://chromium-review.googlesource.com/980941 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52345} R=petermarshall@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I53d92ea7326c5a0ffec25eef0972cdeb659848b6 Reviewed-on: https://chromium-review.googlesource.com/998018Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Reviewed-by:
-
Igor Sheludko authored
1) Add exit point parameter to EmitGenericPropertyStore(), 2) carve TryLookupPropertyInSimpleObject() out of TryLookupProperty(). Bug: v8:5988 Change-Id: I6cef48731c27e5bb72dce5eaa0169fbf59787ed7 Reviewed-on: https://chromium-review.googlesource.com/997747Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#52448}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/647f86b..d1cd744 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/3748a2a..10d701f Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b1c9ad5..aaeb23e Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/82ac1c9..cd83d95 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ib6e4745827cc54412062558c1f7272fc56143518 Reviewed-on: https://chromium-review.googlesource.com/999329 Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... in favor of SelectConstant(). Bug: chromium:829679 Change-Id: Ic7cc887254b4f6b29339b06c5782d71f77d3c9a5 Reviewed-on: https://chromium-review.googlesource.com/999601Reviewed-by:
-
Clemens Hammacher authored
If --wasm-num-compilation-tasks is set to 0, we spawn all background tasks as foreground tasks. Semantically, they are still treated like background tasks, but they will execute interleaved with the foreground tasks. This should not deadlong since all foreground tasks eventually return to the event loop. R=ahaas@chromium.org Bug: chromium:829681 Change-Id: Id57cbb10157c085acd57a3d30a0a43c824a64591 Reviewed-on: https://chromium-review.googlesource.com/999594Reviewed-by:
-
