- 17 Sep, 2018 22 commits
-
-
Benedikt Meurer authored
The computation to find the hash entry is already performed on Word64, and the actual value access later is also performed on Word64 indices, so there's no point to go to Word32 in between. Bug: v8:8015, v8:8178 Change-Id: I160e02166beceb79dcc8e69f9c365871a4c42606 Reviewed-on: https://chromium-review.googlesource.com/1226648Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55950}
-
Michael Lippautz authored
Abort incremental marking pulls in the requirement to also be able to abort on the embedder side. In practice, aborting is never really needed and the GC should just finalize the existing collection and do an atomic followup if exact marking information is required. Bug: chromium:843903 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ic471332d01b0c4be26b71a06248af03255c61a9d Reviewed-on: https://chromium-review.googlesource.com/1225705Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#55949}
-
Georg Neis authored
Also properly implement MapRef::GetInObjectPropertyOffset. Bug: v8:7790 Change-Id: I3e73247df67b7c40336b6c685b784dbf9e542340 Reviewed-on: https://chromium-review.googlesource.com/1226977 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#55948}
-
Clemens Hammacher authored
VirtualMemory objects can be moved since https://crrev.com/c/1213062, so there is no need any more to return them via pointer argument. This also makes the {AllocVirtualMemory} and {AlignedAllocVirtualMemory} functions superfluous. R=ishell@chromium.org, titzer@chromium.org Bug: v8:8015 Change-Id: Id72921e1c66a6c10be6647194603b8283e010e24 Reviewed-on: https://chromium-review.googlesource.com/1226972Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55947}
-
Marja Hölttä authored
It's the same as BytecodeArray::BodyDescriptor. BUG=v8:7308 Change-Id: I3821108cc6cc577261ce58cd034e21dfbe2c3c87 Reviewed-on: https://chromium-review.googlesource.com/1227126Reviewed-by:
-
Georg Neis authored
Bug: v8:7790 Change-Id: I993d04e6ca6b8986749bb3782113ef928952995b Reviewed-on: https://chromium-review.googlesource.com/1226975 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: If115a71b1c57eecdec7c57d3613a4f0bd90f2e66 Reviewed-on: https://chromium-review.googlesource.com/1226791Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55944}
-
Benedikt Meurer authored
For NumberAdd/Subtract/Multiply we currently onlt consult the upper bound to decide whether to compute using Int32 or Float64 operations, whereas for NumberModulus, NumberEqual, etc. we do decide based on the feedback types, where the only significant difference is that we cannot promise Word32 truncations on the inputs. This change unifies the handling for NumberAdd/Subtract/Multiply as well, which triggers surprisingly often in our core benchmark suites.. Bug: v8:8015 Change-Id: If8ec1bc82d1e1b71285c829262a0d343a4eb2af7 Reviewed-on: https://chromium-review.googlesource.com/1226033 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Leszek Swirski authored
This reverts commit a4105a43. Reason for revert: GC stress failures (https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Mac64%20GC%20Stress/3097) Original change's description: > [wasm] Implement handling of exported/imported exceptions. > > This implements the proper semantics for matching exported/imported > exceptions by using the notion of an "exception tag" that is global to > the system. It can be used to match exceptions in one module against > exceptions declared and/or thrown in another module (or instance). > > R=clemensh@chromium.org > TEST=mjsunit/wasm/exceptions-shared > BUG=v8:8091 > > Change-Id: I37586d7be5d5e6169b3418dfbc415b26dd4750dd > Reviewed-on: https://chromium-review.googlesource.com/1226976 > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55940} TBR=mstarzinger@chromium.org,clemensh@chromium.org Change-Id: I5ef19ea3b67f470f2d7807810110d75415ba9ed6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8091 Reviewed-on: https://chromium-review.googlesource.com/1227933Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#55942}
-
Marja Hölttä authored
BodyDescriptorWeak is not needed for all classes. For the classes it's needed it's referred to explicitly (Foo::BodyDescriptorWeak::IterateBody()). BUG=v8:7308 Change-Id: If8591929cd588575e88f3d6f116ec2cac4941e8f Reviewed-on: https://chromium-review.googlesource.com/1226649Reviewed-by:
-
Michael Starzinger authored
This implements the proper semantics for matching exported/imported exceptions by using the notion of an "exception tag" that is global to the system. It can be used to match exceptions in one module against exceptions declared and/or thrown in another module (or instance). R=clemensh@chromium.org TEST=mjsunit/wasm/exceptions-shared BUG=v8:8091 Change-Id: I37586d7be5d5e6169b3418dfbc415b26dd4750dd Reviewed-on: https://chromium-review.googlesource.com/1226976 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55940}
-
Georg Neis authored
... as well as ScopeInfo::ContextLength. Bug: v8:7790 Change-Id: I3ca8b6f252d96b21d0990f8fc08e076eeeea4176 Reviewed-on: https://chromium-review.googlesource.com/1226973 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I5164899da0994a855182ed203572c5984ab87449 Reviewed-on: https://chromium-review.googlesource.com/1227070Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55938}
-
Benedikt Meurer authored
This change introduces the necessary conversion operators to convert from Word64 to other representations (Tagged, Word32, Float64, etc.), and plugs in the Word64 representation for NumberAdd/NumberSubtract, such that TurboFan will go to Int64Add/Sub on 64-bit architectures when the inputs and the output of the operation is in safe integer range. This includes the necessary changes to the Deoptimizer to be able to rematerialize Int64 values as Smi/HeapNumber when going back to Ignition later. This change might affect performance, although measurements indicate that there should be no noticable performance impact. The goal is to have TurboFan support Word64 representation to a degree that changing the TypedArray length to an uint64_t (for 64-bit archs) becomes viable and doesn't have any negative performance implications. Independent of that we might get performance improvements in other areas such as for crypto code later. Bug: v8:4153, v8:7881, v8:8171, v8:8178 Design-Document: bit.ly/turbofan-word64 Change-Id: I29d56e2a31c1bae61d04a89d29ea73f21fd49c59 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel Reviewed-on: https://chromium-review.googlesource.com/1225709 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This adds another instance of the "if allocation fails, run GC then retry" pattern, this time for making the actual memory reservation for wasm memory. R=mlippautz@chromium.org Bug: chromium:883639, v8:7872, v8:8158 Change-Id: I40ed020ed2bbc253c4bbcbe51e3e9f5a0278d7a1 Reviewed-on: https://chromium-review.googlesource.com/1227117Reviewed-by:
-
Benedikt Meurer authored
While investigating crbug.com/878742 I found that somehow the MachineOperatorReducer lacks the ability to constant-fold comparisons of Float64 constants, which obviously leads to pretty weird code. Bug: v8:8015 Change-Id: I7e18ce10e9d5c87f131fb083ccd3e1e336189dae Reviewed-on: https://chromium-review.googlesource.com/1226132Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55935}
-
Marja Hölttä authored
E.g., "ToWeakHeapObject" was misleading, since it didn't convert to a weak heap object, instead returned a weakly pointed heap object. Change the function names (in this case, to "GetHeapObjectIfWeak") to reflect this. Also make casts explicit, if a MaybeObject is an Object, we can call cast<Object>(). Previous version: https://chromium-review.googlesource.com/1219025 BUG=v8:7308 TBR=ishell@chromium.org, ulan@chromium.org, ahaas@chromium.org, yangguo@chromium.org, tebbi@chromium.org Change-Id: I503d4a2a3a68f85e9e02e1c2f9fc1c4187c8e9a1 Reviewed-on: https://chromium-review.googlesource.com/1226800Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
We can remove redundant NumberSilenceNaN operations if the input is known to be an OrderedNumber, which means that it's any number (incl. -0) but not NaN. This seems to specifically occur in applications that perform number crunching on arrays with integer values outside the Smi range, as these arrays will have double elements kind, but for most of the stores to these arrays TurboFan will be able to tell that it's not going to be a NaN. Bug: v8:8015 Change-Id: I451ac0bf0cec26be18b991f6c3756fb41f1fbd97 Reviewed-on: https://chromium-review.googlesource.com/1225897 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Michael Hablich authored
This reverts commit 1a225459. Reason for revert: Makes GC stress unhappy: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20gc%20stress/18325 and blocks the roll Original change's description: > Implement ResolveLocale in C++. > > Bug: v8:8065, v8:5751 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: Id9dc16455d63b7c436126c21758d64fae0ec8de9 > Reviewed-on: https://chromium-review.googlesource.com/1211402 > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55925} TBR=bstell@chromium.org,gsathya@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:8065, v8:5751 Change-Id: I4d71adb31ffd5ab0d2ae42c0255d0a05edbaad29 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1226646Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#55932}
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: Ibc3dedb0bce78ddce4004ee386757ce504bb073a Reviewed-on: https://chromium-review.googlesource.com/1226792 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55931}
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I6bd8e0c8c1965f22a3429fda12bc70ae454c39c2 Reviewed-on: https://chromium-review.googlesource.com/1226978Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I62ef9a644bd8ba68c44e8e224e54e8c20c3442c7 Reviewed-on: https://chromium-review.googlesource.com/1225795Reviewed-by:
-
- 15 Sep, 2018 4 commits
-
-
Igor Sheludko authored
This is a reland of 16816e53 Bug: v8:8096 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I257fc391931a0a4bf01f2e8136183aaed044231c Reviewed-on: https://chromium-review.googlesource.com/1226915 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e021b7c..dc14f7b Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/3e07166..c9dc040 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/b5e8781..2174136 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ic3b93484af284a4297862e12ded35e87229e9113 Reviewed-on: https://chromium-review.googlesource.com/1227505Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#55927}
-
Igor Sheludko authored
This allows to avoid passing around Isolate instance for no actual reason when generating "codegen" functions. Bug: v8:8015 Change-Id: Ic3a9bd5a8ecb5b559479e44c5e1309a78a1546e7 Reviewed-on: https://chromium-review.googlesource.com/1226133Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#55926}
-
Brian Stell authored
Bug: v8:8065, v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Id9dc16455d63b7c436126c21758d64fae0ec8de9 Reviewed-on: https://chromium-review.googlesource.com/1211402Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55925}
-
- 14 Sep, 2018 14 commits
-
-
tzik authored
This is a reland of 836773c0 Original change's description: > Implement v8::internal::MicrotaskQueue::EnqueueMicrotask > > This adds `queue` and `pending_microtask_count` as members of > v8::internal::MicrotaskQueue, and implements its EnqueueMicrotask. > The implementation itself is similar to Isolate::EnqueueMicrotask. > > Bug: v8:8124 > Change-Id: Idb5c50b2add96b72cbe9e36aeec7cb568072f0cb > Reviewed-on: https://chromium-review.googlesource.com/1205430 > Commit-Queue: Taiju Tsuiki <tzik@chromium.org> > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55884} Bug: v8:8124 Change-Id: Ibd32aec28c8fd9eab88904e62ba97a715295765d Reviewed-on: https://chromium-review.googlesource.com/1226577Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#55924}
-
Ben Smith authored
Bug: chromium:883492 Change-Id: I69e76eb51c635d092918a3cb9a8fa94a86f58f2a Reviewed-on: https://chromium-review.googlesource.com/1226410Reviewed-by:
-
PhistucK authored
Previously, DateTimeFormat.prototype.formatToParts returned an object with the property key 'dayperiod' which is incorrect as per the spec. This patch updates the property key to say 'dayPeriod', making this spec compliant. R=cira@chromium.org Bug: chromium:865351 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I37f50797387bc69d5e29d7c2911bc5cc0fad37ac Reviewed-on: https://chromium-review.googlesource.com/1145304Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I6cd63aa164af2e3b4a846933899a9a1baa54b1ef Reviewed-on: https://chromium-review.googlesource.com/1224032Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I85fc4ba0e4188d60d15e389e4682541c65324b55 Reviewed-on: https://chromium-review.googlesource.com/1227071 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I20fd23b5370d15dddc913f6bdb05e649d71c2059 Reviewed-on: https://chromium-review.googlesource.com/1224373Reviewed-by:
-
Marja Hölttä authored
This reverts commit ad72d195. Reason for revert: Build failures on *san Original change's description: > [in-place weak refs] Fix MaybeObject function names > > E.g., "ToWeakHeapObject" was misleading, since it didn't convert to a weak heap > object, instead returned a weakly pointed heap object. Change the function names > (in this case, to "GetHeapObjectIfWeak") to reflect this. > > Also make casts explicit, if a MaybeObject is an Object, we can call cast<Object>(). > > BUG=v8:7308 > > Change-Id: I4ef078572b4f4415afe7e2e706d3bd684e16e47d > Reviewed-on: https://chromium-review.googlesource.com/1219025 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55906} TBR=ulan@chromium.org,marja@chromium.org,yangguo@chromium.org,ahaas@chromium.org,tebbi@chromium.org,ishell@chromium.org Change-Id: I054b578518e3f6fd7dbcddf0b56cc018726c1e7a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7308 Reviewed-on: https://chromium-review.googlesource.com/1226874Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I41b3d7c41ee9f8ff12f70feddcf38f2c9efc5049 Reviewed-on: https://chromium-review.googlesource.com/1224056Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55917}
-
Benedikt Meurer authored
When the backend sees an Int64Constant in a translation, this currently indicates the value is a Smi value. Bug: v8:8015 Change-Id: I1527a6374b395d3a33ae0339df4b563084ea678e Reviewed-on: https://chromium-review.googlesource.com/1226593Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I56b730814539df7fdc2e1e5fb06c8b2b104b5fc8 Reviewed-on: https://chromium-review.googlesource.com/1223830 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5404f0b94c7badce2c59d8eac2c32810f4fa2c3c Reviewed-on: https://chromium-review.googlesource.com/1224317Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: Ifb940f40d4145a6074702a3d870242aeca625d96 Reviewed-on: https://chromium-review.googlesource.com/1224092Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I4236a2cf85a414f9d7d1fbdaaaaf1c72a84f02e3 Reviewed-on: https://chromium-review.googlesource.com/1224093Reviewed-by:
-
Ivica Bogosavljevic authored
Port 6346cdb6 Change-Id: I397ff152f363a3f0345105fbdf5d939bc3245fb4 Reviewed-on: https://chromium-review.googlesource.com/1225707Reviewed-by:
Sreten Kovacevic <skovacevic@wavecomp.com> Commit-Queue: Sreten Kovacevic <skovacevic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#55911}
-
