- 13 Dec, 2012 1 commit
-
-
rossberg@chromium.org authored
Also, disable TestFastElementsLength test for now, since it flakes on buildbots for yet unknown reasons. R=mstarzinger@chromium.org BUG=v8:2409 Review URL: https://codereview.chromium.org/11554019 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13213 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 Dec, 2012 2 commits
-
-
yangguo@chromium.org authored
Follow-up for r13160. R=mstarzinger@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/11446063 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13163 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
R=svenpanne@chromium.org BUG=v8:2443 Review URL: https://chromiumcodereview.appspot.com/11465005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13160 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 Nov, 2012 1 commit
-
-
rossberg@chromium.org authored
Also apply the same fix elsewhere in v8natives.js BUG=v8:2410 Review URL: https://codereview.chromium.org/11364237 Patch from Adam Klein <adamk@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12982 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 06 Nov, 2012 2 commits
-
-
mstarzinger@chromium.org authored
Section 15.14.5.10 and 15.16.5.7 in the October 26, 2012 ES6 draft, http://wiki.ecmascript.org/doku.php?id=harmony:specification_drafts This adds a getter for "size" to Set.prototype and Map.prototype which reflects the number of elements in the Set and Map respectively. BUG=v8:2395 Review URL: https://codereview.chromium.org/11360089 Patch from Erik Arvidsson <arv@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12875 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rossberg@chromium.org authored
In more detail: - Set observation bit for observed objects (and make NormalizedMapCache respect it). - Mutation of observed objects is always delegated from ICs to runtime. - Introduce JS runtime function for notifying generated changes. - Invoke this function in the appropriate places (including some local refactoring). - Inclusion of oldValue field is not yet implemented, nor element properties. Also, shortened flag to --harmony-observation. R=verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/11347037 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12867 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 05 Sep, 2012 1 commit
-
-
erik.corry@gmail.com authored
Review URL: https://chromiumcodereview.appspot.com/10916114 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12442 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 May, 2012 1 commit
-
-
rossberg@chromium.org authored
R=mstarzinger@chromium.org BUG=v8:1543 TEST= Review URL: https://chromiumcodereview.appspot.com/10453053 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 08 Mar, 2012 3 commits
-
-
rossberg@chromium.org authored
Rrraaa, I have to say, doing program rewriting via regexp rules is an inherently broken idea... R=mstarzinger@chromium.org BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/9644001 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10969 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mstarzinger@chromium.org authored
R=rossberg@chromium.org TEST=mjsunit/object-is Review URL: https://chromiumcodereview.appspot.com/9641015 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10967 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mstarzinger@chromium.org authored
R=rossberg@chromium.org TEST=mjsunit/object-is,mjsunit/number-is Review URL: https://chromiumcodereview.appspot.com/9630009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10965 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 Mar, 2012 1 commit
-
-
svenpanne@chromium.org authored
Previously, there were 1 or 2 calls to the runtime when accessors were changed or set. This doesn't really work well with property attributes, leading to some hacks and complicates things even further when trying to share maps in presence of accessors. Therefore, the runtime entry now takes the full triple (getter, setter, attributes), where the getter and/or the setter can be null in case they shouldn't be changed. For now, we do basically the same on the native side as we did before on the JavaScript side, but this will change in future CLs, the current CL is already large enough. Note that object literals with a getter and a setter for the same property still do 2 calls, but this is a little bit more tricky to fix and will be handled in a separate CL. Review URL: https://chromiumcodereview.appspot.com/9616016 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10956 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 05 Mar, 2012 1 commit
-
-
mstarzinger@chromium.org authored
R=rossberg@chromium.org BUG=v8:1980 TEST=mjsunit/function-call,mjsunit/regress/regress-1980 Review URL: https://chromiumcodereview.appspot.com/9568005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10922 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 20 Feb, 2012 1 commit
-
-
rossberg@chromium.org authored
* Turned all uses of 'const' into 'var'. * Turned all uses of local 'function' into 'var'. * Added a couple of missing toplevel 'var' declarations. One consequence is that the properties on the builtin object are no longer non-writable, and I had to adapt one test. Is that a problem? Unfortunately, we cannot actually switch the library scripts to strict mode by default, because that makes observable things like poisoned .caller properties for library functions. Also removed dead flag code in Compiler::Compile. R=yangguo@chromium.org BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/9415010 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10758 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 Dec, 2011 1 commit
-
-
mstarzinger@chromium.org authored
R=rossberg@chromium.org BUG=v8:1756 TEST=test262 Review URL: http://codereview.chromium.org/8890015 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10236 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 05 Dec, 2011 1 commit
-
-
mstarzinger@chromium.org authored
According to the ES5 spec the implementation of DefineOwnProperty() has to special case handling of arrays. This implementation correctly handles definitions of array index properties and redefinitions of the length property. R=svenpanne@chromium.org BUG=v8:1756 TEST=test262 Review URL: http://codereview.chromium.org/8776045 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10149 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 28 Nov, 2011 1 commit
-
-
lrn@chromium.org authored
Multiline conditionals must use braces. Semicolons are not optional. Review URL: http://codereview.chromium.org/8701006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10074 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 15 Nov, 2011 1 commit
-
-
mstarzinger@chromium.org authored
This is a deliberate non-conformity introduced more than 2 years ago to be compatible with JSC. The current state is that all other browsers perform ES5 conform in that regard. R=erik.corry@gmail.com BUG=chromium:1717,chromium:39662 TEST=test262/15.2.3.6-4-6??,mjsunit/undeletable-functions Review URL: http://codereview.chromium.org/8566009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9993 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Nov, 2011 1 commit
-
-
rossberg@chromium.org authored
Leaving out derived construct trap for now, which I'm working on separately. R=mstarzinger@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8506020 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9960 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Nov, 2011 1 commit
-
-
mstarzinger@chromium.org authored
R=vegorov@chromium.org Review URL: http://codereview.chromium.org/8463006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9883 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 31 Oct, 2011 1 commit
-
-
lrn@chromium.org authored
Previously we omitted all cases where the global eval property was shadowed, even if by a variable holding the same value. ES5 requires us to treat these as direct calls. We still throw if calling indirect eval with a detached global object. BUG=v8:994 TEST=mjsunit/eval.js Review URL: http://codereview.chromium.org/8343054 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9838 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 24 Oct, 2011 1 commit
-
-
rossberg@chromium.org authored
Fix related corner case for Object.keys. Remove obsolete GET_KEYS builtin. R=ricow@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8256015 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9760 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 20 Oct, 2011 1 commit
-
-
svenpanne@chromium.org authored
When the descriptor argument is undefined, the spec is very explicit about the fact that we should return false (not true, like we did previously). I couldn't come up with a test case for this, but the old code leaves a bad feeling about corner cases, so better play safe. Review URL: http://codereview.chromium.org/8356004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9711 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 19 Oct, 2011 2 commits
-
-
svenpanne@chromium.org authored
Note that this is not an observable behavior, but following the principle of least surprise, we should follow the spec. Additional (extremely tiny) bonus: Some ICs see fewer values => better code. Review URL: http://codereview.chromium.org/8352004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9706 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
This is not covered by test262 yet, but it really makes sense and matches Firefox's behaviour. TEST=mjsunit/define-properties.js Review URL: http://codereview.chromium.org/8349031 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9694 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Oct, 2011 1 commit
-
-
lrn@chromium.org authored
Also makes func.caller return null if the caller is a bound function, matching JSC. Fix bug preventing poisoned setters from triggering. TEST=mjsunit/function-bind, mjsunit/strict-mode Review URL: http://codereview.chromium.org/8333019 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9681 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 Oct, 2011 1 commit
-
-
lrn@chromium.org authored
Make instanceof work correctly. BUG=v8:893 Review URL: http://codereview.chromium.org/8199004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9659 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 Oct, 2011 1 commit
-
-
mstarzinger@chromium.org authored
According to the ES5 spec the implementation of DefineOwnProperty() has to special case handling of arrays. This is a preliminary implementation correctly handling definition of array index properties, defining length properties is not completely covered yet. R=rossberg@chromium.org TEST=test262 Review URL: http://codereview.chromium.org/8221002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9596 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Sep, 2011 1 commit
-
-
rossberg@chromium.org authored
Rehome some Object/JSReceiver/JSObject methods. R=ricow@chromium.org,kmillikin@chromium.org BUG=v8:1543 TEST= Review URL: http://codereview.chromium.org/7795055 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9381 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 Sep, 2011 1 commit
-
-
rossberg@chromium.org authored
R=kmillikin@chromium.org BUG=v8:1543 TEST= Review URL: http://codereview.chromium.org/7628021 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9310 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 15 Sep, 2011 1 commit
-
-
jkummerow@chromium.org authored
and make window.{Infinity,NaN,undefined} read-only as per ES5 BUG=89490 TEST=mjsunit/const-redecl.js, mjsunit/undeletable-functions.js, es5conform, sputnik Review URL: http://codereview.chromium.org/7811015 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9299 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Sep, 2011 2 commits
-
-
kmillikin@chromium.org authored
Committed incorrectly. TBR=ricow@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7890026 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9270 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
kmillikin@chromium.org authored
port r9260 (af9cfd83). Original commit message: We passed this flag around in a lot of places and had differenc call ICs based on it, but never did any real specialization based on its value. BUG= TEST= Review URL: http://codereview.chromium.org/7886028 Patch from Paul Lind <plind44@gmail.com>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9269 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 13 Sep, 2011 1 commit
-
-
rossberg@chromium.org authored
Introduce new %Apply native. Extend Execution::Call to optionally handle receiver rewriting (needed for %Apply). Fix Function.prototype.bind for functions that have .apply modified. R=kmillikin@chromium.org BUG=v8:1543 TEST= Review URL: http://codereview.chromium.org/7623011 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9258 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 Sep, 2011 1 commit
-
-
lrn@chromium.org authored
The prototype of builtin functions is already unwritable, so we don't have to make it so (the default map for functions changes after builtins are initialized). We no longer need to make the prototype non-extensible, since all properties that are ever read by the bultins code has been added and frozen already. Adding properties to the prototype, or changing its __proto__, cannot affect code. Removing these two pieces of initialization code reduces the snapshot size by a few Kb. Review URL: http://codereview.chromium.org/7839028 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9166 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 06 Sep, 2011 1 commit
-
-
ricow@chromium.org authored
Adding these local properties on all native functions made us do a ConvertDescriptorToField on the callback on each and every native functions, resulting in us creating an extra map for each of these. Review URL: http://codereview.chromium.org/7779046 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9152 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 05 Sep, 2011 2 commits
-
-
lrn@chromium.org authored
Arithmetic on infinities and NaN is much slower than doing several exact comparisons. Review URL: http://codereview.chromium.org/7830036 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9134 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
lrn@chromium.org authored
Prototypes and their properties and methods are locked down to prevent fiddling with their operation, even if the build-in object leaks. Made some built-in functions only work during bootstrapping. Review URL: http://codereview.chromium.org/7799027 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9122 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 Sep, 2011 1 commit
-
-
lrn@chromium.org authored
http://www.ecma-international.org/publications/files/ECMA-ST/Ecma-262.pdf In the current implementation, the order is reversed. So this webkit test (https://bugs.webkit.org/show_bug.cgi?id=65366) fails on Chromium. BUG=1649 TEST=parse-int-float.js Review URL: http://codereview.chromium.org/7740080 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9116 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 01 Sep, 2011 1 commit
-
-
ricow@chromium.org authored
With this change we follow Firefox, Safari has a slightly different approach where the property is just not there (at least according to GetOwnProperty). Review URL: http://codereview.chromium.org/7792054 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9093 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-