Commits · 78dd1d0c69e266579ec2e1f8dfb2fe41bd6ef1b7 · Linshizhi / V8

25 Sep, 2018 22 commits

[turbofan] Move typer into the background. · 78dd1d0c

Georg Neis authored Sep 25, 2018

... if FLAG_concurrent_compiler_frontend is enabled.

Bug: v8:7790
Change-Id: I448560b21d54c8907e8cbf68bdaf8bbdf2b034df
Reviewed-on: https://chromium-review.googlesource.com/1241959Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56205}

78dd1d0c

[wasm][gc] Link Isolates from WasmEngine · 19bad28d

Clemens Hammacher authored Sep 25, 2018

First step towards GC of wasm code: Introduce a link to all Isolates
that use a WasmEngine.

R=mstarzinger@chromium.org

Bug: v8:8217
Change-Id: Ib7f4495e7c7e5cc9ad58293518c65738f23d664c
Reviewed-on: https://chromium-review.googlesource.com/1240335
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56204}

19bad28d

Format typed-array.tq to fix presubmit · 47945fa7

Sergiy Byelozyorov authored Sep 25, 2018

TBR=danno@chromium.org, machenbach@chromium.org

No-Try: true
Bug: v8:7793
Change-Id: Ia47ecf83b80decc5e04b170c2a492a8365a87346
Reviewed-on: https://chromium-review.googlesource.com/1243043
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56203}

47945fa7

[torque]: Require formatting for .tq files in presubmit · ea5207f7

Daniel Clifford authored Sep 25, 2018

Bug: v8:7793
Change-Id: I18bd30b36be3c3f89962a2e9c04d8f159c8cfe2b
Reviewed-on: https://chromium-review.googlesource.com/1240415
Commit-Queue: Daniel Clifford <danno@chromium.org>
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56202}

ea5207f7

Reland "[Compile] Refactor BackgroundCompileTask to enable its use by CompilerDispatcher" · dc204cc6

Ross McIlroy authored Sep 21, 2018

This is a reland of 31228a69

TBR=yangguo@chromium.org,verwaest@chromium.org

Original change's description:
> [Compile] Refactor BackgroundCompileTask to enable its use by CompilerDispatcher
>
> Splits background compilation data out of ScriptStreamingData and into
> BackgroundCompileTask. Also makes BackgroundCompileTask no longer a sub-class
> of ScriptStreamingTask, and instead have ScriptStreamingTask delegate to a
> BackgroundCompileTask.
>
> As part of this change, we now create the CharacterStream on the main thread,
> and therefore have to set the (thread-local) runtime_call_stats on the already
> created CharacterStream when the BackgroundCompileTask is run on the background
> thread. As such, changes to CharacterStream were needed to feed the
> runtime_call_stats through appropriately.
>
> Deprecates Source::GetCachedData and StreamedSource::GetCachedData since they are
> no longer used, and the streamed source never has cached data (streaming is
> suppressed if cached data is available). Also removes Utf8ChunkedStream which
> is dead code.
>
> BUG=v8:8041, v8:8015
> TBR=yangguo@chromium.org
>
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
> Change-Id: Ifcc723ebf930a1dc01135fcb70929d6168471cb3
> Reviewed-on: https://chromium-review.googlesource.com/1236353
> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#56182}

Bug: v8:8041, v8:8015
Change-Id: Ied5132c537d4c25c6e355f289c2a9cc1f8ff98e9
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/1242097
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56201}

dc204cc6

Emit Call node for CallNoFeedback node instead of soft-deopt · fbd7e788

Creddy authored Sep 24, 2018

Emit call node instead of soft-deopt for CallNoFeedback to
avoid performance penalty incase one-shot code gets optimized.
Tweek the inling heuristic to avoid recurisve inling with stress-opt.

Bug: v8:8106, v8:8072
Change-Id: I09643c0648b6c880f491d08a8a73f1960ca999c0
Reviewed-on: https://chromium-review.googlesource.com/1239075Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Chandan Reddy <chandanreddy@google.com>
Cr-Commit-Position: refs/heads/master@{#56200}

fbd7e788

[objects.h splitting] Move BuiltinFunctionId · 68deca9b

Marja Hölttä authored Sep 24, 2018

BUG=v8:5402,v8:8015

Change-Id: I4afa8ada312df691b06c2d107fd5254c0fbb9496
Reviewed-on: https://chromium-review.googlesource.com/1238577Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56199}

68deca9b

[wasm] Remove dead code from runtime stack walks. · df841d5a

Michael Starzinger authored Sep 24, 2018

R=clemensh@chromium.org

Change-Id: Iabbef9d054671ec11a48321bb4e75a49084560ed
Reviewed-on: https://chromium-review.googlesource.com/1238925Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56198}

df841d5a

[cleanup] Provide better error message if the snapshot blob is missing · 53cd3043

Andreas Haas authored Sep 14, 2018

R=yangguo@chromium.org

Bug: chromium:872783, v8:8015
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I2d281ba058961ebe2e2758e90b4afa34b02fd5b1
Reviewed-on: https://chromium-review.googlesource.com/1216004Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56197}

53cd3043

[ia32,root] Allow usage of ebx for register code only in 'neg' · 2a4f602a

Sigurd Schneider authored Sep 25, 2018

Bug: v8:6666
Change-Id: I5af95a3e9dcffb4be26a8ffd2948784d2910d64a
Reviewed-on: https://chromium-review.googlesource.com/1242804Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56196}

2a4f602a

[ia32,root] Preserve kRootRegister (ebx) in enter/leave code · 07f7388b

Sigurd Schneider authored Sep 25, 2018

This CL ensures that kRootRegister (ebx) is preserved in
BailoutOfDeoptimized and PopArgumentsAdaptorFrame.

This CL uses push/pop to preserve eax, even though it is not used in
OPTIMIZED_FUNCTION code. If we must get more performance, we might be
able to get rid of push/pop, but I've left it in because it is cleaner
code this way. Another alternative is to use ecx in case of embedded
builtins only (as it is used for speculation in the standard config).

Change-Id: I437c8754408414d82b2fbd8b33d2faeda17aee30
Bug: v8:6666
Reviewed-on: https://chromium-review.googlesource.com/1242886
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56195}

07f7388b

[arm64] Use literal pool for calls to off-heap targets · 6b74c4bf

Georgia Kouveli authored Sep 24, 2018

Cherry-picked from cd285951 for arm64 only, with a small addition.

Change-Id: I864f811e7fe5cb47390e6a0588b48d057ccb6292
Reviewed-on: https://chromium-review.googlesource.com/1240334Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com>
Cr-Commit-Position: refs/heads/master@{#56194}

6b74c4bf

[turbofan] Remove ConcurrentOptimizationPrepPhase. · 30addb3e

Georg Neis authored Sep 25, 2018

Part of it was already obsolete. The other part, concerned with
typing, is moved to the TyperPhase.

Bug: v8:7790
Change-Id: If728b36d88d19ded26d818eb805d093942576fcd
Reviewed-on: https://chromium-review.googlesource.com/1242884Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56193}

30addb3e

[ia32,root] Refactor register renaming · 3815ad6d

Sigurd Schneider authored Sep 25, 2018

This CL addresses comments left post-merge on
https://crrev.com/c/1238653
which improve readablity.

R=jarin@chromium.org

Bug: v8:6666, v8:8015
Change-Id: Idafd848dafdd97af525646d6321e0ca40ce856c5
Reviewed-on: https://chromium-review.googlesource.com/1242885Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56192}

3815ad6d

[object-stats] Avoid mislabelling script source data · c5b4810d

Leszek Swirski authored Sep 24, 2018

The existing script source tracking was racing with general external
script resource tracking, resulting in heap-order-dependent labels.

Bug: v8:8218
Change-Id: Ib09c28ca1e13768b328ecef7f8ee3ea5131ba12e
Reviewed-on: https://chromium-review.googlesource.com/1238927Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56191}

c5b4810d

[tools] Add build folder auto detection to run-clang-tidy · 738deb5d

Florian Sattler authored Sep 25, 2018

Change-Id: I4cffe3d595aa3b3d85d4c45d5bb9654728c9137b
Reviewed-on: https://chromium-review.googlesource.com/1238923
Commit-Queue: Florian Sattler <sattlerf@google.com>
Reviewed-by: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56190}

738deb5d

[cpu-profiler] Always skip flaky cpu profiler test · 19253b37

Peter Marshall authored Sep 24, 2018

This is a regression test for a really specific issue that is flaky.
We should just disable it for all configurations rather than wait for
extra flakes which we then have to diagnose.

Bug: v8:8209
Change-Id: I976f2d7cdd92f3ce5c7eb9fd28976201d1d6612f
Reviewed-on: https://chromium-review.googlesource.com/1240120Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56189}

19253b37

[wasm] Update spec tests · 8210d664

Andreas Haas authored Sep 24, 2018

R=titzer@chromium.org

Change-Id: I6eabacf07e3dd95d1bec68f1980ec6aae5220c97
Reviewed-on: https://chromium-review.googlesource.com/1238926Reviewed-by: Ben Titzer <titzer@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56188}

8210d664

Revert "[Compile] Refactor BackgroundCompileTask to enable its use by CompilerDispatcher" · 875480d2

Maya Lekova authored Sep 25, 2018

This reverts commit 31228a69.

Reason for revert: Introduces new pretty consistent flakes on Linux sanitizers, one of which block LKGR. Please see https://crbug.com/v8/8219

Original change's description:
> [Compile] Refactor BackgroundCompileTask to enable its use by CompilerDispatcher
> 
> Splits background compilation data out of ScriptStreamingData and into
> BackgroundCompileTask. Also makes BackgroundCompileTask no longer a sub-class
> of ScriptStreamingTask, and instead have ScriptStreamingTask delegate to a
> BackgroundCompileTask.
> 
> As part of this change, we now create the CharacterStream on the main thread,
> and therefore have to set the (thread-local) runtime_call_stats on the already
> created CharacterStream when the BackgroundCompileTask is run on the background
> thread. As such, changes to CharacterStream were needed to feed the
> runtime_call_stats through appropriately.
> 
> Deprecates Source::GetCachedData and StreamedSource::GetCachedData since they are
> no longer used, and the streamed source never has cached data (streaming is
> suppressed if cached data is available). Also removes Utf8ChunkedStream which
> is dead code.
> 
> BUG=v8:8041, v8:8015
> TBR=yangguo@chromium.org
> 
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
> Change-Id: Ifcc723ebf930a1dc01135fcb70929d6168471cb3
> Reviewed-on: https://chromium-review.googlesource.com/1236353
> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#56182}

TBR=rmcilroy@chromium.org,yangguo@chromium.org,verwaest@chromium.org

Change-Id: Ib05bcbde2e9a588bd4008d2155f75cdac5cc47f5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:8041, v8:8015
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/1241958Reviewed-by: Maya Lekova <mslekova@chromium.org>
Commit-Queue: Maya Lekova <mslekova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56187}

875480d2

Revert "[parser] Restructure Binary expression parsing" · cc9748fa

Toon Verwaest authored Sep 25, 2018

This reverts commit f2f48bd8.

Reason for revert: Negative performance impact

Original change's description:
> [parser] Restructure Binary expression parsing
> 
> Change-Id: I1ff35a3e647b32edb229f47fde80de1b8b50737b
> Reviewed-on: https://chromium-review.googlesource.com/1240333
> Reviewed-by: Igor Sheludko <ishell@chromium.org>
> Commit-Queue: Toon Verwaest <verwaest@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#56179}

TBR=ishell@chromium.org,verwaest@chromium.org

Change-Id: If08f8c5f538dc25f5f3ea62cd8dd80e024156e81
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1241957Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56186}

cc9748fa

[wasm] Bump max value for wasm code size histogram · 534820c2

Clemens Hammacher authored Sep 24, 2018

Wasm modules can now grow up to 1024 MB. Bump the maximum of the
corresponding histogram so we record the full range.

R=titzer@chromium.org

Change-Id: I984b2314fcb41435f300df6e8f63b62c096d1330
Reviewed-on: https://chromium-review.googlesource.com/1240337Reviewed-by: Ben Titzer <titzer@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56185}

534820c2

Update V8 DEPS. · 4913a939

v8-ci-autoroll-builder authored Sep 25, 2018

Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/dfca77b..4325c99

Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/868fbbf..c51eb62

Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/baf0927..64b6133

Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/dc90d99..9b435fc

TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org

Change-Id: I6582dfcb56e4f1dbfdd32ea32134044c76dd339d
Reviewed-on: https://chromium-review.googlesource.com/1242603Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#56184}

4913a939

24 Sep, 2018 18 commits

Rename Atomics64 logical binop macro · 5f965c98

Deepti Gandluri authored Sep 24, 2018

Change-Id: I554c028627c4032d7c47e8d6d6a6ed4e4a38d0a5
Reviewed-on: https://chromium-review.googlesource.com/1241474Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56183}

5f965c98

[Compile] Refactor BackgroundCompileTask to enable its use by CompilerDispatcher · 31228a69

Ross McIlroy authored Sep 21, 2018

Splits background compilation data out of ScriptStreamingData and into
BackgroundCompileTask. Also makes BackgroundCompileTask no longer a sub-class
of ScriptStreamingTask, and instead have ScriptStreamingTask delegate to a
BackgroundCompileTask.

As part of this change, we now create the CharacterStream on the main thread,
and therefore have to set the (thread-local) runtime_call_stats on the already
created CharacterStream when the BackgroundCompileTask is run on the background
thread. As such, changes to CharacterStream were needed to feed the
runtime_call_stats through appropriately.

Deprecates Source::GetCachedData and StreamedSource::GetCachedData since they are
no longer used, and the streamed source never has cached data (streaming is
suppressed if cached data is available). Also removes Utf8ChunkedStream which
is dead code.

BUG=v8:8041, v8:8015
TBR=yangguo@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: Ifcc723ebf930a1dc01135fcb70929d6168471cb3
Reviewed-on: https://chromium-review.googlesource.com/1236353
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56182}

31228a69

Update V8 DEPS. · c4cfafc3

Sergiy Byelozyorov authored Sep 24, 2018

Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/7ca3ffa..c52a2a2

This includes fixes from https://crrev.com/c/1240414.

TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org

Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
Change-Id: I2afd319dbb244356a9bb057eb80c5fb0310b8686
Reviewed-on: https://chromium-review.googlesource.com/1240106Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56181}

c4cfafc3

[parser] Add dummy SourceRange tracking for PreParser · d975ca02

Toon Verwaest authored Sep 24, 2018

Change-Id: I05db378984b583d9dff3fe9fceb3adbf7e046e20
Reviewed-on: https://chromium-review.googlesource.com/1240338Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56180}

d975ca02

[parser] Restructure Binary expression parsing · f2f48bd8

Toon Verwaest authored Sep 24, 2018

Change-Id: I1ff35a3e647b32edb229f47fde80de1b8b50737b
Reviewed-on: https://chromium-review.googlesource.com/1240333Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56179}

f2f48bd8

Remove mac_toolchain hook as XCode is now installed via recipe · b308fc58

Sergiy Byelozyorov authored Sep 24, 2018

TBR=machenbach@chromium.org

Bug: chromium:863607
Change-Id: I1352bc236e7e236d70130db7fcc4333821fdec70
Reviewed-on: https://chromium-review.googlesource.com/1238924
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56178}

b308fc58

[parser] Move preparse abort handling to SkipFunction · af07cd9a

Toon Verwaest authored Sep 24, 2018

Change-Id: I6c4f8c736e3c5f55f9541109f0093b2c026bce27
Reviewed-on: https://chromium-review.googlesource.com/1240136
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56177}

af07cd9a

[wasm][cleanup] Use AddressRange instead of std::pair · 141dd667

Clemens Hammacher authored Sep 24, 2018

In the wasm code manager unittest, use the more specific AddressRange
class instead of a generic std::pair.
Also, rename the two {CheckLooksLike} methods to capture what they
actually check ({CheckPool} and {CheckRange}).

R=ahaas@chromium.org

Bug: v8:8015
Change-Id: Ia02523eabb1ddd8a3e8a255cc3987017b8338721
Reviewed-on: https://chromium-review.googlesource.com/1240135Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56176}

141dd667

Reland "Do not use FixedDoubleArray to store RNG state" · ac66c97c

Yang Guo authored Sep 24, 2018

This is a reland of 33fa357b

TBR=mvstanton@chromium.org

Original change's description:
> Do not use FixedDoubleArray to store RNG state
>
> Also:
>  - replace runtime call with cheaper C call
>  - change state to double conversion
>
> R=mvstanton@chromium.org
>
> Bug: v8:8212
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
> Change-Id: If4bfe0f5fb1864c89f4acd871cb8b74c7cd7ab09
> Reviewed-on: https://chromium-review.googlesource.com/1240116
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Michael Stanton <mvstanton@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#56165}

Bug: v8:8212
Change-Id: Iccc9128034ce7b65801a04a54982219b5a4fe84e
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/1238551Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56175}

ac66c97c

[cleanup] Use RootIndex instead of int to avoid casting · 62af397b

Igor Sheludko authored Sep 24, 2018

Bug: v8:8015
Change-Id: I1a423b356d09bdf46d49d69fb83cc24acabb6313
Reviewed-on: https://chromium-review.googlesource.com/1238550Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56174}

62af397b

[parser] Restructure Unary and Conditional expression parsing · 7431175b

Toon Verwaest authored Sep 24, 2018

This allows to inline the part where we call to the nested rule and the token
check while keeping the bulk of the work if it's actually a unary/conditional
expression outline.

Change-Id: I1b1f7ebaf2d4f660f157ece7f9534525b80a95a6
Reviewed-on: https://chromium-review.googlesource.com/1238922Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56173}

7431175b

Remove isolate param from external reference where possible · 71dfbcd7

Yang Guo authored Sep 24, 2018

R=petermarshall@chromium.org

Change-Id: I2738b6ccf8b3c56b58554aa8dd626da5d2c3865d
Reviewed-on: https://chromium-review.googlesource.com/1240137Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56172}

71dfbcd7

[parser] Only clear tempzone if we actually parse in it · dc2e7786

Toon Verwaest authored Sep 24, 2018

The previous clear mechanism would also unnecessarily allocate a preparser.

This fixes regressions introduced by
https://chromium-review.googlesource.com/c/v8/v8/+/1238614

Change-Id: Ia3eef371c80857f2cd6cdd5852c849fa7f8716fc
Reviewed-on: https://chromium-review.googlesource.com/1238918
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56171}

dc2e7786

[API] Rename GetBuiltinsCodeRange to GetEmbeddedCodeRange. · a0c48e1d

Peter Marshall authored Sep 24, 2018

This is more generic as it doesn't restrict embedded code to just
builtins. Also, some builtins are still on-heap so the name was not
totally accurate.

Bug: v8:8116
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I44cd24d6baf2bce0e5d914d36a2bae98e77bdc6d
Reviewed-on: https://chromium-review.googlesource.com/1238919
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56170}

a0c48e1d

[cleanup] Ensure [READ_ONLY|MUTABLE]_ROOT_LIST contain ALL RO/mutable entries · c9e4a21c

Igor Sheludko authored Sep 24, 2018

... so that it is no longer needed to iterate over other lists.
This CL also moves data handler maps to the RO roots list (because they are RO).

Bug: v8:8015
Change-Id: If21fe5bac5a6ac1e44a47783ad930df5fcecda9a
Reviewed-on: https://chromium-review.googlesource.com/1240134Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56169}

c9e4a21c

Update V8 DEPS. · c9ef63e5

v8-ci-autoroll-builder authored Sep 24, 2018

Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/218f466..868fbbf

Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/0dc1fa0..baf0927

TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org

Change-Id: Ifb64ed8de7d45867a7b3bbae1357ba0f0aecc4b6
Reviewed-on: https://chromium-review.googlesource.com/1240103
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#56168}

c9ef63e5

Revert "Do not use FixedDoubleArray to store RNG state" · 601d8896

Maya Lekova authored Sep 24, 2018

This reverts commit 33fa357b.

Reason for revert: Breaking the V8 Linux - arm64 - sim - MSAN bot. Please see here:
https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/23001

Original change's description:
> Do not use FixedDoubleArray to store RNG state
> 
> Also:
>  - replace runtime call with cheaper C call
>  - use xor instead of addition to remove bias
> 
> R=mvstanton@chromium.org
> 
> Bug: v8:8212
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
> Change-Id: If4bfe0f5fb1864c89f4acd871cb8b74c7cd7ab09
> Reviewed-on: https://chromium-review.googlesource.com/1240116
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Michael Stanton <mvstanton@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#56165}

TBR=yangguo@chromium.org,mvstanton@chromium.org

Change-Id: I05f23f0b52a706233bbc1a1877cc15691ed9f40a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:8212
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/1238549Reviewed-by: Maya Lekova <mslekova@chromium.org>
Commit-Queue: Maya Lekova <mslekova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56167}

601d8896

Prune forward declarations in isolate.h · ee1335ad

Jaroslav Sevcik authored Sep 24, 2018

Change-Id: Id31c1178b84be5ec4e876495ce220302864713e0
Reviewed-on: https://chromium-review.googlesource.com/1240118Reviewed-by: Georg Neis <neis@chromium.org>
Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56166}

ee1335ad