1. 01 Jun, 2021 1 commit
  2. 19 May, 2020 1 commit
    • Clemens Backes's avatar
      Reland "[wasm][debug] Fix tier down during streaming compilation" · 18ac08d0
      Clemens Backes authored
      This is a reland of 3cc981cb with a
      fix for data race detected by TSan.
      
      Original change's description:
      > [wasm][debug] Fix tier down during streaming compilation
      >
      > If the debugger is enabled while streaming compilation is happening, we
      > won't correctly tier down to Liftoff. This is because during streaming
      > compilation, we always compile for no debugging. Fixing that is a bit
      > tricky, since when the debugger is enabled, functions can either already
      > have finished compiling, or they are currently being compiled, or their
      > wire bytes are not received yet.
      > Instead of handling this correctly while streaming compilation is
      > running, we just recompile the whole module with Liftoff after streaming
      > compilation finished.
      >
      > For testing this, we use the existing tests for async compilation, and
      > enable --wasm-test-streaming, which compiles via the streaming decoder
      > even in the async compilation case.
      >
      > R=thibaudm@chromium.org
      >
      > Bug: v8:10531
      > Change-Id: I0177248a9ad2e90f83faee965d6746de05423f1f
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207133
      > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
      > Commit-Queue: Clemens Backes <clemensb@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#67882}
      
      Bug: v8:10531, v8:10544
      Change-Id: I884922b6ac55543e6ff9b1046438f6b3abab6f64
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207187Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
      Commit-Queue: Clemens Backes <clemensb@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#67896}
      18ac08d0
  3. 25 Feb, 2020 1 commit
    • Andreas Haas's avatar
      Reland "[wasm] The name of a custom section can cause a validation error" · 7a318130
      Andreas Haas authored
      This is a reland of 03d5a7ba
      
      Nothing changed here compared to the original test. The tests on the
      blink side were invalid, I fixed them in https://crrev.com/c/2066907.
      
      Original change's description:
      > [wasm] The name of a custom section can cause a validation error
      >
      > The WebAssembly spec defines that the name of a custom section can cause
      > a validation error. The streaming decoder, however, used a separate
      > Decoder object to decode the name, and thereby avoided a validation
      > error. With this CL the streaming decoder uses the main decoder to
      > decode the name of the custom section.
      >
      > In addition this CL removes the test mjsunit/regress/wasm/regress-789952.
      > This test defined an invalid WebAssembly module and expected it to
      > compile. As it is a regression test, it makes no sense to fix the test.
      > The module is invalid because it defines the length of the custom section
      > to be '0', so there are no bytes in the custom section for its name.
      >
      > R=clemensb@chromium.org
      > CC=thibaudm@chromium.org
      >
      > Bug: v8:10126
      > Change-Id: I8cfc77c9a5916570d5362d5922e0179a29774da8
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2041446
      > Commit-Queue: Andreas Haas <ahaas@chromium.org>
      > Reviewed-by: Clemens Backes <clemensb@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#66348}
      
      Bug: v8:10126
      Change-Id: I48aaed8eb9899da1703030fb6809fe46a6e66191
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2069325
      Commit-Queue: Andreas Haas <ahaas@chromium.org>
      Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#66431}
      7a318130
  4. 12 Feb, 2020 1 commit
  5. 16 Jan, 2020 1 commit
  6. 14 Jan, 2020 1 commit
  7. 07 Jan, 2020 1 commit