- 21 Jan, 2022 10 commits
-
-
Michael Lippautz authored
Drive-by: Avoid unnecessary memset and clean up Init(). Bug: v8:12559 Change-Id: I6a79f42dd62b47397d70f92efec3b569ca664c3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3404097Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#78722}
-
Andreas Haas authored
Externref does not need a translation from WebAssembly to JavaScript. The return value can therefore just be forwarded to JavaScript. R=thibaudm@chromium.org Bug: v8:12565 Change-Id: I3b3ae37578c2793f6c09d1345f4ee555b40c853d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3404779Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#78721}
-
Clemens Backes authored
This is similar to the previous SIMD spilling fixes, but this time at block merges. The logic is similar to the existing cases, but not quite the same. I did not find a nice way to unify the different locations where we check for SIMD register overlap. R=thibaudm@chromium.org Bug: chromium:1283395, v8:12330 Change-Id: I5ab9b6831368cbce40b8368e4ec7954e985bff96 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3404780Reviewed-by:
-
Andreas Haas authored
The C-API does not support dynamic tiering and still waits for top-tier compilation to finish before serializing code when the explicit serialize() function gets called. This means that serialize() can only finish if the kFinishedTopTierCompilation event was triggered first. With this CL the kFinishedTopTierCompilation event is also triggered after deserialization so that serialize() can work after deserialization. R=clemensb@chromium.org Bug: v8:11024 Change-Id: I3dd14e37087e3cbfbc28cb5625c9f3715f6c236b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3404773Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#78719}
-
Marja Hölttä authored
Bug: v8:11111 Change-Id: Ia84fe23c85b193bc7e31349eddc3705447795c33 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3400960Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#78718}
-
Michael Lippautz authored
Bug: v8:12356 Change-Id: Ib9e99c8b05e24a8983c5ff3d36ca534a262738a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3404774 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#78717}
-
Marja Hölttä authored
We used to serialize the full source code of the script being serialized. This CL makes the source code maximally minimal (only including the needed outer functions) while maintaining the "inner function is textually inside its outer function" relationship. Bug: v8:11525 Change-Id: Ic42772f7ecb76744bc11b97fa1784d847558e1f6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3401864Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#78716}
-
Thibaud Michaud authored
Save the PC in the jump buffer and implement the suspend builtin. R=ahaas@chromium.org CC=fgm@chromium.org Bug: v8:12191 Change-Id: I1a6d965d7864dce0a572f6c8d7102046dad190fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3345006Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#78715}
-
Paolo Severini authored
Allow Wasm to generate calls directly to Fast API C functions. This massively reduces the overhead of these calls (~300%). Currently options parameter is not supported. This is a reland of https://chromium-review.googlesource.com/c/v8/v8/+/3364356 with a fix to a data race. Bug: chromium:1052746 Change-Id: I8c1c255419496d03a94ec2b443329842469586d5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3398394Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Frank Tang authored
Bug: v8:11544 Change-Id: I1a942badc31c0428e8eb07b7e2884f0aab803676 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3373930Reviewed-by:
-
- 20 Jan, 2022 23 commits
-
-
Dominik Inführ authored
So far this flag was process-global, so if one isolate used v8::Locker all isolates were forced to use v8::Locker. With the shared isolate now being a thing that routinely gets migrated between different threads, all users of the shared isolate would be forced to use v8::Locker. So we now store that flag on the isolate such that using v8::Locker for the shared isolate does not affect other isolates. Deprecate v8::Locker::WasEverUsed() at the same time. Bug: v8:11708 Change-Id: I60531f084cc1b1b113620c46f5bed20511f52c26 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3401595Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#78712}
-
Maya Lekova authored
Bug: v8:12561 Change-Id: I6910723a3a85df7ba3d49816e5e800cd4ee6bad6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3404732 Commit-Queue: Maya Lekova <mslekova@chromium.org> Auto-Submit: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#78711}
-
Junliang Yan authored
Change-Id: I0d72b9c72e3a2244409dee6f4694c92ecb3d41b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3403043Reviewed-by:
Milad Farazmand <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#78710}
-
Junliang Yan authored
Change-Id: I6e20fa4ae24db6b799d854aef2ef98e7a8e1e552 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3403041Reviewed-by:
-
Samuel Groß authored
The external pointer table is now managed by the GC, which marks entries that are alive during major GC, then sweeps the table afterwards to free all dead entries and build a free list from them. For now, only major GCs are supported, Scavenger GCs do not interact with the external pointer table. In more detail, garbage collection of the external pointer table works as follows: 1. The external pointer table now reserves a large region of virtual address space for its backing buffer and is then never reallocated, only grown in place until the maximum size is reached. 2. When the GC's marking visitor marks a HeapObject with an external pointer as alive, it also marks the corresponding external pointer table entry as alive. This can happen on a background thread. 3. For that, it uses the MSB of each entry in the table to indicate whether the entry has been marked or not. This works because the MSB is always cleared during the AND-based type check performed when accessing an external pointer. 4. After marking, the external pointer table is swept while the mutator is stopped. This builds an inline, singly-linked freelist of all newly-dead and previously-free entries. 5. When allocating an entry from the table, the first entry on the freelist is used. If the freelist is empty, the table grows, populating the freelist with the new entries. 6. Every newly-allocated entry is marked as alive, and every store to an existing entry also automatically marks that entry as alive (by also setting the MSB). This simplifies the design of the table GC with regards to concurrency (See ExternalPointerTable::Mark). Bug: v8:10391 Change-Id: I8877fdf5576af3761bde65298951bb09e601bd14 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3359625Reviewed-by:
-
Liviu Rau authored
Change-Id: I5114f6975563a59c586c9a28711034cdd35a9b31 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3401870Reviewed-by:
Lutz Vahl <vahl@chromium.org> Commit-Queue: Lutz Vahl <vahl@chromium.org> Cr-Commit-Position: refs/heads/main@{#78707}
-
Nico Hartmann authored
This reverts commit 757830b0. Reason for revert: Speculatively revert due to a number of performance regressions Original change's description: > [Torque] Generalize Torque literals to larger size > > Previously, literals in Torque were stored as double values, which > made it impossible to precisely represent 64 bit integer values. > This CL replaces the old literal expression with an integer and > floating point literal expression that are unbounded in size. We > allow implicit conversion of these literals to arbitary integer > and floating point types respectively and insert a corresponding > bounds check into generated CSA. > > Bug: v8:7793 > Change-Id: I46c231aab92bc2f0c26955d1876079f306b358c6 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3329792 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78671} Bug: v8:7793 Change-Id: I9896e28b3c69b8cf2488bf93e993ec320d8c5d2e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3401866Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#78706}
-
Camillo Bruni authored
Bug: v8:11525 Change-Id: I5bc01779cbc7edf4f50377bc55a26dca1f96f5b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3401587Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#78705}
-
Nico Hartmann authored
This reverts commit 83bf6629. Reason for revert: Have to revert dependent CL Original change's description: > [Torque] Fix compile error in integer-literal.h > > Bug: v8:7793 > Change-Id: I88e6ea24909ba1dde8cada90d7b195b6f6ecc783 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3400958 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> > Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78678} Bug: v8:7793 Change-Id: I4e62d8d121c0585df15f47653c44569d0f6b5606 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3401597 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by:
-
Lutz Vahl authored
This reverts commit 519ee9d6. Reason for revert: Need to adjust to 10.0 Original change's description: > Version 9.10.0 > > Change-Id: I1be4d945e1ba2c1816b5fd335e7fe08eb4aca4c1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3404534 > Reviewed-by: Lutz Vahl <vahl@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Liviu Rau <liviurau@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78702} Change-Id: I2f6f8b64123d477f7c982e2623aca43fc8b245ae No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3404771 Auto-Submit: Lutz Vahl <vahl@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/main@{#78703}
-
V8 Autoroll authored
Change-Id: I1be4d945e1ba2c1816b5fd335e7fe08eb4aca4c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3404534Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/main@{#78702}
-
Dominik Inführ authored
Split method into ShouldRecordRelocSlot and ProcessRelocInfo. ProcessRelocInfo can then be reused in the write barrier and in the future for the OLD_TO_SHARED remembered set. SlotTypeForRelocInfoMode got moved into ProcessRelocInfo. In addition rename and document SlotTypes. This CL does not change behavior. Bug: v8:11708 Change-Id: Iff712e7e6f5d3a4da64510b67b604b9e04998361 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3400968Reviewed-by:
-
Maya Lekova authored
Bug: v8:12558 Change-Id: Ib615c192a0ec6bc7c8ee8b0ee0f393092a5dedb4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3401590 Auto-Submit: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Milad Fa authored
Need to reverse the index on big endian platforms due to this previous change: https://crrev.com/c/1508572 Change-Id: I12e0230d929f5f16ecd2300a49970f92b0d3be50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3402363Reviewed-by:
-
Jakob Gruber authored
Bug: v8:12552 Change-Id: I99e4d8e8aeba5460f11e54cc1b2bcaea98a5276d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3400964Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Samuel Groß authored
In case the requested permissions are kNoAccess, nothing needs to be done as the mapping backing an AddressSpaceReservation is always mapped kNoAccess. This fixes a performance regression on macOS. Bug: chromium:1287599 Change-Id: I77d80489caf477e29434f9d0a06899746cb9403f Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3398144Reviewed-by:
-
Liviu Rau authored
Bug: v8:12405 Change-Id: I00f727ad5172d08f430b5dc2b7a348cbec344c4a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3401721Reviewed-by:
-
Jochen Eisinger authored
Change-Id: I8fd11742c4ea13cfd5cd3864e167785b97f1383a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3404274Reviewed-by:
-
Maya Lekova authored
Bug: v8:12558 Change-Id: If5f8048d1a48719329c257282195f5096e101512 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3401586 Auto-Submit: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Samuel Groß authored
This CL fixes two issues: 1) When the specified vmar_offset was zero, the previous logic would incorrectly conclude that no target address was specified, and would potentially place the allocation elsewhere in memory, not at the desired address. This CL now passes both the target address and the VMAR base address to AllocateInternal, which can then correctly determine whether a target address was supplied. 2) When the root_vmar was used and a hint specified, the previous logic would incorrectly use nullptr as base address of the root_vmar, which appears to be incorrect. The new logic now obtains the actual base (apparently 2MB) through zx_object_get_info during initialization. Bug: v8:10391 Change-Id: Ia8215440a790b4a2a0c8d33f623d3ecb6a731a97 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3398506Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#78693}
-
Jakob Gruber authored
Use the FatalProcessOutOfMemory function such that tooling recognizes these crashes as OOM's. Drive-by: Skip one more test that leads to such stack overflows. Fixed: v8:12555, chromium:1288456 Bug: v8:12472 Change-Id: Ib9203a4aa0487744f7cea9a212aeeffda579ae23 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3401861 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Lu Yahan authored
Port commit db9f6bff Bug: v8:11112 Change-Id: I6c69e0501cae6c46e723d847bf56e69bb4835bec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3398260Reviewed-by:
ji qiu <qiuji@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#78691}
-
v8-ci-autoroll-builder authored
Rolling v8/base/trace_event/common: https://chromium.googlesource.com/chromium/src/base/trace_event/common/+log/7f36dbc..d115b03 Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/f3be6e8..841e388 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/94855f7..7d79126 Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/57e4aff..efb2cbd Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/f92a0a2..8bc3659 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cb340f5..a657331 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/c9643a2..100f6fb Rolling v8/tools/luci-go: git_revision:d1e877e2b3e5a05a5cd34c4a340fedba14a16c2b..git_revision:5b02a4aaeb5fd78d6fe41d6d54d1cb58da17f192 Rolling v8/tools/luci-go: git_revision:d1e877e2b3e5a05a5cd34c4a340fedba14a16c2b..git_revision:5b02a4aaeb5fd78d6fe41d6d54d1cb58da17f192 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ic20a71114072b6240b0ba01252ed9cd562395b80 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3402380 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78690}
-
- 19 Jan, 2022 7 commits
-
-
Seth Brenith authored
This is a regression test for the fixes in https://crrev.com/c/v8/v8/+/3299592 . Some of the helper functions were copied from console-retaining-path.js in the same directory. Bug: v8:12112 Change-Id: I3c313ad003ede5e5036f886161e1d164c98f87fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3400149Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/main@{#78689}
-
Milad Fa authored
enum values need to be explicitly casted to int type to prevent the following error: ``` expects argument of type 'int', but argument 3 has type 'v8::internal::{anonymous}::V8StartupState' ``` Bug: v8:12309 Change-Id: I9515cde7d2496ca070ce4c6b751501236864730b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3401398Reviewed-by: -
Shu-yu Guo authored
super.property accesses in heritage positions like `class C extends super.property` should resolve super in the current scope, not C's class scope. Bug: chromium:1282096 Change-Id: I7ef815bc02cfff35a2898ef9f39b133d1114046c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3400150Reviewed-by:
-
Manos Koukoutos authored
- Do not create a new handle for {target_instance}. - Only instantiate FunctionTargetAndRef once. Bug: chromium:1284557 Change-Id: I42aea5750e93ef4ac578003bca323cda4753b6f6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3395874Reviewed-by: -
Scott Violet authored
The experiment has been would down, so these can be removed. This effectively reverts these two commits: https://chromium-review.googlesource.com/c/v8/v8/+/3271389 https://chromium-review.googlesource.com/c/v8/v8/+/3256006 chrome side here: https://chromium-review.googlesource.com/c/chromium/src/+/3399313 BUG=chromium:1257321 TEST=none Change-Id: I5e9e4e7f56a6f19159d1c8c20c5a1fe5ed2859fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3399226Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Andreas Haas authored
The method SetInstanceDescriptors accessed the bit field before it got initialized, which is undefined behavior. R=cbruni@chromium.org Change-Id: Ie17e6e840a9a4278e066278d1ce81ac4b836a429 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3400970Reviewed-by:
-
Dominik Inführ authored
Bug: v8:11708 Change-Id: I83c9559bb2aee062a53c1d67c293b8f6654c7d99 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3400965Reviewed-by:
-
