1. 13 Jul, 2016 1 commit
    • bakkot's avatar
      Reland of Add errors for declarations which conflict with catch parameters.... · 819fe046
      bakkot authored
      Reland of Add errors for declarations which conflict with catch parameters. (patchset #1 id:1 of https://codereview.chromium.org/2112223002/ )
      
      Reason for revert:
      Correcting issue.
      
      Original issue's description:
      > Revert of Add errors for declarations which conflict with catch parameters. (patchset #6 id:100001 of https://codereview.chromium.org/2109733003/ )
      >
      > Reason for revert:
      > Fuzzer claims `try {  \"\" ; } catch(x) { let x1 = [1,,], x = x; }` causes a crash.
      >
      > Original issue's description:
      > > Add errors for declarations which conflict with catch parameters.
      > >
      > > Catch parameters are largely treated as lexical declarations in the
      > > block which contains their body for the purposes of early syntax errors,
      > > with some exceptions outlined in B.3.5. This patch introduces most of
      > > those errors, except those from `eval('for (var e of ...);')` inside of
      > > a catch with a simple parameter named 'e'.
      > >
      > > Note that annex B.3.5 allows var declarations to conflict with simple
      > > catch parameters, except when the variable declaration is the init of a
      > > for-of statement.
      > >
      > > BUG=v8:5112,v8:4231
      > >
      > > Committed: https://crrev.com/2907c726b2bb5cf20b2bec639ca9e6a521585406
      > > Cr-Commit-Position: refs/heads/master@{#37462}
      >
      > TBR=littledan@chromium.org
      > # Skipping CQ checks because original CL landed less than 1 days ago.
      > NOPRESUBMIT=true
      > NOTREECHECKS=true
      > NOTRY=true
      > BUG=v8:5112,v8:4231
      >
      > Committed: https://crrev.com/8834d5ecb559001c87c42322969471da60574a8c
      > Cr-Commit-Position: refs/heads/master@{#37464}
      
      R=littledan@chromium.org
      BUG=v8:5112,v8:4231
      
      Review-Url: https://codereview.chromium.org/2119933002
      Cr-Commit-Position: refs/heads/master@{#37728}
      819fe046
  2. 01 Jul, 2016 2 commits
    • bakkot's avatar
      Revert of Add errors for declarations which conflict with catch parameters.... · 8834d5ec
      bakkot authored
      Revert of Add errors for declarations which conflict with catch parameters. (patchset #6 id:100001 of https://codereview.chromium.org/2109733003/ )
      
      Reason for revert:
      Fuzzer claims `try {  \"\" ; } catch(x) { let x1 = [1,,], x = x; }` causes a crash.
      
      Original issue's description:
      > Add errors for declarations which conflict with catch parameters.
      >
      > Catch parameters are largely treated as lexical declarations in the
      > block which contains their body for the purposes of early syntax errors,
      > with some exceptions outlined in B.3.5. This patch introduces most of
      > those errors, except those from `eval('for (var e of ...);')` inside of
      > a catch with a simple parameter named 'e'.
      >
      > Note that annex B.3.5 allows var declarations to conflict with simple
      > catch parameters, except when the variable declaration is the init of a
      > for-of statement.
      >
      > BUG=v8:5112,v8:4231
      >
      > Committed: https://crrev.com/2907c726b2bb5cf20b2bec639ca9e6a521585406
      > Cr-Commit-Position: refs/heads/master@{#37462}
      
      TBR=littledan@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=v8:5112,v8:4231
      
      Review-Url: https://codereview.chromium.org/2112223002
      Cr-Commit-Position: refs/heads/master@{#37464}
      8834d5ec
    • bakkot's avatar
      Add errors for declarations which conflict with catch parameters. · 2907c726
      bakkot authored
      Catch parameters are largely treated as lexical declarations in the
      block which contains their body for the purposes of early syntax errors,
      with some exceptions outlined in B.3.5. This patch introduces most of
      those errors, except those from `eval('for (var e of ...);')` inside of
      a catch with a simple parameter named 'e'.
      
      Note that annex B.3.5 allows var declarations to conflict with simple
      catch parameters, except when the variable declaration is the init of a
      for-of statement.
      
      BUG=v8:5112,v8:4231
      
      Review-Url: https://codereview.chromium.org/2109733003
      Cr-Commit-Position: refs/heads/master@{#37462}
      2907c726
  3. 12 Aug, 2015 1 commit
  4. 13 Mar, 2015 1 commit
  5. 25 Nov, 2014 1 commit
  6. 09 Jul, 2014 1 commit
  7. 17 Jun, 2014 1 commit
  8. 28 Aug, 2012 1 commit
    • rossberg@chromium.org's avatar
      Allocate block-scoped global bindings to global context. · ccc827a6
      rossberg@chromium.org authored
      - The global object has a reference to the current global scope chain.
        Running a script adds to the chain if it contains global lexical declarations.
      - Scripts are executed relative to a global, not a native context.
      - Harmony let and const bindings are allocated to the innermost global context;
        var and function still live on the global object.
        (Lexical bindings are not reflected on the global object at all,
        but that will probably change later using accessors, as for modules.)
      - Compilation of scripts now needs a (global) context (previously only eval did).
      - The global scope chain represents one logical scope, so collision tests take
        the chain into account.
      
      R=svenpanne@chromium.org
      BUG=
      
      Review URL: https://chromiumcodereview.appspot.com/10872084
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12398 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      ccc827a6
  9. 14 Feb, 2012 1 commit
  10. 24 Nov, 2011 1 commit
    • keuchel@chromium.org's avatar
      Introduce extended mode. · 1e9a7267
      keuchel@chromium.org authored
      This CL introduces a third mode next to the non-strict
      (henceforth called 'classic mode') and 'strict mode'
      which is called 'extended mode' as in the current
      ES.next specification drafts. The extended mode is based on
      the 'strict mode' and adds new functionality to it. This
      means that most of the semantics of these two modes
      coincide.
      
      The 'extended mode' is entered instead of the 'strict mode'
      during parsing when using the 'strict mode' directive
      "use strict" and when the the harmony-scoping flag is
      active. This should be changed once it is fully specified how the 'extended mode' is entered.
      
      This change introduces a new 3 valued enum LanguageMode
      (see globals.h) corresponding to the modes which is mostly
      used by the frontend code. This includes the following
      components:
      * (Pre)Parser
      * Compiler
      * SharedFunctionInfo, Scope and ScopeInfo
      * runtime functions: StoreContextSlot,
        ResolvePossiblyDirectEval, InitializeVarGlobal,
        DeclareGlobals
      
      The old enum StrictModeFlag is still used in the backend
      when the distinction between the 'strict mode' and the 'extended mode' does not matter. This includes:
      * SetProperty runtime function, Delete builtin
      * StoreIC and KeyedStoreIC
      * StubCache
      
      Review URL: http://codereview.chromium.org/8417035
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10062 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      1e9a7267
  11. 25 Oct, 2011 1 commit
  12. 12 Oct, 2011 1 commit
  13. 01 Sep, 2011 1 commit