- 06 Jan, 2021 1 commit
-
-
Zhi An Ng authored
This adds a regression test for a bug in lowering load transforms. This test will fail if 0efa3fd9 is reverted. Bug: chromium:1124885 Change-Id: I31b714d4565c4fff730c1274af8059031cb1e1b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2610508Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71919}
-
- 05 Jan, 2021 16 commits
-
-
Sara Tang authored
Design doc: https://docs.google.com/document/d/1xkXj94iExFgLWc_OszTNyNGi523ARaKMWPZTeomhI4U A lot has changed since the last patchset! I recommend revisiting this design doc and reading the parts in green. I explain the roadmap for what changes to expect from ETW instrumentation as well as the instrumentation of this particular CL. I'll do my best to answer any further questions anyone has about my particular instrumentation or ETW in general :) --- This is the first of a series of changelists to round out ETW instrumentation for V8. This changelist represents the most minimal change needed to instrument ETW in V8. In particular, it: - defines and registers the ETW provider, - interacts minimally with the rest of V8, by hooking into the existing TracingController::AddTraceEvent function, - is designed with a platform-agnostic layer, so that event tracers for other platforms can be instrumented in teh future. Some notes on instrumentation (aka I copied stuff from the design doc): We make heavy use of the TraceLogging API to log events. It differs from previous methods of emitting ETW events in that it doesn<E2><80><99>t require the overhead of a separate manifest file to keep track of metadata; rather, events using this API are self-descriptive. Here are the five major steps to instrument the TraceLogging API: - Forward declare the provider (from provider-win.h) - Define the provider in a .cc file (from provider-win.cc) - Register the provider (called from v8.cc). - Write events (called from libplatform/tracing-controller.cc) - Unregister the provider (called from v8.cc) At the base, we have an abstract provider class that encapsulates the functionality of an event provider. These are things like registering and unregistering the provider, and the actual event-logging. The provider class is split into provider-win and provider-mac (currently not instantiated) classes, with OS-dependent implementations of the above functions. In particular, the TraceLogging API is used only in provider-win. It is here that we forward declare and define the provider, as well as write ETW events. Finally, there is a v8-provider class that serves as a top-level API and is exposed to the rest of V8. It acts as a wrapper for the platform-specific providers. The .wprp file is needed so that Windows Performance Recorder knows how to capture our events. Some considerations: - Is TracingController::AddTraceEvent the best place from which to write my events? - Is src/libplatform/tracing the best place to put my instrumentation? - Right now, I fail the preupload because of this, which tells me my files are probably not in the best location: You added one or more #includes that violate checkdeps rules. src\init\v8.cc Illegal include: "src/libplatform/tracing/v8-provider.h" Because of "-src/libplatform" from src's include_rules. Change-Id: Id53e4a034c9e526524a17000da0a647a95d93edf Bug: v8:11043 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2233407Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Sara Tang <sartang@microsoft.com> Cr-Commit-Position: refs/heads/master@{#71918}
-
Andreas Haas authored
The negative implication from --single-threaded to --liftoff was introduced because with --single-threaded, no tier-up to TurboFan is possible, and TurboFan provides faster code and smaller code This CL removes this implication. The reason is that this implication does not only define the default compiler for --single-threaded to TurboFan, and also completely disables the option to use Liftoff instead. By removing the implication, and embedder who uses --single-threaded can decide by themselves if they want to use Liftoff by setting --liftoff, or if they don't want to use Liftoff by setting --no-liftoff. R=clemensb@chromium.org Bug: v8:11279 Change-Id: Ie6e64a42823b87484135364ecb4589cfd188db5e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2599548Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#71917}
-
Clemens Backes authored
This reverts commit 2d5f981a. Reason for revert: Fails on noavx: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20-%20debug/35318 Original change's description: > [wasm-simd][liftoff][x64] Move v128.select into macro-assembler > > This allows us to reuse this optimized code sequence in Liftoff. > > We can't do the same thing in IA32 yet, there is no kScratchDoubleReg > defined in the macro-assembler-ia32.cc, it is defined in code-generator-ia32 > as xmm0 but I'm not sure if it is safe to just use that in the macro assembler. > > Change-Id: I6c761857c49d2518fbc82cd0796c62fc86665cb5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2596581 > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71915} TBR=bbudge@chromium.org,clemensb@chromium.org,zhin@chromium.org Change-Id: I2aacee02c89a16516a9cd6686d8cc6180362f78e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2610730Reviewed-by:
-
Zhi An Ng authored
This allows us to reuse this optimized code sequence in Liftoff. We can't do the same thing in IA32 yet, there is no kScratchDoubleReg defined in the macro-assembler-ia32.cc, it is defined in code-generator-ia32 as xmm0 but I'm not sure if it is safe to just use that in the macro assembler. Change-Id: I6c761857c49d2518fbc82cd0796c62fc86665cb5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2596581 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Clemens Backes authored
The tests were failing in official release builds, because those drop the fatal error message and always print "ignored" instead. R=ecmziegler@chromium.org Bug: v8:11251 Change-Id: I40512ca308337cf070ecb6a206dc4a5323d67415 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2595445Reviewed-by:
Emanuel Ziegler <ecmziegler@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#71914}
-
Clemens Backes authored
According to the Torque definition, the type of the 'source' field is 'String|Undefined'. The Factory only allowed to pass a string though, which forced us to set an empty string for wasm scripts. This CL changes the factory to also allow undefined values, which fits slightly better for wasm. The inspector needed a minor change to handle undefined source like an empty string. R=dinfuehr@chromium.org, yangguo@chromium.org Bug: chromium:1125986 Change-Id: Iac0a5ee3767ce121aba8a6a2afe37195e77122fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2584243Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#71913}
-
Zhi An Ng authored
R=ahaas@chromium.org Change-Id: Iffc27328464616b422cb6ccecbaf77d901f8d889 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2599848 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#71912}
-
Benedikt Meurer authored
Previously the proxies that make up the DebugEvaluate implementation for Wasm frames lived in wasm-js.cc, but that was quite confusing since (a) the rest of the debug support for Wasm lives in wasm-debug.cc (and we intend to eventually unify the DebugEvaluate and Scope objects), and (b) the wasm-js.cc file is explicitly about the WebAssembly JS API that's part of the WebAssembly specification, and the DebugEvaluate proxies aren't part of that. Bug: chromium:1162229, chromium:1071432, chromium:1127914 Change-Id: I63016dcace6d8e2af4a03c8eed4f02d464c1dee1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2609418 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71911}
-
Benedikt Meurer authored
Drive-by-fix: Handle duplicate globals names correctly in the scope exposed module object. Bug: chromium:1127914, chromium:1071432 Change-Id: I697256642c5ddbc13f86ff25ab012c53537b9c88 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2609416 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
The wasm-scope-info-liftoff.js and wasm-set-breakpoint-liftoff.js tests were originally testing the Liftoff path (when we still had the Wasm interpreter), and have received some updates along the way. Nowadays the interpreter is going and the non-liftoff versions of these tests don't provide any additional test coverage, but are merely a slightly less updated version of the liftoff test. Bug: chromium:1162229 Change-Id: Ifc9933d47f33674a83b99425ef9d0e4bc5550323 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2609415 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
Consistently use InspectorTest.runAsyncTestSuite() in wasm inspector tests to make tests easier to debug (they'll fail instead of timing out in case of errors). Bug: chromium:1162229, chromium:1071432 Change-Id: I7aada196f9e34071aa1bb059bb45f85f75226060 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2609414 Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Zhi An Ng authored
This will make these functions usable from Liftoff when we later implement extended multiply instructions in Liftoff. This is similar to the x64 versions, except that it takes a scratch register as a parameter. Bug: v8:11262 Change-Id: Ief3d8cdde59da9e05a468286315bcae6d13863d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2603768Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/46adc39..dc0b854 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/364205c..81098e5 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic95d3b8d0d4265a2f43f6434469e9e65601da52a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2610430Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#71906}
-
Zhi An Ng authored
These optimized macro-assembler functions were introduced in https://crrev.com/c/2591853. Reuse them in Liftoff to get better code-gen, especially when AVX is supported. The macro-assembler functions have no alias requirements, so we can pass dst and src directly without doing any checks or moves. Change-Id: I0d1badfc2e2b41a8d92d8c4ac73541ec46daeb0a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2603766Reviewed-by:
-
Zhi An Ng authored
In https://crrev.com/c/2591859 we changed the way we generate code for v128.select, which assumes that all inputs are registers. We did not update the instruction selector with this new constraint. Fixed: chromium:1161954 Bug: v8:11282 Change-Id: I5fc9a0315873a3e795078997d87aa92d4c8bddfe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2603764 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Zhi An Ng authored
For i64x2.ext_mul and i16x8.ext_mul, we can simply call the macro-assembler functions. For i32x4.ext_mul, the macro-assembler requires that dst == src1 if AVX is not supported, so we add a helper function to do that check, and make sure dst == src1 before calling into macro-assembler. Bug: v8:11262 Change-Id: Iff8e99967f4ab157021d0706e0142df894468142 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2603765Reviewed-by:
-
- 04 Jan, 2021 2 commits
-
-
LiuYu authored
Change-Id: Id20ea44e9cf804d305731799045c45a577df47ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2607266Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/master@{#71902}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ff2ef81..46adc39 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic5169bac840db4a0ab25c0b5c8e4ae6166020244 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2609716Reviewed-by:
-
- 03 Jan, 2021 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/4e13e3f..ff2ef81 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4c4f0a80ba0b4dc1e705f5973664a14cc50d6a6c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2609206Reviewed-by:
-
- 02 Jan, 2021 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2f9b06d..4e13e3f TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6c158adeb9d22ee639f6598237e38397f902ab21 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2608869Reviewed-by:
-
- 01 Jan, 2021 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b3c270e..2f9b06d TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5045137ed959ea43bf1262b9f99a42aa66644e7c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2608123Reviewed-by:
-
- 31 Dec, 2020 3 commits
-
-
Jakob Gruber authored
Tbr: machenbach@chromium.org Bug: v8:11255 Change-Id: Ic7dc95306f637af5973764e8c39e2454d959ac23 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2606337Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#71897}
-
Jakob Gruber authored
.. to verify that the trampoline_pc has been set. Bug: chromium:1161357 Change-Id: If7e1a13cff9919e2e8a65c095d80dfcef2dc05cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2606333 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/1016d67..b3c270e Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/3b39cef..364205c TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4130d3e2ea1335fc6fbf6782ee3e602e2804c8d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2607771Reviewed-by:
-
- 30 Dec, 2020 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7c34525..1016d67 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia059af587d2b72fc76fa58a7369c953958f19ac9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2606555Reviewed-by:
-
- 29 Dec, 2020 10 commits
-
-
Benedikt Meurer authored
The "imports" and "exports" that were exposed on WebAssembly frames via Debug-Evaluate aren't useful for the DWARF C/C++ extension (and likely not for any other language extension), since they only expose static information that's easily available (upfront) by reading the Wasm wire bytes. In fact, there are already standardized functions in the WebAssembly specification, namely `WebAssembly.Module.imports(module)` and `WebAssembly.Module.exports(module)`, which yield static information about the imports and exports of a Wasm module. So instead of exposing special, non-standard "imports" and "exports", we now instead expose both the "instance" and the "module" objects via both the Debug Proxy and the Scope view, and also add internal [[Exports]] and [[Imports]] properties to WasmModuleObject, which under the hood use the standard methods mentioned above. Fixed: chromium:1162069 Bug: chromium:1071432, chromium:1083146 Screenshot: https://imgur.com/lcaW2jL.png Doc: https://docs.google.com/document/d/1rqbu0jKTl3q_xCxLnKzkjGXWEsHnJ9aERVhKV9RNDgE#bookmark=id.925bb2qgou38 Change-Id: Ie27e55bb08ea5f90493c57375bf2b48dfb11a4d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2606050 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
For JSArrayBuffer instances (which map to both v8::ArrayBuffer and v8::SharedArrayBuffer), we add a couple of synthetic views to its ValueMirror to make it easy for developers to peak into the contents of the JSArrayBuffer. These were previously real properties, but that's just wrong (both intuitively and semantically), and they should instead be internal properties. Drive-by-fix: The [[IsDetached]] internal property should only be shown on actually detached JSArrayBuffer's to reduce visual clutter. And for detached JSArrayBuffers creating views on them throws TypeErrors per specification, so we shouldn't attempt to display views on them. Bug: v8:9308, chromium:1162229 Change-Id: Ia006de7873ca4b27aae7d00d46e1b69d2e326449 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2606047 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
Bug: chromium:116229 Change-Id: I16e185c2156dd7ba812f7d484c2e281febfa3635 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2606048 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
We accidentally compiled the source for Debug-Evaluate on Wasm frames twice, and used the first script result as outer function info for the second, actual compile (which goes via the `eval` machinery). Also unify DebugEvaluate::Local and DebugEvaluate::WebAssembly, since they are essentially very similar, except for the context. Bug: chromium:1127914 Change-Id: I8eb85c128c05ab1d4fcb73061de89b0942d1e5c8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2605198 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
LiuYu authored
This fix the following instructions: kExprI32SConvertF64 in mips32, RecordSpillsInSafepoint in mips32 and mips64. Change-Id: I762fe4a7afa06fa8470fb0de932756a145d66099 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2605905 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by:
-
Zhi An Ng authored
Prototype these 4 instructions: - i64x2.widen_low_i32x4_s - i64x2.widen_high_i32x4_s - i64x2.widen_low_i32x4_u - i64x2.widen_high_i32x4_u Bug: v8:10972 Change-Id: I3defd0a2431252bc3f5bb45e022e62b37beb34ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2601012 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ffd4756..7c34525 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/46ef281..3b39cef TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3881d27d5aec152fbb1059e8db3a2e85337a6b77 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2605670Reviewed-by:
-
Zhi An Ng authored
Bug: v8:10971 Change-Id: I60186a445f3a5ad366cba4e6bcb16519098aa6ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2601009 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Zhi An Ng authored
This will make these functions usable from Liftoff when we later implement extended multiply instructions in Liftoff. Bug: v8:11262 Change-Id: I5fb105bc0184675eb60cd8ae63cc13955b0f767d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2601876 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Zhi An Ng authored
In AVX, it is better to use the appropriate integer or floating point moves depending on which instructions produce/consume these moves, since there can be a delay moving from integer to floating point domain. On SSE systems, it is less important, and we can move movaps/movups which is 1 byte shorter than movdqa/movdqu. This patch cleans up a couple of places, and defines macro-assembler functions Movdqa, Movdqu, Movapd, to call into movaps/movups when AVX is not supported. Change-Id: Iba6c54e218875f1a70f61792978d7b3f69edfb4b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2599843 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
- 28 Dec, 2020 3 commits
-
-
Milad Fa authored
Change-Id: Idae6adfd81889da96e7f9dad8781c9a285bea72a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2601343Reviewed-by:
-
Benedikt Meurer authored
With https://crrev.com/c/2087396 we introduced a new CDP method `Debugger.executeWasmEvaluator()`, which we originally intended to use as the foundation for Debug-Evaluate on Wasm frames. However in the process of prototyping we learned that it is too costly and too inefficient to use WebAssembly modules here, and we switched to regular Debug-Evaluate with JavaScript instead (with a special debug proxy exposed that allows JavaScript to peak into the Wasm frame), since JavaScript is better suited for short-lived / short-running snippets and we don't need clang and wasm-ld then to generate these snippets. The JavaScript exposed debug proxy (as described in [1]) not only enables more powerful and flexible Debug-Evaluate for the DWARF C/C++ extension, but also serves as the basis for various aspects of the Basic Wasm Developer Experience. In order to pay down technical debt and to keep the maintenance overhead low, we should remove the initial prototype now, also to ensure that we don't accidentally attract other users of CDP to rely on this unsupported API (despite it being marked as "experimental"). [1]: https://docs.google.com/document/d/1VZOJrU2VsqOZe3IUzbwQWQQSZwgGySsm5119Ust1gUA Fixed: chromium:1162062 Bug: chromium:1020120, chromium:1068571, chromium:1127914 Change-Id: I6dba8c906a8675ce6c29a52e3c32bb6626a27247 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2605186 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3d38a62..ffd4756 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2692889cddf15d7d9adfbe9594bd94fa41aea87c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2604592Reviewed-by:
-
- 27 Dec, 2020 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c5cfdff..3d38a62 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/ea9f1f7..2277272 Rolling v8/buildtools/linux64: git_revision:53d92014bf94c3893886470a1c7c1289f8818db0..git_revision:0d67e272bdb8145f87d238bc0b2cb8bf80ccec90 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic602dc2aafdb1224b64b1407de0415acc1453ae2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2604148Reviewed-by:
-
