- 20 Dec, 2018 36 commits
-
-
Ulan Degenbaev authored
This fixes a bug from 0400fc20, which assumed that we can set the markbits and the marked descriptors counter independently. This does not work because the Scavenger skips slots recording for non-black promoted objects. The fix is to mark the descriptor array black whenever we change the marked descriptors counter. Bug: v8:8617, v8:8618, v8:8486 Tbr: mlippautz@chromium.org Change-Id: I80f3488061fa648b6c81963ba802ef045d92bcc6 Reviewed-on: https://chromium-review.googlesource.com/c/1387486 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#58417}
-
Sathya Gunasekaran authored
Bug: v8:5368 Change-Id: I0f6edc028baf009b81612ecc4be9a70c3621bc4e Reviewed-on: https://chromium-review.googlesource.com/c/1385528Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#58416}
-
Adam Klein authored
Also remove ImportNow() and helper runtime functions and Context methods that are now unused. Bug: v8:7624 Change-Id: I109b112d2147240e72eb0ed6112a267057de59cb Reviewed-on: https://chromium-review.googlesource.com/c/1385224 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58415}
-
Michael Lippautz authored
The DCHECK was overly restrictive when checking that a weak handle is not a finalizer when hitting it through a regular scavenge processing path. Only happened with finalizers to unmodified API wrappers or regular objects that were also marked as independent. Bug: v8:8586 Change-Id: I2c2a5b21f6e8a5ddc6671f762b508ba083c04335 Reviewed-on: https://chromium-review.googlesource.com/c/1387485Reviewed-by:
-
Adam Klein authored
This CL makes several changes to bootstrapper to reduce code verbosity: - Adds an InstallToStringTag helper and uses it everywhere (while removing now-redundant comments). - Reduces explicit calls to Factory::InternalizeUtf8String by adding some overloads of helpers and of JSObject::AddProperty. - Uses InstallConstant in all applicable cases. - Removes attributes arguments when all callers pass DONT_ENUM. Change-Id: Ifb5f5102f5fbf89d475045270eeda78a2ee99248 Reviewed-on: https://chromium-review.googlesource.com/c/1385526Reviewed-by: -
Alexei Filippov authored
It failed on the CHECK when receiver object was JSAsyncFunctionObject. BUG=chromium:901241 Change-Id: I7ce563758185908728135005cb5ba2878fdea446 Reviewed-on: https://chromium-review.googlesource.com/c/1382822Reviewed-by:
-
Clemens Hammacher authored
This silences the new presubmit check for the whole src/compiler directory. R=neis@chromium.org Bug: v8:8616 Change-Id: Ib76d669861f829b4f35f9e9921b72b073300da08 Reviewed-on: https://chromium-review.googlesource.com/c/1386871Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58411}
-
Jakob Kummerow authored
Merging the temporary HeapObjectPtr back into HeapObject. Bug: v8:3770 Change-Id: I5bcd23ca2f5ba862cf5b52955dca143e531c637b Reviewed-on: https://chromium-review.googlesource.com/c/1386492 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
The simulated C++ signature for generated code entry points should rely on primitive values (as opposed to ObjectPtr). Bug: v8:3770 Change-Id: I6f6f4dc8a93c7ba46bfc7052dc4745b16e9fd62f Reviewed-on: https://chromium-review.googlesource.com/c/1386875Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#58409}
-
Clemens Hammacher authored
Avoid named constructors for Value and Control and the hack to also have them on subclasses. Instead, add a new template type and a constructor to create the subtype from this template. Instead of the named constructors on the subtype, we now create a template and initialize the subtype from the template. R=herhut@chromium.org Bug: v8:8562 Change-Id: I374fc4104ab1ae5769c587bdf5a4ca7f9a0a10d7 Reviewed-on: https://chromium-review.googlesource.com/c/1382454Reviewed-by:
Stephan Herhut <herhut@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58408}
-
Sergiy Belozorov authored
R=machenbach@chromium.org No-Try: true Bug: chromium:893593 Change-Id: I11cce7694eb7755ccee42c9a342fc1aa22663d85 Reviewed-on: https://chromium-review.googlesource.com/c/1382468Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#58407}
-
Clemens Hammacher authored
The V8_NOEXCEPT annotation is not needed for deleted class members. Also our DISALLOW_COPY_AND_ASSIGN macro does not add it there. Additionally, include the file name to find the reported location more easy. R=jkummerow@chromium.org Bug: v8:8616 No-Try: true Change-Id: I93162804493542fed2a5832649b80386e338bd47 Reviewed-on: https://chromium-review.googlesource.com/c/1386870 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#58406}
-
Toon Verwaest authored
This simplifies NextArrowFunctionInfo, allows us to Scope::Snapshot::Reparent directly rather than moving it, and allows us to skip reparenting in the simple parameter arrow function cases. This CL additionally fixes arrow function name inferring. Change-Id: Ie3e5ea778f3d7b84b2a10d4f4ff73931cfc9384a Reviewed-on: https://chromium-review.googlesource.com/c/1386147Reviewed-by:
-
Clemens Hammacher authored
Forgetting V8_NOEXCEPT annotations on copy constructors, move constructors, copy assignment operators or move assignment operators can cause subtle performance bugs or compilation failures, sometimes only on specific architectures or compilers. Thus check that all those special class members are marked V8_NOEXCEPT. This check is only executed on modified files for now, and can be bypassed. Please report any false positives on the associated bug. Bug: v8:8616 R=jgruber@chromium.org, machenbach@chromium.org Change-Id: Ieefd8e39fbb1b314dc8d72ee87f6138b784205af Reviewed-on: https://chromium-review.googlesource.com/c/1386496Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/9945d79..4f828d0 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/5cce74c..0e1cbc4 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/203676d..7d95d86 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/c6a8d11..2cc6e25 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/2823bdd..23de016 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/1bc365f..c8e8d67 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I016fd6ce19da97aef7aa97362731f7a5e220bfd6 Reviewed-on: https://chromium-review.googlesource.com/c/1386724Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#58403}
-
Ross McIlroy authored
BUG=v8:8395 Change-Id: Ibf97962f1bdfa5c83cd228569c88abcf9d0a7c51 Reviewed-on: https://chromium-review.googlesource.com/c/1386487Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#58402}
-
Jakob Kummerow authored
This does not include moving function definitions from objects-inl.h to heap-object-inl.h, because that would be messy for no immediate benefit. This is in preparation for merging HeapObjectPtr into HeapObject. Bug: v8:5402 Change-Id: Id170d9cac8ebabb2876b85bad29ce90fe02d842d Reviewed-on: https://chromium-review.googlesource.com/c/1386491Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#58401}
-
Yang Guo authored
Change-Id: I8de0f11c0a7d21d980f5d8691a6e3888a386cbba Reviewed-on: https://chromium-review.googlesource.com/c/1386144Reviewed-by:
-
Sergiy Belozorov authored
R=machenbach@chromium.org Bug: chromium:893593 Change-Id: Ic3a3612fc557b1f35b4632cfab553b4492ec6222 Reviewed-on: https://chromium-review.googlesource.com/c/1382734Reviewed-by:
-
Camillo Bruni authored
- Reduce ExpressionResultScope size by reusing accessing the generator from its RegisterAllocationScope member - Mark the ExpressionResultScope destructor non-virtual since there are no destructors in subclasses Change-Id: I3abe1856c091100217c668cd6bd5e7fd96eb8397 Reviewed-on: https://chromium-review.googlesource.com/c/1386485Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#58398}
-
Sigurd Schneider authored
This is work towards making instructions in the sequence view selectable. For now, they are clickable and will select the corresponding instructions in the disassembly view. Bug: v8:7327 Notry: true Change-Id: I8850efeec7f94487bd80c11a7ad250a959062393 Reviewed-on: https://chromium-review.googlesource.com/c/1386112 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This reverts commit 0e22ec73. Reason for revert: Breaks layout tests: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064/28814 Original change's description: > [regexp] Escape newlines when setting [[OriginalSource]] > > This escapes LineTerminator characters in a regexp pattern when > creating the string that will be stored in the [[OriginalSource]] slot. > > As an example, the source property for all following objects will equal > "\n" (a '\' character followed by 'n'): > > /\n/ > new RegExp("\n") > new RegExp("\\n") > > Bug: v8:1982, chromium:855009 > Change-Id: I3b539497a0697e3d51ec969cae49308b0b312a19 > Reviewed-on: https://chromium-review.googlesource.com/c/1384316 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Mathias Bynens <mathias@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58387} TBR=yangguo@chromium.org,jgruber@chromium.org,mathias@chromium.org Change-Id: I1db7e6a0c6cd1cd995fe9f499458108e88dc8cb9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:1982, chromium:855009 Reviewed-on: https://chromium-review.googlesource.com/c/1386493Reviewed-by:
-
Georg Neis authored
The check was accidentally done only when a stress-flag was enabled. Moreover, the check is actually unnecessary because the code will deopt itself once it gets run. Also add a DCHECK that these invalidations can only happen due to pretenuring changes. Bug: v8:8520 Change-Id: Ibb008f93e9e417d2f88cd5fd8fd1380db88bbb85 Reviewed-on: https://chromium-review.googlesource.com/c/1384304Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58395}
-
Clemens Hammacher authored
The source register of {movsx_b} must be a byte register. Drive-by: Add missing sign extension opcodes to wasm-constants.js. R=herhut@chromium.org Bug: chromium:916869 Change-Id: I571c1ea2a0e197afefc810f306eed238250cd5e0 Reviewed-on: https://chromium-review.googlesource.com/c/1386110Reviewed-by: -
Georg Neis authored
This reverts commit ac85ab0a. A chromium test caused trouble and was taken care of in https://chromium-review.googlesource.com/c/1384064. Original change's description: > [turbofan] Use feedback when reducing global loads/stores. > > We already record the script context location or the property cell > as feedback of the global load/store IC, so Turbofan doesn't need > to do the lookups again. TBR=sigurds@chromium.org Change-Id: I58bcd9bceec2f9cf401f7b0fc4460a6da6cd0abc Reviewed-on: https://chromium-review.googlesource.com/c/1386404 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Jakob Gruber authored
V8 is almost completely JS-free. There's no need to ship the minifier any more. Bug: v8:7624,v8:5505,v8:4240,v8:4235,v8:4188,v8:1557 Change-Id: Iee15bf68c66bac27a67fe70e10b1edd4dcef89d1 Reviewed-on: https://chromium-review.googlesource.com/c/1386146Reviewed-by:
-
Mythri authored
Disable mjsunit/spread-large-array and mjsunit/spread-large-string in lite mode. Bug: v8:8394 Change-Id: I630efc1e2b397189b0ea1e602fbfa472851abe1f Reviewed-on: https://chromium-review.googlesource.com/c/1386484Reviewed-by:
-
Toon Verwaest authored
- Merge is_simple branches at the top - Remove block around inner_body parsing. Always merge fully at the end. - Remove conditional inner block adding to outer body. Simply add it to the inner body making merge push it to the parent. Change-Id: I1f062918a7abac354b949136463517bd0440984f Reviewed-on: https://chromium-review.googlesource.com/c/1386111 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This changes the CompileLazyDeoptimizedCode call to use the standard builtin calling sequence, which (for optimized code) creates an inlined off-heap trampoline instead of embedding a CODE_TARGET. Drive-by: Add missing conditional jump handling to masm::Jump. It was missing only for the case of inlined trampolines. Bug: v8:7777 Change-Id: Id79a10ba99fd97c1b3351774b9ecf5adf10ee6d4 Reviewed-on: https://chromium-review.googlesource.com/c/1382460 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Georg Neis authored
Bug: chromium:906567 Change-Id: I1c459bd5acd425f1433b6727214a8f5ed2fe0177 Reviewed-on: https://chromium-review.googlesource.com/c/1384313Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58388}
-
Jakob Gruber authored
This escapes LineTerminator characters in a regexp pattern when creating the string that will be stored in the [[OriginalSource]] slot. As an example, the source property for all following objects will equal "\n" (a '\' character followed by 'n'): /\n/ new RegExp("\n") new RegExp("\\n") Bug: v8:1982, chromium:855009 Change-Id: I3b539497a0697e3d51ec969cae49308b0b312a19 Reviewed-on: https://chromium-review.googlesource.com/c/1384316 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#58387}
-
Frank Tang authored
Remove flags and all string in JSLocale This does not change the logic of Intl.Locale constructor but only the way we store the information. Preparation for logic rewrite that sync with latest spec. Bug: v8:7684 Change-Id: Ib61705eaf00e5bcf63443c55c29f0b0b61f8e4c9 Reviewed-on: https://chromium-review.googlesource.com/c/1377996 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Frank Tang authored
Bug: v8:7808 Change-Id: Idcfd927d9e4df3dc30ab8cf815149c6ede76b852 Reviewed-on: https://chromium-review.googlesource.com/c/1384800Reviewed-by:
-
Frank Tang authored
Follow up comments in https://chromium-review.googlesource.com/c/v8/v8/+/1378658 Bug: v8:8468 Change-Id: I1bfcc305959e8230b08db034d99a2e6ac867775e Reviewed-on: https://chromium-review.googlesource.com/c/1385166 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Alexei Filippov authored
BUG=chromium:897816 Change-Id: Ie28efcab73ccbcb6d8b1a7508b99aec59f3a3ae3 Reviewed-on: https://chromium-review.googlesource.com/c/1384795Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#58383}
-
Rafael Cintron authored
Coalesce all of the individual contributors from Microsoft in AUTHORS file into *@microsoft.com. Change-Id: Ic0e7e01e8055b426c86fee2a5af2174f071c872a Reviewed-on: https://chromium-review.googlesource.com/c/1385504Reviewed-by:
-
- 19 Dec, 2018 4 commits
-
-
Adam Klein authored
It's been enabled for several releases now. R=gsathya@chromium.org Change-Id: Ib1806a1373821ee542dae2fd80f639b56bd99ed9 Reviewed-on: https://chromium-review.googlesource.com/c/1384796Reviewed-by:
-
Sathya Gunasekaran authored
Since we have FindEntry, this is redudant. This patch also * Makes the tests for FindEntry stricter by testing the value * Makes the OrderedNameDictionary::Add and SmallOrderedNameDictionary::Add consistent by using GetHash and using a DCHECK for the FindEntry call Bug: v8:6443, v8:7569 Change-Id: I4859cd6735ec385c19acad6ce5cecaeac45173dd Reviewed-on: https://chromium-review.googlesource.com/c/1382828 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#58380}
-
Igor Sheludko authored
Bug: v8:8477, v8:8562 Change-Id: Iaa995c8fbb9f309dadac4e308d727f628fdb8b3c Reviewed-on: https://chromium-review.googlesource.com/c/1384314Reviewed-by:
-
Sathya Gunasekaran authored
Bug: v8:6443, v8:7569 Change-Id: I1bcd3458c2d548d36bf2961a2faf41919c433a91 Reviewed-on: https://chromium-review.googlesource.com/c/1382829 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
