- 30 May, 2017 11 commits
-
-
Jochen Eisinger authored
Also enable post-upload-hooks R=machenbach@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I8001394454f5d71d48a5e6261c891d6c7c2c3825 Reviewed-on: https://chromium-review.googlesource.com/518167Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#45590}
-
Clemens Hammacher authored
Both lazy initialization and static initialization (via static initializer) are bad. Fortunately, the arrays we are constructing are constant anyway, so we can just compute them at compile time. This is enforced by making them constexpr. This also saves all code needed for the initialization, and makes accesses to the tables faster, as they don't need any atomic operations (via LazyInstance). R=ahaas@chromium.org Change-Id: I7d3ba9b0f2602f596a6c71c8c567e0d1bc306268 Reviewed-on: https://chromium-review.googlesource.com/517083 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#45589}
-
Michael Achenbach authored
V8-part of: https://chromium-review.googlesource.com/c/517791 NOTRY=true NOTREECHECKS=true TBR=kjellander@chromium.org,tandrii@chromium.org,mstarzinger@chromium.org Bug: chromium:726584 Change-Id: I0e8b6adf6938dce02c84f5d5cbde6ff828dcbb08 Reviewed-on: https://chromium-review.googlesource.com/518152 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#45588}
-
Clemens Hammacher authored
This time for the current memory size. This call also used to use the context object stored in the instance, hence it required the instance to be set. This is no longer the case, so the DCHECKs can just be removed. R=ahaas@chromium.org BUG=chromium:727222 Change-Id: I72a7e3e80c3beb15ecad00c5be068e803456797e Reviewed-on: https://chromium-review.googlesource.com/517947Reviewed-by:
-
Wiktor Garbacz authored
Non-printable characters will are printed as escapes. NUL won't terminate error message prematurely now. Change-Id: Ie24b34e377221e9b99d2268f8dfb5ce26d064cc2 Reviewed-on: https://chromium-review.googlesource.com/509490Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Wiktor Garbacz <wiktorg@google.com> Cr-Commit-Position: refs/heads/master@{#45586}
-
Wiktor Garbacz authored
Change-Id: Icf4d67700bae4338ecf66411f2a5f57c5351f688 Reviewed-on: https://chromium-review.googlesource.com/504867Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Wiktor Garbacz <wiktorg@google.com> Cr-Commit-Position: refs/heads/master@{#45585}
-
ulan authored
This is consistent with C++ memory model and avoids confusion with GC write barrier. BUG= Review-Url: https://codereview.chromium.org/2912773002 Cr-Commit-Position: refs/heads/master@{#45584}
-
Jochen Eisinger authored
This reverts commit 75843f4f. Reason for revert: Shouldn't affect test Original change's description: > Revert "Remove ENTER_V8_DO_NOT_USE usage from other macros" > > This reverts commit 2ba1fcda. > > Reason for revert: Speculative for: > https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/8413 > > Original change's description: > > Remove ENTER_V8_DO_NOT_USE usage from other macros > > > > Eventually I want to delete that macro, so just inline it at the places > > where we'll need to keep it. > > > > BUG=v8:5830 > > R=marja@chromium.org > > > > Change-Id: I904a1dd3555c23c69e457e078faaaa86a9514932 > > Reviewed-on: https://chromium-review.googlesource.com/518043 > > Reviewed-by: Marja Hölttä <marja@chromium.org> > > Commit-Queue: Jochen Eisinger <jochen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#45561} > > NOTRY=true > NOTREECHECKS=true > NOPRESUBMIT=true > > TBR=marja@chromium.org,jochen@chromium.org > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > BUG=v8:5830 > > Change-Id: I7097597d2695980f71fc93a79999d59956dd76c9 > Reviewed-on: https://chromium-review.googlesource.com/518107 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45578} TBR=machenbach@chromium.org,marja@chromium.org,jochen@chromium.org,v8-reviews@googlegroups.com No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=v8:5830 Change-Id: I148f2415249c4f2a554229f814ae46688acc3918 Reviewed-on: https://chromium-review.googlesource.com/518111Reviewed-by:
-
Jochen Eisinger authored
Original change's description: > Get rid of PREPARE_FOR_EXECUTION_WITH_ISOLATE > > Replace the macro with more generic macros expanding to the same > code. > > BUG=v8:5830 > R=marja@chromium.org > > Change-Id: Ibf31fa4d89960a025af859198e190910c5608a20 > Reviewed-on: https://chromium-review.googlesource.com/518006 > Commit-Queue: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45560} TBR=marja@chromium.org BUG=v8:5830 Change-Id: I5492286bde4532ad092ac36bd54d99583844ada1 Reviewed-on: https://chromium-review.googlesource.com/518110 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Michael Achenbach authored
V8-side for https://chromium-review.googlesource.com/c/517949/ NOTRY=true NOTREECHECKS=true Bug: chromium:724486 Change-Id: Id778b5b0483bf917cf903d86289c1637ab9edda4 Reviewed-on: https://chromium-review.googlesource.com/518164 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#45581}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ff6a082..e840a06 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Change-Id: Ie172612a3753a11ef85b4762b0e3f12891e040ad Reviewed-on: https://chromium-review.googlesource.com/517727Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#45580}
-
- 29 May, 2017 29 commits
-
-
Michael Achenbach authored
This reverts commit 5031f608. Reason for revert: Speculative for: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/8413 Original change's description: > Get rid of PREPARE_FOR_EXECUTION_WITH_ISOLATE > > Replace the macro with more generic macros expanding to the same > code. > > BUG=v8:5830 > R=marja@chromium.org > > Change-Id: Ibf31fa4d89960a025af859198e190910c5608a20 > Reviewed-on: https://chromium-review.googlesource.com/518006 > Commit-Queue: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45560} NOTRY=true NOTREECHECKS=true NOPRESUBMIT=true TBR=marja@chromium.org,jochen@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=v8:5830 Change-Id: I1135da755ec78d756edcf3dd6da9e94f1768bfb7 Reviewed-on: https://chromium-review.googlesource.com/518108Reviewed-by:
-
Michael Achenbach authored
This reverts commit 2ba1fcda. Reason for revert: Speculative for: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/8413 Original change's description: > Remove ENTER_V8_DO_NOT_USE usage from other macros > > Eventually I want to delete that macro, so just inline it at the places > where we'll need to keep it. > > BUG=v8:5830 > R=marja@chromium.org > > Change-Id: I904a1dd3555c23c69e457e078faaaa86a9514932 > Reviewed-on: https://chromium-review.googlesource.com/518043 > Reviewed-by: Marja Hölttä <marja@chromium.org> > Commit-Queue: Jochen Eisinger <jochen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45561} NOTRY=true NOTREECHECKS=true NOPRESUBMIT=true TBR=marja@chromium.org,jochen@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=v8:5830 Change-Id: I7097597d2695980f71fc93a79999d59956dd76c9 Reviewed-on: https://chromium-review.googlesource.com/518107 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
kschimpf authored
Add histogram to track sizes of share array buffers in Wasm/Js. Associated with Chrome CL: https://codereview.chromium.org/2898953003 BUG=chromium:725309 Review-Url: https://codereview.chromium.org/2902773002 Cr-Commit-Position: refs/heads/master@{#45577}
-
kschimpf authored
By moving StatsTable from class Isolate to class Counters, it make the class StatsTable thead safe. This is needed because these two classes call each other, and for background compilation, instances of the Counters class can persist longer that the corresponding Isolate it came from. It also removes unnecessary hops to the the Isolate, and checks if the StatsTable has been created, for these communications. BUG=v8:6361 Review-Url: https://codereview.chromium.org/2906063002 Cr-Commit-Position: refs/heads/master@{#45576}
-
Michael Achenbach authored
This reverts commit 81d3427b. Reason for revert: Several gc related failures, e.g.: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/13488 Original change's description: > [heap] Move pointers updating to ItemParallelJob > > Furthermore avoid lock-step between pointer updating phases as they > should execute in parallel without synchronization restrictions. > > Bug: chromium:726040 > Change-Id: I26ce0d1f2a4637ff5610cae556113e3d736788e2 > Reviewed-on: https://chromium-review.googlesource.com/518103 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#45574} NOPRESUBMIT=true NOTRY=true NOTREECHECKS=true TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:726040 Change-Id: I60860aef390605d07bc520141cab9d5be9b712b3 Reviewed-on: https://chromium-review.googlesource.com/518106 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Furthermore avoid lock-step between pointer updating phases as they should execute in parallel without synchronization restrictions. Bug: chromium:726040 Change-Id: I26ce0d1f2a4637ff5610cae556113e3d736788e2 Reviewed-on: https://chromium-review.googlesource.com/518103 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#45574}
-
Michael Starzinger authored
This widens the range of value output counts to 32 bit on the {Operator} class. Note that the limit imposed by the parser is 65535 parameters for each function, but the {Start} node has additional value outputs. R=jarin@chromium.org TEST=mjsunit/regress/regress-crbug-724153 BUG=chromium:724153 Change-Id: I21b5d947cc2305b255ddbbff6ec1dfa5c02784c7 Reviewed-on: https://chromium-review.googlesource.com/517489Reviewed-by:Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#45573}
-
Toon Verwaest authored
Bug: Change-Id: Ie754efaec80eb175ac18c328c750524009ca8e60 Reviewed-on: https://chromium-review.googlesource.com/517104Reviewed-by:
-
ulan authored
BUG= Review-Url: https://codereview.chromium.org/2906313002 Cr-Commit-Position: refs/heads/master@{#45571}
-
ulan authored
BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2910933002 Cr-Commit-Position: refs/heads/master@{#45570}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/53a7b31..ff6a082 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/98f00fa..1045741 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/51b3178..ea7d9cf Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/05f3060..34e6d43 Rolling v8/tools/swarming_client: https://chromium.googlesource.com/external/swarming.client/+log/a941a08..5c4eed8 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Change-Id: Ic7e269d5c8e3051caf61c117465bfcdd96cb5266 Reviewed-on: https://chromium-review.googlesource.com/517644Reviewed-by:
-
Michael Starzinger authored
This removes special support in the compilation pipeline to keep alive unoptimized code for inlined functions (i.e. preventing the code flusher from clearing it). Now that the code flusher is gone, this is obsolete. R=jarin@chromium.org Change-Id: I00361d12f2d17556056d06c10ad19f09a4772cd8 Reviewed-on: https://chromium-review.googlesource.com/517948Reviewed-by:
-
Peter Marshall authored
Bug: chromium:725865 Change-Id: I94006d45aefb969fb0cf98ec475c30c14b3837fa Reviewed-on: https://chromium-review.googlesource.com/517488Reviewed-by:
-
Marja Hölttä authored
For non-simple param lists, the parser first declares a TEMPORARY for each param, and then the named variables as locals. The TEMPORARY variables determine the parameter count. This CL makes the PreParser produce the same parameter count as the Parser. BUG=v8:5516 Change-Id: I8a794d6a8342145ab7934d922e2d69450d67b199 Reviewed-on: https://chromium-review.googlesource.com/517944 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#45566}
-
Marja Hölttä authored
BUG=v8:5402 Change-Id: If5f763e6a11d446e36719277a18b00a0cd8df8fa Reviewed-on: https://chromium-review.googlesource.com/517162 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Michael Achenbach authored
Manually rolls: https://chromium.googlesource.com/chromium/src/build/+log/5488ca8df..53a7b319 Fixes gyp build after: https: //codereview.chromium.org/2900193003 Change-Id: I0249aa7d1c40bcb1533c56577bfbda4aedd8cbf9 Reviewed-on: https://chromium-review.googlesource.com/518144Reviewed-by:
-
Camillo Bruni authored
Bug: v8:6211 Change-Id: If6d2ef7889ae6a0c3aa430d3f69c53f19cc1f1c6 Reviewed-on: https://chromium-review.googlesource.com/509571Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#45563}
-
Jochen Eisinger authored
R=machenbach@chromium.org Change-Id: I48b6bda0bfb3c8aef117616015ee4225d4bdecfc Reviewed-on: https://chromium-review.googlesource.com/517486 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Jochen Eisinger authored
Eventually I want to delete that macro, so just inline it at the places where we'll need to keep it. BUG=v8:5830 R=marja@chromium.org Change-Id: I904a1dd3555c23c69e457e078faaaa86a9514932 Reviewed-on: https://chromium-review.googlesource.com/518043Reviewed-by:
-
Jochen Eisinger authored
Replace the macro with more generic macros expanding to the same code. BUG=v8:5830 R=marja@chromium.org Change-Id: Ibf31fa4d89960a025af859198e190910c5608a20 Reviewed-on: https://chromium-review.googlesource.com/518006 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
For lazy compilation, we encode information about table exports in the deoptimization data. This information is rebuilt on each instantiation, so we need to reset it when reusing code objects from another instance. R=ahaas@chromium.org BUG=chromium:727219 Change-Id: I90557ef06e692d0a8323223cac26679efcfa408b Reviewed-on: https://chromium-review.googlesource.com/517945Reviewed-by:
-
Clemens Hammacher authored
It happens frequently that unrelated compiler errors lead to the instantiation of {read_leb_tail} with an invalid {byte_index}, which again triggers compiler errors. This change fixes this, such that illegal instantiation just triggers a static_assert and nothing more. This helps to spot the actual error. Drive-by: Mark {Min} and {Max} constexpr, such that they can produce constexpr results. Note that the result will only be constexpr if both arguments are constexpr. R=ahaas@chromium.org Change-Id: I35d6865a7f569d72ace0debb045ac615cfd87d92 Reviewed-on: https://chromium-review.googlesource.com/518005Reviewed-by: -
Jochen Eisinger authored
All APIs that can throw exceptions should return Maybe<> values BUG=none R=neis@chromium.org,gsathya@chromium.org Change-Id: I6a6e5888cd71257bb02bdcfcc587c909d0c1d8f4 Reviewed-on: https://chromium-review.googlesource.com/517785 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#45557}
-
Clemens Hammacher authored
WasmGraphBuilder::GrowMemory does not access the module or the instance any more. This was initially needed to reference the context as a HeapConstant in the code. This CL just removes the DCHECKs, which failed with the --wasm-lazy-compilation flag. R=ahaas@chromium.org BUG=chromium:726665 Change-Id: Ieac53fe376256c47e8ef2fafca818a99ff063683 Reviewed-on: https://chromium-review.googlesource.com/516706Reviewed-by:
-
Clemens Hammacher authored
Parallel compilation should only be chosen if there are background threads available. Otherwise, the overhead of orchestrating (non-)parallel work can be omitted by just compiling synchronously. R=ahaas@chromium.org Change-Id: I333fb87e07fdb3260ab4c9c2c1885a1df4c5e4ef Reviewed-on: https://chromium-review.googlesource.com/513062Reviewed-by:
-
Jochen Eisinger authored
Also move the soon-to-be-deprecated version to deprecated BUG=none R=ulan@chromium.org Change-Id: I2252404f63e25ac35c7798daf66b36144bef6a7e Reviewed-on: https://chromium-review.googlesource.com/518162Reviewed-by:
-
ulan authored
BUG= Review-Url: https://codereview.chromium.org/2900603004 Cr-Commit-Position: refs/heads/master@{#45553}
-
Michael Achenbach authored
Tests should instead be skipped or fixed. Existing timeout expectations are either optimistically deleted or replaced by the SLOW keyword. Change-Id: Ic43f52bf18d0702674c95f9263a109041a1c9cd8 Reviewed-on: https://chromium-review.googlesource.com/518122Reviewed-by:
-
Sathya Gunasekaran authored
Implements the Allocate, Add, and HasKey operations. Also, adds GC support for this new instance type. Bug: v8:6443 Change-Id: I1cc7ba2faead2a11f7b0381a57858629e123aee6 Reviewed-on: https://chromium-review.googlesource.com/500447 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
