- 15 Jan, 2018 15 commits
-
-
Michael Achenbach authored
This will add three gc fuzzing flags with 5% likelihood each to the second correctness fuzzing config. The random checks are determined by the top-level random-seed passed to the script. This change depends on setting the fuzzer random seed as default to the standard random seed, since the former isn't explicitly passed by clusterfuzz. NOTRY=true TBR=hpayer@chromium.org Bug: v8:7012 Change-Id: I794dc48bb953b6a95bbc4fc4305ad561bc13b6ee Reviewed-on: https://chromium-review.googlesource.com/865912Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#50577}
-
Michal Majewski authored
Bug: v8:6917 Change-Id: I5136f183bd1728a1ab90a9ebb2560d978e17ef28 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel_ng Reviewed-on: https://chromium-review.googlesource.com/863623 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
-
Yang Guo authored
R=ulan@chromium.org Bug: v8:7303 Change-Id: Ica6db623fbb5a4c4dd3ccf1dcbd6f796bb4406fc Reviewed-on: https://chromium-review.googlesource.com/865907Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#50575}
-
Andreas Haas authored
On arm64, the stack pointer has to be aligned all the time. This alignment was not considered in the creation of the CallDescriptor in the fuzzer and thereby caused a mismatch between the CallDescriptor and code generator. In other words, a callee put return values in a stack slot which was different than the stack slot where the caller expected the return value. With this CL we consider this alignment in the fuzzer. R=clemensh@chromium.org Change-Id: I8c78c24c682b7b8678c0d4d112bae99cf405b184 Reviewed-on: https://chromium-review.googlesource.com/864682Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#50574}
-
Michal Majewski authored
Bug: v8:6917 Change-Id: Iab4e9d7a8f8a4313a6722610fb6a2cfcff703d81 Reviewed-on: https://chromium-review.googlesource.com/866710Reviewed-by:
-
Clemens Hammacher authored
Mixing SSE and AVX instructions can cause severe slowdowns, so always use AVX instructions if available. The {Movss} method of {TurboAssembler} automatically does this, emitting either {vmovss} or {movss}. R=titzer@chromium.org Bug: v8:6600 Change-Id: I45124944964e5a970814c7b50dfbfca333137dc1 Reviewed-on: https://chromium-review.googlesource.com/865910Reviewed-by:Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#50572}
-
Martyn Capewell authored
Remove SetStackPointer function and update assembler tests. Bug: v8:6644 Change-Id: I5ea26e57b848d56433c84d8eea22d7e9b761e6bb Reviewed-on: https://chromium-review.googlesource.com/864147Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Cr-Commit-Position: refs/heads/master@{#50571}
-
Pierre Langlois authored
Every JS function has a bailout check at the beginning which makes sure it was not lazily deoptimized. We can improve the check slightly: - Load the code data container directly with a pc-relative load instead of ADR+LDR. - Check the deoptimization bit with TBZ directly, saving us a TST instruction. - Use one of the macro-assembler's dedicated scratch registers instead of x2. Bug: Change-Id: Iea4824c74ed5a01b18595d5e980788f9745bbb6e Reviewed-on: https://chromium-review.googlesource.com/864446Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Cr-Commit-Position: refs/heads/master@{#50570}
-
Pierre Langlois authored
If a NumberConstant can be represented as a Smi, then lower it to a IntPtrConstant node during simplified lowering. Thanks to this, all backends can match Smi values that can also be encoded as immediates in the instruction selector. Additionally, we can apply the same lowering to the CodeAssembler for the snapshot. As a result, we can remove `mov` instructions generated because Int32Matcher and Int64Matcher didn't not recognize Smis: For 32-bit target, it's common for Smis also be immediates: "if (a < 100) {}" ~~~ mov r1, #200 -> cmp r0, #200 cmp r0, r1 -> blt <> blt <> -> ~~~ On Arm64 particularly, we lose opportunites to use `cbz`: "if (a == 0) {}" ~~~ movz x0, #0x0 -> cbz x1 <> cmp x1, x0 -> b.eq <> -> ~~~ Overall, we do not see an impact on benchmarks such as webtooling. However, we do see noteworthy code size reduction, from 0.5% to 1.5%. Bug: Change-Id: I7fbb718ad51b9036c3514fa31c1326bdd6f2b0e6 Reviewed-on: https://chromium-review.googlesource.com/848814Reviewed-by: -
Clemens Hammacher authored
Instead of passing four arguments to the runtime function, just pass one pointer to a struct containing all information. This makes it much easier to implement memory tracing in Liftoff in a follow-up CL. Also fix a few other minor things like the namespace and the include guards. R=titzer@chromium.org Change-Id: I47d8827cbb896a581585947f594af52f42bdb37c Reviewed-on: https://chromium-review.googlesource.com/863673Reviewed-by:
-
sreten.kovacevic authored
Fix wrong MacroAssembler instruction in kArchCallWasmFunction, which caused over 1000 tests to fail. Bug: Change-Id: I5730f33ec2253d2d5dfaf8a8e6d5414f0668b4bd Reviewed-on: https://chromium-review.googlesource.com/866498Reviewed-by:
Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Cr-Commit-Position: refs/heads/master@{#50567}
-
Michael Achenbach authored
The fast variants set got the same as no variants after crankshaft deprecation and there is no plan to extend it again. Hence we remove the modifier now. TBR=yangguo@chromium.org Bug: v8:7264 Change-Id: Ib577542741841b5b9542327b90afea8d5a62c879 Reviewed-on: https://chromium-review.googlesource.com/866496Reviewed-by:
-
Michal Majewski authored
Bug: v8:6917 Change-Id: Id73e4892a0d1b3b9c5bdd70ccc136e7bd2edf360 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel_ng Reviewed-on: https://chromium-review.googlesource.com/863603 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
-
Michael Achenbach authored
TBR=mvstanton@chromium.org Bug: v8:4495 Change-Id: I8a8beb85ec7e28ca98504d811542dff1fced25dc Reviewed-on: https://chromium-review.googlesource.com/865897Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#50564}
-
Benedikt Meurer authored
For JSCreate nodes with constant inputs we cannot simply assume that the new.target input is a JSFunction, since it can essentially be any JSReceiver that is a constructor, i.e. it can also be a JSBoundFunction. Bug: chromium:801627 Change-Id: Ia37bf9c0a751e4665e1167a3771fbe166473c979 Reviewed-on: https://chromium-review.googlesource.com/866493Reviewed-by:
-
- 14 Jan, 2018 1 commit
-
-
Jaroslav Sevcik authored
This moves the funky conditional code in ScheduleAndSelectInstructions to the caller (the caller mostly knows statically what it wants). My hidden agenda is to prepare the pipeline for post-scheduling passes. Change-Id: Ia6009a6b2472d7211ef213eb4eb551957ae9709c Bug: v8:5267 Reviewed-on: https://chromium-review.googlesource.com/863663 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#50562}
-
- 13 Jan, 2018 2 commits
-
-
Michael Achenbach authored
This reverts commit 42667bab. Reason for revert: Breaks msvc compile: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20msvc/builds/908 Original change's description: > Simplify FunctionKind, saving 4 bits in SharedFunctionInfo > > Since we only need to store 18 different function kinds, > the bitfield approach was wasting space (requiring 11 bits). > > This patch replaces the bitfield with a regular enum, and > updates all the FunctionKind predicates to use comparisons > instead of bitwise ops. > > For the small amount of builtin code that depended upon being > able to do masking to determine whether something is a class > constructor, we still store two extra bits on FunctionKind, > which are computed when the SFI is initialized. > > If this approach causes performance regressions (i.e., if it > turns out that other code was implicitly depending on masking > for fast checks), we can revert this or address it in > other ways (e.g., by doing similar caching of repeated checks > in the caller). > > Change-Id: Iebb3214f564ea8bd7b21e78fda33517d63247124 > Reviewed-on: https://chromium-review.googlesource.com/860896 > Commit-Queue: Adam Klein <adamk@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50559} TBR=adamk@chromium.org,gsathya@chromium.org Change-Id: I8e1faa0ca6213d1e70a00fcb417b1bfa35ebd643 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/866310Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/28d46dd..9e6dcff Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/d3ad6b3..6fe4a32 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/30e5a9f..bac35f5 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ia978edcec12aab14d330afad6c811047cf622260 Reviewed-on: https://chromium-review.googlesource.com/866171 Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#50560}
-
- 12 Jan, 2018 22 commits
-
-
Adam Klein authored
Since we only need to store 18 different function kinds, the bitfield approach was wasting space (requiring 11 bits). This patch replaces the bitfield with a regular enum, and updates all the FunctionKind predicates to use comparisons instead of bitwise ops. For the small amount of builtin code that depended upon being able to do masking to determine whether something is a class constructor, we still store two extra bits on FunctionKind, which are computed when the SFI is initialized. If this approach causes performance regressions (i.e., if it turns out that other code was implicitly depending on masking for fast checks), we can revert this or address it in other ways (e.g., by doing similar caching of repeated checks in the caller). Change-Id: Iebb3214f564ea8bd7b21e78fda33517d63247124 Reviewed-on: https://chromium-review.googlesource.com/860896 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#50559}
-
Adam Klein authored
It was shipped in Chrome 63. Bug: v8:5855 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Icc00b8300622d1c7b5662be8ac5e425b9781f666 Reviewed-on: https://chromium-review.googlesource.com/858381 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This reverts commit 2de796fc. Reason for revert: message test suite doesn't work with code serializer step and predictable mode: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug/builds/18708 Looks like the flag doesn't exist anymore and the output comparison in message tests doesn't like that. Original change's description: > [test] Add more d8-based test suites to d8_default > > This will run those suites with gc stress, code serializer, and verify- > predictable mode. > > TBR=sergiyb@chromium.org > > Bug: v8:7285 > Change-Id: I4184376cf3fc9dd161b1e85ec562ed4266f5b8cf > Reviewed-on: https://chromium-review.googlesource.com/864922 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50555} TBR=machenbach@chromium.org,yangguo@chromium.org,sergiyb@chromium.org,majeski@google.com Change-Id: Id0f26fcef246ed59ce3352c476b0643a64251ba1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7285 Reviewed-on: https://chromium-review.googlesource.com/864685Reviewed-by:
-
Adam Klein authored
This reverts commit 2de796fc. Reason for revert: Fails tests on Linux dbg: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug/builds/18708 Original change's description: > [test] Add more d8-based test suites to d8_default > > This will run those suites with gc stress, code serializer, and verify- > predictable mode. > > TBR=sergiyb@chromium.org > > Bug: v8:7285 > Change-Id: I4184376cf3fc9dd161b1e85ec562ed4266f5b8cf > Reviewed-on: https://chromium-review.googlesource.com/864922 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50555} TBR=machenbach@chromium.org,yangguo@chromium.org,sergiyb@chromium.org,majeski@google.com Change-Id: I8d769829bdb96820e57b1cefcf92fb6976a1031d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7285 Reviewed-on: https://chromium-review.googlesource.com/865334Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#50556}
-
Michael Achenbach authored
This will run those suites with gc stress, code serializer, and verify- predictable mode. TBR=sergiyb@chromium.org Bug: v8:7285 Change-Id: I4184376cf3fc9dd161b1e85ec562ed4266f5b8cf Reviewed-on: https://chromium-review.googlesource.com/864922 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Michael Achenbach authored
TBR=easterbunny Change-Id: I4229d55d8953c74a9b167527b0aae56c3b570a26 Reviewed-on: https://chromium-review.googlesource.com/864664 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
With --jit-to-native, we current don't disassemble any Liftoff code. This CL adds that, and also adds printing of relocation info of native wasm code. R=mstarzinger@chromium.org CC=titzer@chromium.org Bug: v8:6600 Change-Id: Icb1249868224180171107b82e2dd7dc69e23db16 Reviewed-on: https://chromium-review.googlesource.com/863762 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org Bug: chromium:784597 Change-Id: I4218842d46971c9594d12c51e12ab796c1ceabe6 Reviewed-on: https://chromium-review.googlesource.com/857006 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
These opcodes will always call out to a C function for now. R=titzer@chromium.org Bug: v8:6600 Change-Id: I0ba8984d593c0203b46c2814dec4c091754df99a Reviewed-on: https://chromium-review.googlesource.com/860924 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Dan Elphick authored
Add tests with a few Array.of invocations in preparation for adding a CodeStubAssembler generated version. Change-Id: I5aee3f32a584ae31cebcbbe6b0e5491a4bc1da34 Reviewed-on: https://chromium-review.googlesource.com/861884Reviewed-by:
-
Ali Ijaz Sheikh authored
Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Icb3cf7b7f96704e1eaa4c5fbf773b94b70cddc85 Reviewed-on: https://chromium-review.googlesource.com/861302Reviewed-by:
Fadi Meawad <fmeawad@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> Cr-Commit-Position: refs/heads/master@{#50549}
-
Michael Achenbach authored
This reverts commit 22d894c8. Reason for revert: https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder/builds/14553 Original change's description: > [turbofan] Add simplified operator for String.prototype.codePointAt > > This CL adds the simplified operators > StringCodePointAt > SeqStringCodePointAt > and associated lowering. > > Bug: v8:7270 > Change-Id: I5aeefddeec39c3119b2d225e92a3116f802e7b45 > Reviewed-on: https://chromium-review.googlesource.com/861789 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50547} TBR=sigurds@chromium.org,petermarshall@chromium.org,bmeurer@chromium.org Change-Id: If07881fce121538cc4abc72ed5eaa42dd7829101 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7270 Reviewed-on: https://chromium-review.googlesource.com/864662Reviewed-by:
-
Sigurd Schneider authored
This CL adds the simplified operators StringCodePointAt SeqStringCodePointAt and associated lowering. Bug: v8:7270 Change-Id: I5aeefddeec39c3119b2d225e92a3116f802e7b45 Reviewed-on: https://chromium-review.googlesource.com/861789 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#50547}
-
Sigurd Schneider authored
This CL shares most of the implementation in the string builtins String.prototype.charAt/charCodeAt/codePointAt. Bug: v8:7270 Change-Id: Ibe43a0a22aa17fb5cd7f0519fd877fa8ae483863 Reviewed-on: https://chromium-review.googlesource.com/861786 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#50546}
-
Michael Achenbach authored
This adds a reduced version of bot_default with only d8-based test suites. Those can be used for gc stress testing, fuzzing and predictable mode. This also adds a missing explicit build rule for the debugger test suite. It's working as it's part of the isolate file, but incremental re-isolation might break on code changes. Running the tests is still commented out to allow the infra-side to land. Afterwards, we'll activate the extra testing as a V8 CL commenting the lines back in. Bug: v8:7285 Change-Id: I7b758c212f0c4ae3d2f79beea5ec597cee479565 Reviewed-on: https://chromium-review.googlesource.com/864045Reviewed-by:
-
Ross McIlroy authored
BUG=chromium:801097 Change-Id: Ie631822a668b55b0f0790b719e7d8cdde78d95c6 Reviewed-on: https://chromium-review.googlesource.com/861882 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=machenbach@chromium.org No-Try: true Change-Id: I97dcb68e243aaaac4e103c862a0c28a41fe6553b Reviewed-on: https://chromium-review.googlesource.com/864264Reviewed-by:
-
Sigurd Schneider authored
This changes the return type of - StringBuiltinsAssembler::LoadSurrogatePairAt - CodeStubAssembler::StringCharCodeAt from TNode<Uint32T> to TNode<Int32T>. This is justified because both functions only return values in the positive range of signed integer. This improves interoperatability, as Int32T can be SmiTagged, while this is not allowed for Uint32T. Bug: v8:7270 Change-Id: I2768b6ec320fa0fbcf3e55af784339472fa4909e Reviewed-on: https://chromium-review.googlesource.com/861782Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#50542}
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org No-Try: true Change-Id: Ic218c155bf1fd5eb3065bd36278e5ee7c61ae400 Reviewed-on: https://chromium-review.googlesource.com/864326Reviewed-by:
-
Kanghua Yu authored
-- original -- 143 0fb7400b movzxwl rax,[rax+0xb] 147 663d8200745a cmp rax,0x5a740082 14d 663d83007437 cmp rax,0x37740083 -- patched -- 143 0fb7400b movzxwl rax,[rax+0xb] 147 663d8200 cmp rax,0x82 14b 745a jz 0x3f54d39c767 <+0x1a7> 14d 663d8300 cmp rax,0x83 151 7437 jz 0x3f54d39c74a <+0x18a> Bug: Change-Id: I86f2147d983da9c33ea59a6d8a0a634dcaf32108 Reviewed-on: https://chromium-review.googlesource.com/833508 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Bug: chromium:800810 Change-Id: I905159b5414b4e9fd9db62582d34ca4c264a4d8a Reviewed-on: https://chromium-review.googlesource.com/860927Reviewed-by:
-
Jakob Gruber authored
Flag getters (e.g. RegExp.p.get global) are defined on the prototype and thus we need to use the more general BranchIfFastRegExp here instead of IsFastRegExpNoPrototype. Bug: chromium:800538 Change-Id: Ib6bc8a4fd3bf2f7dd31538c8dbb61814106c184b Reviewed-on: https://chromium-review.googlesource.com/859767Reviewed-by:
-
