- 24 Apr, 2017 3 commits
-
-
jkummerow authored
In general, deleting a property from a fast-properties object requires transitioning the object to dictionary mode. However, when the most-recently-added property is deleted, we can simply roll back the last map transition that the object went through. This is a performance experiment: it should make things faster, but if it turns out to have more negative than positive impact, we will have to revert it. TBR=bmeurer@chromium.org (just adding a comment) Previously reviewed at https://codereview.chromium.org/2830093002 Previously landed as 98acfb36 / r44799 Review-Url: https://codereview.chromium.org/2840583002 Cr-Commit-Position: refs/heads/master@{#44808}
-
machenbach authored
Revert of [builtins] DeleteProperty: Handle last-added fast properties (patchset #2 id:20001 of https://codereview.chromium.org/2830093002/ ) Reason for revert: Breaks: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/12920 and https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/10281 Original issue's description: > [builtins] DeleteProperty: Handle last-added fast properties > > In general, deleting a property from a fast-properties object > requires transitioning the object to dictionary mode. However, > when the most-recently-added property is deleted, we can simply > roll back the last map transition that the object went through. > > This is a performance experiment: it should make things faster, > but if it turns out to have more negative than positive impact, > we will have to revert it. > > TBR=bmeurer@chromium.org (just adding a comment) > > Review-Url: https://codereview.chromium.org/2830093002 > Cr-Commit-Position: refs/heads/master@{#44799} > Committed: https://chromium.googlesource.com/v8/v8/+/98acfb36e1acf2ab52ab6b6439eb6356c83dcda6 TBR=ishell@chromium.org,jkummerow@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2843473002 Cr-Commit-Position: refs/heads/master@{#44806}
-
jkummerow authored
In general, deleting a property from a fast-properties object requires transitioning the object to dictionary mode. However, when the most-recently-added property is deleted, we can simply roll back the last map transition that the object went through. This is a performance experiment: it should make things faster, but if it turns out to have more negative than positive impact, we will have to revert it. TBR=bmeurer@chromium.org (just adding a comment) Review-Url: https://codereview.chromium.org/2830093002 Cr-Commit-Position: refs/heads/master@{#44799}
-
- 08 Jun, 2016 1 commit
-
-
jkummerow authored
Adding properties to prototypes is faster when we don't force their maps into fast mode yet. Once a prototype shows up in the IC system, its setup phase is likely over, and it makes sense to transition it to fast properties. This patch speeds up the microbenchmark in the bug by 20x. Octane-Typescript sees a 3% improvement. BUG=chromium:607010 Review-Url: https://codereview.chromium.org/2036493006 Cr-Commit-Position: refs/heads/master@{#36828}
-
- 07 Aug, 2014 1 commit
-
-
verwaest@chromium.org authored
BUG= R=ishell@chromium.org Review URL: https://codereview.chromium.org/447293002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22979 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Aug, 2014 1 commit
-
-
verwaest@chromium.org authored
Ensure prototypes always stay fast by turning them fast again after an operation that turned them slow BUG= R=ishell@chromium.org Review URL: https://codereview.chromium.org/439243005 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22827 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 Jun, 2014 1 commit
-
-
jkummerow@chromium.org authored
Review URL: https://codereview.chromium.org/332783002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21817 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-