- 29 Nov, 2020 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/fc6f0ec..425e151 Rolling v8/third_party/aemu-linux-x64: nv1qScP1jMWHbtAnUPBMcQOVcG6n7KxhpPYWWa21rA8C..xSLGBy9YVgE3OzSwrnR3yqDwyZerQuy2QBEFfV1Lc2IC Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/5726acb..20f5376 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I67d4a0e805ed6ee7ee63b135fb1340ecdded730c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2564204Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#71466}
-
- 28 Nov, 2020 3 commits
-
-
Camillo Bruni authored
Bug: v8:11195 Change-Id: I19211af9e440940f85351fb38920eb620c222213 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2555010Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71465}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/bd5054a..fc6f0ec Rolling v8/third_party/aemu-linux-x64: Ts7JI7CLxH4-h5lAQEsDnba0CD6d4ACU00UDPQXaW0wC..nv1qScP1jMWHbtAnUPBMcQOVcG6n7KxhpPYWWa21rA8C Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/ae003f5..7598272 Rolling v8/tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:67aba6e3373bb0b9e3ef9871362045736cd29b6e Rolling v8/tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:67aba6e3373bb0b9e3ef9871362045736cd29b6e Rolling v8/tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:67aba6e3373bb0b9e3ef9871362045736cd29b6e TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib50f599c06a8da11ddc231432ff60481b647c0cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2563748Reviewed-by:
-
Etienne Pierre-doray authored
This is a reland of 873e5aa3 Reason for revert: Flaky cctest/test-incremental-marking/IncrementalMarkingUsingTasks Safe to reland as-is after https://chromium-review.googlesource.com/c/v8/v8/+/2562121 Original change's description: > Reland "Reland "[Heap]: Convert Sweep to Job"" > > This is a reland of b16c7e5b > > Issue: ShouldYield is called multiple time. > Fix: ConcurrentSweepSpace returns false if not done (yielding), to avoid > calling it again. > > Issue: failing test-streaming-compilation > Safe to reland after > https://chromium-review.googlesource.com/c/v8/v8/+/2507379 > > Original change's description: > > Reland "[Heap]: Convert Sweep to Job" > > > > This is a reland of 795c0b1c > > Reason for revert: > > TSAN failures https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/33884 > > Safe to reland as-is with fix to EagerUnmappingInCollectAllAvailableGarbage > > https://chromium-review.googlesource.com/c/v8/v8/+/2502809 > > > > Original change's description: > > > [Heap]: Convert Sweep to Job > > > > > > max concurrency is inferred from queue size for OLD_SPACE & MAP_SPACE. > > > Extra Sweeper::TearDown() in MarkCompactCollector::TearDown() is needed > > > to cancel job. > > > > > > Change-Id: Iafba7d7d24e8f6e5c5a1d5c0348dea731f0ac224 > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2480783 > > > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#70767} > > > > Change-Id: Id9a5baceed4664f53da39597af56a2067e4f3c6f > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2502808 > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#70845} > > Change-Id: I32de9faebdbd2f7f6d7f9a9525871fc691fb3f2c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507378 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71347} Bug: v8:11198 Change-Id: Ie61b5e90e2e4984e72beb8374fa73814acedb8fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562749 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#71463}
-
- 27 Nov, 2020 22 commits
-
-
Hannes Payer authored
Bug: chromium:1054771 Change-Id: I95a97c9588a0f26190db3f87d18a53c445a89112 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2563272 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Make Timeline.selectTimeRange run in O(log(n)) instead of O(n) comparisons. Drive-by-fix: - Use *Index for variable names in Timeline Bug: v8:10644 Change-Id: I65f3be9f259e6bebcec489526a54712daffd4d15 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507714 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#71461}
-
Milad Fa authored
Condition register might need to be cleared before running instructions to assure sticky bits are cleared. Change-Id: Id18e5759e4cc9f03c2e9334f41b5ff179639ad22 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562747Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#71460}
-
Etienne Pierre-doray authored
Reason for revert: Data race: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/34121 It was assume that MockPlatform runs everything on 1 thread. However, MockPlatform::PostJob previously would schedule the job through TestPlatform, which eventually posts concurrent tasks, thus causing data race. Fix: Manually calling NewDefaultJobHandle and passing the MockPlatform ensures the jobs also run sequentially. Additional change: - CancelAndDetach is now called in ~CompilationStateImpl() to make sure it's called in sequence with ScheduleCompileJobForNewUnits Original CL description: To avoid keeping around a list of job handles, CancelAndDetach() is used in CancelCompilation. Dependency on WasmEngine is handled by a barrier that waits on all jobs to finish. Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2498659 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#71074} Change-Id: Ie9556f7f96f6fb9a61ada0e5cbd58d4fb4a0f571 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2559137 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#71459}
-
Dominik Inführ authored
Remove TRACE_BACKGROUND_GC which was used to emit events on the background thread. It is replaced by TRACE_GC1, which uses the ThreadKind argument to work both on main and background threads. This CL also removes the dedicated BackgroundScope enum, all scopes are now in GCTracer::Scope. Change-Id: Ie377082d6a278dd46f2fa359611fdd99a08afcea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2560203Reviewed-by:
-
Mythri A authored
We used to update profiler ticks after tiering up decisions when tiering up from Ignition and update the ticks before when tiering up from mid-tier optimized code. This meant we added special cases to account for this difference. This cl makes updating the ticks uniform by always updating the ticks before tiering up decisions. Also adjusts the heuristics to take this into account. Bug: v8:9684 Change-Id: I2c63ba3499c542bb4a69e55d6cc4bebe4612793f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2563659Reviewed-by:
-
Santiago Aboy Solanes authored
Otherwise, its behaviour is undefined and shouldn't be permitted. Bug: v8:7790, v8:11135 Change-Id: I9fa5ec02b9126f776ad3ef095e8c70fc5d3620dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2547293Reviewed-by:
-
Santiago Aboy Solanes authored
Like https://crrev.com/c/v8/v8/+/2555001 for v8.h. Done in a separate CL in case it needed to be reverted. Change-Id: I0c7a7cb24e8f0855c8b80ddeeaab979f10011c4a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562252Reviewed-by:
-
Michael Achenbach authored
No-Try: true Bug: v8:10619 Change-Id: I1e227c64fa34caf010271b299d9310d19bdfc53a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2563273 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Omer Katz authored
cppgc_unittests uses tracing (e.g. when setting the TracingController in tests.h) and thus needs to depend on v8_tracing. It cannot inherit the dependency since the cppgc_unittests_sources v8_source_set doesn't depend on cppgc. Bug: v8:11203 Change-Id: I7227f696f841132f174435751a42a02ff865df26 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2563658 Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#71453}
-
Michael Achenbach authored
The error simulation works and crashes during the smoke test are detected. But now this masks real crashes (https://crbug.com/1153200), therefore this change subsumes smoke-test crashes with --simulate-errors under a separate crash state. Now Clusterfuzz will detect the case "unexpected crash" as fixed, but create a new bug for "simulated crash". Which we will keep open forever. No-Try: true Bug: chromium:1152412 Change-Id: I511af167d33430d9b89692151cb8abaf3a90c715 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2563270Reviewed-by:
-
Hannes Payer authored
NewSpace shrinking is already performed in Heap::GarbageCollectionEpilogueInSafepoint. Bug: chromium:1054771 Change-Id: Ia274dd5619fd1d7397a06f0b642f07d68de45ea1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2563267 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
Change-Id: I5e866163b371446b72f5422bf8cc1816effbec95 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562387 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#71450}
-
Maya Lekova authored
This CL extends the TruncateFloat64ToInt64 machine operator with a TruncateKind, allowing EffectControlLinearizer to request truncating to INT64_MIN in case of overflow. The CL adds the necessary low-level support when generating code for kArm64Float64ToInt64. It also enables relevant tests as part of the fast API call suite. Bug: v8:11121 Change-Id: I0cb9964cc3c2ff49e6b0bbfe4a20f280e4aab337 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2560718Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#71449}
-
Vicky Kontoura authored
This is a reland of f2034bf5 Original change's description: > [wasm] Enable --wasm-generic-wrapper > > This CL enables the --wasm-generic-wrapper flag by default. > > Bug: v8:10982 > Change-Id: Iada906ce49810806c500ee3ca26e09e847b69a27 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2539915 > Commit-Queue: Vicky Kontoura <vkont@google.com> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71374} Bug: v8:10982 Change-Id: Ifceac637f7ec21c8f35d6bdd5d7c6c72a43fad43 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562241Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/33f080d..bd5054a Rolling v8/third_party/aemu-linux-x64: b5ckZyVJ3XwwvnxV2J_ybKfLyiHfOj81r9Llym22_UsC..Ts7JI7CLxH4-h5lAQEsDnba0CD6d4ACU00UDPQXaW0wC Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/b9a5e83..dc7b108 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/41850cb..5726acb TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7975927763753bb1c591e3dfb24d2b8657c36f16 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2563119Reviewed-by:
-
Junliang Yan authored
Change-Id: I70ca729c7afea4d4fa6e24f833c3757d3b0b1a63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562681Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#71446}
-
Junliang Yan authored
Change-Id: Idbcc6a0a261357e1680ece3e7946618b6577d78e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562125Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#71445}
-
Manos Koukoutos authored
See also: https://chromium-review.googlesource.com/c/v8/v8/+/2557515 Bug: chromium:1152937 Change-Id: I8043f88f3a64a3e45e00c8e6848cb6e4ec6f8a42 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562239 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Etienne Pierre-doray authored
Currently MockPlatform has shorter lifetime than the isolate that uses it. Creating isolate before MockPlatform leads to races in concurrent tasks that were scheduled before the MockPlatform replaced the default TestPlatform. This caused issues after landing https://chromium-review.googlesource.com/c/v8/v8/+/2561198 This CL ensures that MockPlatform is valid throughout the whole lifetime of the isolate Bug: v8:11198 Change-Id: I79f82712165d1f1fbe0fe9af68aedf126e54b241 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562121Reviewed-by:
-
Omer Katz authored
When V8_USE_PERFETTO is defined, TracingController doesn't have AddTraceEvent and GetCategoryGroupEnabled methods. Bug: v8:11203 Change-Id: I05d7ff829d8b134662bc1dbe4cb56bb740185918 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562381 Auto-Submit: Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Maya Lekova authored
This reverts commit 28f0b62a. Reason for revert: Speculative revert for broken arm64 sim GC stress bot - https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20gc%20stress/20100 Also appears as a flake later - https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20-%20arm64%20-%20sim%20-%20pointer%20compression/7419 Original change's description: > [heap] Committed SemiSpace state depends on pages being present in the memory_chunk_list_. > > Bug: chromium:1054771 > Change-Id: Idad2d6464ed29c8aa6d7d0665b84525c0f954df8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562245 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Hannes Payer <hpayer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71429} TBR=ulan@chromium.org,hpayer@chromium.org Change-Id: Ib7f9666abe059126004de6a81e5f1fa93e36e932 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1054771 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2563258Reviewed-by:
-
- 26 Nov, 2020 14 commits
-
-
Dominik Inführ authored
Avoid virtual call on the fast path when invoking Heap::MonotonicallyIncreasingTimeInMs by using base::TimeTicks directly. With --predictable we need to fall back to Heap::MonotonicallyIncreasingTimeInMs though. Convert base::TimeTicks to milliseconds as double, since this was the format GCTracer was using internally. Change-Id: I25ab6f1a77ffc8a317782b5754521c39ccb46e48 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562240Reviewed-by:
-
Camillo Bruni authored
Properly indent wrapper source lines so the source line numbers are easily visible. Change-Id: I25095ca3e15a8e953c6e826eb8594289a10aa41b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2551105 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Junliang Yan authored
Change-Id: I79fc56578878f326725272d67a9936b04b22a02f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562119Reviewed-by:
-
Hannes Payer authored
Bug: chromium:1054771 Change-Id: I58a49461723d8444fca8c2a3b0f3e75367604c76 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562257Reviewed-by:
-
Mythri A authored
1. Don't optimize small functions early when tiering up from ignition to Turboprop. 2. When tiering up from Turboprop to Turbofan scale the ticks so we optimize small functions at roughly same time as default. 3. Adjust for the fact that profiler ticks are updated before performing the ShouldOptimize check when tiering up from TP -> TF. Bug: v8:9684 Change-Id: I6b68eed70abb9a86f9b99eac9c0b9a1fe6346027 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2560725 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Make the IsEqualTo equality type parameter a template parameter, and add an option to skip the length check for cases where the length is known (e.g. in string table key comparisons). Change-Id: I893ac880ec1e830a50ba6d8f58f375ed96d6e14e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562247 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#71435}
-
Camillo Bruni authored
- Add ToolTip helper that tracks scrolling target elements - Auto hide if the target scrolls out of view - ToolTip position depends on target position - Add basic tooltips for maps in the transition view, entries in timeline tracks and the source panel Drive-by-fix: - Move events.mjs to view/ folder - Add basic toString methods on various log entries - Add requestAnimationFrame update support for V8CustomElement Bug: v8:10644 Change-Id: I1059733cd094a986b715547b3d5747eefbc54bc5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2551103 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#71434}
-
Junliang Yan authored
Because actual condition code used by s390/ppc does not distinguish between signed and unsigned, we need to use a generic enum class for liftoff which needs to deal with signed/unsigned case differently. Change-Id: Ia870dc30788037996dc1c65de0117eac7d941697 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2560603 Commit-Queue: Junliang Yan <junyan@redhat.com> Reviewed-by:
-
Michael Achenbach authored
This passes the --simulate-errors flag for differential fuzzing with a probability of 0.01%. No-Try: true Bug: chromium:1152412 Change-Id: I3146c0ea5706be8b5ec13ee8740e1d185e008075 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562248Reviewed-by:
-
Thibaud Michaud authored
Use the overload of NativeModule::PublishCode that accepts a vector of codes to only lock/unlock once per batch. R=ahaas@chromium.org Bug: v8:11164 Change-Id: I6428d3d9cec8526bdfef223d7ba03b35bad9e1eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562251Reviewed-by:
-
Michael Achenbach authored
This adds a d8 flag --simulate-errors, which on shutdown will cause certain errors. This enables testing the reliability of sanitizers. This will cause a fatal error, a dcheck (if available) or a violation that can be detected with one of the following sanitizers: ASAN, UBSAN, MSAN, CFI. The same flag used in differential fuzzing will cause an error subsumed with the error state "fake_difference". Bug: chromium:1152412 Change-Id: I4b36c6fe716797004d634263617d22ca67b05600 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2554999 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Hannes Payer authored
Bug: chromium:1054771 Change-Id: Idad2d6464ed29c8aa6d7d0665b84525c0f954df8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562245Reviewed-by:
-
Clemens Backes authored
This specific case was not implemented or tested before. Implementing it actually simplifies some of the existing logic, since StepOut can now reuse the generic logic in debug.cc for all cases (Wasm->Wasm, Wasm->JS, JS->Wasm). Drive-by: 1) Fix typo ("skip" -> "step"). 2) Move the check for Liftoff code from debug.cc to wasm-debug.cc, where it fits better. 3) Remove a TODO which is done already. R=thibaudm@chromium.org, szuend@chromium.org Bug: chromium:1145176 Change-Id: I415ca1d8bacef5b21bf1dafd9e16417ec2d12c7c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2560719 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#71428}
-
Hannes Payer authored
Bug: chromium:1054771 Change-Id: I64d0d2a4f07add4adef78136b303881a900474a7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2560198Reviewed-by:
-
