- 26 Feb, 2021 7 commits
-
-
Clemens Backes authored
Wasm tests and wasm fuzzers should not be compiled (and run) if v8_enable_webassembly=false. R=machenbach@chromium.org Bug: v8:11238 Change-Id: I78bbb1d1d98179cac315411b8c2c2ecaee8ede91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2721761Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73071}
-
Clemens Backes authored
This renames more fields holding "ValueKind" or methods operating on "ValueKind" to contain "kind" instead of "type". It also renames "is_reference_type" to "is_reference" on both ValueType and ValueKind, as the "_type" prefix is kind of implicit from the argument. R=manoskouk@chromium.org, jgruber@chromium.org Bug: v8:11477 Change-Id: I7809f1af6e983aebca96e03fe1fbc6ccaa22db72 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2718063 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#73070}
-
Liu Yu authored
Port: 47ffa7a5 Bug: v8:6020 Change-Id: I4ae6261828b27f88553781a93d8557b6b685c217 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2719811 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#73069}
-
Clemens Backes authored
In https://crrev.com/c/2707170, Liftoff was changed to only store the ValueKind instead of the ValueType, because we only need to know kind for code emission. For debugging though, the whole type is useful. This CL changes the debug sidetable back to store the full type, and retrieves this information from the decoder. R=jkummerow@chromium.org Bug: v8:11477 Change-Id: I08a512d24cdf0955c95f3b9261d68a02a39b9b4e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2720302 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#73068}
-
LiuYu authored
Simd unsupported in simulator and some machines on mips. Original Commit Message: As of https://crrev.com/c/2629465, Simd tests cannot pass on architectures without Simd support. Tests will need to be re-enabled once Simd support is fully implemented on PPC. Port: aaacffa1 Change-Id: Ic7451211cbe2bfa13952b994ea440189620579cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2717158 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#73067}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/67d73b8..be2a0bf Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/45fb4c0..fd1ca3e Rolling v8/third_party/aemu-linux-x64: qI8e328VwkWv64EapCvG3Xj9_hDpKQFuJWeVdUHz7W0C..8c4TvsC0hrCVIdsAVOIoQ3TnOJ3PX5iVaUqg4iQkJP4C Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/a34cee3..9105610 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/fb09de2..7d69005 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/823927c..6a9fd91 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I013a44bd204f5acb8a0af9ec71b7f29945e9dbd1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2721362Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73066}
-
Omer Katz authored
This was causing DevTools to crush whenever I took a heap snapshot. Bug: chromium:1056170 Change-Id: Ice7b3039c21a3f902f242299939e92ba0e393c9f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2720307 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73065}
-
- 25 Feb, 2021 29 commits
-
-
Omer Katz authored
This CL adds WasConservativeGC to HeapState which reports whether the last GC was finalized conservatively. The state is updated at the end of marking atomic pause. Currently the library integration in Blink ignores the stack state when scheduling a forced GC for testing. That means that we always schedule another GC after a forced GC. This causes a crash in web_tests which assume no GC is happening between forced GCs if the thread is not idle and no new allocations happen. Usage CL: https://crrev.com/c/2720201 Drive by: Fix stack state for MarkingVerifier in CppHeap. Bug: chromium:1056170 Change-Id: I6ad23ed7c1a53fae96425b968bc4b3eb18ce80b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2720279 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Bug: v8:11347 Change-Id: I17859b226e14df63380dd6895bee62b0e8a380b9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2719297Reviewed-by:
-
Milad Fa authored
Change-Id: I49d0911fe72f624cd0700e6aafaadb9fdc401f93 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2720466Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#73062}
-
Milad Fa authored
Port 47ffa7a5 Original Commit Message: This instruction is not in the final SIMD proposal. R=zhin@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I7e701fb6a995fb62737e9473cdf76a33c5518cac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2716055Reviewed-by:
-
Michael Lippautz authored
- cppgc_headers: Do not depend on any internals but merely expose the public API interface. - v8_libbase: Do not depend on v8_headers but merely on v8_config_headers as src/base should be independent of general V8. Bug: chromium:1056170 Change-Id: I06d1a4ea20f243bae8e994deba9d76f07993ed4a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2720303Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73060}
-
Milad Fa authored
This CL also adds and makes use of the __int128 data type to help with vector loads and stores. Change-Id: I0d02eddcedfe17d12eadd214e205b693fa7ebe53 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2720459Reviewed-by:
-
Ng Zhi An authored
This instruction is not in the final SIMD proposal. Bug: v8:6020 Change-Id: Ifef1b3d58bf660f2d30784f587aed85f327825ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2716073 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Improve SSE codegen similar to suggestions in https://crrev.com/c/2698066: - s/movdqa/movaps/ - s/por/orps - s/pxor/xorps - s/pand/andps - use movshdup (SSSE3) insted of shuffle Bug: v8:11415 Change-Id: I2e76cbbe16267c055e24f258354b77994aed47b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2713131Reviewed-by:
-
Ng Zhi An authored
Copy paste error leading to wrong definition. Change-Id: I93c516d11ed4c76ed389afb6e911315a8ce49ef0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2716741 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Bug: v8:11346 Change-Id: I95a82da62feb6c42562f655f954407ad58c4ca33 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2718660Reviewed-by:
-
pthier authored
VLQ encoding was implemented in TranslationArray and Sparkplug PC <-> bytecode mapping. This CL introduces new VLQ helper methods used in both. Bug: v8:11429 Change-Id: I89d9777eab4ad28f08e5957421b63df07e37f9cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2704674Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Hannes Payer authored
Change-Id: Ib1c871098a9f39cd9db445f18a387d42583afe5c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712758Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#73053}
-
Hannes Payer authored
Change-Id: I0005fe0ed7b9f00fd074161d355da430b85675ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2714703Reviewed-by:
-
Hannes Payer authored
Change-Id: I86b0d01ed283f97cde2f3d71df68c3a75107c61d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712906Reviewed-by:
-
Hannes Payer authored
Change-Id: Ib54d5abad3e67f74d1930af135778e1f201ba28f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712964 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Hannes Payer authored
Change-Id: I1acfd953b9ea4dd09edd8b9e6e170e94427dfeb9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712757 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
We have several ways of doing the Isolate or LocalIsolate calls. Let's unify it to have one consistent way of doing it. Bug: v8:7790 Change-Id: I7d860e918406b07e3b8ab2d46e775a2beb5a4397 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2718609Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#73048}
-
Leszek Swirski authored
Clean-up and slightly unify the CodeEvent tags: * Remove INTERPRETED_FUNCTION_TAG. It was only used for interpreter trampoline copies, which are used for --interpreted-frames-native-stack. However, even actual bytecode compilation doesn't use INTERPRETED_FUNCTION_TAG, so we can remove it for simplicity. * The tag used by the above is now the same as for the bytecode creation event, i.e. EVAL_TAG, SCRIPT_TAG, FUNCTION_TAG or LAZY_COMPILE, depending on whether this was a script, and eval, an eager or a lazy compile (respectively. * Baseline was also using INTERPRETED_FUNCTION_TAG, so now it does the same thing as above. * Existing code is now logged as FUNCTION_TAG rather than LAZY_COMPILE, because we lost the laziness information. * The SCRIPT_TAG is set based on the SharedFunctionInfo flags, not the compilation flags, so that eager inner functions are labelled as FUNCTION_TAG rather than SCRIPT_TAG. Bug: v8:11420,v8:11429 Change-Id: I0286002674255ff4ba8f5d865df372a3e2975b16 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2713104Reviewed-by: -
Liu Yu authored
in builtin Port: 68105996 Bug: v8:11377 Change-Id: Ib60f0b0c0c994791e02ebde6ee8519134a3dd9f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2719806 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/446bf3e..67d73b8 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/4c78ef9..45fb4c0 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/196ba1a..5fb4080 Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/a2cc4f8..8d5fb6f Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/81c9d30..a34cee3 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/5fe664f..fb09de2 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/cfd0f62..823927c TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9815099eca93e82385b8a4a417c4a1cf28802eed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2717935Reviewed-by:
-
Santiago Aboy Solanes authored
Rename string_access to internalized_string_access and transition_array_access to full_transition_array_access. Bug: v8:7790 Change-Id: I225f90d4c0d6ddac1f15796848428bc962a2420f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2718145Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
-
Lutz Vahl authored
TBR=hablich@chromium.org, vahl@chromium.org Change-Id: Ibbae1509e1f546c77d4ef21d42386af44f1005c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2718607Reviewed-by:
Lutz Vahl <vahl@chromium.org> Commit-Queue: Lutz Vahl <vahl@chromium.org> Cr-Commit-Position: refs/heads/master@{#73043}
-
Victor Gomes authored
Change-Id: I59b26323bd8d2fd35379fb73c799943315d5422b Bug: v8:11502 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2719564 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#73042}
-
Dan Elphick authored
Remove most dependencies on v8_wrappers. The remainder all depend on v8_libbase anyway, so just fold it into that target which removes a gn check error. Also removes v8_wrappers from the fuzzers where it's not used. Bug: v8:7330 Change-Id: I916806b62f8c49cc1d50ef493aa900e30fc623aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2716383 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#73041}
-
Frank Emrich authored
This is a reland of https://chromium-review.googlesource.com/c/v8/v8/+/2715192. This CL is part of a series that adds the C++ implementation of SwissNameDictionary, a deterministic property backing store based on Swiss Tables. This CL adds the Add, DeleteEntry, Rehash, and Shrink operations, as well as some helpers required by those. Bug: v8:11388 Change-Id: I028dbf3215c76e4f40cba420c125ef25223f252e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2719561Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Frank Emrich <emrich@google.com> Cr-Commit-Position: refs/heads/master@{#73040}
-
Ting Shao authored
Optimize the implementation of this method by removing unnecessary bitwise OR operation. Change-Id: Ic16e0d556d7fca6883aed77e592faa2fdd602624 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2709558Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#73039}
-
Michael Achenbach authored
No-Try: true Bug: v8:11437 Change-Id: I589e9695a00bea632fa4cfa7575d902872b41e2b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2719559 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#73038}
-
Liu Yu authored
Port: 96a0677a Bug: v8:11477 Change-Id: I438a5b833a9838ffa53d30785cf627f75997d7fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2719402 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by:
-
Manos Koukoutos authored
Calling CheckForException through the BUILD macro for almost every invocation of WasmGraphBuilder from graph-builder-interface created multiple issues: - It generated an invalid graph with GetExceptionValues, resulting in us having to hack CallBuiltin(). - It will generate multiple problems with wasm-gc operations. - It needlessly slowed down compilation. Changes: - Remove BUILD macro, call CheckForException directly only for function calls and throws. - Split CheckForException into a fast inline path and a slow non-inline one. - Move BUILD's DCHECK into CHECK_INTERFACE. - Add an early exit to Decode(). - Since we do not need the hack anymore, implement CallBuiltin properly. Change-Id: I38e3c73e0af80894584ce37e2f3bfc90111ac54f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2717304 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73036}
-
- 24 Feb, 2021 4 commits
-
-
Ng Zhi An authored
Bug: v8:11086 Change-Id: I214ebd0cc7c3b0379fcd6bc78e131fccf7bfe631 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2707776Reviewed-by:
-
Francis McCabe authored
This reverts commit ae153904. Reason for revert: link error in https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20full%20debug/16047/overview Original change's description: > [dict-proto] C++ implementation of SwissNameDictionary, pt. 6 > > This CL is part of a series that adds the C++ implementation of > SwissNameDictionary, a deterministic property backing store based on > Swiss Tables. > > This CL adds the Add, DeleteEntry, Rehash, and Shrink operations, as > well as some helpers required by those. > > Bug: v8:11388 > Change-Id: I81a181e99e679095c2acc877a293e81b6a581db4 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2715192 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Commit-Queue: Frank Emrich <emrich@google.com> > Cr-Commit-Position: refs/heads/master@{#73020} Bug: v8:11388 Change-Id: I7c83ddfab6055b992f1580e03aae0da31d83ba63 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2718662 Auto-Submit: Francis McCabe <fgm@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#73034}
-
Junliang Yan authored
Change-Id: I60683dd37939d330169e3879982a6ac9ca7694a2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2718230Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#73033}
-
Ng Zhi An authored
Accidentally omitted this in a previous change https://crrev.com/c/2686013. Extract code sequence into macro-assembler for sharing between Liftoff and TurboFan. Bug: v8:11348 Change-Id: Ia4e9d1e0dc7a7f3a1a21ff1e1745923a847328cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2707773Reviewed-by:
-
