- 06 Mar, 2019 13 commits
-
-
Yang Guo authored
R=ulan@chromium.org Change-Id: Ib2caeeeb9877f853848b4014a8088ee447d1705a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503765Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#60055}
-
Predrag Rudic authored
Yu Yin is working for company that is willing to maintain MIPS ports therefore I am transferring ownership to Yu Yin. No-Presubmit: true TBR=mstarzinger@chromium.org NOTRY=true Change-Id: Ibb534165a1a67ad65a58ea85f5885a70b59302be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505454Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Predrag Rudic <prudic@wavecomp.com> Commit-Queue: Predrag Rudic <prudic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#60054}
-
Maya Lekova authored
This reverts commit 43b92772. Reason for revert: Breaks Mac build, see https://ci.chromium.org/p/v8/builders/ci/V8%20Mac64%20ASAN/22200 Particular cause: https://chromium.googlesource.com/chromium/src/build/+/7b62c8979c4963f8f0fa8ec33391793bd9d73f28 Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/80892bf..983d3df > > Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cf661ac..7e68767 > > TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org > > Change-Id: I6f335b8628338d94558309b5bc06725f9d20ea8b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1504781 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#60050} TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I6ca9cf4d0f7051979f59c4a72f2a46ad67331b21 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505812Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#60053}
-
Mathias Bynens authored
Unicode v12 was released today: https://unicode.org/versions/Unicode12.0.0/ This patch updates the following sequence property escapes per Unicode 12: - Emoji_Flag_Sequence (no changes) - Emoji_Keycap_Sequence (no changes) - Emoji_Tag_Sequence (no changes) - Emoji_ZWJ_Sequence Note that Emoji_Modifier_Sequence is still using Unicode 11 data. This will be fixed automatically once a version of ICU with Unicode 12 support rolls into V8, at which point I'll update the relevant tests. Bug: v8:7467 Change-Id: Iba575a471382ba7b029da06c2868c368ff43c649 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503764Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#60052}
-
Simon Zünd authored
Bug: chromium:938251 Change-Id: I336765c894cc78ca822904a32356db43feadea07 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505312Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#60051}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/80892bf..983d3df Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cf661ac..7e68767 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I6f335b8628338d94558309b5bc06725f9d20ea8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1504781Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#60050}
-
Yu Yin authored
Port https://crrev.com/c/1469821 Original Commit Message: Refactor the CallApiCallback builtin to - pass the context as with other stubs, and - pass holder and call data in registers. This avoids having to place holder and call data onto the stack, and thus makes it possible to easily call the CallApiCallback builtin from other builtins while just forwarding the (stack) arguments. The idea is to use this in the future to optimize the general case of calling into any API method via a FunctionTemplateInfo and doing appropriate security and/or interface checks upfront as necessary (eventually making the HandleApiCall C++ builtin obsolete at some point). Change-Id: Ice52b68678fbea69e765c22daa3134524860e5de Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505234Reviewed-by:
-
Michael Lippautz authored
Blink CL: http://crrev.com/c/1504573 Bug: chromium:936797 Change-Id: I24092f53f40dbd663ffb58122ec0239b7c185904 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505372Reviewed-by:
-
Simon Zünd authored
This CL refactors the torque-compiler module slightly to allow compilation of string inputs in addition to file path inputs. The added functionality is then used to implement the first 'goto type defintion' unit test. R=tebbi@chromium.org Bug: v8:8880 Change-Id: I178a387abda6e319e66d41c50431cb139ac6e9f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503263 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#60047}
-
Yang Guo authored
This becomes necessary due to [1]. We cannot roll DEPS otherwise [2]. WebRTC is doing this too [3]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1500198 [2] https://chromium-review.googlesource.com/c/v8/v8/+/1505272 [3] https://webrtc-review.googlesource.com/c/src/+/125840 TBR=machenbach@chromium.org Change-Id: I07ecc878f6c64767be025c9999dbb49423031e90 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505292Reviewed-by:
-
tzik authored
This adds overloads of v8::Isolate::{Add,Remove}MicrotaskCompletedCallback, that use MicrotasksCompletedCallbackWithData, and marks the original one as V8_DEPRECATE_SOON for transition. Bug: v8:8124 Change-Id: I124c3108545e1a2b29cd95620f36901431663c65 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1493766Reviewed-by: -
Yang Guo authored
This reverts commit 83fa1717. Reason for revert: Mac ASan failure. This also happens for WebRTC and is due to this change: https://chromium-review.googlesource.com/c/chromium/src/+/1500198 Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/80892bf..0416321 > > Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cf661ac..7e68767 > > TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org > > Change-Id: I029046d9e7fbceaed48d94e9e20c2eba61b08cac > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1504778 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#60043} TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: If8c60c8d83f70a0fc966d7bda00999bc5630431e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505272Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/80892bf..0416321 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cf661ac..7e68767 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I029046d9e7fbceaed48d94e9e20c2eba61b08cac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1504778Reviewed-by:
-
- 05 Mar, 2019 21 commits
-
-
Frank Tang authored
This is in preparation for the removal of Unibrow. Bug: v8:8362 Change-Id: Icb969457e71d64d765eaf0fd1d0b8b9c6b6eb388 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1490572 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#60042}
-
Z Duong Nguyen-Huu authored
JSDate, JSStringIterator, JSAsyncFromSyncIterator, JSDataPropertyDescriptor Change-Id: Ia2cfd8fa61672fb4d6ec5082bae07e7add97fe60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1500674Reviewed-by:
-
Ben Smith authored
The bulk memory operations should not bounds check ahead of time, but instead should write as many bytes as possible until the first out-of-bounds access. Bug: v8:8890 Change-Id: Ia8179fe268fc65816c34a8f3461ed0a0d35600aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1497520 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by:
-
Vadim Gorbachev (bmsdave) authored
we can't use {**dict1, **dict2} in python2 code. see report https://travis-ci.com/bmsdave/v8/jobs/180113432 Bug: v8:935200 Change-Id: I2f2a1283583432d6d0167436dd7d4205455049cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1484303 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#60039}
-
Tamer Tas authored
R=clemensh@chromium.org CC=machenbach@chromium.org,sergiyb@chromium.org Bug: v8:8728 Change-Id: I37d10867a805647c98660699233c5c2b23429eae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503377Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Hannes Payer authored
Bug: v8:8945 Change-Id: Ib26d97bb6b5b1a6d523079bd3277ca28488eec9b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503264 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Sven Sauleau authored
Align the Table implementation limits with the JavaScript Embedding limits defined in the specification (from MAX_UINT32 to 1e7). Introduce a new helper (max_table_init_entries) that returns the maximum number of Table entry at initialization. It takes into account the maximum Table size, which can be passed by a flag. Bug: v8:8633 Change-Id: Idfa19418e81f478f7886a30876e66c9b216e25ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1496971 Commit-Queue: Sven Sauleau <ssauleau@igalia.com> Reviewed-by:
-
peterwmwong authored
Also ports GrowableFixedArray to Torque. The CSA version is preserved for now, as the Torque structs are not consumable by CSA builtins yet (Struct methods are inlined). TypedArrayPrototypeFilter builtin size decreased by 24% (Mac x64.release): TFJ Builtin, TypedArrayPrototypeFilter, 5689 -> 4298 TypedArrays/Filter micro benchmarks have improved 10-15% (Mac x64.release): TypedArrays-Uint8Array(Score): 746 -> 857 TypedArrays-Uint16Array(Score): 758 -> 862 TypedArrays-Uint32Array(Score): 746 -> 855 TypedArrays-Float32Array(Score): 749 -> 817 TypedArrays-Float64Array(Score): 751 -> 839 TypedArrays-BigUint64Array(Score): 562 -> 625 Bug: v8:8906 Change-Id: I1172b7407de95b067448e680ec327e726e9194cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1501469 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#60035}
-
Clemens Hammacher authored
This reduces the number of {BackgroundCompileScope}s per compilation unit from 2 to 1. This reduces the number of concurrent accesses to the {SharedMutex}. R=ahaas@chromium.org Bug: v8:8916 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel Change-Id: I872683101dfc9361aa7054ea67f16e3f3f2b82b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1495989 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Mike Stanton authored
In the recent port of reduce() and reduceRight(), a check for a length change during the loop (standard for iterating builtins) was omitted. We did get array bounds check protection, however it didn't expose the issue in our tests because the bounds check is against the backing store length, not against the length in the referring JSArray. Also added a test for reduceRight(). R=jgruber@chromium.org Bug: chromium:937676 Change-Id: I76e22e0d71965bff84a0822b1df5dc818a00b50e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503732Reviewed-by:
-
Junliang Yan authored
Port 9c7b6e1e Original Commit Message: This is the implementation of crrev.com/c/766371 for arm. Original description: Add the ability to return (multiple) return values on the stack: - Extend stack frames with a new buffer region for return slots. This region is located at the end of a caller's frame such that its slots can be indexed as caller frame slots in a callee (located beyond its parameters) and assigned return values. - Adjust stack frame constructon and deconstruction accordingly. - Extend linkage computation to support register plus stack returns. - Reserve return slots in caller frame when respective calls occur. - Introduce and generate architecture instructions ('peek') for reading back results from return slots in the caller. - Aggressive tests. - Some minor clean-up. R=ahaas@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, miladfar@ca.ibm.com BUG= LOG=N Change-Id: I83df1af8c49f6d6c5b529db599fce61a1da2490d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1496549Reviewed-by:
-
Ben L. Titzer authored
When a function is exported from a WebAssembly module, it is implicitly wrapped in a WasmExportedFunction. For functions that were imports into this module, the exported function appears like other Wasm function, e.g. can be used in tables. When that exported function was re-imported to another module, the logic to compute the import kind mistakenly assumed the exported function was indeed originally a Wasm function and tried to call it directly, instead of treating it like an imported JS function. R=ahaas@chromium.org BUG=v8:8947 Change-Id: Ib8fac81fbe0f49c50cfbfb2e69d9bb60aef91fcc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503632 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
-
Hannes Payer authored
Bug: v8:8945 Change-Id: I2ee060c03496bbcb388d82fd05ecc61658047f98 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503633Reviewed-by:
-
Hannes Payer authored
Bug: v8:8945 Change-Id: I4e5f08a722e83fd8b4accb066eca50242a116a6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503452Reviewed-by:
-
Ulan Degenbaev authored
This allows us to change the page size without affecting Scavenger heuristics and performance. Bug: chromium:852420 Change-Id: Idcff4296e88e16f9af0ee6ecd00c63d789866fd6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1499494 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60028}
-
Tobias Tebbi authored
Bug: chromium:937649 Change-Id: I13c64a7cab7a6f1668c546114610006d0d6b91ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1501052Reviewed-by:
-
Pierre Langlois authored
The `TurboAssembler::CallRecordWriteStub()` method which generates out-of-line code to call the write barrier would push and pop arguments to move them to different registers. Let's use `mov` instructions instead, making sure we handle overlapping registers. Change-Id: Ideb654cd558e984ccb90c7cf44b1c2c49f1c5b50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1499496 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL changes the language server to store file paths as URIs and decodes them on-demand during compilation. For now, this will eliminate the need for an URI encoding function. R=tebbi@chromium.org Bug: v8:8880 Change-Id: If79f635cb60035f58712c1458ecca3bfa23a6e47 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1502992 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/9e80056..80892bf Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b3bee2e..ccc2908 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e9e89e3..cf661ac Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/5ec7f0c..efecb0b TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Id94d65fceb3dad447e57c9cf27905e325c484330 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1501468Reviewed-by:
-
Bill Ticehurst authored
Launching Python scripts can fail on Windows if the Python executable isn't given as the first argument to the shell. This change adds the path of the current Python executable, as per the behavior of v8gen.py Change-Id: Iedaf57bcafc4c6aa6ebb89e945ee967cf393da04 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1497522Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#60023}
-
Deepti Gandluri authored
This reverts commit 821bc649. Reason for revert: Fails on ARM hardware :( https://ci.chromium.org/p/v8/builders/ci/V8%20Arm%20-%20debug/9271 Original change's description: > [wasm simd] Fix F32x4 Min and Max > > - Fix F32x4 tests to save results in globals, so they can be checked > in C++ code. Perform correct checks in case of NaNs. > - Fix ia32, x64 implementations of F32x4Min, F32x4Max to correctly > deal with NaNs. > - Enable tests for all float values on all platforms, except skip > denormalized results on ARM, and skip extreme values for reciprocal, > reciprocal square root approximation opcodes. > - Disable Min, Max test for interpreter (see v8:8425) since it doesn't > handle NaNs correctly. > - Fix vmin, vmax implementations in ARM simulator. > > Bug: v8:8639 > Change-Id: I87e188e3cb078f09fdacfd9955f426c20a11bf64 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1495897 > Commit-Queue: Bill Budge <bbudge@chromium.org> > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60021} TBR=bbudge@chromium.org,gdeepti@chromium.org Change-Id: Ib0dc8395ff86263fe0c02faa53d90c7da46b50a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8639 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1501732Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#60022}
-
- 04 Mar, 2019 6 commits
-
-
Bill Budge authored
- Fix F32x4 tests to save results in globals, so they can be checked in C++ code. Perform correct checks in case of NaNs. - Fix ia32, x64 implementations of F32x4Min, F32x4Max to correctly deal with NaNs. - Enable tests for all float values on all platforms, except skip denormalized results on ARM, and skip extreme values for reciprocal, reciprocal square root approximation opcodes. - Disable Min, Max test for interpreter (see v8:8425) since it doesn't handle NaNs correctly. - Fix vmin, vmax implementations in ARM simulator. Bug: v8:8639 Change-Id: I87e188e3cb078f09fdacfd9955f426c20a11bf64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1495897 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
-
Ben Smith authored
Passive elements have a different binary format, where the contents are instructions instead of function indexes: 0xd0 0x0b -> (ref.null) 0xd2 var:x 0x0b -> (ref.func x) Bug: v8:8891 Change-Id: Ie7e8efe7b5acdf99622880dd97d28d3c13744dff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1497516 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by: -
Deepti Gandluri authored
Change-Id: I092fff31b9cffef673f6929a510b3e643ab0ee29 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1496274Reviewed-by:
-
Yang Guo authored
This reverts commit f8a67670. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/25576 I don't think I've seen MSAN being flaky. Chances are that the change to SFI's object layout indeed left some field uninitialized. Original change's description: > Remove builtin-function-id in SFI > > builtin_function_id corresponded to BuiltinFunctionId (a manually maintained list of 'interesting' functionsmainly used during optimization). With this change, we nuke builtin-function-id in favor of builtin-id and 8 bits is freed up in SFI. > > Bug: v8:6993 > Change-Id: Iee9b539475bc6531c9aa65b1904d1402a9ef30db > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1495898 > Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60017} TBR=ulan@chromium.org,jgruber@chromium.org,leszeks@chromium.org,bmeurer@chromium.org,duongn@microsoft.com Change-Id: Ic3964ce182ddbd7ef529ddb8b78b9bdfb1be7887 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6993 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1499500Reviewed-by:
-
Z Duong Nguyen-Huu authored
builtin_function_id corresponded to BuiltinFunctionId (a manually maintained list of 'interesting' functionsmainly used during optimization). With this change, we nuke builtin-function-id in favor of builtin-id and 8 bits is freed up in SFI. Bug: v8:6993 Change-Id: Iee9b539475bc6531c9aa65b1904d1402a9ef30db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1495898 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
-
David Benjamin authored
If buffer_ is empty and start_ is zero, even though the MemCopy would be a no-op, &buffer_[start_] is undefined. buffer_.data() + start_ would work, but due to a C/C++ language bug, that is technically undefined too[*] if an empty buffer_.data() returns nullptr, so add a length() == 0 check, matching methods above. This was caught by building with _LIBCPP_DEBUG=0. [*] https://www.imperialviolet.org/2016/06/26/nonnull.html Bug: chromium:893810 Change-Id: I9f0834ffae6769e0e191e786842e6ecc6c95a58a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1483616Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#60016}
-
