- 22 Dec, 2020 10 commits
-
-
Andrey Kosyakov authored
This lets embedder to produce an id with sufficient entropy to facilitate an id appropriate for a multi-process system and immune to regular RNG seed being overriden, while maintaining deterministic id allocation for tests. Design doc: https://docs.google.com/document/d/1vGVWvKP9FTTX6kimcUJR_PAfVgDeIzXXITFpl0SyghQ Related blink-side change: https://chromium-review.googlesource.com/c/chromium/src/+/2600273 Bug: v8:11268 Change-Id: I1a4d12463cf56d4378859dfa3ee4d717e176d468 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2600442Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#71864}
-
Milad Fa authored
Port 1215f2a8 Original Commit Message: The codegen is the same as on TurboFan, using Smull, Umull, Smull2, and Umull2. The rest of the changes are adding skeleton functions to the different archs, which bailout for now. Actual codegen will come in future patches. R=zhin@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I58bc84ede44a9c90e315d6dc3346ea09b31deaf7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2600731Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#71863}
-
Zhi An Ng authored
Change-Id: I6ae8699032efc4e55f3e6f808620591c4ad8fc3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2599841Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71862}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/34da458..3e20802 Rolling v8/third_party/aemu-linux-x64: qMq36BPvKEIxjpVFBefO08HoyM51jARe3EuX0vcgzWsC..GI8QGXYA44_uicQ1AX9ecXBzIK4dImUA90X-kMlohyIC Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/d324a17..1283870 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ief40dcfffd3dee29abd267149af5a9e57907675f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2600368Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#71861}
-
Zhi An Ng authored
When a 8x16 shuffle matches a 32x4 shuffle (every group of 4 indices are consecutive), and the first 2 indices are in the range [0-3], and the other 2 indices are in the range [4-7], then we can match it to a shufps. E.g. [0,2,4,6], [1,3,5,7]. These shuffles are commonly used to extract odd/even floats. Change-Id: I031fe44f71a13bbc72115c22b02a5eaaf29d3794 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2596579 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#71860}
-
Zhi An Ng authored
The codegen is the same as on TurboFan, using Smull, Umull, Smull2, and Umull2. The rest of the changes are adding skeleton functions to the different archs, which bailout for now. Actual codegen will come in future patches. Bug: v8:11262 Change-Id: I06f0b018b85b5cca29382ab730510959e1a81ab6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2589064Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71859}
-
Andrew Comminos authored
As a first step towards freeing CodeEntry objects that are neither still referenced by JS or stored in a profile, enable freeing of refcounted strings by CodeEntry instances. For now, this leaves behaviour unchanged until we receive CodeEntry destruction events. Bug: v8:11054 Change-Id: Iabd05aa730343cd1a879ff5b04326f23e68aa948 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2590604 Commit-Queue: Andrew Comminos <acomminos@fb.com> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#71858}
-
Zhi An Ng authored
For pblendw and palignr, if AVX is supported, we can use the 3-operand AVX instruction, this can save us a move. Bug: v8:11270 Change-Id: Ifd837e29c76886a3008bc63c17d4a68bc6aae364 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2596578Reviewed-by:
-
Zhi An Ng authored
Optimize: - i32x4.widen_high_i16x8_s - i32x4.widen_high_i16x8_u - i16x8.widen_high_i8x16_s - i16x8.widen_high_i8x16_u These optimizations were suggested in http://b/175364869. The main change is to move away from palignr, which has a dependency on dst, and also the AVX version is 2 bytes longer than the punpckhqdq. For the signed and unsigned variants, we have slightly different optimizations. Unsigned variants can use an punpckh* instruction with a zero-ed scratch register, that effectively zero-extends. Signed variants use the movhlps instruction to move high half to low half of dst, then use packed signed extension instructions. The common fallback for these instructions is to use pshufd, which does not have a dependency on dst, but is 1 byte longer than the punpckh* instructions. FIXED=b/175364869 Change-Id: If28da2aaa8f6e39a58e63b01cc9a81bbbb294606 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2591853Reviewed-by:
-
Deepti Gandluri authored
Bug: v8:11154 Change-Id: Idc1ae98c2f4c0b2924f34c76b56f230cb091c16e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2600360Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#71855}
-
- 21 Dec, 2020 10 commits
-
-
Junliang Yan authored
Change-Id: I036bad7eba4bcf0ba80f7cec6f3d58a674e22b12 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2599937Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#71854}
-
Sami Kyostila authored
We also change pipeline-statistics.cc to use a combination of turbofan- related categories since that more accurately reflects the emitted events. TBR=bmeurer@chromium.org Bug: chromium:1084929 Change-Id: I85dcd89ab3e4cd95df3ae9791d158b4ab6c00829 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2599749 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
LAST_FUNCTION_TYPE, FIRST_FUNCTION_TYPE are no longer necessary. TBR: tebbi@chromium.org Bug: v8:11256 Change-Id: I37b1396eca8f89a287e04f2ef6b642dad248ae67 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2599745 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71852}
-
Junliang Yan authored
Change-Id: Idb8948c3ff9209a6a41d0793cd2f5c1557b417df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2598697Reviewed-by:
-
Camillo Bruni authored
This prevents CF from crashing and assuming it's a security issue for flaky bots. Bug: chromium:1152525 Change-Id: Ie782e55705e3bdbf2742ccd711f6544a71235b33 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2599748Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71850}
-
Camillo Bruni authored
- Fix landing page - Introduce and use SelectRelatedEvent for centralising the logic of finding and showing related LogEntries. It also clears the selection of all list panels if there are no related entries. - Add "select related" button to the script-panel to show events only from the currently selected script - Add selection type tabs for the map-panel - Fix transition colors for map-transitions view - Introduce separate map-transition view for the currently selected Map Bug: v8:10644 Change-Id: I4199a8332bab2518d98078712ed5ce9a8f1dc19e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2599555 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Junliang Yan authored
Change-Id: I8cdf2d79d0b0340c924360bf25e3ce0167ed8ee4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2595724Reviewed-by:
-
LiuYu authored
Port: 4ad68f1c Bug: v8:11008 Change-Id: I0aa384612b529babf9e526fca83c8c69f58b6f3b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2592828Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d6efe53..34da458 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie358cbfd3f3a9204427cdf4f7f030d3a49113259 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2599325Reviewed-by:
-
Zhi An Ng authored
Couple of optimizations for v128.bitselect on both ia32 and x64. 1. Remove an extra movaps when AVX is supported, since we have 3-operand instructions 2. Tweak the algorithm from: xor(and(xor(src1, src2), mask) src2) To: or(and(src1, mask), andnot(src2, mask)) It is easier to read and understand, and also eliminate a dependency chain (on kScratchDoubleReg) in the older algorithm. 3. Use integer forms of the logical ops. Older processors have higher throughput on these, compared to the floating point ops. However, the integer forms are 1 byte longer, so on SSE, we stick to the floating point ops. For AVX, this reduces instruction count from 9948 to 9868. Change-Id: Idd5d26b99a76255dbfa63e2c304e6af3760c4ec6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2591859Reviewed-by:
-
- 20 Dec, 2020 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6ae4be1..d6efe53 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I70dfc2899b0e47318254ada04b398e6212aebdcf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2599105Reviewed-by:
-
- 19 Dec, 2020 2 commits
-
-
LiuYu authored
Port: 7bdb0fbb Bug: v8:10582 Change-Id: I2a2227ddc45b86f7ad496b524514db96f423b185 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2598463Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/master@{#71843}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/68fec68..6ae4be1 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iedfb1d8a959bfa8a52939d7b3617bafdf4043051 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2598675Reviewed-by:
-
- 18 Dec, 2020 3 commits
-
-
Junliang Yan authored
Change-Id: Icf959a6e3ac66a5e907379ee9fec25223517af51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2598696Reviewed-by:
-
LiuYu authored
Port: 3dffdf03 Besides, port another CL which is needed by this one. Port: 8656a594 Bug: v8:7748 Change-Id: Ie0a8030794d69b3ea372e722230e82dceaf5fece Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2597960Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d50897f..68fec68 Rolling v8/third_party/aemu-linux-x64: j06MN21Z7_ISpAwWL3mLbbrGDGsSKnxGaEYTCDtE-RIC..qMq36BPvKEIxjpVFBefO08HoyM51jARe3EuX0vcgzWsC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/92c7710..8d43e58 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/36810de..d324a17 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1cbe60a0ca4e62e21489d5cc4fc416858dad1e28 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2598011Reviewed-by:
-
- 17 Dec, 2020 14 commits
-
-
Milad Fa authored
Features supported on P8 should also be enabled on P9. Change-Id: Iae96471e5b66a801f28e3e1069d0d522ec901d93 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2596998Reviewed-by:
-
Milad Fa authored
Change-Id: I2fb08d891112f8d88896a116622688ce6ea83a10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2595312Reviewed-by:
-
Clemens Backes authored
The opcodes were renamed long ago, but the macros were still using the old syntax. This CL was created using the following script (for WASM_GET_GLOBAL and WASM_SET_GLOBAL): ag -l WASM_GET_GLOBAL | xargs -L 1 sed -i 's/\bWASM_GET_GLOBAL\b/WASM_GLOBAL_GET/g' R=ahaas@chromium.org Bug: v8:11074 Change-Id: I3a9bd64f6e09ce97dae6d4132c224350dc079c0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2597576 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Clemens Backes authored
The opcodes were renamed long ago, but the macros were still using the old syntax. This CL was created using the following command (for WASM_GET_LOCAL, WASM_SET_LOCAL, and WASM_TEE_LOCAL): ag -l WASM_GET_LOCAL | xargs -L 1 sed -i 's/\bWASM_SET_LOCAL\b/WASM_LOCAL_SET/g' R=ahaas@chromium.org Bug: v8:11074 Change-Id: I0018bea185030be29344e66e59706fed183cc2f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2595446Reviewed-by: -
Milad Fa authored
PPC will be implemented separately. Change-Id: I358f5a73275a40f8083e9c07b7028d162969f836 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2597578Reviewed-by:
-
Nico Hartmann authored
This CL changes SharedFunctionInfo::GetBytecodeArray to a function template, which is specialized for Isolate and LocalIsolate arguments. This allows main thread only uses to avoid taking a lock. Bug: v8:7790, chromium:1154603 Change-Id: I3462c4e36b66073e09393c01c765dd8a018a98f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2595307 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#71833}
-
Tobias Tebbi authored
Change-Id: I31d2a19153fa17e6e78d3da93352da886addf089 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2581960 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#71832}
-
Seth Brenith authored
This change adds two simple lint rules to prevent including 'generates' or 'constexpr' clauses in cases where they have no impact on behavior. Bug: v8:7793 Change-Id: Ib1d8fde39ca26735ff9cb7892f01e464619c2090 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2590515Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#71831}
-
Andreas Haas authored
The TurboFan events, like time in register allocation, are only interesting in special cases, but create lots of events. Therefore it is good to put these events into their own tracing category. Bug: chromium:1084929 Change-Id: I971badc1ff58f99bd57b2ddfc93b625b356d6a2d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2595436Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#71830}
-
Mike Stanton authored
Bug: chromium:1158124 Change-Id: Ic23f4b2ffb9436771afcc0090f2179b48851c39d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2596336Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#71829}
-
Clemens Backes authored
The class disallows copy construction, but still allows copy assignment. This is fixed in this CL. Drive-by: Fix punctuation. Drive-by 2: Fix indentation in code example. R=etiennep@chromium.org Bug: v8:11074 Change-Id: I09e993a69d72e262d7b220200ef94b36d346548e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2584246Reviewed-by:
-
Patrick Thier authored
When we know a value passed to BytecodeArrayBuilder::LoadLiteral(double) can be encoded as a Smi, we create LdaSmi instead of LdaConstant. Driven by a forgotten Smi::FromInt() in BytecodeGenerator, also fixed in this CL. Bug: v8:11278 Change-Id: I4a1ad48e2c9aff8391113812e34dae838a1a38d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2595437Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#71827}
-
Sathya Gunasekaran authored
This allows the JSFunctionOrBoundFunction instance type range to no longer be stuck at the last of the JSObject instance type range. This will be useful in the future where we extend the function instance types and include them in fast protector cell checks. Bug: v8:11256 Change-Id: I955991576b3cca76b10f76c87748016fe527e3d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2595275Reviewed-by:
-
Nico Hartmann authored
This reverts commit 860fcb1b. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20arm%20-%20sim%20-%20lite/13831/overview Original change's description: > Faster JS-to-Wasm calls > > This replaces https://chromium-review.googlesource.com/c/v8/v8/+/2376165/. > > Currently JS-to-Wasm calls go through a wrapper/trampoline, built on > the basis of the signature of a Wasm function to call, and whose task > is to: > - set "thread_in_wasm_flag" to true > - convert the arguments from tagged types into Wasm native types > - calculate the address of the Wasm function to call and call it > - convert back the result from Wasm native types into tagged types > - reset "thread_in_wasm_flag" to false. > > This CL tries to improve the performance of JS-to-Wasm calls by > inlining the code of the JS-to-Wasm wrappers in the call site. > > It introduces a new IR operand, JSWasmCall, which replaces JSCall for > this kind of calls. A 'JSWasmCall' node is associated to > WasmCallParameters, which contain information about the signature of > the Wasm function to call. > > WasmWrapperGraphBuilder::BuildJSToWasmWrapper is modified to avoid generating code to convert the types for the arguments > of the Wasm function, when the conversion is not necessary. > The actual inlining of the graph generated for this wrapper happens in > the simplified-lowering phase. > > A new builtin, JSToWasmLazyDeoptContinuation, is introduced to manage > lazy deoptimizations that can happen if the Wasm function callee calls > back some JS code that invalidates the compiled JS caller function. > > Bug: v8:11092 > Change-Id: I3174c1c1f59b39107b333d1929ecc0584486b8ad > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2557538 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> > Reviewed-by: Georg Neis (ooo until January 5) <neis@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Paolo Severini <paolosev@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#71824} TBR=neis@chromium.org,ahaas@chromium.org,jgruber@chromium.org,tebbi@chromium.org,ishell@chromium.org,mslekova@chromium.org,nicohartmann@chromium.org,paolosev@microsoft.com Change-Id: I214cbdee74c1a2aaad907ffc84662ed25631983e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:11092 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2595438Reviewed-by:
-
