- 06 Apr, 2022 40 commits
-
-
David Benjamin authored
Bug: v8:12518 Change-Id: Ie22303416749affc0629d60fbed6f9dc4288b09d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3494443Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/main@{#79834}
-
Shu-yu Guo authored
Bug: v8:12744 Change-Id: I3e356c16554e8bc19afc06b18f4afd7fed2f228e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3563540 Commit-Queue: Shu-yu Guo <syg@chromium.org> Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#79833}
-
Kevin Babbitt authored
Embedders can currently specify a callback for OOM errors during Isolate initialization. However, there are cases where an OOM error can be thrown in a context where we don't have access to an Isolate, for example on a task posted to a worker thread. This CL introduces an initialization API to allow the embedder to specify a process-wide OOM callback. Bug: chromium:614440 Change-Id: I326753d80767679f677e85104d9edeef92e19086 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3561916Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/main@{#79832}
-
Michael Lippautz authored
IM::Finalize() was merely finishing marking through the incremental marking in the atomic pause. Avoid the Hurry() call since the marking worklists would anyways be drained with parallel marking. Bug: v8:12775 Change-Id: Ice72a8bb5f900368eadec7f62bf18e03d568454b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3574547Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#79831}
-
Jakob Gruber authored
With kLazy deopts gone, we can remove the stored DeoptimizeKind from Deoptimize nodes and all related spots - all Deoptimize nodes are eager deopts. Bug: v8:12765 Change-Id: I8e727e046c498198e50d9b7dba25442fb54f5da9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3568456 Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#79830}
-
Leszek Swirski authored
Also add a mixin for using the single-threaded default platform instead of swapping it in with SetPlatformForTesting. Bug: v8:12781 Change-Id: I304303e58ed713e5558d108cd7eb826c17abb40f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3574553 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#79829}
-
Alexander Schulze authored
Currently, v8_presubmit uses the system version of depot_tools for C++ and JS linting. This is an issue for branches which rely on a specific depot_tools version for linting. This CL proposes the use of the depot_tools version defined in DEPS. This change was evaluated in https://crrev.com/c/3571813. The first v8_presubmit attempt uses the system-defined depot_tools version, while the second attempt is rebased on this CL and uses the DEPS defined version. Bug: v8:12743 Change-Id: I87e14ea5c1e3dc20b34106ff56f608d55ec3253d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571805Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Alexander Schulze <alexschulze@chromium.org> Reviewed-by: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/main@{#79828}
-
Seth Brenith authored
Currently, the category named “(compiled code)” contains Code, SharedFunctionInfo, and Script objects. However, there are various other object types that are allocated per script function, such as BytecodeArray and FeedbackVector. There are also plain FixedArrays which are used for function-specific data such as polymorphic feedback and code deoptimization data. I propose we move all of this to the “(compiled code)” category, because this memory usage is related to the number of functions in the script, the size of those functions, and/or the number of times those functions have been called. Bug: v8:12769 Change-Id: Ib5e0265a9ef88063596c17419f5b65f683156c52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3569876Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/main@{#79827}
-
Camillo Bruni authored
This is no longer actively used. Change-Id: I88b0695732ead8652a21ed5d59f3d9752c0c88d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3574551Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#79826}
-
Clemens Backes authored
A worker might be terminated while creating a new Realm. While this was handled mostly correctly already, a DCHECK was places slightly too early, which is fixed by this CL. Also, we avoid printing an error message if we fail to install an extension due to isolate termination. As this is externally triggered, it's not really an error condition. R=jkummerow@chromium.org Bug: chromium:1313475 Change-Id: I67b7fd27002d9b9a33439378d8336fefb2a2371a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571811Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79825}
-
Omer Katz authored
A lot of the space/chunk methods can be trivially marked as const. There are more methods that can be made const but these will require creating new const object iterators, so those are left out for now. Bug: v8:12612 Change-Id: I753b8b3f7a200ecf255596c7825917e4eb600b81 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571815Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#79824}
-
Marja Hölttä authored
Looks like historical leftovers from the time when we had "pixel arrays" and external array elements kinds. See https://codereview.chromium.org/1262583002 Bug: v8:11111 Change-Id: I288d47ae802218737bd6226cbb999c3289d1dbaf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3574548Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#79823}
-
Dominik Inführ authored
This CL only refactors code in the sweeper without changing behavior. This method can be simplified by moving duplicate code into new methods. Also move definition of FreeRangesMap into TypedSlotSet and replace all usages of that raw map type with that type-alias. Since we are already here, remove the unused argument in Sweeper::FreeAndProcessFreedMemory. Bug: v8:12760 Change-Id: Ifa1848b456aef7955eccbaafc00df55fbcbc385c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3574542Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79822}
-
Benedikt Meurer authored
Similar to what we did for FunctionMirror before in https://crrev.com/c/2887508, we also need to avoid running user JavaScript for DateMirrors. This also refactors the ToDateString logic a bit. Fixed: chromium:1311613 Change-Id: I793b86106765550a9aa449f85f0766840081cc58 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571896Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/main@{#79821}
-
Leszek Swirski authored
Change the unittest runner to no longer uncondtionally set up a default platform in the "environment", but to instead make platform set-up part of the "mixin" framework for test fixtures. Requires modifying some tests that expect the platform to be available, and all flag implications resolved, before the mixin constructors run. We still keep the environment for setting up the process for cppgc. This process setup can only be done once per process, so it can no longer use the platform -- that's ok though, the page allocator used by cppgc's process initialisation doesn't have to be the same as the platform's so we can just pass in a separate new one. Change-Id: Ic8ccf39722e8212962c5bba87350c4b304388a7c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571886Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#79820}
-
Omer Katz authored
TearDown was actually redundant and can be replaced with the dtor. Bug: v8:12612 Change-Id: Idc4a77c3f20372a53b0003cda6fb00ae7ec0035c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571806Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#79819}
-
Clemens Backes authored
Replace by std types defined in <type-traits> since C++17. R=mslekova@chromium.org Bug: v8:12425 Change-Id: I7ec8454634ecb63a3da4f93412d7a6c5002bb7c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3572045Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79818}
-
Hannes Payer authored
Bug: v8:12503 Change-Id: I81d02231b7e40fb0ed487de128ffaedcd3cd2126 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571898Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/main@{#79817}
-
Camillo Bruni authored
Reduce the dispatching overhead in the hottest loop when parsing log-lines. - Using a JSMap we can avoid internalizing strings - Preprocess the dispatch table and only have varArgs or functions as parsers - string[] seems to be slightly faster than string.charAt() Bug: v8:10644 Change-Id: I03b13bdeecda1ad037191ff74e05142ceeb6533c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571890Reviewed-by: Patrick Thier <pthier@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#79816}
-
Clemens Backes authored
The 'ForRegs' method is not needed for clarity of the code, it's pretty clear what to construct a register list from. Hence turn the static {LiftoffRegList::ForRegs} method into a constructor. This makes the code more concise. Also, turn the for loop into a C++17 folding expression, which might generate better code because the loop will automatically be unrolled. R=thibaudm@chromium.org Bug: v8:12425 Change-Id: Ic4446f23022db5f17420303d45b9c15fa5daff60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3572041Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79815}
-
Dominik Inführ authored
This CL adds additional checks for typed slots cleanup in the sweeper: 1) Old-to-old typed slots should never be removed during sweeping. Such slots are only ever recorded on live code objects (which are never e.g. right-trimmed or invalidated). 2) Old-to-new typed slots should never be removed when sweeping lazily or concurrently. New space is empty after a full GC, therefore the old-to-new typed slots are also cleared during a full GC. The main thread can record new slots but not in free memory. Bug: v8:12760 Change-Id: I7b507c862e43a15437e8ee609c6c2af0abf3a5ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3568479Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79814}
-
Clemens Backes authored
This is a reland of commit 54e360d1. The two WasmGC cctests which require SSE4.1 support in Liftoff are now skipped, so we can keep disallowing any bailout (even for missing CPU features) in --liftoff-only. Original change's description: > [wasm] --liftoff-only should disable --wasm-dynamic-tiering > > A Liftoff only configuration should never tier up to TurboFan, hence add > a proper implication to disable dynamic tiering if --liftoff-only is > set. > Also, add a DCHECK to ensure we never accidentally compile with TurboFan > if --liftoff-only is set. > > R=jkummerow@chromium.org > > Bug: v8:12281 > Change-Id: Ia9b81add503cc939f59fde3f4d3bb67252facf2c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3569741 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/main@{#79779} Bug: v8:12281 Change-Id: I334bd81f75c3ef6d31b6117da5ef59a33fb46ae2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3572043Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79813}
-
Clemens Backes authored
Remove the pre-C++17 implementation of void_t, just use std::void_t now. R=omerkatz@chromium.org Bug: v8:12425 Change-Id: Iabf72f1540ddb4db666e5a74f169f73546241c1f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571888Reviewed-by: Omer Katz <omerkatz@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79812}
-
Stephen Roettger authored
Change from V8_DEPRECATE_SOON to V8_DEPRECATED. It turned out that we don't have to make changes in chrome code, so we can go to deprecated right away. Bug: chromium:1310790 Change-Id: I1bd529536d3a0098f11f13b3e44fe3dbc80eed04 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571897Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Stephen Röttger <sroettger@google.com> Cr-Commit-Position: refs/heads/main@{#79811}
-
Leszek Swirski authored
This reverts commit 8ba60b7a. Reason for revert: code_serializer failures: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20debug/38940/overview Original change's description: > [string] Non-transitioning shared strings > > Instead of transitioning shared strings to ThinString on > internalization, use a forwarding table to the internalized string and > store the index into the forwarding table in the string's hash field. > > This way we don't need to handle concurrent string transitions that > modify the underlying string data. > > During stop-the-world GC, live strings in the forwarding table are > migrated to regular ThinStrings. > > Bug: v8:12007 > Change-Id: I6c6f3d41c6f644e0aaeafbf25ecec5ce0aa0d2d8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3536647 > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Reviewed-by: Jakob Linke <jgruber@chromium.org> > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Patrick Thier <pthier@chromium.org> > Cr-Commit-Position: refs/heads/main@{#79801} Bug: v8:12007 Change-Id: I740904f3edfc395331f06c7218e89476b06b0563 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3574543 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Owners-Override: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#79810}
-
Leszek Swirski authored
Change-Id: Ibc256e202a75f7dbcba27dad2b591cf45738b005 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571900 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#79809}
-
Leszek Swirski authored
Change-Id: Ia574baaa796f1b2d6feea3e76364c9c417fb8ceb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571899 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#79808}
-
Harshal Nandigramwar authored
* When the source node is above the target node we draw curved (cubic bezier) lines. * Else, we fallback to rectangular lines. Change-Id: Ic80245c7b449942e4477f0056e63618cfbeaaaf7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3565715Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Auto-Submit: Harshal Nandigramwar <pro.bbcom18@gmail.com> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#79807}
-
Nikolaos Papaspyrou authored
Report per-cycle incremental mark/sweep statistics to the Recorder API. These will be used by Blink to populate UMA histograms such as V8.GC.Cycle.MainThread.Full.Incremental.(Mark|Sweep). Also, report time spent in starting incremental marking, used by Blink to populate V8.GC.Event.MainThread.Full.Incremental.Mark.Start. Bug: chromium:1154636 Change-Id: Iad205471f3b20843b7e439f47c0d681e840c9043 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3568480Reviewed-by: Omer Katz <omerkatz@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org> Cr-Commit-Position: refs/heads/main@{#79806}
-
yangwenming authored
With this CL, spilled parameters with ref type in a call to wasm function, will be placed at a consecutive area in the generic JSToWasmWrapper frame as WasmCallDescriptor expected. Bug: v8:12722 Change-Id: I8b82f35b712a32b87abf5100ec46ee499a8178bc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3563445Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#79805}
-
Clemens Backes authored
This enabled dynamic tiering by default in V8. Chromium overwrites the default, so this CL by itself has no effect on Chrome users, but a similar CL will land in the chromium repo. R=mslekova@chromium.org Bug: v8:12281 Change-Id: Iaa6d77dc80063f3c4e1d005c371573fc70c698aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3568449Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79804}
-
Clemens Backes authored
Use C++17's std::conjunction instead. R=leszeks@chromium.org Bug: v8:12425 Change-Id: I004a1bb4fe1b09f441f8822075a72fd20fc90fec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3570429Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79803}
-
Jakob Gruber authored
This flag was a leftover from very early Turbofan days and serves no purpose. Non-OSR TF code automatically uses function context specialization (FCS) when appropriate without looking at the flag value. OSR TF code should never use FCS since it is cached by the SharedFunctionInfo (not by the JSFunction). Bug: v8:12161 Change-Id: Ifb5a10918dbdf34a7164f7e665a230698b793e9e Fixed: chromium:1313419 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571895 Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#79802}
-
Patrick Thier authored
Instead of transitioning shared strings to ThinString on internalization, use a forwarding table to the internalized string and store the index into the forwarding table in the string's hash field. This way we don't need to handle concurrent string transitions that modify the underlying string data. During stop-the-world GC, live strings in the forwarding table are migrated to regular ThinStrings. Bug: v8:12007 Change-Id: I6c6f3d41c6f644e0aaeafbf25ecec5ce0aa0d2d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3536647Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Jakob Linke <jgruber@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/main@{#79801}
-
Anton Bikineev authored
Oilpan minor GC currently doesn't support running with the stack. The CL changes minor GCs to run only when running from task. Bug: chromium:1029379 Change-Id: I96552772e9c3b653a137f48bbaae44278db8f014 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571891Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/main@{#79800}
-
Hannes Payer authored
This CL introduces the --separate-gc-phases flag, which prevents that young and old generation GCs can happen at the same time. When incremental marking is in progress and a young generation GC triggers, marking is forced to finish and the full collection takes care of the young generation. Bug: v8:12503 Change-Id: Ia3e4814f46bff0fdc404b0ac618dfd48fe7cf20c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3351973Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/main@{#79799}
-
Dominik Inführ authored
Only remove old-to-old slots during a GC, but DCHECK that the old-to-old-slot set is empty after a full GC. Previously we simply removed from the remembered set during and outside the full GC. We now have a flag to DCHECK this more precisely. Bug: v8:12760 Change-Id: Ie6adc3f47a700497aaa818da0e83d6cb94e3c75d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3562981Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79798}
-
Liu Yu authored
Port commit 1ff685d8 Fixed: v8:12765 Change-Id: Ia5ac9f06a70a11c3d7a9d97f6772f8f37db0df6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3573114 Auto-Submit: Yu Liu <liuyu@loongson.cn> Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/main@{#79797}
-
Bryant Chandler authored
This reverts commit 8d51d561. Reason for revert: This has runtime failures because including cmx fragments isn't working ocrrectly. Still investigating why this wasn't discovered by CQ. Original change's description: > [fuchsia] Use SDK provided gn templates for v8_unittests > > cr_fuchsia_package is deprecated in favor of using the Fuchsia > SDK provided rules directly. > > Bug: chromium:1092804 > Change-Id: I86a59b6a717cb0aa8c3473e8410bdd98f0ffd042 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3537883 > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Commit-Queue: Bryant Chandler <bryantchandler@chromium.org> > Cr-Commit-Position: refs/heads/main@{#79763} Bug: chromium:1092804 Change-Id: I33e8a6f07c99d7040cffa579a95508e79904889e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3572005 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#79796}
-
Frank Tang authored
Add AO: DefaultMergeFields Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.calendar.prototype.mergefields https://tc39.es/proposal-temporal/#sec-temporal-defaultmergefields Bug: v8:11544 Change-Id: I270f8bffb79e57ef50736ae7ce87cfa53f9cafb1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3388428Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#79795}
-