- 24 Feb, 2010 3 commits
-
-
sgjesse@chromium.org authored
This caused some regressions in Chromium. BUG=http://crbug.com/36604 Review URL: http://codereview.chromium.org/652228 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3939 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
http://codereview.chromium.org/652118serya@chromium.org authored
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3937 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
sgjesse@chromium.org authored
Review URL: http://codereview.chromium.org/570022 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3936 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 23 Feb, 2010 5 commits
-
-
sgjesse@chromium.org authored
It is now possible to experiment with profiler guided optimizations when building V8. First build an instrumented sample shell: > scons pgo=instrument sample=shell Then run the JavaScript code to optimize for using that sample shell. Finally build an optimized sample shell. > scons pgo=optimize sample=shell Currently this does not work when building V8 as a DLL due to scons deleting v8.exp prior to the pgo=optimize step. Due to a bug in Visual Studio (seen in version 2008) the function MessageDispatchHelperThread::Run() in debug.cc needs to be empty for this to work. Review URL: http://codereview.chromium.org/652114 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3934 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
serya@chromium.org authored
Review URL: http://codereview.chromium.org/650047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3933 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
whesse@chromium.org authored
Review URL: http://codereview.chromium.org/652110 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3932 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
lrn@chromium.org authored
Review URL: http://codereview.chromium.org/652041 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3929 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
fschneider@chromium.org authored
Review URL: http://codereview.chromium.org/654003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3928 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Feb, 2010 4 commits
-
-
fschneider@chromium.org authored
These two asserts in ComputeEntryFrame are wrong since the virtual frame already knows how to deal with the number type information of copy elements: We do not store type information with copy elements. Instead the backing element contains the type information. Review URL: http://codereview.chromium.org/652044 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3927 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
whesse@chromium.org authored
Review URL: http://codereview.chromium.org/650140 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3925 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
whesse@chromium.org authored
Review URL: http://codereview.chromium.org/650136 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3924 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
sgjesse@chromium.org authored
Some functions of the stub cache returned undefined if a code stub could not be generated. However the clients of these functions only cehcks for failure. Now all these functions return a failire object if no code stub can be made available Review URL: http://codereview.chromium.org/652039 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3923 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 19 Feb, 2010 15 commits
-
-
vitalyr@chromium.org authored
Original review: http://codereview.chromium.org/646010/show Change the implementation of lastIndexOf method of String. Convert the strings in question to Vector<char> or Vector<uc16> and execute simple search algorithm on them. The difference in speed on 500k character string is about 10x. TBR=ager@chromium.org Review URL: http://codereview.chromium.org/650036 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3922 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
whesse@chromium.org authored
Review URL: http://codereview.chromium.org/650028 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3921 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
kmillikin@chromium.org authored
A list of bailout descriptions is kept in the CompilationInfo structure that is shared between the primary and secondary code generators. The primary adds a description to the list for each bailout position. Responsibility for binding labels is moved from the primary to the secondary code generator. All the labels still target the start of the secondary code and the compilation state of the primary is still ignored. Move the compilation mode flag to the CompilationInfo. Review URL: http://codereview.chromium.org/651031 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3920 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yurys@chromium.org authored
Review URL: http://codereview.chromium.org/647022 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3919 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ricow@chromium.org authored
Added test for bug 619 - we should move this to object-define-property when the bug has been corrected. Review URL: http://codereview.chromium.org/651028 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3918 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
vitalyr@chromium.org authored
* Inlined checks for strings and regexps. * Rewrote split for the non-regexp case. * Implemented one-char case for lastIndexOf. Review URL: http://codereview.chromium.org/596122 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3917 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ricow@chromium.org authored
Removed asserts on attributes when setting elements. Will file a bug on not handling elements correctly when using Object.defineProperty Review URL: http://codereview.chromium.org/651025 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3914 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ager@chromium.org authored
been missing for a long time but the fallthrough to the default case used to break. Now the default case should be unreachable and the fallthrough therefore causes assertion failures. Review URL: http://codereview.chromium.org/651024 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3913 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
kmillikin@chromium.org authored
Reorder code so that helper functions and simple accessors come before all the visit function. Review URL: http://codereview.chromium.org/650026 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3912 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
whesse@chromium.org authored
Review URL: http://codereview.chromium.org/651019 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3911 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
fschneider@chromium.org authored
Although algorithmically correct, the compiler would not allow to instantiate a BitField that uses all 32 bits without warnings about a too large shift count. As a consequence we were limited to 31 bit values when using BitField. This happened when instantiating a bitfield BitField<T, shift, size> with [shift=0, size=32] or [shift=31, size=1] or more general any [shift=X, size=32-X] As side-effect of the new implementation the compiler now warns if we ever try instantiating a bitfield with size 0. Review URL: http://codereview.chromium.org/606063 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3910 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
fschneider@chromium.org authored
TBR=kmillikin@chromium.org, Review URL: http://codereview.chromium.org/650025 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3909 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
fschneider@chromium.org authored
This allows us to make changes to one platform without affecting the others. Review URL: http://codereview.chromium.org/646019 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3907 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
kmillikin@chromium.org authored
Add a (currently) syntactic predicate to AST expression nodes telling whether they are 'trivial'. Trivial expressions have no side effects, do not require storage to be allocated for them, and can be evaluated out of order (because their value does not change between when they are visited by the code generator as expressions in the AST and when it is consumed). Mark 'this' and literals as trivial. Allow them to be pushed on the virtual frame. Make use of them to push 'this' more lazily in this property assignments. Review URL: http://codereview.chromium.org/647018 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3906 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ager@chromium.org authored
Review URL: http://codereview.chromium.org/651016 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3903 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Feb, 2010 10 commits
-
-
antonm@chromium.org authored
Review URL: http://codereview.chromium.org/647013 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3902 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ager@chromium.org authored
Replaced IsValid by IsPropertyOrTransition and used IsProperty in most of the places where IsValid was used before. Most of the time when inspecting a lookup result we really want to know if there is a real property present. Only for stores are we interested in transitions. BUG=http://crbug.com/20104 TEST=cctest/test-api/NamedInterceptorMapTransitionRead Review URL: http://codereview.chromium.org/647015 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3901 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ricow@chromium.org authored
Added access check to SetNormalizedProperty which is used from runtime DefineOrRedefineDataProperty. Review URL: http://codereview.chromium.org/647010 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3900 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
kmillikin@chromium.org authored
Change compilation of assignment expressions in the ia32 code generator to no longer use the Reference helper class. This gives us more explicit control over which subexpressions are evaluated and when. Review URL: http://codereview.chromium.org/643001 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3899 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
sgjesse@chromium.org authored
Review URL: http://codereview.chromium.org/647014 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3898 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
whesse@chromium.org authored
Fix error in compound assignment to keyed load by making platform-independent full compiler code platform dependent, add test of compound assignments. Review URL: http://codereview.chromium.org/646009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3897 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mikhail.naganov@gmail.com authored
It doesn't mean I'm participating in some fixit, just spotted some code which doesn't have usages and decided to remove it. Review URL: http://codereview.chromium.org/646007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3896 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
whesse@chromium.org authored
Review URL: http://codereview.chromium.org/601080 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3895 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
sgjesse@chromium.org authored
Fix broken condition. Fixe some style issues. Re-enabel part of a test which was turned off. TBR=ager@chromium.org Review URL: http://codereview.chromium.org/647007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3894 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
sgjesse@chromium.org authored
Moved all the logic to a function on SharedFunctionInfo (including the flag check) to make things more readable. Changed the check for setter to do a lookup for a named setter for each of the properties assigned in the constructor. Added tests using accessors and interseptors set through the API. Added fast case objects to the mjsunit test. TEST=test/mjsunit/setter-on-constructor-prototype.js TEST=test/cctest/test-api/SetterOnConstructorPrototype TEST=test/cctest/test-api/InterceptorOnConstructorPrototype Review URL: http://codereview.chromium.org/619006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3893 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 Feb, 2010 3 commits
-
-
peter.rybin@gmail.com authored
Review URL: http://codereview.chromium.org/626002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3892 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
peter.rybin@gmail.com authored
Review URL: http://codereview.chromium.org/607004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3891 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
kmillikin@chromium.org authored
Remove a move and jump from the fast-path code in the speculative backend. Ultimately, this code belongs to the bailout and not the fast path. Review URL: http://codereview.chromium.org/601094 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3890 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-