- 19 Dec, 2019 21 commits
-
-
Z Nguyen-Huu authored
This is the first part of switching between Liftoff and Turbofan in debugging Wasm. In this CL, we implemented the logic to tier down/up all functions in module. Bug: v8:9654 Change-Id: Ia25103ca29963afa103c124ff5f159f197c2b2b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1970470 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65529}
-
Richard Townsend authored
Bug: v8:10012 Change-Id: Id94276d8ab10835758b9c63029ac3c35d35e903b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1962853Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#65528}
-
Clemens Backes authored
It would be nice if unused {RegClass}es just equal {kNoReg} on all platforms. This CL adds the static asserts for that, and slightly modifies the definition of the {RegClass} enum to fulfil that. Interestingly, this only changes the values for the one configuration that is currently unused :) R=zhin@chromium.org Change-Id: Ib1b2a663183ad34822f514d6168c65450c1d7f2e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1975753Reviewed-by:Zhi An Ng <zhin@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65527}
-
Ng Zhi An authored
For functions which check if a register pair is used, change them from is_gp_pair to is_pair, since they do not care if the pair of register is a gp pair or a fp pair. Bug: v8:9909 Change-Id: I262108caadd616c64019b39ebbf6972a548112df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1974833Reviewed-by:
-
Clemens Backes authored
For Smi, we can avoid calling the ToNumber builtin, and also the conversion to float and back. This adds some complexity, but greatly improves performance for parameters that fit in a Smi. R=jkummerow@chromium.org Bug: v8:10070 Change-Id: Ic55f17e42ce52811296293f3cd218c850af42961 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1965576 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#65525}
-
Peter Marshall authored
Bug: chromium:1033407 Change-Id: I59642d64fd111884547605f7a010d40e974d2762 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1975752Reviewed-by:
-
Joshua Litt authored
Bug: v8:9838 Change-Id: Ibf0c0b0f55a3728810de026c0132ff89e2c9861f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1961943Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Joshua Litt <joshualitt@chromium.org> Cr-Commit-Position: refs/heads/master@{#65523}
-
Ulan Degenbaev authored
This is a reland of ff7acbd6 Original change's description: > Reland "Delay setting up deserialized JSArrayBuffer" > > This is a reland of 83786cb4 > > Original change's description: > > Delay setting up deserialized JSArrayBuffer > > > > Setting up JSArrayBuffer may trigger GC. Delay this until we > > are done with deserialization. > > > > R=ulan@chromium.org > > > > Bug: chromium:1033395 > > Change-Id: I6c79bc47421bc2662dc1906534fc8e820c351ced > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1965580 > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Commit-Queue: Yang Guo <yangguo@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#65441} > > Tbr: yangguo@chromium.org > Bug: chromium:1033395, chromium:1034059 > Change-Id: I89d05768f52a480400d9c6f5aaaa233c5d5ba126 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1969896 > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65484} Tbr: yangguo@chromium.org Bug: chromium:1033395, chromium:1034059 Change-Id: I1cc47fa742bd7c5ce602b1eb9a0a78cb479a86f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1975756Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#65522}
-
Peter Marshall authored
This new API uses the code pages rather than code ranges approach. It's supported on arm32, as well as the previous two supported platforms, x64 and arm64. Deprecate the old API which only works on x64 and arm64 to reduce the maintenance overhead of keeping both. Users of the old API should migrate to the new one as it can be used all on supported platforms. We keep the tests for the old API by ignoring deprecation warnings so that we don't accidentally break it while it is still in the codebase. Design doc: https://docs.google.com/document/d/1VGwUult5AHLRk658VetwEHMOmDDxA2eDQs9lDFMZTE0 Bug: v8:8116 Change-Id: I1de8246a48fc1b4991603501ea6087db6b43fdd9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1969900 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Clemens Backes authored
After calling the ToNumber builtin, we are guaranteed to get either a Smi or a HeapNumber. Thus we can skip the check for undefined, which removes quite some unneeded code from wasm-to-js and js-to-wasm wrappers. R=ahaas@chromium.org Bug: v8:10070 Change-Id: I0e2ad19f1575fb6979222e324fbdb71aaf85e6fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1962279 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#65520}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d854784..09a0189 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/aa39e6f..104d957 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I152d09c71e965fec6e0b4cfafce4a0a8ae858941 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1975950Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#65519}
-
Daniel Clifford authored
Bug: v8:7793 Change-Id: Ib950ce398f101779a4654353d08ce947b8e05a66 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526016Reviewed-by:
-
Shu-yu Guo authored
The spec was normatively changed to simplify var scopes for parameter expressions. Previously there was a per-parameter var scope in sloppy mode so direct evals could introduce vars that did not escape the parameter position. That semantics is complex both for the programmer and implementation and has resulted in bugs in the past. Furthermore, it has never been fully interoperable (with Safari in particular). The spec was instead changed to be simpler: to have a single var scope for sloppy evals in parameters that encloses the parameter scope and body scope. This simplification lets us remove expression-scope-reparenter. Drive-by removal of stale reference to PatternRewriter. Bug: v8:7532 Change-Id: Iade5594abe0009f7f3f6a1adad18628b17e1e779 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1962471Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#65517}
-
Nico Hartmann authored
This reverts commit ff7acbd6. Reason for revert: https://ci.chromium.org/p/chromium/builders/try/win_optional_gpu_tests_rel/34257 Original change's description: > Reland "Delay setting up deserialized JSArrayBuffer" > > This is a reland of 83786cb4 > > Original change's description: > > Delay setting up deserialized JSArrayBuffer > > > > Setting up JSArrayBuffer may trigger GC. Delay this until we > > are done with deserialization. > > > > R=ulan@chromium.org > > > > Bug: chromium:1033395 > > Change-Id: I6c79bc47421bc2662dc1906534fc8e820c351ced > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1965580 > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Commit-Queue: Yang Guo <yangguo@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#65441} > > Tbr: yangguo@chromium.org > Bug: chromium:1033395, chromium:1034059 > Change-Id: I89d05768f52a480400d9c6f5aaaa233c5d5ba126 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1969896 > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65484} TBR=ulan@chromium.org,yangguo@chromium.org,petermarshall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1033395, chromium:1034059 Change-Id: I3ad17293bfeba8a817346f57f885c7ba95739d36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1975751Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#65516}
-
Igor Sheludko authored
... in object literals. Bug: chromium:1034973 Change-Id: Ie357eef4c46f87486f2c3756ba1c288ad25a93df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1974070Reviewed-by:
-
Frank Tang authored
Bug: chromium:1014272 Change-Id: I5707dbfcff4ac52f7f27b0f9feb2edfe1c7775ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1972425Reviewed-by:
Frank Tang <ftang@chromium.org> Reviewed-by:
-
Zhang, Shiyu authored
Contributed by fanchen.kong@intel.com Change-Id: I99f2360ba1b064577c6891a161fd62114cce7a3f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1975341Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#65513}
-
Zhang, Shiyu authored
Change-Id: I3c83a3e9b0a9aa58d31968dbcb5bcb483eb47926 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1965927 Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/471c567..d854784 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/0124932..aa39e6f Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/5e2debe..a892219 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I44762690b171d49e5d744dc01748b0f480ab70da Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1975192Reviewed-by:
-
Joshua Litt authored
Also port a few smaller functions. Bug: v8:9838 Change-Id: I2245abe648378970a89331baa19af49f7f49359b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1961942 Commit-Queue: Joshua Litt <joshualitt@chromium.org> Reviewed-by:
-
Johannes Henkel authored
New revision: 3b0551d3904f7fc067e78905ce697002187fa7a5 Upstream reviews: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1972474 https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1967550 Change-Id: Ie9cec5faf410cc80ddb178da30cda66d801196f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1972404Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#65509}
-
- 18 Dec, 2019 19 commits
-
-
Ng Zhi An authored
This introduces a new constant kNeedS128RegPair, which is set for architecture where a pair of FP registers (DoubleRegister) is mapped to single Simd128Register (ARM). In this case, a new RegClass, kFpRegPair, is defined to represent LiftoffRegister of this type. kFpRegPair will be kNoReg on all other architectures. We add 1 more bit to the encoding on ARM, so now the top bit is set for kFpRegPair, the second most top bit is set for kGpRegPair. When the top bit is set, we encode the FP register code into the bottom bits of code_. Note that this is directly encoded, i.e. not added to kMaxGpRegCode, so we can save an add/subtract when converting to/from DoubleRegister. We only need to store 1 FP register, the low register, since the high other register is implicity the next register. Note that the stored register is *always* an even-numbered register. Bug: v8:9909 Change-Id: I78d603c9938c3d0add9bd3ca77ddebbfa7abbc05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1973276 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Frank Tang authored
Implement the ECMA402 localeMatcher: "best fit" option by using ICU LocaleMatcher API. Bug: v8:7051 Change-Id: I3d7c1ee39a5c649a5f500429f2b41329346a1a78 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943050Reviewed-by:
-
Joshua Litt authored
Change-Id: I9fa2276b9e27fe51d15be3c1afb34633b53d1230 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1973969Reviewed-by:
-
Z Nguyen-Huu authored
In setting breakpoint in wasm, we can find wasm script from location but in removing a breakpoint, only breakpoint id is provided. For wasm, we have a list of all BreakPointInfo objects attached to the Script. From breakpoint id, we iterates all scripts to find the targeted breakpoint and remove it. Bug: chromium:837572 Change-Id: Ia5d0fb7d804fb98270b2103232bc10eb5d4f93a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1959749 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65505}
-
Liviu Rau authored
Bug: v8:9633 Change-Id: I44e8e2d036552f47c82441cd0484807ca34d0e14 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1973739 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by:
-
Nico Hartmann authored
This CL implements enums in Torque in three steps: 1.) It implements necessary changes to Torque's type system. In particular, the constraints on constexpr types are relaxed such that constexpr types can exist without a corresponding non-constexpr version. Furthermore, constexpr and their non-constexpr counterpart need not be of the same kind of type. This allows an AbstractType to have a UnionType as its non-constexpr counterpart. 2.) The enum feature itself is realized as a pure desugaring in the parser, where all required types, constants and macro specializations (like FromConstexpr<>) are generated from a simple enum declaration, such that enum entries are not just constants, but are namespace scoped and have distinct types so that they can be used within typeswitch constructs. 3.) Almost all of the existing constants defined in torque (.tq files) are ported to new enum definitions. Bug: v8:10053 Change-Id: I72426d3b1434f301fd690847e15603de0dc1021b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1964392 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
-
Maya Lekova authored
Fixed: chromium:1035331 Change-Id: I6ef31910b2e22e4687412c45cc14c98669c6bd3f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1973733Reviewed-by:
-
Joey Gouly authored
This is similar to the change made to IsImmLSPair in 9f7ae50a. Change-Id: I17a7cc95661542efb5711df0639cc11ac7926702 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1971950 Commit-Queue: Joey Gouly <joey.gouly@arm.com> Reviewed-by:
-
Thibaud Michaud authored
This is a reland of c509bb8c Original change's description: > Cache native modules in the wasm engine by their wire bytes. This is to > prepare for sharing {Script} objects between multiple {WasmModuleObject} > created from the same bytes. This also saves unnecessary compilation > time and memory. > > R=clemensb@chromium.org > > Bug: v8:6847 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1916603 > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65296} R=clemensb@chromium.org Bug: v8:6847 Change-Id: I8839c9ec96dc4141cf3c30916a62ccf86f5463ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1960287 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Leszek Swirski authored
This reverts commit 5377e72c. Reason for revert: Looks like the relevant graphs didn't recover after this revert, which suggests that the regression was an unrelated secondary effect. Relanding the original change since the revert did cause some microbenchmark regressions. Original change's description: > Revert "[ic] Load name/context lazily in LdaNamedProperty" > > This reverts commit 347092ac. > > Not a clean revert, since other changes got baked on top, but rather > a manual removal of LoadLazyICParameters. > > Reason for revert: Seems to actually regress bindings perf tests (see > bugs and https://chromeperf.appspot.com/group_report?rev=62539), doesn't > seem to improve performance elsewhere, and increases complexity. > > Original change's description: > > [ic] Load name/context lazily in LdaNamedProperty > > > > Introduces LazyLoadICParameters which allow a LazyNode for context and > > name. These aren't used on the fast path, so we want to avoid reading > > them for both performance and register pressure reasons. > > > > Change-Id: Ifb637cf4782ce984feee9af503998e7539beb823 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1686665 > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#62539} > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: chromium:981797 > Bug: chromium:982630 > Change-Id: I88af764d17afb76d6e64b95a3d1e4aaa1c6c8978 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1934327 > Auto-Submit: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65205} TBR=leszeks@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:981797, chromium:982630, v8:10059 Change-Id: I13754de06c83439e03e22cfaa7a14ce454076db9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1973730Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#65499}
-
Shu-yu Guo authored
For supporting use of dictionaries during GC, such as in the JS WeakRef implementation. Bug: v8:8179 Change-Id: Ide3f5c45d2602f13a1bcb1968b36f08881067090 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1972427Reviewed-by:
-
Simon Zünd authored
When V8 throws an uncaught exception, we store a JSMessageObject with a stack trace and source positions on the isolate itself. The JSMessageObject can be retrieved by a TryCatch scope and is used by the inspector to provide additional information to the DevTools frontend (besides the exception). Introducing top-level await for REPL mode causes all thrown exceptions to be turned into a rejected promise. The implicit catch block that does this conversion clears the JSMessageObject from the isolate as to not leak memory. This CL preserves the JSMessageObject when the debugger is active and stores the JSMessageObject on the rejected promise itself. The inspector is changed to retrieve the JSMessageObject in the existing catch handler and pass the information along to the frontend. Drive-by: This CL removes a inspector test that made assumptions when a promise is cleaned up by the GC. These assumptions no longer hold since we hold on to the promise longer. Bug: chromium:1021921 Change-Id: Id0380e2cf3bd79aca05191bc4f3c616f6ced8db7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1967375 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Clemens Backes authored
This reverts commit cb2090cd. Reason for revert: Still fails with custom snapshot: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/29200 Original change's description: > [test] Enable compiler/deopt-array-builtins on gc_stress > > Bug: v8:10035 > Change-Id: I296e6b8a087e081d2f4d2fa15067e755e2ee3585 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1970212 > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Commit-Queue: Mythri Alle <mythria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65493} TBR=mythria@chromium.org,mslekova@chromium.org Change-Id: I4d7c1537136ed1d5c42f7a7c6c94db8987c9b9ec No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10035 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1973734Reviewed-by:
-
Dan Elphick authored
Allocate memory more quickly so the test completes faster. (On the ARM simulator tests with slow asserts and verify-heap, it was taking around 20 minutes). Change-Id: I6b4d0a4788817c4f996a073cc3fdf8b69d11bc40 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1973731Reviewed-by:
-
Shu-yu Guo authored
Nullify is already defined in an -inl.h, so there is no need for the extra functionality (and overhead) of std::function. Bug: v8:8179 Change-Id: I0b149a962409503a9fde150aa1241de74870533e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1972426Reviewed-by:
-
Mythri A authored
Bug: v8:10035 Change-Id: I296e6b8a087e081d2f4d2fa15067e755e2ee3585 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1970212Reviewed-by:
-
Nico Hartmann authored
This reverts commit 9f18e55f. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/29660 Original change's description: > [TurboFan] Don't serialize read-only heap objects > > Read-only heap objects are immutable and immovable. It is safe to access > these objects directly from the heap. Not having to serialize them > reduces the time we spend on main thread especially for TurboProp. > > Bug: v8:9684 > Change-Id: Ibabb7076af50c9007d2a8ed57fe257406958fb6a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955596 > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Commit-Queue: Mythri Alle <mythria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65490} TBR=mvstanton@chromium.org,neis@chromium.org,mythria@chromium.org,mslekova@chromium.org Change-Id: If2d8649cdc083f7d064684352501320a96a1ba2c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9684 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1973732Reviewed-by:
-
Sigurd Schneider authored
This CL adds an argument to the heap profiler that allows to control whether global objects (e.g. 'window' in JavaScript) are treated as roots in the heap snapshot. Doing so hides blink-internal details and is often a good choice when user-JS leaks are investigated. Sometimes, however, this introduces spurious retainer cycles, which are hard to debug. Previously, this option was exposed as a V8 flag. The blink implications of the build-time V8 flag are now available via the new blink flag `enable_additional_blink_object_names`. Tbr: hpayer@chromium.org Bug: chromium:1034504 Change-Id: Ibe9412917ae598a3ff0c3dc956ab0bc179f50a21 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1967387Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Mythri A authored
Read-only heap objects are immutable and immovable. It is safe to access these objects directly from the heap. Not having to serialize them reduces the time we spend on main thread especially for TurboProp. Bug: v8:9684 Change-Id: Ibabb7076af50c9007d2a8ed57fe257406958fb6a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955596Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
