Commits · 6cae9d1ce80094d1d0ae215a5977eed2bb452f7f · Linshizhi / V8

23 Apr, 2014 11 commits

Allow Object.defineProperty to update value of an API accessor. · 6cae9d1c

ulan@chromium.org authored Apr 23, 2014

This is needed for converting internal accessors to API accessors and can break blink tests.

BUG=
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/240573004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20910 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6cae9d1c

Fix ToObject and Object.isSealed in four Array builtins. · 66ec2998

mstarzinger@chromium.org authored Apr 23, 2014

R=mvstanton@chromium.org
TEST=mjsunit/regress/regress-builtinbust-6

Review URL: https://codereview.chromium.org/240223006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20909 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

66ec2998

Harden DefineOrRedefineDataProperty. · f3488658

ulan@chromium.org authored Apr 23, 2014

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/240973002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20908 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f3488658

Introduce .DEPS.git file to support full git checkouts · b881d871

jochen@chromium.org authored Apr 23, 2014

This is the result of running deps2git.py -d DEPS -o .DEPS.git -s -c /tmp

BUG=none
R=jkummerow@chromium.org, machenbach@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/246633009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20907 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b881d871

Extract common macros and start a base library · 88dc054f

jochen@chromium.org authored Apr 23, 2014

BUG=v8:3015
R=svenpanne@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/249183003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20905 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

88dc054f

Disable field type tracking by default. · 4b56570c

bmeurer@chromium.org authored Apr 23, 2014

BUG=365172
LOG=y
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/247913005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20902 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4b56570c

Fix tracking of computed fields when field type tracking is disabled. · a504406a

bmeurer@chromium.org authored Apr 23, 2014

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/247523004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20901 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a504406a

Avoid setting transitions in-place for cached maps when observed · 783eb25a

jarin@chromium.org authored Apr 23, 2014

R=verwaest@chromium.org
BUG=

Review URL: https://codereview.chromium.org/246523004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20900 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

783eb25a

Avoid exposing compiler-allocated temporaries to the debugger · e12ae547

wingo@igalia.com authored Apr 23, 2014

R=yangguo@chromium.org
BUG=

Review URL: https://codereview.chromium.org/245963006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20899 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e12ae547

Handle boxed length in JSON stringify. · 1f53decc

jarin@chromium.org authored Apr 23, 2014

Here is the test that used to fail in Smi::cast:

JSON.stringify(new Array(4000000000));

I am not adding the test because it takes huge amount of time before it
runs out of memory.

R=verwaest@chromium.org
BUG=

Review URL: https://codereview.chromium.org/247063003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20898 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1f53decc

Sort functions in polymorphic calls based on overall profiling ticks and inlined AST size. · 7e48108f

bmeurer@chromium.org authored Apr 23, 2014

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/248953002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20897 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7e48108f

22 Apr, 2014 23 commits

MIPS: Return Object* instead of MaybeObject* from runtime calls. · 0735f045

palfia@homejinni.com authored Apr 22, 2014

Port r20888 (d6883d72)

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/246893010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20894 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0735f045

Fix issue with Map/SetIterator and types · 71750f7b

adamk@chromium.org authored Apr 22, 2014

BUG=v8:3281
LOG=N
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/246993003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20893 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

71750f7b

MIPS: Improve code generation for bounds checks. · 69186565

plind44@gmail.com authored Apr 22, 2014

Port r20872 (0e79653)

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/246253007

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20892 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

69186565

ARM64: Move sign-extension to load instructions. · 13783324

Jacob.Bramley@arm.com authored Apr 22, 2014

The SXTW extend mode is usually free when used in a load or store
operand, but it can slightly increase the latency of an arithmetic
instruction. This patch optimises some address calculations accordingly:
  - PrepareKeyedExternalArrayOperand.
  - BuildSeqStringOperand.
  - DoStringCharFromCode.

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/247443002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20891 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13783324

Use MaybeHandles in Compiler to indicate failure instead of a null Handle. · 5600046f

mvstanton@chromium.org authored Apr 22, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/246603003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20890 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5600046f

Insert HSimulate immediately after Crankshaft-inlined push. · b4fa81db

danno@chromium.org authored Apr 22, 2014

R=jarin@chromium.org
LOG=N

Review URL: https://codereview.chromium.org/247383002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20889 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b4fa81db

Return Object* instead of MaybeObject* from runtime calls. · 41bfa036

yangguo@chromium.org authored Apr 22, 2014

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/240053010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20888 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

41bfa036

Cache maps for externalized typed array objects. · b0f91095

dslomov@chromium.org authored Apr 22, 2014

After this, the maps do not garbage-collect, and typed array
constructors do not deopt.

R=ulan@chromium.org
BUG=363855
LOG=N

Review URL: https://codereview.chromium.org/247343002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20887 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b0f91095

Context-allocate all parameters in generators · a2ac40ac

wingo@igalia.com authored Apr 22, 2014

Generator function scopes have forced context allocation.  Ensure that
all variables in such scopes get context allocation -- even unused
variables.

This fixes an assertion when reifying generator scopes in the debugger.

R=yangguo@chromium.org
LOG=Y
BUG=v8:3280

Review URL: https://codereview.chromium.org/246733003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20883 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a2ac40ac

Do not avoid flattening cons string when creating a string slice. · a68be762

yangguo@chromium.org authored Apr 22, 2014

R=ulan@chromium.org
BUG=364656
LOG=N

Review URL: https://codereview.chromium.org/247093002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20882 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a68be762

HBranch should also print its expected input types. · 9437b59a

bmeurer@chromium.org authored Apr 22, 2014

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/247153003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20881 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9437b59a

Optimize numeric comparison with known successors. · 376bff24

bmeurer@chromium.org authored Apr 22, 2014

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/246133005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20880 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

376bff24

Revert "Simplify v8/Isolate teardown." · eeb1d702

svenpanne@chromium.org authored Apr 22, 2014

This reverts commit r20876, it broke non-snapshot tests.

TBR=bmeurer@chromium.org

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20879 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

eeb1d702

Bumped the boot-up memory-limit, part 2. · 206dbe87

svenpanne@chromium.org authored Apr 22, 2014

Basically a follow-up to r20851

TBR=jarin@chromium.org

Review URL: https://codereview.chromium.org/247193003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20878 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

206dbe87

JSObject::DeepCopy and other functions returned an empty handle to · 5ef2c186

mvstanton@chromium.org authored Apr 22, 2014

indicate an exception. All usages but one changed to return
MaybeHandles, and to use macros around the call.

The remaining work is in Compiler::GetUnoptimizedCode(), and when
that is turned into a MaybeHandle, then the macros dealing with
null handle returns can be eliminated.

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/247013002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20877 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5ef2c186

Simplify v8/Isolate teardown. · 618ff3a3

svenpanne@chromium.org authored Apr 22, 2014

This implies that one better has a v8::V8::Initialize when v8::V8::Dispose is used.

BUG=359977
LOG=y
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/238353015

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20876 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

618ff3a3

Cons string maps must be marked as unstable. · 2a941b2e

bmeurer@chromium.org authored Apr 22, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/247063002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20875 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2a941b2e

Make sure to clear any previously collected field maps. · 7ab274d4

bmeurer@chromium.org authored Apr 22, 2014

TEST=http://www.chaostoperfection.com/
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/246963003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20874 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7ab274d4

Set code on the SharedFunctionInfo before creating the function. · c9db6148

verwaest@chromium.org authored Apr 22, 2014

BUG=
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/238773009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20873 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c9db6148

Improve code generation for bounds checks. · af051411

bmeurer@chromium.org authored Apr 22, 2014

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/246423005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20872 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

af051411

Introduce exception object and remove some uses of MaybeObject::IsFailure(). · 2c394ad0

yangguo@chromium.org authored Apr 22, 2014

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/240883003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20871 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2c394ad0

Fix field type handling in load elimination. · eccda7f0

bmeurer@chromium.org authored Apr 22, 2014

Drive-by-fix: map_set() must return a pointer to the UniqueSet
instead of a copy.

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/244383002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20870 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

eccda7f0

Fix interpreted-regexp test. · c44dc2fc

yangguo@chromium.org authored Apr 22, 2014

TBR=ishell@chromium.org

Review URL: https://codereview.chromium.org/246953002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20869 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c44dc2fc

19 Apr, 2014 1 commit

Switch CPU profile start/stop markers to monotonic time. · b97a2a25

alph@chromium.org authored Apr 19, 2014

LOG=N
BUG=363976
R=bmeurer@chromium.org, yurys@chromium.org

Review URL: https://codereview.chromium.org/243033002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20866 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b97a2a25

17 Apr, 2014 5 commits

Return int64_t instead of intptr_t for RootRegisterDelta and support x32 as well. · 3416e7bc

haitao.feng@intel.com authored Apr 17, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/236753002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20863 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3416e7bc

Update CheckBothSmi, CheckInteger32ValidSmiValue,... · 6e405733

haitao.feng@intel.com authored Apr 17, 2014

Update CheckBothSmi, CheckInteger32ValidSmiValue, CheckUInteger32ValidSmiValue, SmiAddConstant, SmiNot, AddSmiField and Test to support x32 port.

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/236723004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20862 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6e405733

MIPS: Serializer enable/disable flags need thread safety. · c8c95120

palfia@homejinni.com authored Apr 17, 2014

Port r20855 (ac70e129)

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/239173004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20859 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c8c95120

Fix breakage on V8 Linux - nosse2 · 15721154

adamk@chromium.org authored Apr 17, 2014

This was introduced by https://code.google.com/p/v8/source/detail?r=20857

R=adamk@chromium.org
TBR=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/241433002

Patch from Erik Arvidsson <arv@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20858 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15721154

ES6: Add support for Map/Set forEach · 3308cb58

adamk@chromium.org authored Apr 17, 2014

This implements MapIterator and SetIterator which matches
the same constructs in the ES6 spec. However, these 2
iterators are not exposed to user code yet. They are only
used internally to implement Map.prototype.forEach and
Set.prototype.forEach.

Each iterator has a reference to the OrderedHashTable where
it directly accesses the hash table's entries.

The OrderedHashTable has a reference to the newest iterator
and each iterator has a reference to the next and previous
iterator, effectively creating a double linked list.

When the OrderedHashTable is mutated (or replaced) all the
iterators are updated.

When the iterator iterates passed the end of the data table
it closes itself. Closed iterators no longer have a
reference to the OrderedHashTable and they are removed from
the double linked list. In the case of Map/Set forEach, we
manually call Close on the iterator in case an exception was
thrown so that the iterator never reached the end.

At this point the OrderedHashTable keeps all the non finished
iterators alive but since the only thing we currently expose
is forEach there are no unfinished iterators outside a forEach
call. Once we expose the iterators to user code we will need
to make the references from the OrderedHashTable to the
iterators weak and have some mechanism to close an iterator
when it is garbage collected.

BUG=1793, 2323
LOG=Y
R=adamk@chromium.org
TBR=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/238063009

Patch from Erik Arvidsson <arv@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20857 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3308cb58