- 29 Nov, 2019 14 commits
-
-
Michael Starzinger authored
This fixes the accessor functions (getters and setters) for WebAssembly accessor properties to not have 'prototype' properties and not be marked as constructors. R=ahaas@chromium.org TEST=mjsunit/wasm/js-api BUG=chromium:1027945 Change-Id: I0288f511fee1f99997031b41354ecf7b8629b783 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943157 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#65265}
-
Liviu Rau authored
No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ib485ec835d73f9da0c5379c80865ad6702293e6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943148 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#65264}
-
Jakob Kummerow authored
Reported at comment #18 of the linked bug. Bug: chromium:1027461 Change-Id: I64fb4c4edd4df07ddf86c508dfecec7f509efc9f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940262Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#65263}
-
Jakob Kummerow authored
Replacing a constant BigInt with a constant int64 is only valid when the use site has truncating semantics. (For non-constant values, the representation changer did correctly check for this.) Bug: chromium:1028593 Change-Id: Ib58b16ece6f21ba30153fd6cfa0560cc2d78d6a2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940263Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#65262}
-
Mythri A authored
This cl: https://chromium-review.googlesource.com/c/v8/v8/+/1924439 has renamed the optimize passed happening on the backgroudn to OptimizeBackground instead of OptimizeConcurrent or RecompileConcurrent. Concurrent optimization has main thread phases so using OptimizeConcurrent for background computations only was a bit confusing. Bug: chromium:1029456 Change-Id: Idd0a0ff82597bb18c2d8896c7288f268e59acc05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943156 Commit-Queue: Mythri Alle <mythria@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Auto-Submit: Mythri Alle <mythria@chromium.org> Reviewed-by: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#65261}
-
Georg Neis authored
If the inputs are Unsigned32OrMinusZeroOrNaN and we want to compile for an Unsigned32 result, we still need to deopt if the RHS is zero (because that must produce NaN). Bug: chromium:1028862 Change-Id: Ib5b7cd10f8c4ec9a76b75a2b408729f1ca86ea3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943150Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#65260}
-
Toon Verwaest authored
This reverts commit 5253d7bf. Reason for revert: Elements don't properly invalidate the cache. Original change's description: > [runtime] Cache prototype chain enumerable keys in PrototypeInfo > > This CL adds a prototype_chain_enum_cache to cache the enumeration of a > prototype and its entire chain on the PrototypeInfo. It can improve for-in > performance via simply merging the receiver enumeration with this cache. > > It improves the score of JetStream2-tagcloud-SP case by ~9% on IA Chromebook. > > Contributed by tao.pan@intel.com > > Change-Id: Ib40bfe41e772672337155584672f06fa1ba1e70d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1870844 > Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65224} TBR=verwaest@chromium.org,shiyu.zhang@intel.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ic5d476bc8b334241b2accb8344749fcf7dcf5e09 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943153Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#65259}
-
Sigurd Schneider authored
This is a reland of 4ed9d48f CompileRun leads to undefined behavior if the compile fails; CompileRunChecked can be used to assert that the compile must succeed. I've removed the attempt to compile and rely on a simpler check in the tests now. Original change's description: > [exceptions] Don't re-request interrupt in InvokeWithTryCatch > > This CL changes InvokeWithTryCatch to not re-request the terminate > execution interrupt, but instead schedule the termination exception. > This ensures that leaving the outermost TryCatch scope will clear > the exception, and no interrupt remains. > > Previously, the interrupt request could remain and prevent further > JavaScript execution even after the TryCatch scope was left. > > Change-Id: I1e603dc822bbcb0def4cf0a898d59cf8d4b9d039 > Bug: chromium:1014415 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871910 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65255} Tbr: yangguo@chromium.org, verwaest@chromium.org Bug: chromium:1014415 Change-Id: I29444c4b7ea5a158865f54d4608f374914f7b133 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943151Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#65258}
-
Michael Achenbach authored
R=neis@chromium.org No-Try: true Change-Id: I91ebaceb036381f8183b0703ccfed58e1cbbeeb3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943152Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#65257}
-
Leszek Swirski authored
This reverts commit 4ed9d48f. Reason for revert: UBSan failure https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20UBSan/9084 Original change's description: > [exceptions] Don't re-request interrupt in InvokeWithTryCatch > > This CL changes InvokeWithTryCatch to not re-request the terminate > execution interrupt, but instead schedule the termination exception. > This ensures that leaving the outermost TryCatch scope will clear > the exception, and no interrupt remains. > > Previously, the interrupt request could remain and prevent further > JavaScript execution even after the TryCatch scope was left. > > Change-Id: I1e603dc822bbcb0def4cf0a898d59cf8d4b9d039 > Bug: chromium:1014415 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871910 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65255} TBR=yangguo@chromium.org,sigurds@chromium.org,verwaest@chromium.org Change-Id: Iedefe5320d8bdc442a87e03698a20daf6a0ebf4f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1014415 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943149Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#65256}
-
Sigurd Schneider authored
This CL changes InvokeWithTryCatch to not re-request the terminate execution interrupt, but instead schedule the termination exception. This ensures that leaving the outermost TryCatch scope will clear the exception, and no interrupt remains. Previously, the interrupt request could remain and prevent further JavaScript execution even after the TryCatch scope was left. Change-Id: I1e603dc822bbcb0def4cf0a898d59cf8d4b9d039 Bug: chromium:1014415 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871910 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#65255}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/eeb227e..2fc048c Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/fa0def7..b97d4ce Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/f31cb80..7c62ed6 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I0fb2bb08bc55ecc83695a5f7aa5bcb7676fb550b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1942916Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#65254}
-
jiepan authored
The lane indices of S8x16Shuffle will be printed as null-terminated character array in Operator1's PrintParameter implementation.This patch add S8x16ShuffleParameter class, override operater<<, print indices as integer array. before fix: Shuffle[\b\t\n^K\f\r^N^O] after fix: Shuffle[8,9,10,11,12,13,14,15,0,0,0,0,0,0,0,0] Change-Id: I421e639f5229d3a5e348868be33f2d8bbfcfd2d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1922735 Commit-Queue: Jie Pan <jie.pan@intel.com> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Auto-Submit: Jie Pan <jie.pan@intel.com> Cr-Commit-Position: refs/heads/master@{#65253}
-
Shu-yu Guo authored
Correctly passing the receiver depends on the Call AST node's type. Calling a parenthesized optional chain expression is parsed as a Call of an OptionalChain of a Property. Currently the computation of the type does not take optional chains of property loads into consideration, so calls of parenthesized optional chain expressions always get passed an undefined receiver. Bug: v8:10024 Change-Id: I904b0eeca2df30160def674fb32adf821403aef9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1938571Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#65252}
-
- 28 Nov, 2019 26 commits
-
-
Dan Elphick authored
If source positions are not required when a background compilation task starts, but then something like profiling is started before the task finalizes, then logging of the compilation task will crash due to a missing source position table. This ensures source positions are collected if source positions are required during finalization. R=rmcilroy@chromium.org Bug: chromium:1022749 Change-Id: Ie83c3d88131a1c1f434274ea9ee52895c6753b49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1942611 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#65251}
-
Santiago Aboy Solanes authored
git cl upload failed since I needed to do a git cl format. Missed that and uploaded https://chromium-review.googlesource.com/c/v8/v8/+/1940153 without the rename. Bug: v8:7703 Change-Id: I26090433af86968357eaeecf3e906a9e824647a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940260 Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#65250}
-
Hannes Payer authored
Change-Id: I5d98dac3cde530f2bac5ef1239bc0e8805a01f99 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1942609 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#65249}
-
Santiago Aboy Solanes authored
Due to the ordering of the nodes to be changed, we might change the ChangeTaggedToCompressed's input before the ChangeTaggedToCompressed node itself changes. Then, we need to check for this possibility too. Bug: v8:7703 Change-Id: I2b453211dc264b509f2ea7c0cf891be50f404009 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1942607 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#65248}
-
Anna Henningsen authored
Ensure that all fields of `SyntheticModule` are set before creating the exports hash table for it, because the latter may trigger garbage collection, leading to crashes. This has been causing failures in the Node.js CI over the last weeks, after making the creating of synthetic modules part of Node’s startup sequence. (I am generally not very familiar with this part of the V8 code and there might be a better way, or possibly a way to add a reliable regression test, that I am not aware of.) Refs: https://github.com/nodejs/node/issues/30498 Refs: https://github.com/nodejs/node/issues/30648 Change-Id: I32da4b7bd888c6ec1421f34f5bd52e7bad154c1e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1939752 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#65247}
-
Jakob Gruber authored
Ports are getting easier now. This one was fairly straightforward. Bug: v8:9972 Change-Id: I69c0566060523e505e30980cb1d3d9633da976b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940257 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#65246}
-
Andreas Haas authored
The bulk-memory tests changed with recent proposal changes: OOB accesses of size 0 cause traps now. R=thibaudm@chromium.org CC=emcziegler@chromium.org Change-Id: Id3f74373839434a61d3bf346a12146aa77894a8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940159Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#65245}
-
Jakob Gruber authored
These node/edge kinds don't fit into the heap object type system; add wrapper classes for them instead. The wrapper class must be explicitly created, but is implicitly convertible to Node*. Bug: v8:9972 Change-Id: Ic6c253a95bb5705fb946ee3f35508ea70c9f0070 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940255 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#65244}
-
Jakob Gruber authored
... for convenient TNode access (e.g.: PhiAt, LoadField, LoadElement). Bug: v8:9972 Change-Id: Ie6f5f204079cf7c84279d1cb015055816f301916 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940254 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#65243}
-
Clemens Backes authored
Fix a TODO from Ben to change the macro argument order to match the actual order in wasm code. After this fix, we can remove the individual {WASM_CALL_INDIRECT[0-5]} macros and implement them via a common variadic macro. Also, rename {WASM_CALL_INDIRECT_TABLE0} to {WASM_CALL_INDIRECT_TABLE}. The name was confusing, because this macro explictly allows to set a table index different from 0. Thus, just drop the "0" in the name. The individual test changes were done via a vim macro, to avoid manual errors. R=mstarzinger@chromium.org Bug: v8:10021 Change-Id: I9f0f31511c5c6e20a0b07524bf75fe9cf1598eba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940265Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65242}
-
Jakob Gruber authored
This is an initial (and partial) step towards full typing in graph assembler. It removes all uses of SloppyTNode, starts to introduce types in the GraphAssembler base class, and makes lambda function types (for if- and for-builders) more specific. Plenty of TODOs remain; e.g. checked casts and complete typing of GraphAssembler are left to follow-up work. Bug: v8:9972 Change-Id: I780adf83b53ad76beda4726960d95ab6df13e2ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940476 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#65241}
-
Georg Neis authored
A call to this intrinsic will produce true in the interpreter and false in optimized code. This is useful for writing tests. Change-Id: I64d06ed062027e723eca82d6f879202244f21fdf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1939750 Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#65240}
-
Milad Farazmand authored
CodeStubAssembler::ComputeSeededHash is passing key as Int32 to ComputeSeededIntegerHash, but ComputeSeededIntegerHash only accepts Uint32 value. This could cause problems on s390 and ppc because GCC expects any value less than 8 bytes sign/zero-extending to 64-bits by the caller, therefore, the static cast from uint32->uint64 will be treated as no-op (expecting zero-ext instead), which leads to unexpected behaviors. Change-Id: Icd1eecaea1415e36c0c13eef513ff69cc418f247 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940209Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#65239}
-
Michael Starzinger authored
The last use of the predicate in question was to switch builtins that implement WebAssembly runtime stubs to use hard aborts instead of normal aborts like other builtins. This is no longer needed since the builtins in question are embedded and no longer copied into WebAssembly modules. This also allows to move the {WASM_RUNTIME_STUB_LIST} macro out of the builtins-defintions.h file and into the wasm-code-manager.h file. R=clemensb@chromium.org BUG=v8:10021 Change-Id: Ib42d3731fc92df378cfce39d39e7fbdbbf722937 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940266 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65238}
-
Clemens Backes authored
They have been deprecated in v7.9, hence they can be removed in v8.0. R=ulan@chromium.org CC=mstarzinger@chromium.org Bug: v8:10021 Change-Id: Ic21c5ee5703b548ddcca2ffeba6c583715d3fbd3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864947 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#65237}
-
Michael Starzinger authored
This makes sure that proper checked casts (i.e. {CAST} instead of the unsafe {UncheckedCast} before) are used for all WebAssembly runtime stubs. This is possible because the corresponding builtins are embedded and hence can use proper assertion mechanisms. R=clemensb@chromium.org BUG=v8:10021 Change-Id: I344ae8ba7dd4c5d3f5dc2467f7d58b93517d9af7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940264 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65236}
-
Milad Farazmand authored
Port a0b1a9cd Original Commit Message: This adds a few tests that test that the output of Liftoff is deterministic. These tests will be extended to test the debug side table in follow-up CLs. R=clemensb@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I3e3391afa73f93298d6aff47aecb8ae1e2299bd3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940208Reviewed-by: Junliang Yan <jyan@ca.ibm.com> Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#65235}
-
Clemens Backes authored
Use {std::unique_ptr} instead of raw {malloc}ed memory. This increases readability and memory safety significantly. The only downside is that we cannot use {realloc} any more (there is no C++ replacement for that), but that should not be noticeable. Drive-by: Make fields private. R=mstarzinger@chromium.org Bug: v8:10021 Change-Id: Ie99d61fe136fc18a07aa45f38a5a9b6542308504 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940261Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65234}
-
Jakob Gruber authored
Very similar to the recent ArrayPrototypeForEach port, this moves the Reduce reduction, which previously operated directly on the graph, to graph assembler. Nothing too interesting here, but it's becoming clearer that we will need more flexible Branch (multiple merge values) and If (a `break` mechanism) handling in the future. Bug: v8:9972 Change-Id: Ic48c85305ba721a9a43c67f7ad13c60da310487e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1934329 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#65233}
-
Peter Marshall authored
Reverting https://chromium-review.googlesource.com/c/v8/v8/+/1741660 This fixed one bug but caused a lot of others and on balance I think reverting it is the lesser evil. This also fixed generator-relocation.js because (function*(){}).constructor is the function constructor and we try to set a breakpoint on line 3. Bug: chromium:109362, chromium:1028689 Fixes: v8:9721 Change-Id: I1bfe6ec57ce77ea7292df91266311f5c0194947e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940259 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#65232}
-
Dan Elphick authored
If V8_SHARED_RO_HEAP is set, then GetSharedMemoryStatistics now reports the size of RO_SPACE. Additionally size values for RO_SPACE are zeroed in the per-isolate Heap and Space stats. Bug: v8:7464 Change-Id: I2d6843c001b55974460d1df034f08d1ed5b0d8da Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1900459 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#65231}
-
Georg Neis authored
https://chromium-review.googlesource.com/c/v8/v8/+/1937147 removed the DCHECK in ProcessNamedPropertyAccess but forgot to remove the one in ProcessKeyedPropertAccess too. Tbr: mvstanton@chromium.org Bug: v8:7790, chromium:1029198 Change-Id: Ia313c92969fe7d5e559e34995b39834267e6b3fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940258Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#65230}
-
Michael Starzinger authored
R=tebbi@chromium.org BUG=v8:10021 Change-Id: I39052fa22ea90b392a36e7841f8586c19c8ca9cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940156 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#65229}
-
Clemens Backes authored
We implement exponential growing of the native allocations by always growing at least by the old size. This speeds up use cases that grow a table incrementally (e.g. by 1). R=mstarzinger@chromium.org CC=ecmziegler@chromium.org Bug: v8:10018 Change-Id: I580ecf1ac87f793ff4a34ba45a86ae599eb3e6f7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1939452Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65228}
-
Santiago Aboy Solanes authored
Even though they don't generate any code, it breaks some pattern matching when these nodes are present (e.g comparisons with compressed heap objects). Bug: v8:7703 Change-Id: I9670c2b4e85b1635061b16d4b125de9ff51fd403 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940153Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#65227}
-
David Carlier authored
Those fields are incorrect in FreeBSD. Upstreaming local FreeBSD patches. Change-Id: I28cf6dbec1d5e4d26e62dd9a0d78d039c3e36cdb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906374Reviewed-by: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#65226}
-