- 02 Oct, 2018 13 commits
-
-
Peter Marshall authored
We can call FeedbackTypeOf before the switch statement to avoid generating callsites for every operation. This CL saves 4 KiB binary size. Bug: v8:8238 Change-Id: I0f9d7a155e0cec219306ca1fb35f1eb9ff18a36f Reviewed-on: https://chromium-review.googlesource.com/1254207 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#56340}
-
Ulan Degenbaev authored
Bug: chromium:876759 Change-Id: I9ea3c84b477e03f96cbef79a4a0b546a53a674ce Reviewed-on: https://chromium-review.googlesource.com/1256771Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#56339}
-
Sigurd Schneider authored
Change-Id: I8fd0ce9ac2dc37e2daa0728b5d4c119a2bd1f340 Bug: v8:6666 Reviewed-on: https://chromium-review.googlesource.com/1256865 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#56338}
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org Bug: v8:8239 Change-Id: I2451230f92fa6ad66ce6446f97efaa7fafd04e12 Reviewed-on: https://chromium-review.googlesource.com/1251524 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#56337}
-
Peter Marshall authored
Don't re-log all existing functions during StartProcessorIfNotStarted(). They will already be in the CodeMap attached to the ProfileGenerator and re-logging them causes leaks. See the linked bug for more details. Bug: v8:8253 Change-Id: Ibb1a1ab2431c588e8c3a3a9ff714767cdf61a88e Reviewed-on: https://chromium-review.googlesource.com/1256763 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This reverts commit 574daf03. Reason for revert: Seems to break native arm: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Android%20Arm64%20-%20N5X/1051 https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Arm%20GC%20Stress/8462 Original change's description: > [disassembler] Better support for root-relative values > > In particular, recognize builtins' values accesses and direct accesses > to external reference values. For example: > > REX.W leaq rax,[r13+0x47a0] > REX.W leaq rbx,[r13+0x80b0] > > turns into > > REX.W leaq rax,[r13+0x47a0] (builtin (RecordWrite)) > REX.W leaq rbx,[r13+0x80b0] (external value (Isolate::context_address)) > > This CL also extends the via-root-register-accessible region to the > whole Isolate object. > > Bug: v8:8238 > Change-Id: I218d8589690579919cfa01b2f3c3094af0e73c51 > Reviewed-on: https://chromium-review.googlesource.com/1251550 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56332} TBR=mstarzinger@chromium.org,ishell@chromium.org Change-Id: I28ad24c923f04fffbc2fd5a5d2248740302fae02 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8238 Reviewed-on: https://chromium-review.googlesource.com/1256772Reviewed-by:
-
Michael Achenbach authored
NOTRY=true TBR=sergiyb@chromium.org Bug: chromium:890231 Change-Id: Id5934d864f5e90bb3ec918567afe7542a2cf28c6 Reviewed-on: https://chromium-review.googlesource.com/1256770Reviewed-by:
-
Marja Hölttä authored
BUG=v8:5402,v8:8238 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I6cdc27cc8e687e32e08dfbd4f16b014f60ec2747 Reviewed-on: https://chromium-review.googlesource.com/1256243Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#56333}
-
Igor Sheludko authored
In particular, recognize builtins' values accesses and direct accesses to external reference values. For example: REX.W leaq rax,[r13+0x47a0] REX.W leaq rbx,[r13+0x80b0] turns into REX.W leaq rax,[r13+0x47a0] (builtin (RecordWrite)) REX.W leaq rbx,[r13+0x80b0] (external value (Isolate::context_address)) This CL also extends the via-root-register-accessible region to the whole Isolate object. Bug: v8:8238 Change-Id: I218d8589690579919cfa01b2f3c3094af0e73c51 Reviewed-on: https://chromium-review.googlesource.com/1251550 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Ivica Bogosavljevic authored
MIPS architecture doesn't have support for 64-bit atomics. It is possible to implement them using 32-bit atomics, but the process is involved and takes time. For the time being support 64-bit atomics using runtime. Bug: v8:8100 Change-Id: I8c732ea9975c46be70643a1e722d78938c8a70de Reviewed-on: https://chromium-review.googlesource.com/1251521 Commit-Queue: Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#56331}
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTRY=true Bug: chromium:890222 Change-Id: I5a48dca2a4c1dec61d21d068eee4b49d138a5c4b Reviewed-on: https://chromium-review.googlesource.com/1256244Reviewed-by:
-
Hai Dang authored
This improves the performance on primitive strings of IterableToListWithSymbolLookup, which implements the CreateArrayFromIterable bytecode. The fast path is only taken if the string iterator protector is valid (that is, String.prototype[Symbol.iterator] and String.prototype[Symbol.iterator]().next are untouched). This brings spreading of primitive strings closer to the performance of the string iterator optimizations. (see https://docs.google.com/document/d/13z1fvRVpe_oEroplXEEX0a3WK94fhXorHjcOMsDmR-8/). Bug: chromium:881273, v8:7980 Change-Id: Ic8d8619da2f2afcc9346203613a844f62653fd7a Reviewed-on: https://chromium-review.googlesource.com/1243110 Commit-Queue: Hai Dang <dhai@google.com> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#56329}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/79a709e..64ce4b0 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/98289bc..2ba11d1 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/ff74025..6e1868c TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I54af669d392f12b7f57076381869a8655b400b8f Reviewed-on: https://chromium-review.googlesource.com/1255560 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#56328}
-
- 01 Oct, 2018 22 commits
-
-
andrew-cc-chen authored
R=jyan@ca.ibm.com Change-Id: Ib60ccc5f78af73afe3212c480aa2bd82f38d2678 Reviewed-on: https://chromium-review.googlesource.com/1255543Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#56327}
-
Aseem Garg authored
For wasm modules with non-absolute sourceMappingURL, the source needs to be empty so that devtools can look for the source map at the origin of the module. R=clemensh@chromium.org,adamk@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I74c40addc1a7cb1be0442e9f2b272590c0b81f60 Reviewed-on: https://chromium-review.googlesource.com/1250402 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#56326}
-
Benedikt Meurer authored
Following up on the earlier work regarding redundant Smi checks in https://chromium-review.googlesource.com/c/v8/v8/+/1246181, it was noticed that the handling of the 0 and -0 and how some operations identify these is not really consistent, but was still rather ad-hoc. This change tries to unify the handling a bit by making sure that all number comparisons generally pass truncations that identify zeros, since for the number comparisons in JavaScript there's no difference between 0 and -0. In the same spirit NumberAbs and NumberToBoolean should also pass these truncations, since they also don't care about the differences between 0 and -0. Adjust NumberCeil, NumberFloor, NumberTrunc, NumberMin and NumberMax to pass along any incoming kIdentifiesZeros truncation, since these operations also don't really care whether the inputs can be -0 if the use nodes don't care. Also utilize the kIdentifiesZeros truncation for NumberModulus with Signed32 inputs, because it's kind of common to do something like `x % 2 === 0`, where it doesn't really matter whether `x % 2` would eventually produce a negative zero (since that would still be considered true for the sake of the comparison). This also adds a whole lot of tests to ensure that not only are these optimizations correct, but also that we do indeed perform them. Drive-by-fix: The `NumberAbs(x)` would incorrectly lower to just `x` for PositiveIntegerOrMinusZeroOrNaN inputs, which was obviously wrong in case of -0. This was fixed as well, and an appropriate test was added. The reason for the unification is that with the introduction of Word64 for CheckBounds (which is necessary to support large TypedArrays and DataViews) we can no longer safely pass Word32 truncations for the interesting cases, since the index might be outside the Signed32 or Unsigned32 ranges, but we still identify 0 and -0 for the sake of the bounds check, and so it's important that this is handled consistently to not regress performance on TypedArrays and DataViews accesses. Bug: v8:8015, v8:8178 Change-Id: Ia1d32f1b726754cea1e5793105d9423d84a6393a Reviewed-on: https://chromium-review.googlesource.com/1246172Reviewed-by:
-
Alexei Filippov authored
TracingCpuProfiler wrapper uses API interrupt to start the profiling on the Isolate thread. However it could do it before Isolate is initialized, so the interrupt it requested got lost. The patch moves TracingCpuProfiler creation after ThreadLocal object for isolate is initialized. BUG=v8:8247 Change-Id: I5b0b3d18e017396f9860faeab909abbfab4616df Reviewed-on: https://chromium-review.googlesource.com/1252762Reviewed-by:
-
Mathias Bynens authored
It was shipped in Chrome 66. Bug: v8:6530, v8:8238 Change-Id: I07e95073ffcf388659b9d0b16a081e0f5a5eedaf Reviewed-on: https://chromium-review.googlesource.com/1253603Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#56323}
-
Torne (Richard Coles) authored
The current Android NDK defines __BIONIC_HAVE_UCONTEXT_T for all architecures, so the old paths are no longer needed. Bug: chromium:437330 Change-Id: I6314971e9ee1d78c4b73f8c1b37af7aa6f419b71 Reviewed-on: https://chromium-review.googlesource.com/1252282Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#56322}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I1fd7f103968dc0964f44777c6610ed758eb363bf Reviewed-on: https://chromium-review.googlesource.com/1254129Reviewed-by:
-
Georg Neis authored
Picking a few low-hanging fruits. Bug: v8:7790 Change-Id: I798d579b1f1a08fab821e159d08f453d2dad89c1 Reviewed-on: https://chromium-review.googlesource.com/1254124Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This removes duplication in the platform-dependent assemblers by introducing {AssemblerBase::ShouldRecordRelocInfo}. On arm64, we also remove a bool and replace it by an early exit. R=mstarzinger@chromium.org Bug: v8:8238 Change-Id: I08c623a19167a358c3188dc9008f045120da82b1 Reviewed-on: https://chromium-review.googlesource.com/1251085Reviewed-by: -
Michael Starzinger authored
R=titzer@chromium.org Change-Id: Id2766ee8d69ebd1a747374f1be71788c77a41d70 Reviewed-on: https://chromium-review.googlesource.com/1254128Reviewed-by:
-
Peter Marshall authored
This change saves 55 KiB binary size. Bug: v8:8238 Change-Id: I01ba8ea7de2884f178577ba007496b35d8578acc Reviewed-on: https://chromium-review.googlesource.com/1254122Reviewed-by:
-
Peter Marshall authored
This reduces the usage of macros and shrinks the binary size (by 4 KiB). Bug: v8:8238 Change-Id: Ic689f8ce7dabe481125fcdb74a265155431317b6 Reviewed-on: https://chromium-review.googlesource.com/1253605Reviewed-by:
-
Hai Dang authored
The protector is useful for follow-up optimizations on string iterator. Tests are also added. Change-Id: I416037c742628c4d4d3b878d0df727a9ae7162f7 Reviewed-on: https://chromium-review.googlesource.com/1251122Reviewed-by:
-
Florian Sattler authored
Delay the creation of FunctionNameVariables until we validated the FormalParameters. This is needed so we don't declare them in cases where we later get an error, have to reset, and reparse. Bug: chromium:890553, v8:7926 Change-Id: I742e6f7f71158e3903843bd583dc7943468c18f6 Reviewed-on: https://chromium-review.googlesource.com/1254061Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#56314}
-
Michael Starzinger authored
R=titzer@chromium.org Change-Id: I543f7d65d04b54951be126ca1e30bb7e81f026a8 Reviewed-on: https://chromium-review.googlesource.com/1253606Reviewed-by:
-
Tobias Tebbi authored
This removes the burden from Torque not to emit unnecessary phis. This is factored out from the Torque IR CL (https://crrev.com/c/1245766). Change-Id: I302714250e9ea6367f37613c09caa522d56c151c Reviewed-on: https://chromium-review.googlesource.com/1254121Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#56312}
-
Michael Lippautz authored
Instead of writing the forwarding pointer of this object and treating it like an object that would survive on scavenge just write the actual string pointer to the outer slot. As a consequence, the ThingString will not look like a live object and is handled properly when pruning the external string table. Bug: v8:8249 Test: test/cctest/heap/test-external-string-tracker.cc Change-Id: I975900213e2e4b598f298c8f78b6c6047c9e6da4 Reviewed-on: https://chromium-review.googlesource.com/1252885Reviewed-by:
-
Mathias Bynens authored
It was shipped in Chrome 67. Bug: v8:6791, v8:8238 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;luci.v8.try:v8_linux_noi18n_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I94d8f0aa18570452403a35dea270b18f155c970a Reviewed-on: https://chromium-review.googlesource.com/1253604Reviewed-by:
-
Maya Lekova authored
This change adds an infrastructure to "snapshot" data that is being serialized only once. This data lives in its own per-isolate zone, wrapped in a new CompilerData class. This change reduces the "serialize standard objects" on TypeScript benchmark from ~69ms to ~30ms (more than 50% improvement). Bug: v8:7790 Change-Id: I6ce4f6fb993334969662fdd993d681945a9f3727 Reviewed-on: https://chromium-review.googlesource.com/1238920 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Georg Neis authored
Once the broker retired, only allow retrieval of a reference's handle. That's all we need for now. Bug: v8:7790 Change-Id: Ib75887ed4a68e19ad7fad4c6046e340502542850 Reviewed-on: https://chromium-review.googlesource.com/1251086Reviewed-by:
-
Jaroslav Sevcik authored
Currently, we call the MapRef::AsElementsKind method on an initial map multiple times (from JSCreateLowering::ReduceJSCreateArray). However, this does not does not play well with the heap copier/broker, which only expectes AsElementsKind to be called on initial maps. This CL makes sure we only call AsElementsKind once (on the initial map). Bug: chromium:890620 Change-Id: If44421d3900abb7629ea8f789a005b8d8ebaf881 Reviewed-on: https://chromium-review.googlesource.com/1253105Reviewed-by:
-
Toon Verwaest authored
Shortcuts allow identifiable primary expressions to bypass all productions starting from assignment expression. We can identify them by looking at the token after the single token of which the primary expression consists. This CL adds support for 'identifier' followed by '=' as a primary LHS. Change-Id: I2f1939a39e03384598359a3a39e1d6cef9967e21 Reviewed-on: https://chromium-review.googlesource.com/1252805Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#56306}
-
- 30 Sep, 2018 4 commits
-
-
Michael Achenbach authored
This reverts commit c285380c. Reason for revert: Lots of dcheck failures on GPU bots, e.g.: https://ci.chromium.org/p/v8/builders/luci.v8.ci/Win%20V8%20FYI%20Release%20(NVIDIA)/1997 https://ci.chromium.org/p/v8/builders/luci.v8.ci/Linux%20V8%20FYI%20Release%20(NVIDIA)/2770 Original change's description: > Create a fast path to get migration target when updating map > > During map updating, store the pointer to new map in the > raw_transitions slot of the old map that is deprecated from map > transition tree. Thus, we can get the migration target directly > instead of TryReplayPropertyTransitions when updating map. > > This can improve Speedometer2.0 Elm-TodoMVC case by ~5% on ATOM > Chromebook and ~9% on big-core Ubuntu. > > Change-Id: I56f9ce5183bbdd567b964890f623ef0ceed9b7db > Reviewed-on: https://chromium-review.googlesource.com/1233433 > Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56303} TBR=ishell@chromium.org,shiyu.zhang@intel.com Change-Id: I9b268d662cfa3a7fec577468eafe6570389252bc No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1253104Reviewed-by:
-
Benedikt Meurer authored
The representation changer was lacking support for directly converting Word64 values to Bit representation. Bug: chromium:890243, v8:4153, v8:7881, v8:8171, v8:8178 Change-Id: I5fa31716c7b2b10ad00dc31d5035a1ada152661c Reviewed-on: https://chromium-review.googlesource.com/1251551Reviewed-by:
-
Shiyu Zhang authored
During map updating, store the pointer to new map in the raw_transitions slot of the old map that is deprecated from map transition tree. Thus, we can get the migration target directly instead of TryReplayPropertyTransitions when updating map. This can improve Speedometer2.0 Elm-TodoMVC case by ~5% on ATOM Chromebook and ~9% on big-core Ubuntu. Change-Id: I56f9ce5183bbdd567b964890f623ef0ceed9b7db Reviewed-on: https://chromium-review.googlesource.com/1233433 Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#56303}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e76ff65..79a709e Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/d525ef3..98289bc Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/003e878..7792d28 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I831486cac2077b74f5a4cd89243908dce2cceee4 Reviewed-on: https://chromium-review.googlesource.com/1253186Reviewed-by:
-
- 29 Sep, 2018 1 commit
-
-
Benedikt Meurer authored
Change the way that the (internal) await closures store the link to the generator object by introducing a dedicated AwaitContext, which stores the generator object into the extension slot (instead of misusing a regular FunctionContext here). Also unify the allocation+initialization of these contexts in the await-related builtins (both for async functions and generators). The rationale behind this is that for (zero-cost) async stack traces, we will need to dig into these contexts and we can do better checking with a dedicated instance type there. As an additional benefit, we save one word per await context, since we just use (the otherwise unused) extension slot to remember the generator object. As yet another benefit we will never accidentally use any of these contexts in the regular scope chain lookups, meaning we can also catch bugs there. And last but not least the objects printing machinery understands these contexts now and can even print the generator object for AwaitContexts for short printing, which is really valuable for debugging. Tbr: ulan@chromium.org Bug: v8:7253, v8:7522, v8:8015 Change-Id: I86955f5701e694e8a10b91ebe5f52705aa90968d Reviewed-on: https://chromium-review.googlesource.com/1249491Reviewed-by:
-
