1. 26 May, 2021 5 commits
    • Jakob Gruber's avatar
      Reland "[compiler] Make NativeContextRef never-serialized" · 6b9c91e7
      Jakob Gruber authored
      This is a reland of 5258364e
      
      No changes since revert.
      
      Original change's description:
      > [compiler] Make NativeContextRef never-serialized
      >
      > Most NativeContext elements are immutable after initialization;
      > additionally, we now use acquire-release semantics to load/store
      > elements when possible. Reading and constructing Refs for elements
      > is thus possible from the background.
      >
      > A few notes:
      >
      > - A few elements are not immutable; if read from the background
      > thread, these must use acquire-release semantics.
      > - Elements can be stored from generated code; these are not compatible
      > with bg-thread accesses.
      > - While elements can be read safely from the native context, the
      > elements themselves may still require serialization; this is done in
      > NativeContextRef::Serialize.
      >
      > Bug: v8:7790
      > Change-Id: I12e9611a292e7dd912438c712390731a5422407d
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2897254
      > Auto-Submit: Jakob Gruber <jgruber@chromium.org>
      > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      > Commit-Queue: Georg Neis <neis@chromium.org>
      > Reviewed-by: Georg Neis <neis@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#74604}
      
      Tbr: neis@chromium.org
      Bug: v8:7790
      Change-Id: Ica736a4afda2be7276508fe2f734293d0b9eeaf1
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2917606Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#74774}
      6b9c91e7
    • Jakob Gruber's avatar
      [testrunner] Implicitly detect trivial flag contraditions · c21d0148
      Jakob Gruber authored
      This changes the test runner to automatically treat cases in which
      both a flag and its negation are present as a flag contradiction.
      Example: "--foo --no-foo".
      
      With this change it's no longer necessary to explicitly specify these
      trivial contraditions in variants.py.
      
      Note: since negations are created through simple string operations,
      bogus constructions are possible ("--nobodys-perfect" ->
      "--bodys-perfect"). We accept these as unlikely-to-cause-problems.
      
      Bug: v8:10577
      Change-Id: Ic52a92ed1e884b495ee4136f6e2f3257cca243c2
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2904218Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#74773}
      c21d0148
    • Georg Neis's avatar
      [compiler] Use kCrashOnError in MakeRef · e39711a6
      Georg Neis authored
      ... to get better error messages.
      
      Bug: v8:7790
      Change-Id: I2296e78804e243177a7e984a0284561cd41c61bf
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2917602
      Commit-Queue: Georg Neis <neis@chromium.org>
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Auto-Submit: Georg Neis <neis@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#74772}
      e39711a6
    • Jakob Gruber's avatar
      Revert "Reland "[wasm][bug] Fix a couple of bugs in validation of unreachable code"" · 1f89ee1f
      Jakob Gruber authored
      This reverts commit 916eb869.
      
      Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20gcc/11805/overview
      
      Original change's description:
      > Reland "[wasm][bug] Fix a couple of bugs in validation of unreachable code"
      >
      > This is a reland of 4a037f87
      >
      > Changes compared to original change: None. This seems not to create
      > problems after all.
      >
      > Original change's description:
      > > [wasm][bug] Fix a couple of bugs in validation of unreachable code
      > >
      > > Changes:
      > > - SetBlockType now instantiates the block's start merge with values of
      > >   the correct type in unreachable code.
      > > - EnsureStackArguments now keeps the existing stack values and moves
      > >   them over the new bottom values.
      > > - Drop stack size validation in Drop().
      > > - Add new tests in unreachable-validation.js.
      > >
      > > Change-Id: Ie68b3d9abb0a41d1623d4a123fb526e71941c4e7
      > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2902733
      > > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
      > > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#74650}
      >
      > Change-Id: Id620f7fb6677b772b0dcfd38108256384db44439
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2905598
      > Reviewed-by: Manos Koukoutos <manoskouk@chromium.org>
      > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
      > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#74677}
      
      Tbr: manoskouk@chromium.org
      Change-Id: Ia24aa453735464bdd3aafca4617beabb0cbf8823
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2917601
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Auto-Submit: Jakob Gruber <jgruber@chromium.org>
      Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
      Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#74771}
      1f89ee1f
    • Liu Yu's avatar
      [mips] Remove alignment in kArchStackSlot · a58f812c
      Liu Yu authored
      In commit 4a5adb43, mips may allocate a
      bit more memory than actually needed, and move the beginning of the
      StackSlot in order to have it aligned.
      
      After commit e639eafe, we allocated
      the memory that was actually needed, so we do not need extra alignment
      anymore.
      
      Change-Id: I4c4c01794ed1d2cc5b8c89196eae6834f0da0b6e
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2917578Reviewed-by: 's avatarZhao Jiazhong <zhaojiazhong-hf@loongson.cn>
      Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
      Auto-Submit: Liu yu <liuyu@loongson.cn>
      Cr-Commit-Position: refs/heads/master@{#74770}
      a58f812c
  2. 25 May, 2021 35 commits