1. 10 Aug, 2018 1 commit
    • Bret Sepulveda's avatar
      Escape backslashes when logging. · f642de00
      Bret Sepulveda authored
      Log::MessageBuilder was already escaping most unsafe characters when
      they were being logged, but plain backslashes were not. Merely updating
      the existing escaping path was not sufficient, as recursion would cause
      escape codes to be doubly escaped. This patches refactors the API to
      ensure incoming text is escaped exactly once.
      
      Bug: v8:8039
      Change-Id: Id48aabf29fb6153189ae4a1ad7dfaaf4b41b62ad
      Reviewed-on: https://chromium-review.googlesource.com/1169049Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
      Commit-Queue: Bret Sepulveda <bsep@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55038}
      f642de00
  2. 20 Oct, 2017 1 commit
    • Camillo Bruni's avatar
      [log] Consistently escape log entries · d06cb586
      Camillo Bruni authored
      Implicitly escape all output that is passed to Log::MessageBuilder.
      We escape non-printable characters and the log field separator ','
      using the \x00 and \u0000 escape sequences.
      
      Example:
      Before: event-foo,"space: ","comma: ,","double quotes: """
      After:  event-foo,space: ,comma: \x2C,double quotes: "
      
      This might slightly impact human readability of the log files in
      extreme cases. However, most strings do not contain any escaped
      characters.
      
      Bug: 
      Change-Id: Ic78f6d9932367d02f9f3c3f70b41b5c283bdf880
      Reviewed-on: https://chromium-review.googlesource.com/728332
      Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#48805}
      d06cb586
  3. 10 Feb, 2011 1 commit
  4. 29 Jan, 2010 1 commit
  5. 17 Apr, 2009 1 commit