Commits · 6b1dd6b268415e0f652fe2a0d64088b2d72ce194 · Linshizhi / V8

28 Aug, 2014 14 commits

Fix rare access violation during JS heap serialization. · 6b1dd6b2

yangguo@chromium.org authored Aug 28, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/510013002

Patch from Slava Chigrin <vchigrin@yandex-team.ru>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23488 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6b1dd6b2

MIPS: Fix [de]serialize problem of root objects. · 0b1e18c2

balazs.kilvady@imgtec.com authored Aug 28, 2014

BUG
TEST=mjsunit/deserialize-reference
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/492303004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23487 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0b1e18c2

Add android tools to v8's deps. · d124493d

machenbach@chromium.org authored Aug 28, 2014

BUG=408510
LOG=n
R=hinoka@google.com

Review URL: https://codereview.chromium.org/512183004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23486 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d124493d

Disable running some instruction selector test on unsupported backends. · 2e1295d4

jarin@chromium.org authored Aug 28, 2014

BUG=
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/515793002

Patch from Chunyang Dai <chunyang.dai@intel.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23485 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2e1295d4

Fix serialization references to Cell objects. · 0c38c7df

yangguo@chromium.org authored Aug 28, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/514783002

Patch from Slava Chigrin <vchigrin@yandex-team.ru>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23484 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0c38c7df

Revert "Revert "Remove C++11-ism, until all bots support it."" · 514fcde2

machenbach@chromium.org authored Aug 28, 2014

This reverts commit 1f07f57a4a13985f3a48b06d2848dd3bff165b4f.

AOSP bot is still not ready.

TBR=svenpanne@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/513103002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23481 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

514fcde2

Fix build. · 6afb739e

sigurds@chromium.org authored Aug 28, 2014

GCC needs definitions for constant members (clang doesn't).

TBR=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/511133002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23480 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6afb739e

Remove dependency from generic lowering on compilation info for determining... · e7817a9e

sigurds@chromium.org authored Aug 28, 2014

Remove dependency from generic lowering on compilation info for determining strictness and builtins.

This makes the graphs compositional for inlining (i.e. we can now inline a strict function into a non-strict function, or vice versa).

1) Store strict mode as parameter in StoreNamed/StoreProperty.

R=mstarzinger@chromium.org, titzer@chromium.org

Review URL: https://codereview.chromium.org/473263004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23479 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e7817a9e

Fix disassembly redirection from stdout into a file. · a0d5fa72

svenpanne@chromium.org authored Aug 28, 2014

Pass \n, \r and \t through OStream without escaping.

BUG=
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/458533002

Patch from Vyacheslav Egorov <vegorov@google.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23478 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a0d5fa72

Sub-minor-key-ify seven HydrogenCodeStubs. · 0748ee42

yangguo@chromium.org authored Aug 28, 2014

- FastCloneShallowObjectStub
- StringAddStub
- LoadFastElementStub
- StoreFastElementStub
- TransitionElementsKindStub
- ArrayConstructorStubBase
- InternalArrayConstructorStubBase

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/511853002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23477 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0748ee42

Sub-minor-key-ify four HydrogenCodeStubs. · 3cfef1e0

yangguo@chromium.org authored Aug 28, 2014

- FastNewContextStub
- FastCloneShallowArrayStub
- ToBooleanStub
- ElementsTransitionAndStoreStub.

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/513653003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23474 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3cfef1e0

Reland "Enable C++11 tests on windows." · 33c28c71

machenbach@chromium.org authored Aug 28, 2014

TBR=svenpanne@chromium.org
BUG=400033
LOG=n

Review URL: https://codereview.chromium.org/511113002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23473 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

33c28c71

Revert "Remove C++11-ism, until all bots support it." · 28e95981

machenbach@chromium.org authored Aug 28, 2014

This reverts commit r23463 as by now >> shouldn't be a syntax error anymore in chromium.

TBR=vogelheim@chromium.org, svenpanne@chromium.org

Review URL: https://codereview.chromium.org/512123002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23472 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

28e95981

X87: Minor-key-ify BinaryOpICWithAllocationSiteStub. · 425568d6

weiliang.lin@intel.com authored Aug 28, 2014

port r23444.

original commit message:
  Minor-key-ify BinaryOpICWithAllocationSiteStub.

BUG=
R=weiliang.lin@intel.com

Review URL: https://codereview.chromium.org/514073003

Patch from Chunyang Dai <chunyang.dai@intel.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23471 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

425568d6

27 Aug, 2014 26 commits

Disable running some change tests on unsupported backends. · f875dd66

titzer@chromium.org authored Aug 27, 2014

TBR=vogelheim@chromium.org
BUG=

Review URL: https://codereview.chromium.org/515583002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23468 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f875dd66

Unit test of instruction selection for calls with deoptimization. · 8eb5c152

jarin@chromium.org authored Aug 27, 2014

BUG=
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/505133002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23467 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8eb5c152

Ensure that JSProxy::Fix gives the generated JSObject map a constructor · 71fbe7d4

adamk@chromium.org authored Aug 27, 2014

All JSObjects in V8 either have a map()->constructor() field or are
JSFunctions. JSProxy::Fix, however, was not enforcing this, and
Object.observe's use of JSObject::GetCreationContext() exposed this.

Note that this is not Object.observe-specific: the API call
v8::Object::CreationContext() also would have revealed this bug.

This patch chooses Object as a reasonable constructor to put on the
newly-fixed object's map. Note that this has no effect on the "constructor"
property in JS. In doing so, I've also tightened up the code underlying
JSProxy::Fix to only support JSObject and JSFunction as possible output
types.

BUG=405844
LOG=N
R=rossberg@chromium.org, verwaest@chromium.org

Review URL: https://codereview.chromium.org/505303004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23466 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

71fbe7d4

Remove C++11-ism, until all bots support it. · 887ba6c1

vogelheim@chromium.org authored Aug 27, 2014

R=machenbach@chromium.org
BUG=

Review URL: https://codereview.chromium.org/509963002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23463 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

887ba6c1

Fix expectations of lowering tests. · 79c8cfe2

titzer@chromium.org authored Aug 27, 2014

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/513803002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23462 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

79c8cfe2

MIPS: Minor-key-ify BinaryOpICWithAllocationSiteStub. · 14e190bb

balazs.kilvady@imgtec.com authored Aug 27, 2014

Port r23444 (0331267)

BUG=
R=dusan.milosavljevic@imgtec.com

Review URL: https://codereview.chromium.org/505933003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23461 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14e190bb

Disable some changes tests on ARM64. Also, fix the changes lowering to not use... · fa34ea60

titzer@chromium.org authored Aug 27, 2014

Disable some changes tests on ARM64. Also, fix the changes lowering to not use the more expensive TruncateFloat64ToInt32, but to use ChangeFloat64ToInt32/ChangeFloat64ToUint32, as it was before.

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/512753002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23460 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fa34ea60

Some PNaCL compatibility fixes. · ac8eb911

svenpanne@chromium.org authored Aug 27, 2014

* Removed a few useless and non-standard #includes.
* Made OS::GetCurrentProcessId compile without syscall.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/508933002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23459 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ac8eb911

Fix chromium update in auto-roller. · c21026c8

machenbach@chromium.org authored Aug 27, 2014

BUG=
R=hinoka@google.com

Review URL: https://codereview.chromium.org/511803002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23455 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c21026c8

Fix >> versus > > for stupid C++ compilers. · d806fef1

titzer@chromium.org authored Aug 27, 2014

R=vogelheim@chromium.org
BUG=

Review URL: https://codereview.chromium.org/489733004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23454 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d806fef1

Add Flags<T> class as a type-safe way of storing OR-combinations of enums. · 7fb56e2e

bmeurer@chromium.org authored Aug 27, 2014

TEST=base-unittests
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/510773002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23453 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7fb56e2e

Remove false checks since GetOwnProperty now throws an exception on access check violation. · 7f64aa01

verwaest@chromium.org authored Aug 27, 2014

BUG=
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/514613002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23452 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7f64aa01

[Auto-roll] Bump up version to 3.29.22.0 · 2dbdd413

machenbach@chromium.org authored Aug 27, 2014

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/507353002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23450 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2dbdd413

Remove old changes lowering code and convert test to use new changes lowering code. · 5bf4c830

titzer@chromium.org authored Aug 27, 2014

R=bmeurer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/515433003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23449 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5bf4c830

Fix GN build after r23442. · ef565ef9

mstarzinger@chromium.org authored Aug 27, 2014

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/514583003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23448 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ef565ef9

Disable SysInfoTest.AmountOfPhysicalMemory on NaCl. · 8968087b

bmeurer@chromium.org authored Aug 27, 2014

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/499263003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23447 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8968087b

Introduce sub minor key to remove NotMissMinorKey in hydrogen stubs. · a81ab7af

yangguo@chromium.org authored Aug 27, 2014

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/504333005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23445 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a81ab7af

Minor-key-ify BinaryOpICWithAllocationSiteStub. · 545c04b9

yangguo@chromium.org authored Aug 27, 2014

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/506003002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23444 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

545c04b9

Fix chromium sync command in auto-roller. · af08d3f2

machenbach@chromium.org authored Aug 27, 2014

TBR=hinoka@chromium.org, jarin@chromium.org

Review URL: https://codereview.chromium.org/506273007

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23443 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

af08d3f2

Wire up simplified and change lowering in pipeline. · 5b253766

mstarzinger@chromium.org authored Aug 27, 2014

R=titzer@chromium.org

Review URL: https://codereview.chromium.org/511713003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23442 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5b253766

fix and update debug-debugger.js · 327d843d

yangguo@chromium.org authored Aug 27, 2014

added `switch` statement is missing `break`s

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/494303004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23441 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

327d843d

Slightly simplify Math.sign and Math.trunc. · c49aa16f

yangguo@chromium.org authored Aug 27, 2014

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/504343005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23440 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c49aa16f

[turbofan] ARM64 FP instruction selection tests · 31497a45

m.m.capewell@googlemail.com authored Aug 27, 2014

Add some tests for floating pointer instruction selection, and change conversion
tests to be parameterised.

BUG=
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/500503002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23439 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

31497a45

Keep chromium checkout up to date in auto roller. · f435a218

machenbach@chromium.org authored Aug 27, 2014

R=hinoka@google.com

Review URL: https://codereview.chromium.org/504443005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23438 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f435a218

Whitespace change to check MSVS 2013. · 7b784109

machenbach@chromium.org authored Aug 27, 2014

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23437 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7b784109

Tweaks to generate XP-compatible .exes · c6f044b3

svenpanne@chromium.org authored Aug 27, 2014

BUG=407517
LOG=y
R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/504793004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23436 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c6f044b3