- 08 May, 2020 25 commits
-
-
Michael Lippautz authored
The visitor was removing pages while at the same time iterating them on NormalPagedSpace. Removing all pages at once is safe and should also be faster. Bug: chromium:1056170 Change-Id: I56eedf6f09498f126cb09238e01962b48e75b657 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190427Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#67687}
-
Ng Zhi An authored
This started as fixing a clang-tidy warning to use a explicitly defaulted destructor, see https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++-dos-and-donts.md#prefer-to-use. But we can clean it up a bit more to omit the destructor, since the all its members are trivially destructible. With this change, ByteData is now is_trivially_destructible. Bug: v8:10488 Change-Id: If6698ce181dc8bca2a6623987039f3116a375dd1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182309 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#67686}
-
Shu-yu Guo authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/6a18c27c..f1b0a1e2 Bug: v8:7834, v8:10510 Change-Id: I888eb57ef92bcce15bb015ea56ad2f61505a4fb8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2189911Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#67685}
-
Leszek Swirski authored
Bug: chromium:1011762 Change-Id: I3dc2975f3a93fa4c780e54e6e5bd8e689e008f36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190751 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Toon Verwaest authored
This changes the existing implementation that creates an unresolved reference for those cases to look at exactly what scopes are relevant so it can correctly handle catch scopes and avoid re-resolving later. Variable through with aren't marked as assigning since this information isn't relevant for the with itself; and if the with is passed through, there's no need to mark the outer variable as assigned since it's either initialized or it isn't. The catch variable is assigned since it is relevant for the catch variable. The CL uses LookupLocal which wouldn't work for deserialized scopes, but this isn't relevant because 1) eval scopes are declaration scopes, and 2) eval causes all outer variables to be maybe_assigned anyway. Bug: chromium:1074737 Change-Id: I3febca479ddd1f3c62eae299190b06c0b4cd3746 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187272 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Auto-Submit: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#67683}
-
Georg Neis authored
... via a comment in the API and a CHECK in Isolate::RunHostInitializeImportMetaObjectCallback. Also restructure things a little bit such that this function really just runs the callback and doesn't deal with module internals. Memoization now happens in the SourceTextModule class. Bug: v8:7044 Change-Id: I5b850ae629c3638c4b30dfdeaa996642a33d14dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190413Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Bug: chromium:1079066 Change-Id: Ideb6704ce6ff0754250ba8dda4addf0841330db4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190418Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#67681}
-
Daniel Bevenius authored
It looks like the usages of these were removed in Commit 8a1bafaf ("Reland "[platform] Implement TaskRunners in the DefaultPlatform"). Change-Id: I61865548020b6dc0ee7d658080ad148c7ffd6e42 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187500Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#67680}
-
Manos Koukoutos authored
Changes: - Extend wasm/wasm-module-builder.cc to handle reference types. - Add testing infrastructure to wasm-macro-gen.h for reference types. - Add cc tests for ref types in blocks and globals. Bug: v8:7748 Change-Id: I527252a768469e1493ecee9ecf4b4afaf8a8013b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182377Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#67679}
-
Dominik Inführ authored
Remove the SWEEPING state from incremental marking. Sweeping is now always completed when starting incremental marking. Before this change there needed to be a safepoint each for starting marking and completing sweeping. Now both happens within a single safepoint. Bug: v8:10315 Change-Id: Iad2835554865f2de24376372affe9a98992d1fa0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190419Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#67678}
-
Leszek Swirski authored
Bug: chromium:1078913 Change-Id: Ibdd87455797ea2ed4aa6072523352a0c3fbaf844 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190412 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Bug: chromium:1056170 Change-Id: I0854b9b144ad47dc7ea0b16862fea1583aec7402 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190416 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Background threads can now start incremental marking when necessary. In contrast to the main thread they always need to schedule a job and can't start incremental marking right away. Background threads also use a simpler heuristic for deciding whether to start incremental marking. Bug: v8:10315 Change-Id: I2b94e8273c8be860157fe9670797048ed1c5c3da Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184149Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Marja Hölttä authored
There's no need for them to be in NativeContext. This CL moves the minimal subset of SFIs related to Promises / finally. Bug: v8:10482 Change-Id: I06a20dc927f13b7bfc8cea853a11913314ee019d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187271Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Nico Hartmann authored
This reverts commit 6204768b. Reason for revert: A number of Clusterfuzz reports (e.g. https://bugs.chromium.org/p/chromium/issues/detail?id=1079474) Original change's description: > [turbofan] Improve equality on NumberOrOddball > > This CL cleans up CompareOperationFeedback by replacing it with a > composable set of flags. The interpreter is changed to collect > more specific feedback for abstract equality, especially if oddballs > are involved. > > TurboFan is changed to construct SpeculativeNumberEqual operator > instead of the generic JSEqual in many more cases. This change has > shown a local speedup of a factor of 3-10, because the specific > operator is way faster than calling into the generic builtin, but > it also enables additional optimizations, further improving > runtime performance. > > Bug: v8:5660 > Change-Id: I856752caa707e9a4f742c6e7a9c75552fb431d28 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2162854 > Reviewed-by: Mythri Alle <mythria@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67645} TBR=rmcilroy@chromium.org,neis@chromium.org,mythria@chromium.org,nicohartmann@chromium.org Change-Id: I3410310ed2b1ff2eaee70c1b91c3151d35866108 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:5660 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190414Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#67673}
-
Michael Lippautz authored
Adjust suffix to "-unittest" like everywhere else in V8. Accept clang-format suggested changes. Bug: chromium:1056170 Change-Id: I54c1396e79aff87c052233853d7fe560337eeecf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190410 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
along with WASM_ARRAY_TYPE, a WasmArray class, and a very basic test. Bug: v8:7748 Change-Id: I1ad4ff78e428972be52130cc179a91c76fcdbdc6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2185136 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Nico Hartmann authored
Bug: chromium:1077804 Change-Id: Iec47dbbcaf4ab8ea1a738df303b35c241a4d12d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187499Reviewed-by:
-
Tobias Tebbi authored
Bug: v8:10391 Change-Id: I0c7e2110227f9c271a3a644d4e921c6b74b68cfd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2152648Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Zhao Jiazhong authored
Port ac33b533 https://crrev.com/c/2179384 Change-Id: Icfbeab2cd7556b98f84bc7c9e65d82dc18700c85 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190072Reviewed-by:
-
Joyee Cheung authored
Bug: v8:5368, v8:8330 Change-Id: I237541223289546b8de031f905d42bb9234c8448 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184649 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by:
-
Michael Lippautz authored
This patch provides infrastructure to pin object types to specific spaces. This allows embedders to create mutual exclusive arenas for certain (base) types. In future, this will also be used to provide sliding-window compaction on certain custom spaces. We mainly preserve the existing infrastructure with the difference that spaces are now slightly more dynamic than in Blink as they are kept in a vector instead of a fixed-size array. The mechanism differs from Blink in that it does not allow the user object to call allocation methods directly but instead provides a trait that can be overridden to specify a custom space. The patch preserves templatization for objects that do not go into custom spaces to safe a branch in the allocation hot path. Change-Id: I08aa6932348e2d6258e19c4a32d189865f459f02 Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187611 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Yolanda Chen authored
When pick state from predecessor, we should consider live ranges that were split out by the backwards spilling heurisitics and already end before the predecessor does. Bug: chromium:1066869 Change-Id: I9ff85e73059a7c07f1e212fdc041450c79a4d70c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2174337Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Yolanda Chen <yolanda.chen@intel.com> Cr-Commit-Position: refs/heads/master@{#67665}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/4b54ad3..2ec959d Rolling v8/third_party/aemu-linux-x64: u-v5JkP8oS3BCzku9SpOrrUqZvzXDXE3MqO_M0oKrX4C..MeLYn-hjraOzvUMXrfer2KnMsBnC4w6qg8ctTIpuFcgC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/ce41a35..06f14d9 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/f7df9c4..9a73531 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ie811dc60dac7a7c60ee4f23fd2f69e99a07443fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2189794Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#67664}
-
Joyee Cheung authored
To rehash JSMap and JSSet, we simply replace the backing store with a new one created with the new hash. Bug: v8:9187 Change-Id: I90c25b18b33b7bc2b6ffe1b89fe17aa5f978b517 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2143983 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#67663}
-
- 07 May, 2020 15 commits
-
-
Shu-yu Guo authored
Normative change in ecma262 [1]. Errors thrown by GetMethod(iterator, "return") are suppressed in favor of the original exception. [1] https://github.com/tc39/ecma262/pull/1408 Bug: v8:10397 Change-Id: I0dea8bd677c557cced7103c846416bd81f06f482 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2183400 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Change-Id: Ic71dda9c487b6afa95ba2525518c923f2608fd7d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187003Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#67661}
-
Michaël Zasso authored
This is necessary for the pthread_attr_get_np function. Change-Id: I01cfe075a7c86909e8cf37eb7f7c5d44fa044975 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2188310 Commit-Queue: Michaël Zasso <mic.besace@gmail.com> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Michaël Zasso <mic.besace@gmail.com> Reviewed-by:
-
Ng Zhi An authored
Implement conversion of an i8x16 node to a f32x4 node. Bug: v8:10507 Change-Id: Ifefffb779dbf25b57eae278afe41c11b41c949ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2185472Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67659}
-
Ng Zhi An authored
Move them all into wasm-macro-gen.h, other opcodes have their macros there as well. This will make reusing these macros easier when we have other test files for SIMD. (An upcoming one is for scalar lowering tests.) Change-Id: I6c21100ce490abbc26f80a0d204815687fd62f00 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2185471Reviewed-by:
-
Ng Zhi An authored
See https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html for more on this warning. Bug: v8:10488 Change-Id: Ie946a19d567f4b0d09fe61f5efbc3f62f2156b77 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2186634Reviewed-by:
-
Ng Zhi An authored
See https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html for more on this warning. Bug: v8:10488 Change-Id: I81813a500a1651672862c6311c35ccc0a55ce775 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2186633Reviewed-by:
-
Ng Zhi An authored
See https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++-dos-and-donts.md#prefer-to-use. Bug: v8:10488 Change-Id: I6b43374a3f5c3b0bc5a51acb0b5e0daad7d3c801 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2185969Reviewed-by:
-
Omer Katz authored
This reverts commit dc1af6a2. Reason for revert: Diff in patchset 2 Original change's description: > Revert "cppgc: Initial marking loop" > > This reverts commit fb9a19fe. > > Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20UBSan/11028 > > Original change's description: > > cppgc: Initial marking loop > > > > This CL introduces: > > - Worklist > > - MarkingHandler to manage gc marking phase > > - Integration into CollectGarbage for atomic pause GC > > - MarkingVisitor for main thread marking > > > > Still missing from this CL: > > - Proper handling for stack scanning > > - Handling of previously not fully constructed objects > > > > Bug: chromium:1056170 > > Change-Id: I70ac8534dfb898777cf3a06e3119cac8072174fd > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2170526 > > Commit-Queue: Omer Katz <omerkatz@chromium.org> > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#67642} > > TBR=ulan@chromium.org,mlippautz@chromium.org,bikineev@chromium.org,omerkatz@chromium.org > > Change-Id: I666481f44119771be685bf2555aa0dd5eda83a01 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:1056170 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187502 > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> > Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67643} TBR=ulan@chromium.org,mlippautz@chromium.org,bikineev@chromium.org,omerkatz@chromium.org,nicohartmann@chromium.org # Not skipping CQ checks because this is a reland. Bug: chromium:1056170 Change-Id: I54e963e2aeaaf16069bdcdb019c0ac65e28ef6e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187733Reviewed-by:
-
Ulan Degenbaev authored
When the memory reducer decides whether to do the next GC or not, it takes into account the number of detached contexts. This may lead to redundant GCs if the detached contexts are leaking and stay reachable. With the unified heap all unreachable detached contexts are freed in one GC, so this heuristic is no longer necessary. Bug: chromium:1072746 Change-Id: I869fd6ca2008135dfea39e7ceeb01fdc9ead22be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187493Reviewed-by:
-
Omer Katz authored
Bug: chromium:986235 Change-Id: If7c990dd143fd5331d264dcf2c5349525d1321b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187731 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Marja Hölttä authored
Bug: chromium:1078825 Change-Id: I0cfa7dcef0efef8a066ee0e9a85d8d0f27343b1a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187495 Auto-Submit: Marja Hölttä <marja@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Jakob Gruber authored
In upcoming work these flags will be used to configure the experimental native context independent code feature. Build-time flags: v8_enable_nci_code Defines: V8_ENABLE_NCI_CODE Runtime flags: --turbo-nci --turbo-nci-as-highest_tier --print-nci-code --trace-turbo-nci Drive-by: Remove unused embedded builtins and jitless defines. Bug: v8:8888 Change-Id: I4466b440634a787bd84b052fe2466b22540216a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184295Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#67650}
-
Jakob Gruber authored
The snapshot's Checksum function internally uses adler32, which appears to be significantly faster than base::hash_range and almost as fast as doing nothing at all. Test times, measured with $ time tools/run-tests.py --outdir out/release-with-dchecks/ --exit-after-n-failures=1 --quickcheck base::hash_range: 1m35s adler32: 1m15s nop: 1m13s Bug: chromium:1047818 Change-Id: I8def62f6276a3d06d06911abf5368f59331245ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187492Reviewed-by:
-
Jakob Kummerow authored
When the garbage collector needs to get a struct's type information, it must be prepared to deal with forwarding pointers, as those will only get cleaned up at the end of the GC cycle. Bug: v8:7748 Change-Id: Ifdfdffcef27d1dbe07c86a3abd17711f46c1b900 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187732 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
