- 22 Nov, 2018 23 commits
-
-
Ulan Degenbaev authored
This fixes places that assume that DescriptorArray is a WeakFixedArray. In addition to the existing: - LoadDetailsByKeyIndex - LoadValueByKeyIndex - LoadFieldTypeByKeyIndex This introduces Load*ByDescriptorEntry versions and LoadKeyByKeyIndex. Bug: v8:8486 Change-Id: I958867138df7756c715ae3d449b3206a32076514 Reviewed-on: https://chromium-review.googlesource.com/c/1346501 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#57727}
-
Jakob Gruber authored
We recently changed embedded builtins to be emitted as raw assembly files during the build process in order to support MSVC (which doesn't support inline assembly on x64). Ninja uses ml.exe / ml64.exe as the assembler on all Windows builds (msvc & clang); these unfortunately don't support large data streams well and can take over 5 minutes for embedded.S. With this CL we work around this by going back to inlined assembly for clang Windows builds. Bug: v8:6666, v8:8475 Change-Id: I33beb3f5a1df07de3299df0fc2be4e8983701db0 Reviewed-on: https://chromium-review.googlesource.com/c/1344114 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#57726}
-
Dan Elphick authored
Adds a new field rare_data of type FunctionTemplateRareData to FunctionTemplateInfo and moves 8 others which are unset on 90% of FunctionTemplateInfo objects to this field. Getters like prototype_template() are changed to GetPrototypeTemplate() to indicate they're not trivial. The setters are replaced with static methods (e.g. SetPrototypeTemplate) that take an Isolate and the template object, since they can now perform allocation. Bug: v8:8478 Change-Id: If72b132ade4ca4a3f803f913761c9caddc0e9dd6 Reviewed-on: https://chromium-review.googlesource.com/c/1342519 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#57725}
-
Michael Achenbach authored
Many tests were already skipped in debug mode, but they kept running on CQ which sets dcheck_always_on, probably equally slow. Some other tests are marked as slow based on a recent run of the arm64 sim trybot. NOTRY=true Bug: v8:7783 Change-Id: Ic022518edfa112ea6d228ae9a68653c99651dbb4 Reviewed-on: https://chromium-review.googlesource.com/c/1347479Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#57724}
-
Ulan Degenbaev authored
Previosly, LoadArrayElement assumed that the array is a FixedArray. The PropertyArray and WeakFixedArray pretended to be a FixedArray and had static asserts about length offsets. This patch make LoadArrayElement generic and uses a new LoadArrayLength function to fetch the length of the array without hard-coding the length offset. Bug: v8:8486 Change-Id: Ib27132bf3fcecc135ad632c4227c57ca0a05036f Reviewed-on: https://chromium-review.googlesource.com/c/1346498 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#57723}
-
Clemens Hammacher authored
Remove PrintableInstructionSequence and friends, just overload operator<< directly for the respective types. R=herhut@chromium.org Bug: v8:8238 Change-Id: I67713978ab06f7ec5309e52b4090256480f362b1 Reviewed-on: https://chromium-review.googlesource.com/c/1346113Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Stephan Herhut <herhut@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57722}
-
Jakob Gruber authored
With the last remaining TF code stubs gone, c-s-a.{h,cc} is no longer needed in the final binary. Bug: v8:7777 Change-Id: I8573199401678758698df56e0cb680f125f06bdc Reviewed-on: https://chromium-review.googlesource.com/c/1346329 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#57721}
-
George Wort authored
Bug: v8:6600 Change-Id: I4bf99aeac7336eda8989bc6772d8bd34c44117ea Reviewed-on: https://chromium-review.googlesource.com/c/1346112 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57720}
-
Jakob Gruber authored
This CL moves the two remaining IC stubs to builtins, generating a dedicated builtin for each KeyedAccessStoreMode variant. Bug: v8:7777 Change-Id: I540b3c3437adb94094771a19713e71ec8a349553 Reviewed-on: https://chromium-review.googlesource.com/c/1346095Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Notry: true Change-Id: I4de1f561682e8ad7fac0358c259efa44559c1389 Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1347477Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#57718}
-
Sigurd Schneider authored
This CL moves optimization capabilities from typed lowering to typed optimization. In particular, this allows retyping of Speculative to number optimizations depending on their input types. This can save type checks if we know that inputs are already in SafeIntegerRange and uses are truncating to 32bit integers. This change recovers the performance lost to 31bit Smis on Octane/crypto on x64: 32bit nosmis avg 30,984.84 stddev 180.52 31bit smis (w/o patch) avg 29,438.52 stddev 120.30 -4.99% 31bit smis avg 31,274.52 stddev 176.26 +0.93% +6.24% Change-Id: I86d6e37305262336f4f7bd46aac0d2cbca11e8c1 Bug: v8:8344 Reviewed-on: https://chromium-review.googlesource.com/c/1323729 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This should make it possible to load a new graph without reloading Turbolizer. Notry: true Change-Id: Ic6f8bdf7fee658836612043d8893614ae54d7e15 Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1347476 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Daniel Clifford authored
This is a reland of 74a0ad7d Original change's description: > [torque] Implement intrinsics support > > Also add the first intrinsic and usage of it: %RawCast > > Bug: v8:7793 > Change-Id: Id1e3288e8bab6adb510731076a39590e8fd156be > Reviewed-on: https://chromium-review.googlesource.com/c/1344152 > Commit-Queue: Daniel Clifford <danno@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57692} Bug: v8:7793 Change-Id: I315c7d44f265d0f937598e8afb1c28b08d6a23da Reviewed-on: https://chromium-review.googlesource.com/c/1347472Reviewed-by:
Daniel Clifford <danno@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#57715}
-
Jakob Gruber authored
In preparation for converting these stubs to builtins. This turns compile-time elements kind parameters into a runtime check, essentially emitting all contained logic for each elements kinds and dispatching at runtime. Bug: v8:7777 Change-Id: I7a5c97ea2775e9f8ff469db6ab577de6c65c6bbe Reviewed-on: https://chromium-review.googlesource.com/c/1340282 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Hannes Payer authored
Change-Id: Ie2d740b6b584c5104849e46c1286550c80f1f5c9 Reviewed-on: https://chromium-review.googlesource.com/c/1340252Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
peterwmwong authored
Initial port of Array.p.join came before Torque had exception handling. This small cleanup also simplifies a future CL porting TypedArray.p.join. Bug: v8:7624 Change-Id: I74f3880ee6e87917bc87e41d94be1a83b039384b Reviewed-on: https://chromium-review.googlesource.com/c/1347514Reviewed-by:
-
Yang Guo authored
This reverts commit 1d726111. Reason for revert: This breaks a layout test, and blocks V8 roll https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7_chromium_rel_ng/135831 Original change's description: > Implement Faster MicrotaskQueue Step 2 > > This is an implementation of https://bit.ly/v8-faster-microtask-queues > step 2. > > This CL overhauls MicrotaskQueue class, the previous one is on V8 heap, > and the new one is on C++ heap. > > Benchmark: > This CL improves a benchmark score around promise by 5~23%. > https://github.com/v8/promise-performance-tests > https://docs.google.com/spreadsheets/d/1HtwZGzUAGJYg87VmYhV9hLdvfddlCtC6Oz0iOj-WwQA/edit#gid=1952666737 > > Bug: chromium:887920, v8:7253 > Change-Id: I1f26e02c45ae60ae39d1ccc168daa98bca4663d9 > Reviewed-on: https://chromium-review.googlesource.com/c/1290751 > Commit-Queue: Taiju Tsuiki <tzik@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57681} TBR=ulan@chromium.org,adamk@chromium.org,yangguo@chromium.org,ishell@chromium.org,bmeurer@chromium.org,tzik@chromium.org Change-Id: I639882a95fe63c029a2e53d610dc4133d1ac48f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:887920, v8:7253 Reviewed-on: https://chromium-review.googlesource.com/c/1347473 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This commit adds a --run-skipped flag to the test runner that will bypass the 'SKIP' status. Bug: v8:8485 Change-Id: Iac012bdaf2de6b0f8e44ed3a65bc9330709527bb Reviewed-on: https://chromium-review.googlesource.com/c/1346490 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#57710}
-
Jaroslav Sevcik authored
Bug: v8:8361 Change-Id: If5d7e8dd6c4e800ce6f8b82d197c29111bc8707d Reviewed-on: https://chromium-review.googlesource.com/c/1340296Reviewed-by:
-
Tao Pan authored
IA support both "push reg" and "push [mem]" assemble instruction. Use OperandGenerator::UseAny() for initializing Operand of kX64Push with should be more willing to use spill slots (Use constraints are marked as register-beneficial; UseAny are not) UnallocatedOperand: :REGISTER_OR_SLOT. That way, the register allocator Change-Id: I8ffd66915c8acd64221182710257232ef19f06d6 Reviewed-on: https://chromium-review.googlesource.com/c/1337312Reviewed-by:
-
Jaroslav Sevcik authored
With constant field tracking, we get more properties on instance. This negatively affects the common scenario where objects are used as module, i.e., they have large number of constant functions as properties. In that case, we would transition the objects to dictionary mode. Bug: v8:8361 Change-Id: If4831bd081f3c45be651e051e7375eb275d265b4 Reviewed-on: https://chromium-review.googlesource.com/c/1344110 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a2bfd53..05ea63b Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/da9b294..04161ec Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/d115075..aa21a92 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e47ac15..d66dad7 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/aa6b9c8..7fa2bdf Rolling v8/tools/luci-go:infra/tools/luci/isolate/${platform}: https://chrome-infra-packages.appspot.com/infra/tools/luci/isolate/${platform}/+log/git_rev..git_rev TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I5c181380da2230f62677f345c6584f3fd856b75f Reviewed-on: https://chromium-review.googlesource.com/c/1347890 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#57706}
-
Shiyu Zhang authored
This is a reland of 6ec90ece Original change's description: > Reland "Create a fast path to get migration target when updating map" > > This is a reland of c285380c > > Original change's description: > > Create a fast path to get migration target when updating map > > > > During map updating, store the pointer to new map in the > > raw_transitions slot of the old map that is deprecated from map > > transition tree. Thus, we can get the migration target directly > > instead of TryReplayPropertyTransitions when updating map. > > > > This can improve Speedometer2.0 Elm-TodoMVC case by ~5% on ATOM > > Chromebook and ~9% on big-core Ubuntu. > > > > Change-Id: I56f9ce5183bbdd567b964890f623ef0ceed9b7db > > Reviewed-on: https://chromium-review.googlesource.com/1233433 > > Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> > > Reviewed-by: Igor Sheludko <ishell@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#56303} > > Change-Id: Idf0b7716b92a6a15bfe58721c2c34dbd02b31137 > Reviewed-on: https://chromium-review.googlesource.com/c/1270261 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> > Cr-Commit-Position: refs/heads/master@{#56588} Change-Id: Iad23455f66c83340430370be6670bac493c638a1 Reviewed-on: https://chromium-review.googlesource.com/c/1309305 Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> Reviewed-by:
-
- 21 Nov, 2018 17 commits
-
-
Ross McIlroy authored
Moves allocation of the WasmModuleObject for asm.js code out of SyncCompileTranslatedAsmJS since that is called when we are compiling the native context independent SharedFunctionInfo and the WasmModuleObject requires a native context. Instead save the members required to create the object in the AsmWasmData and create it during module instantiation. Note: since the Wasm module is an implementation detail for asm_wasm code and isn't exposed, this doeesn't have semantic change for asm.js code. As part of this change, the AsmWasmData is changed from a FixedArray to a dedicated struct. Some logic is also moved from module-compiler to wasm-engine to make the seperation between Wasm SyncCompile and AsmJS SyncCompile more clear. BUG=chromium:900535,v8:8395 Change-Id: Ia48469c095b0688f210aa86e7430c9ab4ea4b26b Reviewed-on: https://chromium-review.googlesource.com/c/1345509 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Erik Luo authored
Types such as "function" have a ValueMirror that does not override "buildObjectPreview()". This CL updates clients to check that the preview was actually built after call it. Bug: chromium:907400 Change-Id: Id569c98363d47b259a40790b596efedb3d14abc2 Reviewed-on: https://chromium-review.googlesource.com/c/1347067Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#57703}
-
Jakob Kummerow authored
In preparation for incrementally migrating subclasses to deriving from FixedArrayPtr/FixedArrayBasePtr. Once that is done for all subclasses, this duplication will be dropped again. Bug: v8:3770 Change-Id: I6d664997fdcb18f7c0f37183d9f920ae30f3b749 Reviewed-on: https://chromium-review.googlesource.com/c/1345325Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#57702}
-
Sigurd Schneider authored
We haven't put 64bit constants in the constant pool for a while. This CL removes the support, simplifying the implementation. Change-Id: I2c8972ea74dc71ccd5c9d333947d681dad2ea6c0 Bug: v8:8054 Reviewed-on: https://chromium-review.googlesource.com/c/1346109 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Junliang Yan authored
Sharing WasmCall/StubCall will lead to relocation being processed more than once in NativeModule::AddCode for wasm. R=joransiu@ca.ibm.com Change-Id: I88d9a1a956fe36ef81e0a4c61d7dedf868bdf9a3 Reviewed-on: https://chromium-review.googlesource.com/c/1344510 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#57700}
-
Toon Verwaest authored
Change-Id: I50320af8484f247656b79beb3195f371635f6797 Reviewed-on: https://chromium-review.googlesource.com/c/1346495Reviewed-by:
-
Junliang Yan authored
Port de2681c1 Original Commit Message: This adds a {PrintRegister} method which prints the given register in a readable way (e.g. "eax", ... on ia32). This is currently only used in Liftoff. The {RegisterConfiguration} class has the same functionality, and I plan to make {RegisterConfiguration} also use the new {RegisterName} functions in a follow-up CL. R=clemensh@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I8359ed22ebe88d5c30a45a9c6f3caa3b03d902ee Reviewed-on: https://chromium-review.googlesource.com/c/1344509 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
-
Hannes Payer authored
Bug: chromium:852420 Change-Id: I01d0bed33a573adbe1d9365868d63ea9c3cb0552 Reviewed-on: https://chromium-review.googlesource.com/c/1346499Reviewed-by:
-
Toon Verwaest authored
It's unclear that this helps performance. Let's see what the bots say. Change-Id: Ic28783c90495f6ce01b4980d84794d394f941a4f Reviewed-on: https://chromium-review.googlesource.com/c/1346331 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
This reverts commit d8c471ff. Reason for revert: breaks waterfall Original change's description: > [torque] change formatter to emit LF newlines on Windows > > Otherwise, it will always replace LF with CRLF, which is not what you > want if you follow the Chromium instructions for Windows, that is, > configure git with core.autocrlf = false. > > Change-Id: I30fcfc471cde79d5c80d05ce582a8507cf5810b5 > Reviewed-on: https://chromium-review.googlesource.com/c/1345150 > Reviewed-by: Daniel Clifford <danno@chromium.org> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57691} TBR=danno@chromium.org,tebbi@chromium.org Change-Id: Ib30ae0d5b1803dbe8e6e8a0928cc41a6ce2d2bb8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1346502Reviewed-by:
-
Daniel Clifford authored
This reverts commit 74a0ad7d. Reason for revert: Presubmit tests fail Original change's description: > [torque] Implement intrinsics support > > Also add the first intrinsic and usage of it: %RawCast > > Bug: v8:7793 > Change-Id: Id1e3288e8bab6adb510731076a39590e8fd156be > Reviewed-on: https://chromium-review.googlesource.com/c/1344152 > Commit-Queue: Daniel Clifford <danno@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57692} TBR=danno@chromium.org,tebbi@chromium.org Change-Id: Ief78187f2edaf80c715dea676cbd40edd747ad21 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7793 Reviewed-on: https://chromium-review.googlesource.com/c/1346500Reviewed-by:
-
Igor Sheludko authored
and make the slot occupy two tagged words when pointer compression is enabled. Tbr: bmeurer@chromium.org Bug: v8:7703 Change-Id: Idcd3385cc7d5299d9bdaf6a69c7bd0591099f0bb Reviewed-on: https://chromium-review.googlesource.com/c/1346489Reviewed-by:
-
Daniel Clifford authored
Also add the first intrinsic and usage of it: %RawCast Bug: v8:7793 Change-Id: Id1e3288e8bab6adb510731076a39590e8fd156be Reviewed-on: https://chromium-review.googlesource.com/c/1344152 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
Otherwise, it will always replace LF with CRLF, which is not what you want if you follow the Chromium instructions for Windows, that is, configure git with core.autocrlf = false. Change-Id: I30fcfc471cde79d5c80d05ce582a8507cf5810b5 Reviewed-on: https://chromium-review.googlesource.com/c/1345150Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org Bug: chromium:903688 Change-Id: I72b57d45286ae28c44bad0edffeb56e9142767d1 Reviewed-on: https://chromium-review.googlesource.com/c/1346494Reviewed-by:
-
Yang Guo authored
TBR=aseemgarg@chromium.org Change-Id: Iabb0a1d5ac065f97baf9b44815f0c5df37b426b5 Reviewed-on: https://chromium-review.googlesource.com/c/1346493Reviewed-by:
-
Sigurd Schneider authored
Load elimination is running together with to dead code elimination, the latter of which might eliminate allocations (in particular FinishRegion nodes). These are treated as alias nodes by load elimination, and load elimination does not immediatelly learn that a node has been disconnected. This causes load elimination to access the inputs of dead code eliminated nodes while resolving renames, which causes nullptr dereferences. This CL modifies load elimination to not resolve to a nullptr alias but simply stop before that. Change-Id: If4cef061c7c0e25f353727c9e27f790439b0beb5 Bug: chromium:906406 Reviewed-on: https://chromium-review.googlesource.com/c/1346491 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
