1. 05 Mar, 2019 1 commit
    • Sven Sauleau's avatar
      [wasm] correct Table limit · f4e322c3
      Sven Sauleau authored
      Align the Table implementation limits with the JavaScript Embedding
      limits defined in the specification (from MAX_UINT32 to 1e7).
      
      Introduce a new helper (max_table_init_entries) that returns the
      maximum number of Table entry at initialization. It takes into account
      the maximum Table size, which can be passed by a flag.
      
      Bug: v8:8633
      Change-Id: Idfa19418e81f478f7886a30876e66c9b216e25ac
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1496971
      Commit-Queue: Sven Sauleau <ssauleau@igalia.com>
      Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#60036}
      f4e322c3
  2. 30 Jan, 2019 1 commit
  3. 19 Jan, 2019 1 commit
  4. 18 Jan, 2019 1 commit
    • Sven Sauleau's avatar
      [wasm] fix js-api table/grow · fc277117
      Sven Sauleau authored
      Fix WebAssembly's table/grow js-api. The argument is a unsigned long,
      this change refactors most of arithmetic and bounds checks type from
      int64 to uint32_t, according to the spec.
      
      Bug: v8:8319
      Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
      Change-Id: Ia29121c930d7fb930668e54a5a769dae25234f2c
      Reviewed-on: https://chromium-review.googlesource.com/c/1351006
      Commit-Queue: Sven Sauleau <ssauleau@igalia.com>
      Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58936}
      fc277117
  5. 10 Dec, 2018 1 commit
    • Sven Sauleau's avatar
      [wasm] fix js-api Memory and Table constructor · ff6544c5
      Sven Sauleau authored
      Fix and re-enable tests for WebAssembly's memory/constructor and
      table/constructor js-api.
      
      It introduces the '[EnforceRange] unsigned long' algorithm used
      to validate initial and maximum properties.
      
      The initial property is now required, by the switch to the Web IDL
      specification. Most of the input validations errors are now considered
      TypeError instead of RangeError.
      
      The WasmTableObject and WasmMemoryObject APIs use more consistently uint32_t
      to ensure integer range and remove the need for bounds checks.
      
      Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
      Bug: v8:8319
      Change-Id: Iedd3ee6484ef688a5e96f93006eb6ca66d805a48
      Reviewed-on: https://chromium-review.googlesource.com/c/1354043
      Commit-Queue: Adam Klein <adamk@chromium.org>
      Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
      Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58138}
      ff6544c5
  6. 11 Sep, 2018 1 commit
  7. 28 Aug, 2017 1 commit
  8. 10 Jul, 2017 1 commit
  9. 17 Jan, 2017 1 commit
  10. 15 Jan, 2017 1 commit
  11. 13 Jan, 2017 2 commits
  12. 12 Jan, 2017 4 commits
  13. 20 Dec, 2016 1 commit
  14. 17 Nov, 2016 1 commit
  15. 17 Oct, 2016 1 commit
  16. 13 Oct, 2016 2 commits
  17. 26 Sep, 2016 2 commits
    • ahaas's avatar
      [wasm] Do a proper HasProperty() check in the memory and table setup. · 7bffaaac
      ahaas authored
      The WebAssembly spec requires a HasProperty() check for the maximum
      property of the descriptor object which is used to set up a
      WebAssembly.Memory object or a WebAssembly.Table object.
      
      The original implementation only approximated the HasProperty() check.
      It used Get() to get the value of the maximum property of the descriptor
      object and compared the resulting value to {undefined}. However, this
      approximation is incorrect if the property exists but its value is
      {undefined}.
      
      R=titzer@chromium.org, franzih@chromium.org
      BUG=chromium:649461
      TEST=mjsunit/wasm/memory
      
      Review-Url: https://codereview.chromium.org/2367673003
      Cr-Commit-Position: refs/heads/master@{#39722}
      7bffaaac
    • ahaas's avatar
      [wasm] Bound the table size by Smi::kMaxValue. · 10d7ad9d
      ahaas authored
      BUG=chromium:649283
      R=titzer@chromium.org
      TEST=mjsunit/wasm/table
      
      Review-Url: https://codereview.chromium.org/2358923003
      Cr-Commit-Position: refs/heads/master@{#39711}
      10d7ad9d
  18. 21 Sep, 2016 1 commit