- 03 Sep, 2015 26 commits
-
-
mbrandy authored
Port 8a378f46 Original commit message: This turns the has_instance_call_handler bit on Map into an is_callable bit, that matches the spec definition of IsCallable (i.e. instances have [[Call]] internal methods). Also fix the typeof operator to properly say "function" for everything that is callable. Also remove the (unused) premature %_GetPrototype optimization from Crankshaft, which just complicated the Map bit swap. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Review URL: https://codereview.chromium.org/1330613005 Cr-Commit-Position: refs/heads/master@{#30576}
-
mbrandy authored
Port 72bc4b5c Original commit message: Use a single JSIteratorResult type for all implementation provided iterator results (i.e. the String, Array and collection iterators, and also for generators). This removes one source of unnecessary polymorphism in for-of loops. It is accomplished by a new intrinsic %_CreateIterResultObject() that should be used to create iterator result objects from JavaScript builtins (there's a matching factory method for C++ code). Also restructure the %StringIteratorPrototype%.next() and %ArrayIteratorPrototype%.next() functions to be a bit more friendly to optimizing compilers. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Review URL: https://codereview.chromium.org/1325203004 Cr-Commit-Position: refs/heads/master@{#30575}
-
mbrandy authored
Port 510baeac Original commit message: Kills the kRestParameter bailout/disabled optimization, and fixes lazily parsed arrow functions with rest parameters. Supercedes https://crrev.com/1235153006/ R=caitpotter88@gmail.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG=chromium:508074, v8:2160, v8:2700 LOG=N Review URL: https://codereview.chromium.org/1318523006 Cr-Commit-Position: refs/heads/master@{#30574}
-
gdeepti authored
- Print the summary excluding other tick information - Add test to verify that summary is printed correctly. BUG=None LOG=N R=machenbach@chromium.org Review URL: https://codereview.chromium.org/1318933004 Cr-Commit-Position: refs/heads/master@{#30573}
-
balazs.kilvady authored
Port 72bc4b5c Original commit message: Use a single JSIteratorResult type for all implementation provided iterator results (i.e. the String, Array and collection iterators, and also for generators). This removes one source of unnecessary polymorphism in for-of loops. It is accomplished by a new intrinsic %_CreateIterResultObject() that should be used to create iterator result objects from JavaScript builtins (there's a matching factory method for C++ code). Also restructure the %StringIteratorPrototype%.next() and %ArrayIteratorPrototype%.next() functions to be a bit more friendly to optimizing compilers. BUG= Review URL: https://codereview.chromium.org/1315903005 Cr-Commit-Position: refs/heads/master@{#30572}
-
machenbach authored
Revert of Vector ICs: platform support for vector-based stores. (patchset #7 id:120001 of https://codereview.chromium.org/1328603003/ ) Reason for revert: [Sheriff] Breaks compile on arm: http://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20builder/builds/6590 Original issue's description: > Vector ICs: platform support for vector-based stores. > > The last changes for vector store functionality, they are in 3 areas: > > 1) The new vector [keyed] store code stubs - implementation. > 2) IC and handler compiler adjustments > 3) Odds and ends. A change in ast.cc, a test update, a small Oracle fix. > > BUG= > > Committed: https://crrev.com/63af1b3aec6547e7cdf502666ff79c562de8b679 > Cr-Commit-Position: refs/heads/master@{#30570} TBR=bmeurer@chromium.org,jkummerow@chromium.org,mvstanton@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1303053004 Cr-Commit-Position: refs/heads/master@{#30571}
-
mvstanton authored
The last changes for vector store functionality, they are in 3 areas: 1) The new vector [keyed] store code stubs - implementation. 2) IC and handler compiler adjustments 3) Odds and ends. A change in ast.cc, a test update, a small Oracle fix. BUG= Review URL: https://codereview.chromium.org/1328603003 Cr-Commit-Position: refs/heads/master@{#30570}
-
ulan authored
This reverts commit b06a6a89. BUG=chromium:519319,chromium:515873 LOG=NO Review URL: https://codereview.chromium.org/1311993003 Cr-Commit-Position: refs/heads/master@{#30569}
-
machenbach authored
Revert of [es5] Class of object is "Function" if object has [[Call]]. (patchset #3 id:40001 of https://codereview.chromium.org/1307943013/ ) Reason for revert: [Sheriff] Changes several layout test expectations. Please fix upstream first if intended. E.g.: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/1729 Several lines change from PASS to FAIL. Original issue's description: > [es5] Class of object is "Function" if object has [[Call]]. > > The concept of class was mostly removed from ES6, but we still use the > class of objects to distinguish object kinds in our builtins. So update > this to be in sync with IsCallable (thereby getting rid of the previous > instance type based tests for callable things completely). > > R=jarin@chromium.org, jkummerow@chromium.org > > Committed: https://crrev.com/af778389947f1b01fb036756ea3cb8ed8ab98452 > Cr-Commit-Position: refs/heads/master@{#30566} TBR=jarin@chromium.org,jkummerow@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1306303005 Cr-Commit-Position: refs/heads/master@{#30568}
-
machenbach authored
This relands https://codereview.chromium.org/1303183005 BUG=chromium:515782 LOG=n TBR=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1330623002 Cr-Commit-Position: refs/heads/master@{#30567}
-
bmeurer authored
The concept of class was mostly removed from ES6, but we still use the class of objects to distinguish object kinds in our builtins. So update this to be in sync with IsCallable (thereby getting rid of the previous instance type based tests for callable things completely). R=jarin@chromium.org, jkummerow@chromium.org Review URL: https://codereview.chromium.org/1307943013 Cr-Commit-Position: refs/heads/master@{#30566}
-
jarin authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1307203005 Cr-Commit-Position: refs/heads/master@{#30565}
-
mtrofin authored
While we may have consecutive deferred blocks, they may be entered from other blocks that are not predecessors of the first block. Same for the last block and exiting. So the total set of live ranges within the given set of blocks is the union of the individual in and out live sets. This is a performance bug, not a functional bug. BUG= Review URL: https://codereview.chromium.org/1322703003 Cr-Commit-Position: refs/heads/master@{#30564}
-
mlippautz authored
BUG=chromium:524425 LOG=N R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/1325173003 Cr-Commit-Position: refs/heads/master@{#30563}
-
oth authored
Follow up on discussion of https://codereview.chromium.org/1310503006/ BUG= LOG=N Review URL: https://codereview.chromium.org/1313953008 Cr-Commit-Position: refs/heads/master@{#30562}
-
mtrofin authored
Fixed ranges don't have operands assigned, for example. BUG= Review URL: https://codereview.chromium.org/1326643006 Cr-Commit-Position: refs/heads/master@{#30561}
-
mlippautz authored
{AtomicValue}: A simple integer value that can be atomically read/set/incremented. {AtomicEnumSet}: Similar to EnumSet this set basically represents an atomic bitfield based on enums. Atomic operations guarantee that setting one bit does not race with setting other bits. {AtomicEnumFlag}: A flag that is based on an enum that can be read and (attempted to be) changed atomically. BUG=chromium:524425 LOG=N Review URL: https://codereview.chromium.org/1310993004 Cr-Commit-Position: refs/heads/master@{#30560}
-
neis authored
BUG= Review URL: https://codereview.chromium.org/1312893010 Cr-Commit-Position: refs/heads/master@{#30559}
-
machenbach authored
Revert of Automatically download gold plugin for cfi builds. (patchset #1 id:1 of https://codereview.chromium.org/1303183005/ ) Reason for revert: Breaks windows. Original issue's description: > Automatically download gold plugin for cfi builds. > > BUG=chromium:515782 > LOG=n > NOTRY=true > > Committed: https://crrev.com/c8dbd2c477c47a34593a0e7deee55915425b4ac2 > Cr-Commit-Position: refs/heads/master@{#30556} TBR=bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:515782 Review URL: https://codereview.chromium.org/1329653004 Cr-Commit-Position: refs/heads/master@{#30558}
-
bmeurer authored
Use a single JSIteratorResult type for all implementation provided iterator results (i.e. the String, Array and collection iterators, and also for generators). This removes one source of unnecessary polymorphism in for-of loops. It is accomplished by a new intrinsic %_CreateIterResultObject() that should be used to create iterator result objects from JavaScript builtins (there's a matching factory method for C++ code). Also restructure the %StringIteratorPrototype%.next() and %ArrayIteratorPrototype%.next() functions to be a bit more friendly to optimizing compilers. R=ishell@chromium.org Review URL: https://codereview.chromium.org/1302173007 Cr-Commit-Position: refs/heads/master@{#30557}
-
machenbach authored
BUG=chromium:515782 LOG=n NOTRY=true Review URL: https://codereview.chromium.org/1303183005 Cr-Commit-Position: refs/heads/master@{#30556}
-
titzer authored
This is to support WebAssembly 64-bit ints in the short term, since it currently uses CheckedLoad/CheckedStore for accesses to the memory. In the long run, we'll change this to be explicit bounds checks that throw on out of bounds. R=bmeurer@chromium.org BUG= Review URL: https://codereview.chromium.org/1310323006 Cr-Commit-Position: refs/heads/master@{#30555}
-
mstarzinger authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1318863004 Cr-Commit-Position: refs/heads/master@{#30554}
-
mstarzinger authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1327523003 Cr-Commit-Position: refs/heads/master@{#30553}
-
bmeurer authored
This turns the has_instance_call_handler bit on Map into an is_callable bit, that matches the spec definition of IsCallable (i.e. instances have [[Call]] internal methods). Also fix the typeof operator to properly say "function" for everything that is callable. Also remove the (unused) premature %_GetPrototype optimization from Crankshaft, which just complicated the Map bit swap. R=mstarzinger@chromium.org, rossberg@chromium.org, yangguo@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_layout_dbg Review URL: https://codereview.chromium.org/1316933002 Cr-Commit-Position: refs/heads/master@{#30552}
-
v8-autoroll authored
Rolling v8/tools/clang to 91e7a78800b5849e27e098daa42e6ae8650ad322 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1316403006 Cr-Commit-Position: refs/heads/master@{#30551}
-
- 02 Sep, 2015 14 commits
-
-
caitpotter88 authored
Kills the kRestParameter bailout/disabled optimization, and fixes lazily parsed arrow functions with rest parameters. Supercedes https://crrev.com/1235153006/ BUG=chromium:508074, v8:2160, v8:2700 LOG=N R=rossberg@chromium.org, adamk@chromium.org, wingo@igalia.com Review URL: https://codereview.chromium.org/1272673003 Cr-Commit-Position: refs/heads/master@{#30550}
-
oth authored
Add methods for converting parameter index to a register and vice-versa. Move Register class into bytecodes.h. Update Bytecodes::Decode to pretty print parameters. BUG=v8:4280 LOG=NO Review URL: https://codereview.chromium.org/1325983002 Cr-Commit-Position: refs/heads/master@{#30549}
-
mstarzinger authored
This is a follow-up to a previous change and moved object statistics tracking into its own component. It is no longer intertwinded with the normal marking logic, but separated out into ObjectStatsVisitor. R=mlippautz@chromium.org Review URL: https://codereview.chromium.org/1310953008 Cr-Commit-Position: refs/heads/master@{#30548}
-
mstarzinger authored
Note that this is only pulling out the bookkeeping side of things, the marking visitor that actually records the statistics should also move into the ObjectStats class. That will be done as a follow-up. R=mlippautz@chromium.org Review URL: https://codereview.chromium.org/1326793002 Cr-Commit-Position: refs/heads/master@{#30547}
-
cbruni authored
- Use the new ElementsAccessor methods - improve test coverage BUG= Review URL: https://codereview.chromium.org/1317053006 Cr-Commit-Position: refs/heads/master@{#30546}
-
mbrandy authored
Port c29a4061 R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Review URL: https://codereview.chromium.org/1325103003 Cr-Commit-Position: refs/heads/master@{#30545}
-
oth authored
Code::WipeOutHeader now nulls out the next code link to avoid embedding that address in snapshot. BUG= LOG=NO Review URL: https://codereview.chromium.org/1310503006 Cr-Commit-Position: refs/heads/master@{#30544}
-
rmcilroy authored
Adds support for property load operations via Load/KeyedLoad ICs. Adds the following bytecodes: - LoadIC - KeyedLoadIC Also adds support to the interpreter assembler for loading the type feedback vector from the function on the stack, and calling ICs. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1309843007 Cr-Commit-Position: refs/heads/master@{#30543}
-
mvstanton authored
BUG= Review URL: https://codereview.chromium.org/1314503003 Cr-Commit-Position: refs/heads/master@{#30542}
-
conradw authored
Prerequisite for sealing strong class instances. Depends on https://codereview.chromium.org/1314203002/ BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1316333002 Cr-Commit-Position: refs/heads/master@{#30541}
-
mtrofin authored
BUG= Review URL: https://codereview.chromium.org/1313023003 Cr-Commit-Position: refs/heads/master@{#30540}
-
fedor authored
Remove intersection from the `std::map`s representing current live ArrayBuffers. While being simpler to understand, it poses significant performance issue for the active ArrayBuffer users (like node.js). Store buffers separately, and process them together during mark-sweep phase. BUG= R=mlippautz@chromium.org Review URL: https://codereview.chromium.org/1326613002 Cr-Commit-Position: refs/heads/master@{#30539}
-
ishell authored
BUG=chromium:523307 LOG=N Review URL: https://codereview.chromium.org/1304923003 Cr-Commit-Position: refs/heads/master@{#30538}
-
hablich authored
Revert of [turbofan] Greedy: using hints (patchset #2 id:60001 of https://codereview.chromium.org/1329493004/ ) Reason for revert: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20-%20greedy%20allocator/builds/1338 Original issue's description: > [turbofan] Greedy: using hints > > This is a rudimentary introduction of hints. Primarily this helps with > allocating on the same register variables are defined (from instructions) > For dealing with phis, we need to introduce groups, in a subsequent > CL. > > From the last CL (memory ops heuristics), this CL improves some > benchmarks - notably Life (11.94%) in Emscripten x64, and Memops > (Emscripten), 24% on x86; notable regressions: Memops in > AreWeFastYet (-14%, x64) and Corrections -25% on x86. > > BUG= > > Committed: https://crrev.com/038f5eaf3bd6796ed6b7519de83c21d4e1f54850 > Cr-Commit-Position: refs/heads/master@{#30534} TBR=jarin@chromium.org,bmeurer@chromium.org,mtrofin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1324763005 Cr-Commit-Position: refs/heads/master@{#30537}
-