1. 15 Jul, 2019 1 commit
    • Benedikt Meurer's avatar
      [dx] Support some cross-context async stack traces. · 2aa94749
      Benedikt Meurer authored
      When passing promises from other contexts to an `await`, the
      --harmony-await-optimization doesn't kick in, and as such the
      promise will be wrapped in a "native promise" (from this context).
      That means the promises aren't chained immediately, but delayed
      via a PromiseResolveThenableJob, which chains these promises on
      the next turn of this contexts' microtask queue.
      
      If there's anything happening on the macro task queue in between
      this and the point when an exception is raised, the chaining will
      have happened and we actually find our way back via the promise
      chains. And this CL adds support for exactly that case. For other
      cases, it's currently impossible to reconstruct the async stack
      unfortunately, but we hope that this will help with the major
      use cases, where the developer awaits on I/O.
      
      Bug: v8:7522, v8:8673, v8:9487
      Ref: nodejs/node#28680
      Change-Id: Icc06c7df12644c2d8d43b6c7580ee06bb8f1024a
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1701847
      Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#62709}
      2aa94749