- 26 Jan, 2022 12 commits
-
-
Igor Sheludko authored
1) when generating short builtin calls/jumps assemblers should use the offset from the CodeRange base rather than the start of the code range reservation because otherwise it's not guaranteed that the PC-relative offset will fit into architecture's constraints. The code range reservation start could be different from the code range base in the following cases: * when the "base bias size" is non-zero (on Windows 64), * when we ended up over-reserving the address space for the code range, which happens as a last resort to fulfil the CodeRange alignment requirements. See the VirtualMemoryCage description for details. Drive-by fixes: 2) in case of over-reserving address space for external code range, the pre-calculated hint for where the remapped embedded builtins should be copied to was outside of the allocatable CodeRange region and thus useless. The fix is to use the allocatable region instead of the reservation region when calculating the hint. 3) when allocating CodeRange with zero base bias size we can create the VirtualMemory reservation from the first attempt simply by passing the required base alignment to the VirtualMemory constructor. Bug: v8:11880, chromium:1290591 Change-Id: If341418947e2170d967e22b38bcc371594939c1c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3412089Reviewed-by:Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#78772}
-
Marja Hölttä authored
Bug: v8:11525 Change-Id: I4df5144a7d0ed2b68cf15c7bfd72ce4a17ad4e41 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3416237Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#78771}
-
Jochen Eisinger authored
Change-Id: Ib4fd3bc66f5451ac2c50d550515992bdfbe41fcc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3414772Reviewed-by:
-
Camillo Bruni authored
Use DescriptorArray::Set instead of Append to avoid resorting the descriptors for every newly added property Bug: v8:11525 Change-Id: Id6d113f6218e095125256a8c7c8cfb28c8b41ae5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3415391Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#78769}
-
Dominik Inführ authored
Map::Hash relies on the fact that the map space is never compacted. However this might change in the future, so instead of using the address of the prototype's map, we use the prototype's identity hash instead. Bug: v8:12578 Change-Id: Ia4961ed55119681c0033aa187789f6710ff2d22c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3412085Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#78768}
-
Marja Hölttä authored
Exports are properties in the global object. Pre-reserve the space, since we know the count upfront. Bug: v8:11525 Change-Id: Ia8ea992234ed8cf71a1060254766b0ba31562436 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3416231Reviewed-by:
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: Iee5afc3ce21f3a09fdb810beb6a73123bf21afdf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3401594Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#78766}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/57b2bfa..d0fbf8a Cache PerfCounters instance in PerfCountersMeasurement (#1308) (Liqiang TAO) https://chromium.googlesource.com/external/github.com/google/benchmark/+/d0fbf8a R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I982279bd209fedfaf72a8ce674818906eb60147d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3416710 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78765}
-
Hao Xu authored
In current BitwiseSmi bytecodes the code to do Smi operation is inside a loop. This CL fast path the Smi operation by peeling the first Smi check out of the loop, and avoid Smi->Int->Smi conversion where possible. Drive-by fix: Add CSA_DCHECK in Smi shift to avoid unexpected use. Bug: v8:12442 Change-Id: I1adce560fb22a4409337e2958779eccf9197e4ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3328784Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Hao A Xu <hao.a.xu@intel.com> Cr-Commit-Position: refs/heads/main@{#78764}
-
Camillo Bruni authored
- Use raw pointer when setting the SFI in CreateJSFunction - Use some more factory->xxx_value() handle accessor to avoid handle creation Bug: v8:11525 Change-Id: I5ed62f56cf2e53cc765566c0c129c7851b704813 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3401591Reviewed-by:
-
Nico Hartmann authored
This reverts commit 5320fe8d. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20debug/38175/overview Original change's description: > Reland "[string] Support shared strings in Value{Serializer,Deserializer}" > > This is a reland of 3cb4039c > > Changes since revert: > - Fix FLAG_stress_scavenge interaction with shared Isolate > - Use the shared Isolate's global handles to keep shared values > alive in transit during a postMessage > > Original change's description: > > [string] Support shared strings in Value{Serializer,Deserializer} > > > > When FLAG_shared_string_table is true, postMessaging strings will share > > instead of copy. > > > > Note that not all operations on shared strings are supported, and shared > > strings may be slower than non-shared strings for some operations. > > > > Bug: v8:12007 > > Change-Id: I3462128e15410d2568868143571571b3025722c1 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3277250 > > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > > Commit-Queue: Shu-yu Guo <syg@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#78614} > > Bug: v8:12007 > Change-Id: I5d9b99b2dac6f26d5ef046d7aec94f1a1d219419 > Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3389533 > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Shu-yu Guo <syg@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78761} Bug: v8:12007 Change-Id: Ie8e54b30055324e6592562450b51d5a11e11c9d0 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3416232 Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Owners-Override: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#78762}
-
Shu-yu Guo authored
This is a reland of 3cb4039c Changes since revert: - Fix FLAG_stress_scavenge interaction with shared Isolate - Use the shared Isolate's global handles to keep shared values alive in transit during a postMessage Original change's description: > [string] Support shared strings in Value{Serializer,Deserializer} > > When FLAG_shared_string_table is true, postMessaging strings will share > instead of copy. > > Note that not all operations on shared strings are supported, and shared > strings may be slower than non-shared strings for some operations. > > Bug: v8:12007 > Change-Id: I3462128e15410d2568868143571571b3025722c1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3277250 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Shu-yu Guo <syg@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78614} Bug: v8:12007 Change-Id: I5d9b99b2dac6f26d5ef046d7aec94f1a1d219419 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3389533Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#78761}
-
- 25 Jan, 2022 10 commits
-
-
Milad Fa authored
Implementations are added to macro-assembler to be shared between liftoff and code generator. Change-Id: I6bde65dc50f1e52b8fbca150854e0b0863dff301 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3416190Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#78760}
-
Igor Sheludko authored
Drive-by: fix multi-arch build. Bug: v8:11880 Change-Id: I4e56370598117fec2a0131e5638d4bac3d84c52f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3412083Reviewed-by:
Samuel Groß <saelo@chromium.org> Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Adam Klein authored
Change-Id: Idce43801ef5f2f3e194a63cea3522eb6710b681e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3413192Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
legendecas authored
1. Expose all the functions to empty builtins. 2. Wire up the basic structure of ShadowRealm and internal slots. Bug: v8:11989 Change-Id: If7545fe18a74b2bd4b70a1a25776e41f03aaff89 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3195532Reviewed-by:
Shu-yu Guo <syg@chromium.org> Reviewed-by:
-
Michael Lippautz authored
The hello world sample needs to initialize V8's default platform in case it is not built as stand-alone example. Bug: v8:12427 Change-Id: I78b68fbed2c2a25b0ff03675beb94dfc5b9b4135 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3412088Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#78756}
-
Manos Koukoutos authored
Change-Id: I1289fcab6c4812868258b14492d85bad20ae7e9f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3406536Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#78755}
-
Samuel Groß authored
When sandboxed external pointers are enabled, external pointers now only require 32 bits of storage space in a HeapObject. This CL does not shrink the size of EmbedderDataSlots, which will happen in a follow-up CL. Bug: v8:10391 Change-Id: I3cf8b68c3b985cf806a45183717f50462a88c281 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3359629Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#78754}
-
Anton Bikineev authored
The check finds implicit conversions of integer literals to bools: bool b1 = 1; bool b2 = static_cast<bool>(1); and transforms them to: bool b1 = true; bool b2 = true; Bug: chromium:1290142 Change-Id: I1fec7d7a6f25af23e9b9aac687f5896e79f17b51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3406533 Auto-Submit: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Lu Yahan authored
Bug: v8:12576 Change-Id: I4d63f85d6528f2ad5e6502fffbc5fc7d797818ed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3412562Reviewed-by:
ji qiu <qiuji@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#78752}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/acd7562..57b2bfa Fix some errors in Custom Statistics demo code. (#1332) (YuanYingdong) https://chromium.googlesource.com/external/github.com/google/benchmark/+/57b2bfa R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I6682b979c23ce45e6a365371b5d5818b4b3fc3f4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3413460 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78751}
-
- 24 Jan, 2022 18 commits
-
-
Junliang Yan authored
Change-Id: I505026e562cda584aad7e56d1dd02f26b42ddf17 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3412808Reviewed-by:
Milad Farazmand <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#78750}
-
Junliang Yan authored
Change-Id: I9a4ba92f9da9cc964056d5c563b0534d9d172fcb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3412809Reviewed-by:
-
Milad Fa authored
Implementations are added to macro-assembler to be shared between liftoff and code generator. Change-Id: I3fac2b82686836106cefa9a78f5feda6105679d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3412359Reviewed-by:
-
Marja Hölttä authored
Bug: v8:11111 Change-Id: I83778377f1343a6157bf01f13b99ffcb41e4c6d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3404778Reviewed-by:
-
Milad Fa authored
Implementations are added to macro-assembler to be shared between liftoff and code generator. Change-Id: Ia26b82de3f0af076ace3d53e285917029d2d5ac4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3407794Reviewed-by:
-
Joyee Cheung authored
This is a reland of 91f08378 When the class scope does not need a context, the deserialized outer scope of the initializer scope would not be the class scope, and we should not and do not need to use it to fix up the allocation information of the context-allocated variables. The original patch did not consider this case and resulted in a regression when we tried to reparse the initializer function to look for destructuring assignment errors. This fixes the regression by not deserializing the class scope that's going to be reparsed, and using the positions of the scopes to tell whether the scope info matches the reparsed scope and can be used to fix up the allocation info. Original change's description: > [class] implement reparsing of class instance member initializers > > Previously, since the source code for the synthetic class instance > member initializer function was recorded as the span from the first > initializer to the last initializer, there was no way to reparse the > class and recompile the initializer function. It was working for > most use cases because the code for the initializer function was > generated eagarly and it was usually alive as long as the class was > alive, so the initializer wouldn't normally be lazily parsed. This > didn't work, however, when the class was snapshotted with > v8::SnapshotCreator::FunctionCodeHandling::kClear, > becuase then we needed to recompile the initializer when the class > was instantiated. This patch implements the reparsing so that > these classes can work with FunctionCodeHandling::kClear. > > This patch refactors ParserBase::ParseClassLiteral() so that we can > reuse it for both parsing the class body normally and reparsing it > to collect initializers. When reparsing the synthetic initializer > function, we rewind the scanner to the beginning of the class, and > parse the class body to collect the initializers. During the > reparsing, field initializers are parsed with the full parser while > methods of the class are pre-parsed. > > A few notable changes: > > - Extended the source range of the initializer function to cover the > entire class so that we can rewind the scanner to parse the class > body to collect initializers (previously, it starts from the first > field initializer and ends at the last initializer). This resulted > some expectation changes in the debugger tests, though the > initializers remain debuggable. > - A temporary ClassScope is created during reparsing. After the class > is reparsed, we use the information from the ScopeInfo to update > the allocated indices of the variables in the ClassScope. > > Bug: v8:10704 > Change-Id: Ifb6431a1447d8844f2a548283d59158742fe9027 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2988830 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Joyee Cheung <joyee@igalia.com> > Cr-Commit-Position: refs/heads/main@{#78299} Bug: chromium:1278086, chromium:1278085, v8:10704 Change-Id: Iea4f1f6dc398846cbe322adc16f6fffd6d2dfdf3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3325912Reviewed-by:
-
Nico Hartmann authored
This reverts commit 7fc4868e. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Clusterfuzz%20Linux64%20-%20release%20builder/26331/overview Original change's description: > [ext-code-space] Enable external code space on x64 and desktop arm64 > > Perf Sheriffs: this CL might regress some benchmarks while improving > the others. > > Bug: v8:11880 > Change-Id: Iddaba0512100eedf61d8b106da0be0a08d273b67 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3412072 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78743} Bug: v8:11880 Change-Id: I238bb143b3781fc0b865edf4e7cb0ae52cbad0c7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3412078 Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#78744}
-
Igor Sheludko authored
Perf Sheriffs: this CL might regress some benchmarks while improving the others. Bug: v8:11880 Change-Id: Iddaba0512100eedf61d8b106da0be0a08d273b67 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3412072Reviewed-by:
-
Clemens Backes authored
The allocatable registers have holes, so not all FP registers are one half of a valid SIMD register. Thus check if {GetAliases} returned an allocatable SIMD register before looking up if that register is being used. Otherwise we run into a DCHECK because {simd_reg} is invalid. The bug was only introduced recently: https://crrev.com/c/3404780 R=thibaudm@chromium.org Bug: chromium:1290079, v8:12330 Change-Id: I99df1645cfeec375daec82dbf41c110b5474339c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3412075Reviewed-by:Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#78742}
-
Clemens Backes authored
This turns some CHECKs in the mid-tier register allocator into DCHECKs. The ones inside {CheckConsistency} should be DCHECKs anyway, even if they are inside an "#ifdef DEBUG" block. This will make ClusterFuzz correctly detect them as "checks that only happen in debug mode". Others were just unnecessarily always included, instead of only in debug builds. R=thibaudm@chromium.org Bug: chromium:1271369 Change-Id: I51acde3c951c7a2af9dee36e25b196364ddf8f5c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3406760Reviewed-by: -
xieyun authored
negation of 'INT64_MIN' cannot be represented in type 'int64_t'. Change-Id: Ieddb0fc9bae4d3c85485bb94e76c05c72529a978 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3402665Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/main@{#78740}
-
Igor Sheludko authored
... which failed write barrier skipping check. Bug: v8:11880 Change-Id: Id404914b78f8d722da7129a5f6183596698a150f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3412073 Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Clemens Backes authored
This minor change in how we iterate the virtual registers speeds up the consistency checks by a factor of more than four. R=thibaudm@chromium.org Bug: chromium:1271369 Change-Id: Ieb9640d52c84fabacbbcf0fea56825fb594cfc21 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3406759Reviewed-by:
-
Marja Hölttä authored
Bug: v8:11111 Change-Id: Id9ea2e4f3e07be509c8e7a29d93ed80036787df1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3404777Reviewed-by:
-
Clemens Backes authored
Moves between stack slots are rare; they mostly happen for tail calls or for multi-return blocks. The bug exists since a long time, but was only uncovered by the fuzzer now. R=ahaas@chromium.org Bug: chromium:1289678 Change-Id: Ibb0917717c6b7a468f5fcbb01be34267ba06a449 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3406749Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#78736}
-
Jakob Gruber authored
.. caused by accidentally removing the continuation case of a V8_FALLTHROUGH. Fixed: v8:12561 Bug: v8:12552 Change-Id: I720a531155751b5409339344e96957a2e325a82f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3406538 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
This is the only change in crrev.com/c/3398111 that may have impacted performance. Bug: chromium:1289597 Change-Id: I375535aa5c8382073565f1270dc5cc9c5598af4e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3406534Reviewed-by:
-
Clemens Backes authored
This removes a dead method, makes constant fields constant, and avoids a confusing macro (which just prevented me from finding the call to {set_imported_mutable_globals}). R=manoskouk@chromium.org Bug: v8:12425 Change-Id: I76de744c273ed9e2e429647a2d26dc163e1f4525 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3406758Reviewed-by:Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#78733}
-
