- 24 Jul, 2020 1 commit
-
-
Ng Zhi An authored
Using uint8_t[] causes decay to pointer issue, which manifests in copying garbage values in the call to WriteLittleEndianValue. Change it to use a std::array, which doesn't have the decaying behavior. Also add a regression test from comment#6 of the linked bug. Bug: v8:10731 Change-Id: I4a1ca69fe99806642e9931625ca7aeab6663f955 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316465Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#69052}
-
- 22 Jun, 2020 1 commit
-
-
Clemens Backes authored
This addresses a review comment from https://github.com/WebAssembly/spec/pull/1214. R=ahaas@chromium.org Change-Id: Icd473aa16bbf35839556b052271489a2889fe0fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2257229Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68461}
-
- 18 Jun, 2020 1 commit
-
-
Ng Zhi An authored
This was causing issues with strict mode when combined with fuzzers. See https://crrev.com/c/2173952/7/test/mjsunit/wasm/wasm-module-builder.js#471 Change-Id: I164b24c35d7ba7c53a550dc3649eb7268dfb30e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2252540Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#68420}
-
- 16 Jun, 2020 1 commit
-
-
Deepti Gandluri authored
Change-Id: Ie7bf807a51b2dd822b956a92d0051bfabcaf81eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2246528Reviewed-by: Zhi An Ng <zhin@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#68353}
-
- 10 Jun, 2020 1 commit
-
-
Manos Koukoutos authored
As per the latest update to the 'reference types' wasm proposal, the nullref type is removed. Following that, all its uses in V8 were also removed. This CL: - Removes now dead code referencing nullref. - Changes names of functions/exceptions containing 'nullref' to 'null'. - Changes nullref to the corresponding nullable type in some tests. Bug: v8:7748 Change-Id: I5b4606671d7b24dd48a45a3341e8a1c056fcd1d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2238026 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#68283}
-
- 09 Jun, 2020 1 commit
-
-
Manos Koukoutos authored
The reference types wasm proposal dropped all subtyping. Subsequently, the 'anyref' type was renamed to externref. This changes all references of the *type* anyref to externref. Additionally, the flag that permits this extension is renamed to "reftypes" to mirror the proposal name. Bug: v8:7748 Change-Id: Icf323f13b9660fd10540e65125af053fca3a03f9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2232941 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#68270}
-
- 03 Jun, 2020 1 commit
-
-
Andreas Haas authored
With recent changes to the anyref proposal, null refs now have a type immediate which declares the type of a null ref constant. Likewise, the RefIsNull instruction is type aware now. This CL addresses these proposal changes now. R=jkummerow@chromium.org Bug: v8:10556 Change-Id: I810dfa3a4ab4389afc9639f897cee5d43e9b62cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215172 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68141}
-
- 02 Jun, 2020 2 commits
-
-
Clemens Backes authored
This reverts commit 76debfda. Reason for revert: Nullptr access in new test: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux/37265 Original change's description: > [wasm-simd][liftoff] Fix I64x2Mul > > The I64x2Mul overwrote the lhs/rhs if they are the same as dst. So when > deciding if we need temporaries, we should not only check the > cache_state, but whether they alias dst or not. > > Bug: chromium:1088273 > Change-Id: I82efa9b45e0a3d321a06efde60971ce95b21490f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2225796 > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68114} TBR=clemensb@chromium.org,zhin@chromium.org Change-Id: I5fd337b71d82d262d36ff410077a11c17b50036b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1088273 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2226756Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68117}
-
Ng Zhi An authored
The I64x2Mul overwrote the lhs/rhs if they are the same as dst. So when deciding if we need temporaries, we should not only check the cache_state, but whether they alias dst or not. Bug: chromium:1088273 Change-Id: I82efa9b45e0a3d321a06efde60971ce95b21490f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2225796 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68114}
-
- 21 May, 2020 1 commit
-
-
Ng Zhi An authored
The proposal uses the lane shape, e.g. i64x2.anytrue, and we were using s1x2.anytrue in our opcodes. This was a legacy naming, because we were trying to bitpack the booleans. Now that we aren't doing that, rename these to be more consistent with the proposal. This was done with a straightforward sed script, changing both cpp code and also some comments in mjsunit test files. Bug: v8:10506 Change-Id: If077ed805de23520d8580d6b3b1906c80f67b94f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207915 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#67945}
-
- 13 May, 2020 1 commit
-
-
Ng Zhi An authored
The AVX implementation does not have dst == input(0), so the vminps call was wrong. The intention is to compare the 2 input operands. Bug: chromium:1081030 Change-Id: Id54074327a6aca4b75988fc9d85beccfeabfc791 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2194471Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67786}
-
- 01 May, 2020 1 commit
-
-
Deepti Gandluri authored
- Update opcode numbers, tests - As the wasm-module-builder currently assumes opcode bytes, skip the test that needs a multi-byte leb128 opcode - Renumber post-MVP opcodes Change-Id: I6531e954e63986dc6f7a3144ec054d16e6dc1b05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2173952Reviewed-by: Zhi An Ng <zhin@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#67517}
-
- 30 Apr, 2020 1 commit
-
-
Clemens Backes authored
The interpreter will be un-shipped soon, hence we cannot have a compilation hint for interpreted execution. This CL removes the respective enum value, removes a test which specifically tested this one option, and adapts other code to use one of the remaining hints. R=ahaas@chromium.org Bug: v8:10389 Change-Id: Ia754f7de95be271000a9e4e10ef2a3ee171da627 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2172748Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67491}
-
- 27 Apr, 2020 1 commit
-
-
Ng Zhi An authored
This relands commit 1a38573f. The original change used a sequence of instruction in the test that could not be scalar lowered properly. Original change's description: > [arm] Change fp_fixed registers to be allocatable registers > > fp_fixed1 and fp_fixed2 are used by the S8x16Shuffle operation. They > need to be allocatable, so that they can be correctly marked as fixed > and spilled as required. The previous value of fp_fixed2, d29, is not in > the list of allocatable double registers, and not marked as fixed > appropriately. > > One fix could be to extend the list of allocatable double registers, but > there is a comment there saying that the list is kept even-length to > make stack alignment easier. So rather than messing with that, we > instead change what fp_fixed1 and fp_fixed2 is, since S8x16Shuffle is > the only user, this is a simpler change. > > Bug: chromium:1070078 > Change-Id: Id7de9b256bad2cfb11b0f06b66eb80a48ff7827c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2161565 > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67372} Bug: chromium:1070078 Change-Id: I02bb4b3ad03817318cbd0ee706c5ef4f20c845ba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2165867Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67406}
-
- 24 Apr, 2020 2 commits
-
-
Francis McCabe authored
This reverts commit 390ed4b9. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux/36714? Original change's description: > [arm] Change fp_fixed registers to be allocatable registers > > fp_fixed1 and fp_fixed2 are used by the S8x16Shuffle operation. They > need to be allocatable, so that they can be correctly marked as fixed > and spilled as required. The previous value of fp_fixed2, d29, is not in > the list of allocatable double registers, and not marked as fixed > appropriately. > > One fix could be to extend the list of allocatable double registers, but > there is a comment there saying that the list is kept even-length to > make stack alignment easier. So rather than messing with that, we > instead change what fp_fixed1 and fp_fixed2 is, since S8x16Shuffle is > the only user, this is a simpler change. > > Bug: chromium:1070078 > Change-Id: Id7de9b256bad2cfb11b0f06b66eb80a48ff7827c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2161565 > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67372} TBR=gdeepti@chromium.org,zhin@chromium.org,thibaudm@chromium.org Change-Id: I00b4b34771b5832cc3d5fe6eac7aac506ec82d50 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1070078 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2165865Reviewed-by: Francis McCabe <fgm@chromium.org> Commit-Queue: Francis McCabe <fgm@chromium.org> Cr-Commit-Position: refs/heads/master@{#67375}
-
Ng Zhi An authored
fp_fixed1 and fp_fixed2 are used by the S8x16Shuffle operation. They need to be allocatable, so that they can be correctly marked as fixed and spilled as required. The previous value of fp_fixed2, d29, is not in the list of allocatable double registers, and not marked as fixed appropriately. One fix could be to extend the list of allocatable double registers, but there is a comment there saying that the list is kept even-length to make stack alignment easier. So rather than messing with that, we instead change what fp_fixed1 and fp_fixed2 is, since S8x16Shuffle is the only user, this is a simpler change. Bug: chromium:1070078 Change-Id: Id7de9b256bad2cfb11b0f06b66eb80a48ff7827c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2161565Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67372}
-
- 16 Apr, 2020 1 commit
-
-
Ng Zhi An authored
SIMD opcodes consist of the prefix byte, then an LEB128 encoded int. We were decoding this incorrectly as a fixed uint8. This fixes the decoder to properly handle multi bytes. In some cases, the multi byte logic is applied to all prefixed opcodes. This is not a problem, since for values < 0x80, the LEB encoding is a single byte, and decodes to the same int. If the prefix opcode has instructions with index >= 0x80, it would be required to be LEB128 encoded anyway. There are a bunch of trivial changes to test-run-wasm-simd, to change the macro from BUILD to BUILD_V, the former only works for single byte opcodes, the latter is a new template-based macro that correct handles multi-byte opcodes. The only unchanged test is the shuffle fuzzer test, which builds its own sequence of bytes without using the BUILD macro. Bug: v8:10258 Change-Id: Ie7377e899a7eab97ecf28176fd908babc08d0f19 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2118476 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#67186}
-
- 06 Apr, 2020 1 commit
-
-
Ng Zhi An authored
This relands commit 7d955faa. Changed the test case to use i16x8 splat instead of i8x16 splat, the latter was causing issues when doing scalar lowering. This change still causes the regression test to fail without the fix. Original change's description: > [wasm-simd][x64][ia32] Do not overwrite input register > > We are ovewriting input register (contains the shift) when we are > masking it, instead, move to a temporary,then mask it. > > Bug: chromium:1065599 > Change-Id: Iab72b94581239447e444746681387350b576e24a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2125941 > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66997} Bug: chromium:1065599 Change-Id: I0dc78ddb013652ef88c07d065c3f6877937c5300 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136220Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67026}
-
- 03 Apr, 2020 2 commits
-
-
Zhi An Ng authored
This reverts commit 7d955faa. Reason for revert: Bad change, modified wrong test file https://ci.chromium.org/p/v8/builders/ci/V8%20Linux/36416 Original change's description: > [wasm-simd][x64][ia32] Do not overwrite input register > > We are ovewriting input register (contains the shift) when we are > masking it, instead, move to a temporary,then mask it. > > Bug: chromium:1065599 > Change-Id: Iab72b94581239447e444746681387350b576e24a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2125941 > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66997} TBR=gdeepti@chromium.org,zhin@chromium.org Change-Id: I50c57906d6eb49758584b477c971179ea3c6e5d3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1065599 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2134655Reviewed-by: Zhi An Ng <zhin@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67000}
-
Ng Zhi An authored
We are ovewriting input register (contains the shift) when we are masking it, instead, move to a temporary,then mask it. Bug: chromium:1065599 Change-Id: Iab72b94581239447e444746681387350b576e24a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2125941 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#66997}
-
- 23 Mar, 2020 3 commits
-
-
Clemens Backes authored
Before, it was specified between the globals and the exports section. This changed with https://github.com/WebAssembly/exception-handling/issues/98. The event section is now placed between the memory and the globals section. R=jkummerow@chromium.org CC=aheejin@chromium.org Bug: v8:10176 Change-Id: Icafeaae4ff7796273c73d61ed417c028fcbcb02d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2116032Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66833}
-
Clemens Backes authored
The behaviour was clarified in the spec: https://github.com/WebAssembly/exception-handling/pull/97 br_on_exn (which was done in another CL) and also rethrow should trap on nullptr. This CL implements this by an explicit check in the builtin called for rethrow. R=jkummerow@chromium.org CC=aheejin@chromium.org Bug: v8:10128 Change-Id: Icb0f4e54991b3385917bf183efa825048db4cb82 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2115430 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#66827}
-
Clemens Backes authored
The behaviour was clarified in the spec: https://github.com/WebAssembly/exception-handling/pull/97 br_on_exn (and also rethrow, which will be added in another CL) should trap on nullptr. This CL implements this by an explicit check on each br_on_exn (within {GetExceptionTag}). This check will be redundant if several br_on_exn follow each other. Since also the runtime call for {GetExceptionTag} is redundant, and also the fact that we do a runtime call is suboptimal, I consider the whole implementation prototypical for now anyway. R=jkummerow@chromium.org CC=aheejin@chromium.org Bug: v8:10128 Change-Id: I234c3183f93fe0884aadd2ab6dbd6c2b7a07c660 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2113381 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#66826}
-
- 28 Feb, 2020 1 commit
-
-
Jakob Kummerow authored
There were a few places that still checked against the limit for initial memory size rather than the limit for memory size after growth (which was recently separated from the former). Bug: v8:7881 Change-Id: Id17d86e2f7a5dfa4f1dd35153b0cefc01f72ed33 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2078574 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#66496}
-
- 26 Feb, 2020 1 commit
-
-
Ng Zhi An authored
Move load splat and load extend ops into the list of SIMD memory opcodes, since they similarly take an i32 and an memarg. This fixes the OpcodeLength calculation in function-body-decoder-impl.h. And in turn, fixes the mjsunit test code that the fuzzer generates. See the regress-1055692.js file for the weird S8x16LoadSplat followed by 2 kExprUnreachable, where the kExprUnreachable really is a memarg {0x0, 0x0}. This bug was caught by the fuzzer, and that was the generated test (with small fixes to add kExprDrop), so leaving it as it is. Bug: chromium:1055692 Change-Id: I743b6beb82350b5fea22c8dd10b546a02741cfed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071401Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#66439}
-
- 25 Feb, 2020 1 commit
-
-
Ng Zhi An authored
This is a reland of 548fda4a regress-1054466 is modified to not use 64x2 operations, since that was causing problems on noavx/nosse builds, which requires scalar lowering, and scalar lowering for 64x2 ops is not implemented. Original change's description: > [liftoff] Check fp_pair when looking up register for reuse > > Given two registers that are both not gp_pair, one could be an fp_pair, > and the other not, and we will incorrect call == on them. The current > check needs to be expanded to check that both registers are fp_pair. > > Bug: chromium:1054466 > Change-Id: Ib986c002a8a5cadb9668458597a797cecfd971b1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2070006 > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66402} Bug: chromium:1054466 Change-Id: If88f1ff2fb17aaa3727758cda5b368be1c6d9bd6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071396Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#66423}
-
- 24 Feb, 2020 2 commits
-
-
Clemens Backes authored
This reverts commit 548fda4a. Reason for revert: Segfault on nosse bot: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux/35905? Original change's description: > [liftoff] Check fp_pair when looking up register for reuse > > Given two registers that are both not gp_pair, one could be an fp_pair, > and the other not, and we will incorrect call == on them. The current > check needs to be expanded to check that both registers are fp_pair. > > Bug: chromium:1054466 > Change-Id: Ib986c002a8a5cadb9668458597a797cecfd971b1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2070006 > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66402} TBR=clemensb@chromium.org,zhin@chromium.org Change-Id: I56f13406ef3cc3793c9d0e2273c4dc5fb0e3de38 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1054466 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2069327Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66405}
-
Ng Zhi An authored
Given two registers that are both not gp_pair, one could be an fp_pair, and the other not, and we will incorrect call == on them. The current check needs to be expanded to check that both registers are fp_pair. Bug: chromium:1054466 Change-Id: Ib986c002a8a5cadb9668458597a797cecfd971b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2070006 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66402}
-
- 17 Feb, 2020 1 commit
-
-
Emanuel Ziegler authored
Implement the latest spec changes: - Allow declarative segments to behave like passive & dropped segments. - Enforce that only declared functions may be returned or used in globals as funcref. - Ensure that table fill does not modify any entries if OOB. Spec tests for select and br_table are still failing due to proposal issue Bug: v8:10156 R=ahaas@chromium.org Change-Id: I5b95be36a67bc7482a84b848908cc4cbdf94af03 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2027458Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#66297}
-
- 15 Jan, 2020 2 commits
-
-
Emanuel Ziegler authored
Add tests for select, reject undefined globals for nullref and reformat JS R=ahaas@chromium.org Bug: chromium:10063 Change-Id: I97f7c86fe7435ca64ce1f4b86d8d9eadd29cc76b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002531Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#65795}
-
Emanuel Ziegler authored
Add decoding of ref.null as a valid argument for references in TurboFan, LiftOff and the interpreter. R=ahaas@chromium.org R=jkummerow@chromium.org Bug: chromium:10063 Change-Id: I1e2d9c76f616dacb3aa06f8b535543bdcdcf0783 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991485 Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#65788}
-
- 10 Jan, 2020 1 commit
-
-
Eric Leese authored
Change-Id: I7dd05e5b5feffceb1dd3b2a055c308266aea7c94 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1995272Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Milad Farazmand <miladfar@ca.ibm.com> Commit-Queue: Eric Leese <leese@chromium.org> Cr-Commit-Position: refs/heads/master@{#65702}
-
- 09 Jan, 2020 1 commit
-
-
Eric Leese authored
Inspector will no longer report per-function wasm scripts or provide wasm disassembly. Locations in wasm are now consistently reported through the inspector API as lineNumber=0 columnNumber=byte offset in module. Bug: chromium:1013527, chromium:1003022 Change-Id: Ide85bbaa85ad75f29248ff82a3e7f3e40688d377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991481 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65660}
-
- 14 Nov, 2019 1 commit
-
-
Michael Starzinger authored
This is a reland of 837556be Original change's description: > [wasm] Improve test coverage of s128 exception handling. > > This adds test coverage for the encoding and decoding of s128 values as > part of an exception package. The encoding within an exception package > is not specified (and not observable), but the full bit-pattern needs to > survive an encoding/decoding round trip. > > R=clemensb@chromium.org > TEST=mjsunit/wasm/exceptions-simd > BUG=v8:8091 > > Change-Id: I4cf6c1f00c64757512f66d068640a7e772eb0127 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1905769 > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64932} Bug: v8:8091,v8:9973 Change-Id: I7daf17a0cbc6904e7130ec4e50b12a829b1b1d34 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1916203 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64951}
-
- 13 Nov, 2019 2 commits
-
-
Maya Lekova authored
This reverts commit 837556be. Reason for revert: Breaks V8 Linux https://cr-buildbucket.appspot.com/build/8896896548394462912 Original change's description: > [wasm] Improve test coverage of s128 exception handling. > > This adds test coverage for the encoding and decoding of s128 values as > part of an exception package. The encoding within an exception package > is not specified (and not observable), but the full bit-pattern needs to > survive an encoding/decoding round trip. > > R=clemensb@chromium.org > TEST=mjsunit/wasm/exceptions-simd > BUG=v8:8091 > > Change-Id: I4cf6c1f00c64757512f66d068640a7e772eb0127 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1905769 > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64932} TBR=mstarzinger@chromium.org,clemensb@chromium.org Change-Id: I9276c6f6600a0f4e8a06dd1a7907cac25c761577 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8091 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1914211Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#64935}
-
Michael Starzinger authored
This adds test coverage for the encoding and decoding of s128 values as part of an exception package. The encoding within an exception package is not specified (and not observable), but the full bit-pattern needs to survive an encoding/decoding round trip. R=clemensb@chromium.org TEST=mjsunit/wasm/exceptions-simd BUG=v8:8091 Change-Id: I4cf6c1f00c64757512f66d068640a7e772eb0127 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1905769 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64932}
-
- 16 Oct, 2019 1 commit
-
-
Michael Starzinger authored
This extends existing table support to be able to store 'exnref' in addition to 'anyref' types. Tools can use this to maintain data structures for exception packages. R=ahaas@chromium.org TEST=mjsunit/wasm/exceptions-anyref BUG=v8:8091 Change-Id: Iccbcfdc328db81a366921bcdd98c2256f66e7fc8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781046 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#64323}
-
- 11 Oct, 2019 1 commit
-
-
Ng Zhi An authored
Increase the embedded vector size to 91 as that is the max size needed to print a s128 as a 32x4. - max value of uint32_t has 10 digits in decimal, 1 for a potential sign, 3 spaces in between 4 of them -> 3 + 4 * 11 = 47 - max value of uint32_t has 8 digits in hex, 3 spaces in between -> 3 + 4 * 8 = 35 - the prefix "v128:" -> 5 - " / " to separate the decimal and hex representation -> 3 - null byte 47 + 35 + 5 + 3 + 1 = 91 Bug: v8:9754 Change-Id: I153c30738fa8862b44fb5103cbe62ea0bcea9718 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1814885 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#64256}
-
- 08 Oct, 2019 2 commits
-
-
Clemens Backes authored
This brings our constants back in line with the changed spec text. We already use kExprTableGet and kExprTableSet, but for locals and globals we still use the old wording. This renaming is mostly mechanical. PS1 was created using: ag -l 'kExpr(Get|Set)Global' src test | \ xargs -L1 sed -E 's/kExpr(Get|Set)Global\b/kExprGlobal\1/g' -i PS2 contains manual fixes. R=mstarzinger@chromium.org Bug: v8:9810 Change-Id: I064a6448cd95bc24d31a5931b5b4ef2464ea88b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847355 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#64163}
-
Clemens Backes authored
This brings our constants back in line with the changed spec text. We already use kExprTableGet and kExprTableSet, but for locals and globals we still use the old wording. This renaming is mostly mechanical. PS1 was created using: ag -l 'kExpr(Get|Set|Tee)Local' src test | \ xargs -L1 sed -E 's/kExpr(Get|Set|Tee)Local\b/kExprLocal\1/g' -i PS2 contains manual fixes. R=mstarzinger@chromium.org Bug: v8:9810 Change-Id: I1617f1b2a100685a3bf56218e76845a9481959c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847354Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64161}
-